49287 2010-11-09 16:43:42 -0800 [Qt] crash when attempting to add a JS object 2010-11-20 22:03:29 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 smagnuso webkit-unassigned commit-queue oldest_to_newest 307051 0 smagnuso 2010-11-09 16:43:42 -0800 There is a crash due to a null pointer dereference. I noticed this with a crash in: LayoutTests/fast/frames/sandboxed-iframe-plugins.html with the fix this test still doesn't pass, but at least it no longer crashes :) 307055 1 73435 smagnuso 2010-11-09 16:47:15 -0800 Created attachment 73435 Patch 312040 2 73435 kling 2010-11-20 21:34:35 -0800 Comment on attachment 73435 Patch Nice catch, root will be null here if scripts are sandboxed. r=me 312048 3 commit-queue 2010-11-20 22:02:16 -0800 The commit-queue encountered the following flaky tests while processing attachment 73435: fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dumi@chromium.org. The commit-queue is continuing to process your patch. 312049 4 73435 commit-queue 2010-11-20 22:03:24 -0800 Comment on attachment 73435 Patch Clearing flags on attachment: 73435 Committed r72491: <http://trac.webkit.org/changeset/72491> 312050 5 commit-queue 2010-11-20 22:03:29 -0800 All reviewed patches have been landed. Closing bug. 73435 2010-11-09 16:47:15 -0800 2010-11-20 22:03:24 -0800 Patch bug-49287-20101109165145.patch text/plain 1231 smagnuso ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcCBiL1dlYktpdC9xdC9BcGkv cXdlYmZyYW1lLmNwcAppbmRleCA2M2NkN2Y3MDQxYTQzZTllYmM4MWQ3YTY2NTZkNjVhNzFlM2Iw MzAxLi4wMDVlNDg1NWE4MWUxZGE1YTc1NWI4NmU2MDQyOTRlMmY4MDQ1ZjNiIDEwMDY0NAotLS0g YS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViZnJh bWUuY3BwCkBAIC01NjEsNiArNTYxLDEwIEBAIHZvaWQgUVdlYkZyYW1lOjphZGRUb0phdmFTY3Jp cHRXaW5kb3dPYmplY3QoY29uc3QgUVN0cmluZyAmbmFtZSwgUU9iamVjdCAqb2JqZWN0CiAgICAg ICAgIHFEZWJ1ZygpIDw8ICJXYXJuaW5nOiBjb3VsZG4ndCBnZXQgd2luZG93IG9iamVjdCI7CiAg ICAgICAgIHJldHVybjsKICAgICB9CisgICAgaWYgKCFyb290KSB7CisgICAgICAgIHFEZWJ1Zygp IDw8ICJXYXJuaW5nOiBjb3VsZG4ndCBnZXQgcm9vdCBvYmplY3QiOworICAgICAgICByZXR1cm47 CisgICAgfQogCiAgICAgSlNDOjpFeGVjU3RhdGUqIGV4ZWMgPSB3aW5kb3ctPmdsb2JhbEV4ZWMo KTsKIApkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VM b2cKaW5kZXggODcyZWFkMTIyM2Y3YzBkZDdmZDMzNWE3YjVkODA5NzZhNjBjMmU3Ni4uZTY3YWE1 YTVhMDg4OGQyMzNlNWRhMmY2Y2YyNGM2ODBjMTEzMDdmNiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MTAtMTEtMDkgIFNhbSBNYWdudXNvbiAgPHNtYWdudXNvQGdtYWlsLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIGNyYXNoIHdoZW4gYXR0 ZW1wdGluZyB0byBhZGQgYSBKUyBvYmplY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ5Mjg3CisKKyAgICAgICAgKiBBcGkvcXdlYmZyYW1lLmNwcDoK KyAgICAgICAgKFFXZWJGcmFtZTo6YWRkVG9KYXZhU2NyaXB0V2luZG93T2JqZWN0KToKKworICAg ICAgICBUZXN0OiBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9zYW5kYm94ZWQtaWZyYW1lLXBsdWdp bnMuaHRtbAorCiAyMDEwLTExLTA3ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCg==