49281 2010-11-09 14:36:18 -0800 Remove broken code for embedded CSS xml-stylesheet 2010-11-09 15:09:42 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 306988 0 ap 2010-11-09 14:36:18 -0800 We have code in Document.cpp to support something like <?xml-stylesheet href="#mystyle" type="text/css" ?> <foo id="mystyle">heading { color: red; }</foo> It's not clear to me whether this is supposed to work. The spec <http://www.w3.org/TR/xml-stylesheet/> only says: --------------------------------- It is possible to associate a style sheet that is in the same document as the xml-stylesheet processing instruction by using just a fragment identifier in the href pseudo-attribute. For details on how this is managed in XSLT, see 3.11 Embedded Stylesheet Modules in [XSLT]. --------------------------------- One needs an actual xsl:stylesheet element to reference. For CSS, the analog would be a <style> element, but it makes no sense to reference it - it works by the virtue of being in document. I couldn't make a reference like this work in Firefox. This code is completely untested, and I think that it's wrong, because it sets stylesheet owner node to document, but assigns it to processing instruction node. 306991 1 ap 2010-11-09 14:41:00 -0800 https://bugzilla.mozilla.org/show_bug.cgi?id=61675 306999 2 ap 2010-11-09 14:48:57 -0800 So, it's a bit more useful for Mozilla, because you can style arbitrary XML, not just XHTML. But there is no clarity on how this should work, and our implementation is definitely broken. 307000 3 73423 ap 2010-11-09 14:49:39 -0800 Created attachment 73423 proposed patch 307019 4 ap 2010-11-09 15:09:42 -0800 Committed <http://trac.webkit.org/changeset/71684>. 73423 2010-11-09 14:49:39 -0800 2010-11-09 15:07:26 -0800 proposed patch EmbeddedStylesheet.txt text/plain 2307 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTY4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMDkgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MjgxCisgICAgICAgIFJl bW92ZSBicm9rZW4gY29kZSBmb3IgZW1iZWRkZWQgQ1NTIHhtbC1zdHlsZXNoZWV0CisKKyAgICAg ICAgKiBkb20vRG9jdW1lbnQuY3BwOiAoV2ViQ29yZTo6RG9jdW1lbnQ6OnJlY2FsY1N0eWxlU2Vs ZWN0b3IpOiBUaGlzIG1hZGUgbm8gc2Vuc2UsIHdhcyB1bnRlc3RlZCwKKyAgICAgICAgYW5kIGRp ZG4ndCBtYXRjaCBGaXJlZm94LgorCiAyMDEwLTExLTA5ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpJbmRleDogV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL0RvY3VtZW50 LmNwcAkocmV2aXNpb24gNzE0MjQpCisrKyBXZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTI5MjEsMjYgKzI5MjEsOCBAQCB2b2lkIERvY3VtZW50OjpyZWNhbGNTdHls ZVNlbGVjdG9yKCkKICAgICAgICAgICAgICAgICAgICAgYXBwbHlYU0xUcmFuc2Zvcm0ocGkpOwog ICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIC8vIFdl IGRvbid0IHN1cHBvcnQgbGlua2luZyB0byBlbWJlZGRlZCBDU1Mgc3R5bGVzaGVldHMsIHNlZSA8 aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MjgxPiBmb3IgZGlzY3Vz c2lvbi4KICNlbmRpZgotICAgICAgICAgICAgaWYgKCFzaGVldCAmJiAhcGktPmxvY2FsSHJlZigp LmlzRW1wdHkoKSkgewotICAgICAgICAgICAgICAgIC8vIFByb2Nlc3NpbmcgaW5zdHJ1Y3Rpb24g d2l0aCByZWZlcmVuY2UgdG8gYW4gZWxlbWVudCBpbiB0aGlzIGRvY3VtZW50IC0gZS5nLgotICAg ICAgICAgICAgICAgIC8vIDw/eG1sLXN0eWxlc2hlZXQgaHJlZj0iI215c3R5bGUiPiwgd2l0aCB0 aGUgZWxlbWVudAotICAgICAgICAgICAgICAgIC8vIDxmb28gaWQ9Im15c3R5bGUiPmhlYWRpbmcg eyBjb2xvcjogcmVkOyB9PC9mb28+IGF0IHNvbWUgbG9jYXRpb24gaW4KLSAgICAgICAgICAgICAg ICAvLyB0aGUgZG9jdW1lbnQKLSAgICAgICAgICAgICAgICBFbGVtZW50KiBlbGVtID0gZ2V0RWxl bWVudEJ5SWQocGktPmxvY2FsSHJlZigpLmltcGwoKSk7Ci0gICAgICAgICAgICAgICAgaWYgKGVs ZW0pIHsKLSAgICAgICAgICAgICAgICAgICAgU3RyaW5nIHNoZWV0VGV4dCgiIik7Ci0gICAgICAg ICAgICAgICAgICAgIGZvciAoTm9kZSogYyA9IGVsZW0tPmZpcnN0Q2hpbGQoKTsgYzsgYyA9IGMt Pm5leHRTaWJsaW5nKCkpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIGlmIChjLT5ub2RlVHlw ZSgpID09IFRFWFRfTk9ERSB8fCBjLT5ub2RlVHlwZSgpID09IENEQVRBX1NFQ1RJT05fTk9ERSkK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICBzaGVldFRleHQgKz0gYy0+bm9kZVZhbHVlKCk7 Ci0gICAgICAgICAgICAgICAgICAgIH0KLQotICAgICAgICAgICAgICAgICAgICBSZWZQdHI8Q1NT U3R5bGVTaGVldD4gY3NzU2hlZXQgPSBDU1NTdHlsZVNoZWV0OjpjcmVhdGUodGhpcyk7Ci0gICAg ICAgICAgICAgICAgICAgIGNzc1NoZWV0LT5wYXJzZVN0cmluZyhzaGVldFRleHQpOwotICAgICAg ICAgICAgICAgICAgICBwaS0+c2V0Q1NTU3R5bGVTaGVldChjc3NTaGVldCk7Ci0gICAgICAgICAg ICAgICAgICAgIHNoZWV0ID0gY3NzU2hlZXQuZ2V0KCk7Ci0gICAgICAgICAgICAgICAgfQotICAg ICAgICAgICAgfQogICAgICAgICB9IGVsc2UgaWYgKChuLT5pc0hUTUxFbGVtZW50KCkgJiYgKG4t Pmhhc1RhZ05hbWUobGlua1RhZykgfHwgbi0+aGFzVGFnTmFtZShzdHlsZVRhZykpKQogI2lmIEVO QUJMRShTVkcpCiAgICAgICAgICAgICB8fCAgKG4tPmlzU1ZHRWxlbWVudCgpICYmIG4tPmhhc1Rh Z05hbWUoU1ZHTmFtZXM6OnN0eWxlVGFnKSkK