49273 2010-11-09 13:03:48 -0800 Make showLayerTree() more useful for debugging 2010-11-09 14:52:21 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser abarth eric jamesr simon.fraser webkit.review.bot oldest_to_newest 306944 0 simon.fraser 2010-11-09 13:03:48 -0800 showLayerTree() needs to not force layout, and could show the needsLayout dirty bits. 306952 1 73406 simon.fraser 2010-11-09 13:30:20 -0800 Created attachment 73406 Patch 306959 2 73406 jamesr 2010-11-09 13:47:24 -0800 Comment on attachment 73406 Patch R=me Thanks a lot! This will be very helpful when debugging. 306967 3 simon.fraser 2010-11-09 14:00:09 -0800 http://trac.webkit.org/changeset/71674 307007 4 webkit.review.bot 2010-11-09 14:52:21 -0800 http://trac.webkit.org/changeset/71674 might have broken GTK Linux 32-bit Release The following tests are not passing: fast/text/international/plane2.html 73406 2010-11-09 13:30:20 -0800 2010-11-09 13:47:24 -0800 Patch bug-49273-20101109133019.patch text/plain 5846 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTliNmFiMDQ4ZTljM2IyZDk0NzNhMDQyZTQ2ODcxZTlmY2E3OTA1Yi4uYTY2ODgyMzFmODUwNGFi N2ZlN2ZiNDA4OTA0MjIyMDFkY2I0YjcwMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNSBAQAogMjAxMC0xMS0wOSAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHNob3dMYXllclRyZWUoKSBtb3JlIHVz ZWZ1bCBmb3IgZGVidWdnaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00OTI3MworCisgICAgICAgIFRocmVlIHRoaW5ncyB0byBtYWtlIHNob3dMYXll clRyZWUoKSBtb3JlIHVzZWZ1bCB3aGVuIGNhbGxlZCBmcm9tIGdkYjoKKyAgICAgICAgMS4gQWRk IHNob3dMYXllclRyZWUoUmVuZGVyT2JqZWN0KikKKyAgICAgICAgMi4gTWFrZSBpdCBub3QgdXBk YXRlIGxheW91dCwgc28geW91IGNhbiBjYWxsIGl0IHdoZW4gZGVidWdnaW5nIGxheW91dCBjb2Rl LgorICAgICAgICAzLiBBZGQgb3V0cHV0IG9mIHRoZSAnbmVlZHMgbGF5b3V0JyBmbGFncyBmb3Ig ZWFjaCByZW5kZXJlci4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6Cisg ICAgICAgIChzaG93TGF5ZXJUcmVlKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIu aDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVHJlZUFzVGV4dC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJUcmVlQXNUZXh0Ojp3cml0ZVJlbmRlck9iamVjdCk6CisgICAgICAgIChX ZWJDb3JlOjpleHRlcm5hbFJlcHJlc2VudGF0aW9uKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyVHJlZUFzVGV4dC5oOgorCisyMDEwLTExLTA5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFz ZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgogCiAgICAg ICAgIENhcmV0IGZhaWxzIHRvIHJlbmRlciB3aXRoIHNvbWUgY29tYmluYXRpb24gb2YgaWZyYW1l cyBhbmQgY29tcG9zaXRpbmcKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCAyZjg5ZWI1 ZGQyYmE5YzM5M2I3NmFiOWE4ZjJkNzMwODliNjU2MDg5Li43YjkwMDBjNjU1M2EyNDYyNWEwMGI2 NjY2MWI4ODQzZDAyNzYxZjhiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllci5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0zOTI0 LDggKzM5MjQsMTUgQEAgdm9pZCBzaG93TGF5ZXJUcmVlKGNvbnN0IFdlYkNvcmU6OlJlbmRlckxh eWVyKiBsYXllcikKICAgICAgICAgcmV0dXJuOwogCiAgICAgaWYgKFdlYkNvcmU6OkZyYW1lKiBm cmFtZSA9IGxheWVyLT5yZW5kZXJlcigpLT5mcmFtZSgpKSB7Ci0gICAgICAgIFdURjo6U3RyaW5n IG91dHB1dCA9IGV4dGVybmFsUmVwcmVzZW50YXRpb24oZnJhbWUsIFdlYkNvcmU6OlJlbmRlckFz VGV4dFNob3dBbGxMYXllcnMgfCBXZWJDb3JlOjpSZW5kZXJBc1RleHRTaG93TGF5ZXJOZXN0aW5n IHwgV2ViQ29yZTo6UmVuZGVyQXNUZXh0U2hvd0NvbXBvc2l0ZWRMYXllcnMgfCBXZWJDb3JlOjpS ZW5kZXJBc1RleHRTaG93QWRkcmVzc2VzIHwgV2ViQ29yZTo6UmVuZGVyQXNUZXh0U2hvd0lEQW5k Q2xhc3MpOworICAgICAgICBXVEY6OlN0cmluZyBvdXRwdXQgPSBleHRlcm5hbFJlcHJlc2VudGF0 aW9uKGZyYW1lLCBXZWJDb3JlOjpSZW5kZXJBc1RleHRTaG93QWxsTGF5ZXJzIHwgV2ViQ29yZTo6 UmVuZGVyQXNUZXh0U2hvd0xheWVyTmVzdGluZyB8IFdlYkNvcmU6OlJlbmRlckFzVGV4dFNob3dD b21wb3NpdGVkTGF5ZXJzIHwgV2ViQ29yZTo6UmVuZGVyQXNUZXh0U2hvd0FkZHJlc3NlcyB8IFdl YkNvcmU6OlJlbmRlckFzVGV4dFNob3dJREFuZENsYXNzIHwgV2ViQ29yZTo6UmVuZGVyQXNUZXh0 RG9udFVwZGF0ZUxheW91dCB8IFdlYkNvcmU6OlJlbmRlckFzVGV4dFNob3dMYXlvdXRTdGF0ZSk7 CiAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiJXNcbiIsIG91dHB1dC51dGY4KCkuZGF0YSgpKTsK ICAgICB9CiB9CisKK3ZvaWQgc2hvd0xheWVyVHJlZShjb25zdCBXZWJDb3JlOjpSZW5kZXJPYmpl Y3QqIHJlbmRlcmVyKQoreworICAgIGlmICghcmVuZGVyZXIpCisgICAgICAgIHJldHVybjsKKyAg ICBzaG93TGF5ZXJUcmVlKHJlbmRlcmVyLT5lbmNsb3NpbmdMYXllcigpKTsKK30KICNlbmRpZgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaCBiL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyLmgKaW5kZXggN2U2NzExNTAwMTlhZGM1NGNhYmFmNGRiMmIwNmM1 YjE1MzZkM2YxOC4uMDdjZjJlYzNiODg0MjZjOGMxMDg1Y2YzMTUwMzZlMWU5M2Q3ZTczOCAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaAorKysgYi9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllci5oCkBAIC02OTMsNyArNjkzLDggQEAgcHJpdmF0ZToKIAogI2lm bmRlZiBOREVCVUcKIC8vIE91dHNpZGUgdGhlIFdlYkNvcmUgbmFtZXNwYWNlIGZvciBlYXNlIG9m IGludm9jYXRpb24gZnJvbSBnZGIuCi12b2lkIHNob3dMYXllclRyZWUoY29uc3QgV2ViQ29yZTo6 UmVuZGVyTGF5ZXIqIGxheWVyKTsKK3ZvaWQgc2hvd0xheWVyVHJlZShjb25zdCBXZWJDb3JlOjpS ZW5kZXJMYXllciopOwordm9pZCBzaG93TGF5ZXJUcmVlKGNvbnN0IFdlYkNvcmU6OlJlbmRlck9i amVjdCopOwogI2VuZGlmCiAKICNlbmRpZiAvLyBSZW5kZXJMYXllcl9oCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUcmVlQXNUZXh0LmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRyZWVBc1RleHQuY3BwCmluZGV4IGVjMzZiN2U0MzdhOTg2MzhhY2ExZTVkMGVmZTc3 MDFmODhkNGU0N2QuLmY5M2NkNTU3MDQ5MzI0MGEyODdlZTMxZDkyMWVhMjZlNzIyYzc2ZjEgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRyZWVBc1RleHQuY3BwCisrKyBiL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRyZWVBc1RleHQuY3BwCkBAIC00MTMsNiArNDEzLDQxIEBA IHZvaWQgUmVuZGVyVHJlZUFzVGV4dDo6d3JpdGVSZW5kZXJPYmplY3QoVGV4dFN0cmVhbSYgdHMs IGNvbnN0IFJlbmRlck9iamVjdCYgbywKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0K KyAgICAKKyAgICBpZiAoYmVoYXZpb3IgJiBSZW5kZXJBc1RleHRTaG93TGF5b3V0U3RhdGUpIHsK KyAgICAgICAgYm9vbCBuZWVkc0xheW91dCA9IG8uc2VsZk5lZWRzTGF5b3V0KCkgfHwgby5uZWVk c1Bvc2l0aW9uZWRNb3ZlbWVudExheW91dCgpIHx8IG8ucG9zQ2hpbGROZWVkc0xheW91dCgpIHx8 IG8ubm9ybWFsQ2hpbGROZWVkc0xheW91dCgpOworICAgICAgICBpZiAobmVlZHNMYXlvdXQpCisg ICAgICAgICAgICB0cyA8PCAiIChuZWVkcyBsYXlvdXQ6IjsKKyAgICAgICAgCisgICAgICAgIGJv b2wgaGF2ZVByZXZpb3VzID0gZmFsc2U7CisgICAgICAgIGlmIChvLnNlbGZOZWVkc0xheW91dCgp KSB7CisgICAgICAgICAgICB0cyA8PCAiIHNlbGYiOworICAgICAgICAgICAgaGF2ZVByZXZpb3Vz ID0gdHJ1ZTsKKyAgICAgICAgfQorCisgICAgICAgIGlmIChvLm5lZWRzUG9zaXRpb25lZE1vdmVt ZW50TGF5b3V0KCkpIHsKKyAgICAgICAgICAgIGlmIChoYXZlUHJldmlvdXMpCisgICAgICAgICAg ICAgICAgdHMgPDwgIiwiOworICAgICAgICAgICAgaGF2ZVByZXZpb3VzID0gdHJ1ZTsKKyAgICAg ICAgICAgIHRzIDw8ICIgcG9zaXRpb25lZCBtb3ZlbWVudCI7CisgICAgICAgIH0KKworICAgICAg ICBpZiAoby5ub3JtYWxDaGlsZE5lZWRzTGF5b3V0KCkpIHsKKyAgICAgICAgICAgIGlmIChoYXZl UHJldmlvdXMpCisgICAgICAgICAgICAgICAgdHMgPDwgIiwiOworICAgICAgICAgICAgaGF2ZVBy ZXZpb3VzID0gdHJ1ZTsKKyAgICAgICAgICAgIHRzIDw8ICIgY2hpbGQiOworICAgICAgICB9CisK KyAgICAgICAgaWYgKG8ucG9zQ2hpbGROZWVkc0xheW91dCgpKSB7CisgICAgICAgICAgICBpZiAo aGF2ZVByZXZpb3VzKQorICAgICAgICAgICAgICAgIHRzIDw8ICIsIjsKKyAgICAgICAgICAgIHRz IDw8ICIgcG9zaXRpb25lZCBjaGlsZCI7CisgICAgICAgIH0KKworICAgICAgICBpZiAobmVlZHNM YXlvdXQpCisgICAgICAgICAgICB0cyA8PCAiKSI7CisgICAgfQogCiAjaWYgUExBVEZPUk0oUVQp CiAgICAgLy8gUHJpbnQgYXR0cmlidXRlcyBvZiBlbWJlZGRlZCBRV2lkZ2V0cy4gRS5nLiB3aGVu IHRoZSBXZWJDb3JlOjpXaWRnZXQKQEAgLTY5MSw3ICs3MjYsOCBAQCBTdHJpbmcgZXh0ZXJuYWxS ZXByZXNlbnRhdGlvbihGcmFtZSogZnJhbWUsIFJlbmRlckFzVGV4dEJlaGF2aW9yIGJlaGF2aW9y KQogICAgICAgICBwcmludENvbnRleHQuYmVnaW4oZnJhbWUtPmNvbnRlbnRSZW5kZXJlcigpLT53 aWR0aCgpKTsKICAgICB9CiAKLSAgICBmcmFtZS0+ZG9jdW1lbnQoKS0+dXBkYXRlTGF5b3V0KCk7 CisgICAgaWYgKCEoYmVoYXZpb3IgJiBSZW5kZXJBc1RleHREb250VXBkYXRlTGF5b3V0KSkKKyAg ICAgICAgZnJhbWUtPmRvY3VtZW50KCktPnVwZGF0ZUxheW91dCgpOwogCiAgICAgUmVuZGVyT2Jq ZWN0KiBvID0gZnJhbWUtPmNvbnRlbnRSZW5kZXJlcigpOwogICAgIGlmICghbykKZGlmZiAtLWdp dCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRyZWVBc1RleHQuaCBiL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRyZWVBc1RleHQuaAppbmRleCA1OWEwYWJiMjU2ZDk1NGRhYTc4YmRkZDVmMTYw OGZhYzZhNzMwMjhmLi40YzhiMTQ1ZDVhMDU1YTEyNjFmNmViOWVmZGJjZTVjNDhjNDBmZDk3IDEw MDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUcmVlQXNUZXh0LmgKKysrIGIvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVHJlZUFzVGV4dC5oCkBAIC00OCw3ICs0OCw5IEBAIGVudW0g UmVuZGVyQXNUZXh0QmVoYXZpb3JGbGFncyB7CiAgICAgUmVuZGVyQXNUZXh0U2hvd0NvbXBvc2l0 ZWRMYXllcnMgPSAxIDw8IDIsIC8vIFNob3cgd2hpY2ggbGF5ZXJzIGFyZSBjb21wb3NpdGVkLgog ICAgIFJlbmRlckFzVGV4dFNob3dBZGRyZXNzZXMgPSAxIDw8IDMsIC8vIFNob3cgbGF5ZXIgYW5k IHJlbmRlcmVyIGFkZHJlc3Nlcy4KICAgICBSZW5kZXJBc1RleHRTaG93SURBbmRDbGFzcyA9IDEg PDwgNCwgLy8gU2hvdyBpZCBhbmQgY2xhc3MgYXR0cmlidXRlcwotICAgIFJlbmRlckFzVGV4dFBy aW50aW5nTW9kZSA9IDEgPDwgNSAvLyBEdW1wIHRoZSB0cmVlIGluIHByaW50aW5nIG1vZGUuCisg ICAgUmVuZGVyQXNUZXh0UHJpbnRpbmdNb2RlID0gMSA8PCA1LCAvLyBEdW1wIHRoZSB0cmVlIGlu IHByaW50aW5nIG1vZGUuCisgICAgUmVuZGVyQXNUZXh0RG9udFVwZGF0ZUxheW91dCA9IDEgPDwg NiwgLy8gRG9uJ3QgdXBkYXRlIGxheW91dCwgdG8gbWFrZSBpdCBzYWZlIHRvIGNhbGwgc2hvd0xh eWVyVHJlZSgpIGZyb20gdGhlIGRlYnVnZ2VyIGluc2lkZSBsYXlvdXQgb3IgcGFpbnRpbmcgY29k ZS4KKyAgICBSZW5kZXJBc1RleHRTaG93TGF5b3V0U3RhdGUgPSAxIDw8IDcgLy8gUHJpbnQgdGhl IHZhcmlvdXMgJ25lZWRzIGxheW91dCcgYml0cyBvbiByZW5kZXJlcnMuCiB9OwogdHlwZWRlZiB1 bnNpZ25lZCBSZW5kZXJBc1RleHRCZWhhdmlvcjsKIAo=