49263 2010-11-09 10:34:07 -0800 Add a PageOverlay::Client object in preparation of not allowing subclassing of PageOverlay 2010-11-09 11:12:03 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 306868 0 andersca 2010-11-09 10:34:07 -0800 Add a PageOverlay::Client object in preparation of not allowing subclassing of PageOverlay 306869 1 73390 andersca 2010-11-09 10:37:16 -0800 Created attachment 73390 Patch 306882 2 andersca 2010-11-09 11:12:03 -0800 Committed r71652: <http://trac.webkit.org/changeset/71652> 73390 2010-11-09 10:37:16 -0800 2010-11-09 10:59:35 -0800 Patch bug-49263-20101109103715.patch text/plain 6708 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MjQxNGVkNGRmZTI4Y2U3ZWQ2MWMxYmZkOWYxZjMxNTBhNDVjMDRiNS4uNTQ4NmZkNmJkMWY2OWIy Mzg0ZGRkNDYwMzJhZjVhODRkOThiNTc2OCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzNSBAQAorMjAxMC0xMS0wOSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIFBhZ2VPdmVybGF5OjpDbGllbnQgb2Jq ZWN0IGluIHByZXBhcmF0aW9uIG9mIG5vdCBhbGxvd2luZyBzdWJjbGFzc2luZyBvZiBQYWdlT3Zl cmxheQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDky NjMKKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9GaW5kUGFnZU92ZXJsYXkuY3BwOgor ICAgICAgICAoV2ViS2l0OjpGaW5kUGFnZU92ZXJsYXk6OkZpbmRQYWdlT3ZlcmxheSk6CisgICAg ICAgIENhbGwgdGhlIFBhZ2VPdmVybGF5IGNvbnN0cnVjdG9yLgorCisgICAgICAgIChXZWJLaXQ6 OkZpbmRQYWdlT3ZlcmxheTo6ZHJhd1JlY3QpOgorICAgICAgICAoV2ViS2l0OjpGaW5kUGFnZU92 ZXJsYXk6Om1vdXNlRXZlbnQpOgorICAgICAgICBUaGVzZSBub3cgdGFrZSBhIFBhZ2VPdmVybGF5 IGNhbGxiYWNrLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRQYWdlT3Zlcmxh eS5oOgorICAgICAgICBGaW5kUGFnZU92ZXJsYXkgbm93IGluaGVyaXRzIGZyb20gUGFnZU92ZXJs YXk6OkNsaWVudC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9QYWdlT3ZlcmxheS5j cHA6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VPdmVybGF5OjpjcmVhdGUpOgorICAgICAgICBBZGQg Y3JlYXRlIGZ1bmN0aW9uLgorCisgICAgICAgIChXZWJLaXQ6OlBhZ2VPdmVybGF5OjpQYWdlT3Zl cmxheSk6CisgICAgICAgIFRoZSBjb25zdHJ1Y3RvciBub3cgdGFrZXMgYSBjbGllbnQuCisKKyAg ICAgICAgKFdlYktpdDo6UGFnZU92ZXJsYXk6OmRyYXdSZWN0KToKKyAgICAgICAgKFdlYktpdDo6 UGFnZU92ZXJsYXk6Om1vdXNlRXZlbnQpOgorICAgICAgICBDYWxsIHRoZSBjbGllbnQgbWV0aG9k cy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9QYWdlT3ZlcmxheS5oOgorICAgICAg ICBBZGQgQ2xpZW50IGNsYXNzLgorCiAyMDEwLTExLTA5ICBCYWxhenMgS2VsZW1lbiAgPGtiYWxh enNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMu CmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kUGFnZU92ZXJsYXku Y3BwIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmluZFBhZ2VPdmVybGF5LmNwcAppbmRl eCBiOGY2NjM1MzIyY2ZkNmNiNDIzZWM1ODU2ZjA2YjJjOGU4YTM0YjdkLi5iMThjOTQwMjkxMGRk Y2Q4ZjgwOTRkN2M4NGFlNDliZWZmMjI0Y2I4IDEwMDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9GaW5kUGFnZU92ZXJsYXkuY3BwCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL0ZpbmRQYWdlT3ZlcmxheS5jcHAKQEAgLTUyLDcgKzUyLDggQEAgUGFzc093blB0cjxG aW5kUGFnZU92ZXJsYXk+IEZpbmRQYWdlT3ZlcmxheTo6Y3JlYXRlKEZpbmRDb250cm9sbGVyKiBm aW5kQ29udHJvbGwKIH0KIAogRmluZFBhZ2VPdmVybGF5OjpGaW5kUGFnZU92ZXJsYXkoRmluZENv bnRyb2xsZXIqIGZpbmRDb250cm9sbGVyKQotICAgIDogbV9maW5kQ29udHJvbGxlcihmaW5kQ29u dHJvbGxlcikKKyAgICA6IFBhZ2VPdmVybGF5KHRoaXMpCisgICAgLCBtX2ZpbmRDb250cm9sbGVy KGZpbmRDb250cm9sbGVyKQogewogfQogCkBAIC0xMDQsNyArMTA1LDcgQEAgc3RhdGljIENvbG9y IG92ZXJsYXlCYWNrZ3JvdW5kQ29sb3IoKQogICAgIHJldHVybiBDb2xvcihvdmVybGF5QmFja2dy b3VuZFJlZCwgb3ZlcmxheUJhY2tncm91bmRHcmVlbiwgb3ZlcmxheUJhY2tncm91bmRCbHVlLCBv dmVybGF5QmFja2dyb3VuZEFscGhhKTsKIH0KIAotdm9pZCBGaW5kUGFnZU92ZXJsYXk6OmRyYXdS ZWN0KEdyYXBoaWNzQ29udGV4dCYgZ3JhcGhpY3NDb250ZXh0LCBjb25zdCBJbnRSZWN0JiBkaXJ0 eVJlY3QpCit2b2lkIEZpbmRQYWdlT3ZlcmxheTo6ZHJhd1JlY3QoUGFnZU92ZXJsYXkqLCBHcmFw aGljc0NvbnRleHQmIGdyYXBoaWNzQ29udGV4dCwgY29uc3QgSW50UmVjdCYgZGlydHlSZWN0KQog ewogICAgIFZlY3RvcjxJbnRSZWN0PiByZWN0cyA9IHJlY3RzRm9yVGV4dE1hdGNoZXMoKTsKICAg ICBBU1NFUlQoIXJlY3RzLmlzRW1wdHkoKSk7CkBAIC0xNDUsNyArMTQ2LDcgQEAgdm9pZCBGaW5k UGFnZU92ZXJsYXk6OmRyYXdSZWN0KEdyYXBoaWNzQ29udGV4dCYgZ3JhcGhpY3NDb250ZXh0LCBj b25zdCBJbnRSZWN0JgogICAgIGdyYXBoaWNzQ29udGV4dC5lbmRUcmFuc3BhcmVuY3lMYXllcigp OwogfQogCi1ib29sIEZpbmRQYWdlT3ZlcmxheTo6bW91c2VFdmVudChjb25zdCBXZWJNb3VzZUV2 ZW50JiBldmVudCkKK2Jvb2wgRmluZFBhZ2VPdmVybGF5Ojptb3VzZUV2ZW50KFBhZ2VPdmVybGF5 KiwgY29uc3QgV2ViTW91c2VFdmVudCYgZXZlbnQpCiB7CiAgICAgLy8gSWYgd2UgZ2V0IGEgbW91 c2UgZG93biBldmVudCBpbnNpZGUgdGhlIHBhZ2Ugb3ZlcmxheSB3ZSBzaG91bGQgaGlkZSB0aGUg ZmluZCBVSS4KICAgICBpZiAoZXZlbnQudHlwZSgpID09IFdlYkV2ZW50OjpNb3VzZURvd24gJiYg Ym91bmRzKCkuY29udGFpbnMoZXZlbnQucG9zaXRpb24oKSkpIHsKZGlmZiAtLWdpdCBhL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRQYWdlT3ZlcmxheS5oIGIvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvRmluZFBhZ2VPdmVybGF5LmgKaW5kZXggMDhkMWE0MWFjYzc0ODBkZjA3OWEw MzUwMTI1ZTFkNzdjMTAyNmIzOC4uMzZjZWUzMjFjNDk2MTY4NWEwOWM3NDJhNmZiNjI3YmQ5YmEx M2MxOSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmluZFBhZ2VPdmVy bGF5LmgKKysrIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmluZFBhZ2VPdmVybGF5LmgK QEAgLTM0LDcgKzM0LDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAKIGNsYXNzIEZpbmRDb250cm9s bGVyOwogCi1jbGFzcyBGaW5kUGFnZU92ZXJsYXkgOiBwdWJsaWMgUGFnZU92ZXJsYXkgeworY2xh c3MgRmluZFBhZ2VPdmVybGF5IDogcHVibGljIFBhZ2VPdmVybGF5LCBwdWJsaWMgUGFnZU92ZXJs YXk6OkNsaWVudCB7CiBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NPd25QdHI8RmluZFBhZ2VPdmVy bGF5PiBjcmVhdGUoRmluZENvbnRyb2xsZXIqKTsKICAgICB2aXJ0dWFsIH5GaW5kUGFnZU92ZXJs YXkoKTsKQEAgLTQ1LDkgKzQ1LDkgQEAgcHJpdmF0ZToKICAgICBWZWN0b3I8V2ViQ29yZTo6SW50 UmVjdD4gcmVjdHNGb3JUZXh0TWF0Y2hlcygpOwogICAgIFdlYkNvcmU6OkludFJlY3QgYm91bmRz KCkgY29uc3Q7CiAKLSAgICAvLyBQYWdlT3ZlcmxheS4KLSAgICB2aXJ0dWFsIHZvaWQgZHJhd1Jl Y3QoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0JiwgY29uc3QgV2ViQ29yZTo6SW50UmVjdCYgZGly dHlSZWN0KTsKLSAgICB2aXJ0dWFsIGJvb2wgbW91c2VFdmVudChjb25zdCBXZWJNb3VzZUV2ZW50 Jik7CisgICAgLy8gUGFnZU92ZXJsYXk6OkNsaWVudC4KKyAgICB2aXJ0dWFsIHZvaWQgZHJhd1Jl Y3QoUGFnZU92ZXJsYXkqLCBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQmLCBjb25zdCBXZWJDb3Jl OjpJbnRSZWN0JiBkaXJ0eVJlY3QpOworICAgIHZpcnR1YWwgYm9vbCBtb3VzZUV2ZW50KFBhZ2VP dmVybGF5KiwgY29uc3QgV2ViTW91c2VFdmVudCYpOwogCiAgICAgRmluZENvbnRyb2xsZXIqIG1f ZmluZENvbnRyb2xsZXI7CiB9OwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvUGFnZU92ZXJsYXkuY3BwIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvUGFnZU92ZXJs YXkuY3BwCmluZGV4IDljZWQ5YmZhMTFhYjI3MTczMzZjMzQxYjk5NjEwNTk3Y2IxNTMwNGIuLmQ0 N2I4NDE2NGU5NDFjOGE0ZmYwZWU5ZDg1MmZmNjUxYTVmYzdiZDIgMTAwNjQ0Ci0tLSBhL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1BhZ2VPdmVybGF5LmNwcAorKysgYi9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9QYWdlT3ZlcmxheS5jcHAKQEAgLTMxLDggKzMxLDE0IEBAIHVzaW5nIG5h bWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAotUGFnZU92ZXJsYXk6OlBh Z2VPdmVybGF5KCkKLSAgICA6IG1fd2ViUGFnZSgwKQorUGFzc1JlZlB0cjxQYWdlT3ZlcmxheT4g UGFnZU92ZXJsYXk6OmNyZWF0ZShDbGllbnQqIGNsaWVudCkKK3sKKyAgICByZXR1cm4gYWRvcHRS ZWYobmV3IFBhZ2VPdmVybGF5KGNsaWVudCkpOworfQorCitQYWdlT3ZlcmxheTo6UGFnZU92ZXJs YXkoQ2xpZW50KiBjbGllbnQpCisgICAgOiBtX2NsaWVudChjbGllbnQpCisgICAgLCBtX3dlYlBh Z2UoMCkKIHsKIH0KIApAQCAtNTMsNCArNTksMTQgQEAgdm9pZCBQYWdlT3ZlcmxheTo6c2V0TmVl ZHNEaXNwbGF5KCkKICAgICBtX3dlYlBhZ2UtPmRyYXdpbmdBcmVhKCktPnNldE5lZWRzRGlzcGxh eShJbnRSZWN0KEludFBvaW50KCksIG1fd2ViUGFnZS0+c2l6ZSgpKSk7CiB9CiAKK3ZvaWQgUGFn ZU92ZXJsYXk6OmRyYXdSZWN0KEdyYXBoaWNzQ29udGV4dCYgZ3JhcGhpY3NDb250ZXh0LCBjb25z dCBJbnRSZWN0JiBkaXJ0eVJlY3QpCit7CisgICAgbV9jbGllbnQtPmRyYXdSZWN0KHRoaXMsIGdy YXBoaWNzQ29udGV4dCwgZGlydHlSZWN0KTsKK30KKyAgICAKK2Jvb2wgUGFnZU92ZXJsYXk6Om1v dXNlRXZlbnQoY29uc3QgV2ViTW91c2VFdmVudCYgbW91c2VFdmVudCkKK3sKKyAgICByZXR1cm4g bV9jbGllbnQtPm1vdXNlRXZlbnQodGhpcywgbW91c2VFdmVudCk7Cit9CisKIH0gLy8gbmFtZXNw YWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvUGFnZU92 ZXJsYXkuaCBiL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1BhZ2VPdmVybGF5LmgKaW5kZXgg MDJmZGU0NTUyNDFhMWRmMTc5ZTk5NThjMzViNTdhNTU1YTM5MmRjZi4uMDVjNWY0ZmI5MzRmYjI3 NDdkNjY5ODFlNWE5ODQ0NmJkNTU3YTI4MCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvUGFnZU92ZXJsYXkuaAorKysgYi9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Q YWdlT3ZlcmxheS5oCkBAIC0yNiw3ICsyNiw4IEBACiAjaWZuZGVmIFBhZ2VPdmVybGF5X2gKICNk ZWZpbmUgUGFnZU92ZXJsYXlfaAogCi0jaW5jbHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+CisjaW5j bHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KKyNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogCiBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgY2xhc3MgR3JhcGhpY3NDb250ZXh0OwpAQCAtMzgsMjMg KzM5LDM0IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogY2xhc3MgV2ViTW91c2VFdmVudDsKIGNsYXNz IFdlYlBhZ2U7CiAKLWNsYXNzIFBhZ2VPdmVybGF5IHsKLSAgICBXVEZfTUFLRV9OT05DT1BZQUJM RShQYWdlT3ZlcmxheSk7Ci0KK2NsYXNzIFBhZ2VPdmVybGF5IDogcHVibGljIFJlZkNvdW50ZWQ8 UGFnZU92ZXJsYXk+IHsKIHB1YmxpYzoKLSAgICB2aXJ0dWFsIH5QYWdlT3ZlcmxheSgpOwotICAg IHZpcnR1YWwgdm9pZCBkcmF3UmVjdChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQmLCBjb25zdCBX ZWJDb3JlOjpJbnRSZWN0JiBkaXJ0eVJlY3QpID0gMDsKLSAgICB2aXJ0dWFsIGJvb2wgbW91c2VF dmVudChjb25zdCBXZWJNb3VzZUV2ZW50JikgPSAwOworICAgIGNsYXNzIENsaWVudCB7CisgICAg cHJvdGVjdGVkOgorICAgICAgICB2aXJ0dWFsIH5DbGllbnQoKSB7IH0KKyAgICAKKyAgICBwdWJs aWM6CisgICAgICAgIHZpcnR1YWwgdm9pZCBkcmF3UmVjdChQYWdlT3ZlcmxheSosIFdlYkNvcmU6 OkdyYXBoaWNzQ29udGV4dCYsIGNvbnN0IFdlYkNvcmU6OkludFJlY3QmIGRpcnR5UmVjdCkgPSAw OworICAgICAgICB2aXJ0dWFsIGJvb2wgbW91c2VFdmVudChQYWdlT3ZlcmxheSosIGNvbnN0IFdl Yk1vdXNlRXZlbnQmKSA9IDA7CisgICAgfTsKIAorICAgIHN0YXRpYyBQYXNzUmVmUHRyPFBhZ2VP dmVybGF5PiBjcmVhdGUoQ2xpZW50Kik7CisgICAgdmlydHVhbCB+UGFnZU92ZXJsYXkoKTsKKyAg ICAKICAgICB2b2lkIHNldFBhZ2UoV2ViUGFnZSopOwogICAgIHZvaWQgc2V0TmVlZHNEaXNwbGF5 KCk7CiAKKyAgICB2b2lkIGRyYXdSZWN0KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCYsIGNvbnN0 IFdlYkNvcmU6OkludFJlY3QmIGRpcnR5UmVjdCk7CisgICAgYm9vbCBtb3VzZUV2ZW50KGNvbnN0 IFdlYk1vdXNlRXZlbnQmKTsKKwogcHJvdGVjdGVkOgotICAgIFBhZ2VPdmVybGF5KCk7CisgICAg ZXhwbGljaXQgUGFnZU92ZXJsYXkoQ2xpZW50Kik7CiAKICAgICBXZWJQYWdlKiB3ZWJQYWdlKCkg Y29uc3QgeyByZXR1cm4gbV93ZWJQYWdlOyB9CiAKIHByaXZhdGU6CisgICAgQ2xpZW50KiBtX2Ns aWVudDsKKwogICAgIFdlYlBhZ2UqIG1fd2ViUGFnZTsKIH07CiAK