49253 2010-11-09 07:26:00 -0800 [Qt][WK2] ASSERT fail in fast/frames/lots-of-objects.html 2010-11-09 08:51:15 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 kbalazs webkit-unassigned oldest_to_newest 306777 0 kbalazs 2010-11-09 07:26:00 -0800 > WebKitBuild/Debug/bin/WebKitTestRunner LayoutTests/ast/frames/lots-of-objects.html ASSERTION FAILED: attached (../../../WebKit2/Platform/qt/SharedMemoryQt.cpp:131 static WTF::PassRefPtr<WebKit::SharedMemory> WebKit::SharedMemory::create(const WebKit::SharedMemory::Handle&, WebKit::SharedMemory::Protection)) We should remove the assert and handle the case when the attach is unsuccessful. This can happen when the process that created the shared memory has been already detached from that when we are attaching. In the test, the VisitedLinkProvider creates a new table, send the SetVisitedLinkTable message to the web process, and a bit later WTR terminates and detaches from the shared memory. When the web process sees the message then the shared memory has been already released so it is not attachable. 306785 1 73377 kbalazs 2010-11-09 07:34:57 -0800 Created attachment 73377 Patch 306814 2 73377 kbalazs 2010-11-09 08:51:07 -0800 Comment on attachment 73377 Patch Clearing flags on attachment: 73377 Committed r71638: <http://trac.webkit.org/changeset/71638> 306815 3 kbalazs 2010-11-09 08:51:15 -0800 All reviewed patches have been landed. Closing bug. 73377 2010-11-09 07:34:57 -0800 2010-11-09 08:51:07 -0800 Patch bug-49253-20101109163456.patch text/plain 1648 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg Y2ZhMjgxYjU3OWFhYzliZDVmNzYwYzRjMDEyNWY2NjA1MDNjN2FhYi4uNWMwYjEzZmMzM2Q2YmRh OTIzZGRmMWM0MTc2YzE1YjEzNzRkODU0YSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxMC0xMS0wOSAgQmFs YXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XVtXSzJdIEFTU0VSVCBmYWlsIGluIGZhc3Qv ZnJhbWVzL2xvdHMtb2Ytb2JqZWN0cy5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00OTI1MworCisgICAgICAgICogUGxhdGZvcm0vcXQvU2hhcmVk TWVtb3J5UXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpTaGFyZWRNZW1vcnk6OmNyZWF0ZSk6IERv IG5vdCBhc3NlcnQKKyAgICAgICAgd2hlbiB0aGUgYXR0YWNoIHdhcyB1bnN1Y2Nlc3NmdWwgYnV0 IHJldHVybiB3aXRoIDAuCisKKzIwMTAtMTEtMDkgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3 ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCiAKICAgICAg ICAgW1F0XVtXSzJdIFdlYktpdFRlc3RSdW5uZXIgaXMgZGVhZApkaWZmIC0tZ2l0IGEvV2ViS2l0 Mi9QbGF0Zm9ybS9xdC9TaGFyZWRNZW1vcnlRdC5jcHAgYi9XZWJLaXQyL1BsYXRmb3JtL3F0L1No YXJlZE1lbW9yeVF0LmNwcAppbmRleCBjYTk5N2M1YjVhMmNiZjk4NmVhODlhZTBjMTUyOWNiZTY5 YjE5YjNhLi5lNTM0MWVjZTFhODI2MGQ4MWNlOWZkMTVjNDEwMDNhOWExNjdkNTYwIDEwMDY0NAot LS0gYS9XZWJLaXQyL1BsYXRmb3JtL3F0L1NoYXJlZE1lbW9yeVF0LmNwcAorKysgYi9XZWJLaXQy L1BsYXRmb3JtL3F0L1NoYXJlZE1lbW9yeVF0LmNwcApAQCAtMTI1LDExICsxMjUsMTQgQEAgUGFz c1JlZlB0cjxTaGFyZWRNZW1vcnk+IFNoYXJlZE1lbW9yeTo6Y3JlYXRlKGNvbnN0IEhhbmRsZSYg aGFuZGxlLCBQcm90ZWN0aW9uIHAKICAgICBpZiAoaGFuZGxlLmlzTnVsbCgpKQogICAgICAgICBy ZXR1cm4gMDsKIAotICAgIFJlZlB0cjxTaGFyZWRNZW1vcnk+IHNoYXJlZE1lbW9yeShhZG9wdFJl ZihuZXcgU2hhcmVkTWVtb3J5KSk7CiAgICAgUVNoYXJlZE1lbW9yeSogaW1wbCA9IG5ldyBRU2hh cmVkTWVtb3J5KFFTdHJpbmcoaGFuZGxlLm1fa2V5KSk7CiAgICAgYm9vbCBhdHRhY2hlZCA9IGlt cGwtPmF0dGFjaChhY2Nlc3NNb2RlKHByb3RlY3Rpb24pKTsKLSAgICBBU1NFUlRfVU5VU0VEKGF0 dGFjaGVkLCBhdHRhY2hlZCk7CisgICAgaWYgKCFhdHRhY2hlZCkgeworICAgICAgICBkZWxldGUg aW1wbDsKKyAgICAgICAgcmV0dXJuIDA7CisgICAgfQogCisgICAgUmVmUHRyPFNoYXJlZE1lbW9y eT4gc2hhcmVkTWVtb3J5KGFkb3B0UmVmKG5ldyBTaGFyZWRNZW1vcnkpKTsKICAgICBzaGFyZWRN ZW1vcnktPm1faW1wbCA9IGltcGw7CiAgICAgQVNTRVJUKGhhbmRsZS5tX3NpemUgPT0gaW1wbC0+ c2l6ZSgpKTsKICAgICBzaGFyZWRNZW1vcnktPm1fc2l6ZSA9IGhhbmRsZS5tX3NpemU7Cg==