49251 2010-11-09 06:15:11 -0800 Unused parameter warning causes JSC build failure with deviceorientation 2010-11-09 07:47:19 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned commit-queue oliver steveblock oldest_to_newest 306747 0 steveblock 2010-11-09 06:15:11 -0800 The warnings are due to the ExecState being unused in the JSDeviceMotionEvent and JSDeviceOrientationEvent getters after http://trac.webkit.org/changeset/70496 306748 1 73366 steveblock 2010-11-09 06:20:17 -0800 Created attachment 73366 Patch 306791 2 73366 commit-queue 2010-11-09 07:47:14 -0800 Comment on attachment 73366 Patch Clearing flags on attachment: 73366 Committed r71632: <http://trac.webkit.org/changeset/71632> 306792 3 commit-queue 2010-11-09 07:47:19 -0800 All reviewed patches have been landed. Closing bug. 73366 2010-11-09 06:20:17 -0800 2010-11-09 07:47:14 -0800 Patch bug-49251-20101109142015.patch text/plain 2874 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTYyNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTEtMDkgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVudXNlZCBwYXJhbWV0ZXIgd2FybmluZyBjYXVzZXMgSlNDIGJ1aWxkIGZhaWx1cmUgd2l0aCBk ZXZpY2VvcmllbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDkyNTEKKworICAgICAgICBObyBuZXcgdGVzdHMsIGJ1aWxkIGZpeCBvbmx5Lgor CisgICAgICAgICogYmluZGluZ3MvanMvSlNEZXZpY2VNb3Rpb25FdmVudEN1c3RvbS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpKU0RldmljZU1vdGlvbkV2ZW50OjppbnRlcnZhbCk6CisgICAgICAg ICogYmluZGluZ3MvanMvSlNEZXZpY2VPcmllbnRhdGlvbkV2ZW50Q3VzdG9tLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkpTRGV2aWNlT3JpZW50YXRpb25FdmVudDo6YWxwaGEpOgorICAgICAgICAo V2ViQ29yZTo6SlNEZXZpY2VPcmllbnRhdGlvbkV2ZW50OjpiZXRhKToKKyAgICAgICAgKFdlYkNv cmU6OkpTRGV2aWNlT3JpZW50YXRpb25FdmVudDo6Z2FtbWEpOgorCiAyMDEwLTExLTA5ICBKZW5u IEJyYWl0aHdhaXRlICA8amVubmJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERtaXRyeSBUaXRvdi4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMvSlNEZXZpY2VNb3Rpb25F dmVudEN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0Rldmlj ZU1vdGlvbkV2ZW50Q3VzdG9tLmNwcAkocmV2aXNpb24gNzE1NzUpCisrKyBXZWJDb3JlL2JpbmRp bmdzL2pzL0pTRGV2aWNlTW90aW9uRXZlbnRDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NTMsNyArMTUzLDcgQEAgSlNWYWx1ZSBKU0RldmljZU1vdGlvbkV2ZW50Ojpyb3RhdGlvblJhdAog ICAgIHJldHVybiBjcmVhdGVSb3RhdGlvblJhdGVPYmplY3QoaW1wLT5kZXZpY2VNb3Rpb25EYXRh KCktPnJvdGF0aW9uUmF0ZSgpLCBleGVjKTsKIH0KIAotSlNWYWx1ZSBKU0RldmljZU1vdGlvbkV2 ZW50OjppbnRlcnZhbChFeGVjU3RhdGUqIGV4ZWMpIGNvbnN0CitKU1ZhbHVlIEpTRGV2aWNlTW90 aW9uRXZlbnQ6OmludGVydmFsKEV4ZWNTdGF0ZSopIGNvbnN0CiB7CiAgICAgRGV2aWNlTW90aW9u RXZlbnQqIGltcCA9IHN0YXRpY19jYXN0PERldmljZU1vdGlvbkV2ZW50Kj4oaW1wbCgpKTsKICAg ICBpZiAoIWltcC0+ZGV2aWNlTW90aW9uRGF0YSgpLT5jYW5Qcm92aWRlSW50ZXJ2YWwoKSkKSW5k ZXg6IFdlYkNvcmUvYmluZGluZ3MvanMvSlNEZXZpY2VPcmllbnRhdGlvbkV2ZW50Q3VzdG9tLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTRGV2aWNlT3JpZW50YXRpb25F dmVudEN1c3RvbS5jcHAJKHJldmlzaW9uIDcxNTc1KQorKysgV2ViQ29yZS9iaW5kaW5ncy9qcy9K U0RldmljZU9yaWVudGF0aW9uRXZlbnRDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3 ICszNSw3IEBAIHVzaW5nIG5hbWVzcGFjZSBKU0M7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAot SlNWYWx1ZSBKU0RldmljZU9yaWVudGF0aW9uRXZlbnQ6OmFscGhhKEV4ZWNTdGF0ZSogZXhlYykg Y29uc3QKK0pTVmFsdWUgSlNEZXZpY2VPcmllbnRhdGlvbkV2ZW50OjphbHBoYShFeGVjU3RhdGUq KSBjb25zdAogewogICAgIERldmljZU9yaWVudGF0aW9uRXZlbnQqIGltcCA9IHN0YXRpY19jYXN0 PERldmljZU9yaWVudGF0aW9uRXZlbnQqPihpbXBsKCkpOwogICAgIGlmICghaW1wLT5vcmllbnRh dGlvbigpLT5jYW5Qcm92aWRlQWxwaGEoKSkKQEAgLTQzLDcgKzQzLDcgQEAgSlNWYWx1ZSBKU0Rl dmljZU9yaWVudGF0aW9uRXZlbnQ6OmFscGhhKAogICAgIHJldHVybiBqc051bWJlcihpbXAtPm9y aWVudGF0aW9uKCktPmFscGhhKCkpOwogfQogCi1KU1ZhbHVlIEpTRGV2aWNlT3JpZW50YXRpb25F dmVudDo6YmV0YShFeGVjU3RhdGUqIGV4ZWMpIGNvbnN0CitKU1ZhbHVlIEpTRGV2aWNlT3JpZW50 YXRpb25FdmVudDo6YmV0YShFeGVjU3RhdGUqKSBjb25zdAogewogICAgIERldmljZU9yaWVudGF0 aW9uRXZlbnQqIGltcCA9IHN0YXRpY19jYXN0PERldmljZU9yaWVudGF0aW9uRXZlbnQqPihpbXBs KCkpOwogICAgIGlmICghaW1wLT5vcmllbnRhdGlvbigpLT5jYW5Qcm92aWRlQmV0YSgpKQpAQCAt NTEsNyArNTEsNyBAQCBKU1ZhbHVlIEpTRGV2aWNlT3JpZW50YXRpb25FdmVudDo6YmV0YShFCiAg ICAgcmV0dXJuIGpzTnVtYmVyKGltcC0+b3JpZW50YXRpb24oKS0+YmV0YSgpKTsKIH0KIAotSlNW YWx1ZSBKU0RldmljZU9yaWVudGF0aW9uRXZlbnQ6OmdhbW1hKEV4ZWNTdGF0ZSogZXhlYykgY29u c3QKK0pTVmFsdWUgSlNEZXZpY2VPcmllbnRhdGlvbkV2ZW50OjpnYW1tYShFeGVjU3RhdGUqKSBj b25zdAogewogICAgIERldmljZU9yaWVudGF0aW9uRXZlbnQqIGltcCA9IHN0YXRpY19jYXN0PERl dmljZU9yaWVudGF0aW9uRXZlbnQqPihpbXBsKCkpOwogICAgIGlmICghaW1wLT5vcmllbnRhdGlv bigpLT5jYW5Qcm92aWRlR2FtbWEoKSkK