49249 2010-11-09 05:28:05 -0800 Output of old-run-webkit-tests is buggy in verbose mode 2010-11-09 07:18:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ossy ossy commit-queue kling vestbo oldest_to_newest 306734 0 ossy 2010-11-09 05:28:05 -0800 output without verbose option: ------------------------------- svg/custom ....................................................... svg/custom/mask-colorspace.svg -> new ............... buggy output with verbose option: ---------------------------------- ... running svg/custom/marker-referencePoint.svg -> succeeded running svg/custom/marker-strokeWidth-changes.svg -> succeeded running svg/custom/mask-colorspace.svg -> new test new running svg/custom/mask-invalidation.svg -> succeeded running svg/custom/mask-on-multiple-objects.svg -> succeeded ... expected output with verbose option: ------------------------------------- ... running svg/custom/marker-referencePoint.svg -> succeeded running svg/custom/marker-strokeWidth-changes.svg -> succeeded running svg/custom/mask-colorspace.svg -> new test running svg/custom/mask-invalidation.svg -> succeeded running svg/custom/mask-on-multiple-objects.svg -> succeeded ... 306739 1 73364 ossy 2010-11-09 05:34:14 -0800 Created attachment 73364 proposed fix 306742 2 73364 vestbo 2010-11-09 05:49:25 -0800 Comment on attachment 73364 proposed fix LGTM, this has been annoying me as well 306754 3 73364 commit-queue 2010-11-09 06:24:21 -0800 Comment on attachment 73364 proposed fix Rejecting patch 73364 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: ...................... java/lc3/JSObject ............. java/lc3/JSObject/ToObject-001.html -> failed Exiting early after 1 failures. 17829 tests run. 304.70s total testing time 17828 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) had stderr output Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-new-test-results', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd']" exit_code: 1 layout 6 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/5539057 306755 4 73364 ossy 2010-11-09 06:26:53 -0800 Comment on attachment 73364 proposed fix Andreas told me, that --new-test-results --verbose mode is still buggy: ... running svg/text/select-textLength-spacingAndGlyphs-stretch-2.svg -> new test new (results generated in /home/oszi/WebKit/LayoutTests/platform/qt/svg/text) ... I propose the following output for this case: ... running svg/text/select-textLength-spacingAndGlyphs-stretch-2.svg -> new test (results generated in /home/oszi/WebKit/LayoutTests/platform/qt/svg/text) ... New patch is coming soon. 306762 5 73371 ossy 2010-11-09 06:59:31 -0800 Created attachment 73371 proposed fix v2 With this new, sophisticated patch we will get the following outputs: without option: ---------------- svg/text . svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg -> new . svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg -> new with --verbose option: ----------------------- running svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg -> new test running svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg -> new test with --new-test-results option: -------------------------------- svg/text . svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg -> new (results generated in /home/oszi/WebKit/LayoutTests/platform/qt/svg/text) . svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg -> new (results generated in /home/oszi/WebKit/LayoutTests/platform/qt/svg/text) with --verbose --new-test-results options: ------------------------------------------- running svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg -> new test (results generated in /home/oszi/WebKit/LayoutTests/platform/qt/svg/text) running svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg -> new test (results generated in /home/oszi/WebKit/LayoutTests/platform/qt/svg/text) 306771 6 ossy 2010-11-09 07:17:52 -0800 Landed in http://trac.webkit.org/changeset/71627 73364 2010-11-09 05:34:14 -0800 2010-11-09 06:26:53 -0800 proposed fix 1.patch text/plain 1153 ossy ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjODhjZTNlLi5iZGM2MTY0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTEt MDkgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdXRwdXQgb2Ygb2xkLXJ1bi13ZWJr aXQtdGVzdHMgaXMgYnVnZ3kgaW4gdmVyYm9zZSBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTI0OQorCisgICAgICAgICogU2NyaXB0cy9vbGQt cnVuLXdlYmtpdC10ZXN0czogUmVkdW5kYW50IHByaW50aW5nIG9mICJuZXciIHJlbW92ZWQgaW4g dmVyYm9zZSBtb2RlLgorCiAyMDEwLTExLTA4ICBOaWNvbGFzIER1ZnJlc25lICA8bmljb2xhcy5k dWZyZXNuZUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJv Ymluc29uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10 ZXN0cyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKaW5kZXggMmNl ZjE4Yi4uZTg4ODFhOCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdl YmtpdC10ZXN0cworKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3Rz CkBAIC05MzgsNyArOTM4LDcgQEAgZm9yIG15ICR0ZXN0IChAdGVzdHMpIHsKICAgICAgICAgICAg IG15ICRyZXN1bHRzRGlyID0gY2F0ZGlyKCRleHBlY3RlZERpciwgZGlybmFtZSgkYmFzZSkpOwog ICAgICAgICAgICAgaWYgKCRnZW5lcmF0ZU5ld1Jlc3VsdHMpIHsKICAgICAgICAgICAgICAgICBw cmludCAibmV3IChyZXN1bHRzIGdlbmVyYXRlZCBpbiAkcmVzdWx0c0RpcilcbiI7Ci0gICAgICAg ICAgICB9IGVsc2UgeworICAgICAgICAgICAgfSBlbHNpZiAoISR2ZXJib3NlKSB7CiAgICAgICAg ICAgICAgICAgcHJpbnQgIm5ld1xuIjsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgICRhdExp bmVTdGFydCA9IDE7Cg== 73371 2010-11-09 06:59:31 -0800 2010-11-09 07:18:03 -0800 proposed fix v2 1.patch text/plain 1780 ossy ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjODhjZTNlLi4xNmVmNGIxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTEt MDkgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdXRwdXQgb2Ygb2xkLXJ1bi13ZWJr aXQtdGVzdHMgaXMgYnVnZ3kgaW4gdmVyYm9zZSBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTI0OQorCisgICAgICAgICogU2NyaXB0cy9vbGQt cnVuLXdlYmtpdC10ZXN0czogUmVkdW5kYW50IG91dHB1dHMgcmVtb3ZlZC4KKwogMjAxMC0xMS0w OCAgTmljb2xhcyBEdWZyZXNuZSAgPG5pY29sYXMuZHVmcmVzbmVAY29sbGFib3JhLmNvLnVrPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1dlYktp dFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMgYi9XZWJLaXRUb29scy9TY3JpcHRz L29sZC1ydW4td2Via2l0LXRlc3RzCmluZGV4IDJjZWYxOGIuLmU2YjUwYjEgMTAwNzU1Ci0tLSBh L1dlYktpdFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKKysrIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwpAQCAtOTE3LDggKzkxNyw3IEBAIGZvciBt eSAkdGVzdCAoQHRlc3RzKSB7CiAgICAgICAgIHRlc3RDcmFzaGVkT3JUaW1lZE91dCgkdGVzdCwg JGJhc2UsIDEsICRhY3R1YWwsICRlcnJvcik7CiAgICAgfSBlbHNpZiAoIWRlZmluZWQgJGV4cGVj dGVkKSB7CiAgICAgICAgIGlmICgkdmVyYm9zZSkgewotICAgICAgICAgICAgcHJpbnQgIm5ldyAi IC4gKCRyZXNldFJlc3VsdHMgPyAicmVzdWx0IiA6ICJ0ZXN0IikgLiJcbiI7Ci0gICAgICAgICAg ICAkYXRMaW5lU3RhcnQgPSAxOworICAgICAgICAgICAgcHJpbnQgIm5ldyAiIC4gKCRyZXNldFJl c3VsdHMgPyAicmVzdWx0IiA6ICJ0ZXN0Iik7CiAgICAgICAgIH0KICAgICAgICAgJHJlc3VsdCA9 ICJuZXciOwogCkBAIC05MzYsMTEgKzkzNSwxMyBAQCBmb3IgbXkgJHRlc3QgKEB0ZXN0cykgewog ICAgICAgICAgICAgICAgIHByaW50ICIkdGVzdCAtPiAiOwogICAgICAgICAgICAgfQogICAgICAg ICAgICAgbXkgJHJlc3VsdHNEaXIgPSBjYXRkaXIoJGV4cGVjdGVkRGlyLCBkaXJuYW1lKCRiYXNl KSk7CisgICAgICAgICAgICBpZiAoISR2ZXJib3NlKSB7CisgICAgICAgICAgICAgICAgcHJpbnQg Im5ldyI7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICBpZiAoJGdlbmVyYXRlTmV3UmVzdWx0 cykgewotICAgICAgICAgICAgICAgIHByaW50ICJuZXcgKHJlc3VsdHMgZ2VuZXJhdGVkIGluICRy ZXN1bHRzRGlyKVxuIjsKLSAgICAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgcHJp bnQgIm5ld1xuIjsKKyAgICAgICAgICAgICAgICBwcmludCAiIChyZXN1bHRzIGdlbmVyYXRlZCBp biAkcmVzdWx0c0RpcikiOwogICAgICAgICAgICAgfQorICAgICAgICAgICAgcHJpbnQgIlxuIiB1 bmxlc3MgJGF0TGluZVN0YXJ0OwogICAgICAgICAgICAgJGF0TGluZVN0YXJ0ID0gMTsKICAgICAg ICAgfQogICAgIH0gZWxzaWYgKCRhY3R1YWwgZXEgJGV4cGVjdGVkICYmICRkaWZmUmVzdWx0IGVx ICJwYXNzZWQiKSB7Cg==