49234 2010-11-08 18:59:50 -0800 gtk platform doesn't support link prefetch 2010-11-09 05:35:02 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 gavinp webkit-unassigned abarth commit-queue eric webkit.review.bot xan.lopez oldest_to_newest 306565 0 gavinp 2010-11-08 18:59:50 -0800 The configure script used for the GTK platform doesn't at present pass through the link prefetch feature in WebKit. It probably should. 306567 1 73336 gavinp 2010-11-08 19:03:44 -0800 Created attachment 73336 Patch 306571 2 gavinp 2010-11-08 19:06:19 -0800 Xan, Can you look at this? Manual testing shows that it works with build-webkit and ./configure, and prefetch validation sites show it working. 306578 3 73336 xan.lopez 2010-11-08 19:43:28 -0800 Comment on attachment 73336 Patch >+AM_CONDITIONAL([ENABLE_LINK_PREFETCH],[test "$enable_link_prefetch" = "yes"]) I think you only need this if you are going to use the variable in a makefile. Since you won't it's unneeded. > > # Gtk conditionals > AM_CONDITIONAL([ENABLE_INTROSPECTION],[test "$enable_introspection" = "yes"]) >@@ -1027,6 +1039,7 @@ Features: > XHTML-MP support : $enable_xhtmlmp > XPATH support : $enable_xpath > XSLT support : $enable_xslt >+ Link prefetch support : $enable_link_prefetch This should be in alphabetical order. > GTK+ configuration: > GTK+ version : $with_gtk > GDK target : $with_target r- for those reasons, thanks for the patch. 306583 4 73338 gavinp 2010-11-08 20:05:47 -0800 Created attachment 73338 Patch 306692 5 73338 commit-queue 2010-11-09 04:05:16 -0800 Comment on attachment 73338 Patch Clearing flags on attachment: 73338 Committed r71620: <http://trac.webkit.org/changeset/71620> 306693 6 commit-queue 2010-11-09 04:05:20 -0800 All reviewed patches have been landed. Closing bug. 306740 7 webkit.review.bot 2010-11-09 05:35:02 -0800 http://trac.webkit.org/changeset/71620 might have broken GTK Linux 64-bit Debug The following tests are not passing: fast/text/international/plane2.html 73336 2010-11-08 19:03:44 -0800 2010-11-08 20:05:43 -0800 Patch bug-49234-20101108220342.patch text/plain 2357 gavinp ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBhNWUyMzUwM2U4MDAyNWY4 NWU3YTlmMjQ5MWIyYzUzYTg1MjQzNWViLi45NTVmN2RiMjIzM2RiNmZiNWZmM2U4YzViMzMwNjhk NzA3NGQ2ZWY2IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTAtMTEtMDggIEdhdmluIFBldGVycyAgPGdhdmlucEBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZ3RrIHBs YXRmb3JtIGRvZXNuJ3Qgc3VwcG9ydCBsaW5rIHByZWZldGNoCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTIzNAorCisgICAgICAgICogY29uZmlndXJl LmFjOgorCiAyMDEwLTExLTA0ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL2NvbmZp Z3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCA2N2JhYjlmZDk2MzJhZGJhNmE4OWM0NjMzZmIy YjZmOTc0YzYxZDY1Li44YmY2M2M3MWQxNTVjMTg0YzgwNjlkNTkxMTY1ZDYzNDQ3MmM2OGJkIDEw MDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC03MzUsNiArNzM1 LDE3IEBAIGlmIHRlc3QgIiRlbmFibGVfb3Bjb2RlX3N0YXRzIiA9ICJ5ZXMiOyB0aGVuCiAgIEFD X0RFRklORShbRU5BQkxFX09QQ09ERV9TVEFUU10sIFsxXSwgW0RlZmluZSB0byBlbmFibGUgT3Bj b2RlIHN0YXRpc3RpY3NdKQogZmkKIAorIyBMaW5rIHByZWZldGNoCitBQ19NU0dfQ0hFQ0tJTkco W3doZXRoZXIgdG8gZW5hYmxlIGxpbmsgcHJlZmV0Y2ggc3VwcG9ydF0pCitBQ19BUkdfRU5BQkxF KFtsaW5rLXByZWZldGNoXSwKKyAgW0FTX0hFTFBfU1RSSU5HKFstLWVuYWJsZS1saW5rLXByZWZl dGNoXSwgW0VuYWJsZSBMaW5rIHByZWZldGNoIHN1cHBvcnQgKGRlZmF1bHQ6IGRpc2FibGVkKV0p XSwKKyAgW10sW2VuYWJsZV9saW5rX3ByZWZldGNoPW5vXSkKK0FDX01TR19SRVNVTFQoWyRlbmFi bGVfbGlua19wcmVmZXRjaF0pCisKK2lmIHRlc3QgIiRlbmFibGVfbGlua19wcmVmZXRjaCIgPSAi eWVzIjsgdGhlbiAKKyAgQUNfREVGSU5FKFtFTkFCTEVfTElOS19QUkVGRVRDSF0sIFsxXSwgW0Rl ZmluZSB0byBlbmFibGUgbGluayBwcmVmZXRjaCBzdXBwb3J0XSkKK2ZpCisKICMgR09iamVjdCBJ bnRyb3NwZWN0aW9uCiBBQ19NU0dfQ0hFQ0tJTkcoW3doZXRoZXIgdG8gZW5hYmxlIEdPYmplY3Qg aW50cm9zcGVjdGlvbiBzdXBwb3J0XSkKIEFDX0FSR19FTkFCTEUoW2ludHJvc3BlY3Rpb25dLApA QCAtOTU3LDYgKzk2OCw3IEBAIEFNX0NPTkRJVElPTkFMKFtIVE1MX0ZMQUdTXSxbdGVzdCAiJGh0 bWxfZmxhZ3MiID0gInllcyJdKQogQU1fQ09ORElUSU9OQUwoW0VOQUJMRV9XRUJfU09DS0VUU10s W3Rlc3QgIiRlbmFibGVfd2ViX3NvY2tldHMiID0gInllcyJdKQogQU1fQ09ORElUSU9OQUwoW0VO QUJMRV9XRUJfVElNSU5HXSxbdGVzdCAiJGVuYWJsZV93ZWJfdGltaW5nIiA9ICJ5ZXMiXSkKIEFN X0NPTkRJVElPTkFMKFtFTkFCTEVfT1BDT0RFX1NUQVRTXSxbdGVzdCAiJGVuYWJsZV9vcGNvZGVf c3RhdHMiID0gInllcyJdKQorQU1fQ09ORElUSU9OQUwoW0VOQUJMRV9MSU5LX1BSRUZFVENIXSxb dGVzdCAiJGVuYWJsZV9saW5rX3ByZWZldGNoIiA9ICJ5ZXMiXSkKIAogIyBHdGsgY29uZGl0aW9u YWxzCiBBTV9DT05ESVRJT05BTChbRU5BQkxFX0lOVFJPU1BFQ1RJT05dLFt0ZXN0ICIkZW5hYmxl X2ludHJvc3BlY3Rpb24iID0gInllcyJdKQpAQCAtMTAyNyw2ICsxMDM5LDcgQEAgRmVhdHVyZXM6 CiAgWEhUTUwtTVAgc3VwcG9ydCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgOiAkZW5hYmxlX3hodG1sbXAKICBYUEFUSCBzdXBwb3J0ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICA6ICRlbmFibGVfeHBhdGgKICBYU0xUIHN1cHBvcnQgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6ICRlbmFibGVfeHNsdAor IExpbmsgcHJlZmV0Y2ggc3VwcG9ydCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IDogJGVuYWJsZV9saW5rX3ByZWZldGNoCiBHVEsrIGNvbmZpZ3VyYXRpb246CiAgR1RLKyB2ZXJz aW9uICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAkd2l0aF9n dGsKICBHREsgdGFyZ2V0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICA6ICR3aXRoX3RhcmdldAo= 73338 2010-11-08 20:05:47 -0800 2010-11-09 04:05:16 -0800 Patch bug-49234-20101108230545.patch text/plain 2397 gavinp ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBhNWUyMzUwM2U4MDAyNWY4 NWU3YTlmMjQ5MWIyYzUzYTg1MjQzNWViLi45NTVmN2RiMjIzM2RiNmZiNWZmM2U4YzViMzMwNjhk NzA3NGQ2ZWY2IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTAtMTEtMDggIEdhdmluIFBldGVycyAgPGdhdmlucEBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZ3RrIHBs YXRmb3JtIGRvZXNuJ3Qgc3VwcG9ydCBsaW5rIHByZWZldGNoCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTIzNAorCisgICAgICAgICogY29uZmlndXJl LmFjOgorCiAyMDEwLTExLTA0ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL2NvbmZp Z3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCA2N2JhYjlmZDk2MzJhZGJhNmE4OWM0NjMzZmIy YjZmOTc0YzYxZDY1Li5kOWQzMGMxMWViMDViNDk3ZDY0YmRmYzE5MzYzMjBkMmRlOGVkMjJmIDEw MDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC03MzUsNiArNzM1 LDE3IEBAIGlmIHRlc3QgIiRlbmFibGVfb3Bjb2RlX3N0YXRzIiA9ICJ5ZXMiOyB0aGVuCiAgIEFD X0RFRklORShbRU5BQkxFX09QQ09ERV9TVEFUU10sIFsxXSwgW0RlZmluZSB0byBlbmFibGUgT3Bj b2RlIHN0YXRpc3RpY3NdKQogZmkKIAorIyBMaW5rIHByZWZldGNoCitBQ19NU0dfQ0hFQ0tJTkco W3doZXRoZXIgdG8gZW5hYmxlIGxpbmsgcHJlZmV0Y2ggc3VwcG9ydF0pCitBQ19BUkdfRU5BQkxF KFtsaW5rLXByZWZldGNoXSwKKyAgW0FTX0hFTFBfU1RSSU5HKFstLWVuYWJsZS1saW5rLXByZWZl dGNoXSwgW0VuYWJsZSBMaW5rIHByZWZldGNoIHN1cHBvcnQgKGRlZmF1bHQ6IGRpc2FibGVkKV0p XSwKKyAgW10sW2VuYWJsZV9saW5rX3ByZWZldGNoPW5vXSkKK0FDX01TR19SRVNVTFQoWyRlbmFi bGVfbGlua19wcmVmZXRjaF0pCisKK2lmIHRlc3QgIiRlbmFibGVfbGlua19wcmVmZXRjaCIgPSAi eWVzIjsgdGhlbiAKKyAgQUNfREVGSU5FKFtFTkFCTEVfTElOS19QUkVGRVRDSF0sIFsxXSwgW0Rl ZmluZSB0byBlbmFibGUgbGluayBwcmVmZXRjaCBzdXBwb3J0XSkKK2ZpCisKICMgR09iamVjdCBJ bnRyb3NwZWN0aW9uCiBBQ19NU0dfQ0hFQ0tJTkcoW3doZXRoZXIgdG8gZW5hYmxlIEdPYmplY3Qg aW50cm9zcGVjdGlvbiBzdXBwb3J0XSkKIEFDX0FSR19FTkFCTEUoW2ludHJvc3BlY3Rpb25dLApA QCAtMTAxMSw2ICsxMDIyLDcgQEAgRmVhdHVyZXM6CiAgSFRNTDUgdmlkZW8gZWxlbWVudCBzdXBw b3J0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAkZW5hYmxlX3ZpZGVvCiAgSWNvbiBk YXRhYmFzZSBzdXBwb3J0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAkZW5h YmxlX2ljb25fZGF0YWJhc2UKICBJbWFnZSByZXNpemVyIHN1cHBvcnQgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICA6ICRlbmFibGVfaW1hZ2VfcmVzaXplcgorIExpbmsgcHJlZmV0 Y2ggc3VwcG9ydCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogJGVuYWJsZV9s aW5rX3ByZWZldGNoCiAgT3Bjb2RlIHN0YXRzICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgOiAkZW5hYmxlX29wY29kZV9zdGF0cwogIFNoYXJlZFdvcmtlcnMgc3Vw cG9ydCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogJGVuYWJsZV9zaGFyZWRf d29ya2VycwogIFNwZWVjaCBpbnB1dCBzdXBwb3J0ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIDogJGVuYWJsZV9pbnB1dF9zcGVlY2gKQEAgLTEwMjcsNiArMTAzOSw3IEBAIEZl YXR1cmVzOgogIFhIVE1MLU1QIHN1cHBvcnQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIDogJGVuYWJsZV94aHRtbG1wCiAgWFBBVEggc3VwcG9ydCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAkZW5hYmxlX3hwYXRoCiAgWFNMVCBzdXBw b3J0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAkZW5hYmxl X3hzbHQKKwogR1RLKyBjb25maWd1cmF0aW9uOgogIEdUSysgdmVyc2lvbiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogJHdpdGhfZ3RrCiAgR0RLIHRhcmdldCAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAkd2l0aF90YXJn ZXQK