49231 2010-11-08 18:31:01 -0800 getAttachedShaders should only return null (not undefined) on error 2010-11-09 00:59:01 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 1 enne enne commit-queue enne kbr oldest_to_newest 306544 0 enne 2010-11-08 18:31:01 -0800 Currently gl-object-get-calls allows getAttachedShaders to return undefined or null in the case of an error. It should only allow null. This is to fix a minor issue from https://bugs.webkit.org/show_bug.cgi?id=48962. 306547 1 73330 enne 2010-11-08 18:33:51 -0800 Created attachment 73330 Patch 306548 2 enne 2010-11-08 18:35:09 -0800 (In reply to comment #1) > Created an attachment (id=73330) [details] > Patch Already updated in the Khronos repository. Tested on 10.6. 306638 3 73330 kling 2010-11-09 00:21:50 -0800 Comment on attachment 73330 Patch LGTM 306655 4 73330 commit-queue 2010-11-09 00:58:57 -0800 Comment on attachment 73330 Patch Clearing flags on attachment: 73330 Committed r71615: <http://trac.webkit.org/changeset/71615> 306656 5 commit-queue 2010-11-09 00:59:01 -0800 All reviewed patches have been landed. Closing bug. 73330 2010-11-08 18:33:51 -0800 2010-11-09 00:58:57 -0800 Patch bug-49231-20101108183349.patch text/plain 2445 enne ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlMDYxMjZmODI1YWU4ZjIxMDM2OGRkMDNlNWQ2MjczMzJlODAxYjcwLi43Y2EyODVj NTRiZmM2YzU1ODk1NjYxZjU0ZmIwNWJlNDFlNzAzM2Y3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTEtMDggIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBnZXRBdHRhY2hlZFNoYWRl cnMgc2hvdWxkIG9ubHkgcmV0dXJuIE5VTEwgaW4gdGhlIGNhc2Ugb2YgZXJyb3IuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTIzMQorCisgICAgICAg ICogZmFzdC9jYW52YXMvd2ViZ2wvZ2wtb2JqZWN0LWdldC1jYWxscy1leHBlY3RlZC50eHQ6Cisg ICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvZ2wtb2JqZWN0LWdldC1jYWxscy5odG1sOgorCiAy MDEwLTExLTA1ICBGdW1pdG9zaGkgVWthaSAgPHVrYWlAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9n bC1vYmplY3QtZ2V0LWNhbGxzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFz L3dlYmdsL2dsLW9iamVjdC1nZXQtY2FsbHMtZXhwZWN0ZWQudHh0CmluZGV4IGZlMzJiNWEzNjYx N2ZkYTM2ZmM5NDZmOTUxZTQ2YmQ2MDRkODRlMjEuLjQ5YTRjNzZmYzIyMjk5MTlkMDk2YmRkZGNj NDA1OTA2ZjljY2MxMmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmds L2dsLW9iamVjdC1nZXQtY2FsbHMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv Y2FudmFzL3dlYmdsL2dsLW9iamVjdC1nZXQtY2FsbHMtZXhwZWN0ZWQudHh0CkBAIC01LDcgKzUs NyBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2Vz LCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURQogUEFTUyBzaGFkZXJzLmxlbmd0aCBpcyAyCiBQ QVNTIHNoYWRlcnNbMF0gPT0gc3RhbmRhcmRWZXJ0ICYmIHNoYWRlcnNbMV0gPT0gc3RhbmRhcmRG cmFnIHx8IHNoYWRlcnNbMV0gPT0gc3RhbmRhcmRWZXJ0ICYmIHNoYWRlcnNbMF0gPT0gc3RhbmRh cmRGcmFnIGlzIHRydWUKIFBBU1MgZ2V0RXJyb3Igd2FzIGV4cGVjdGVkIHZhbHVlOiBOT19FUlJP UiA6IAotUEFTUyBnbC5nZXRBdHRhY2hlZFNoYWRlcnMobnVsbCkgPT0gdW5kZWZpbmVkIGlzIHRy dWUKK1BBU1MgZ2wuZ2V0QXR0YWNoZWRTaGFkZXJzKG51bGwpIGlzIG51bGwKIFBBU1MgZ2V0RXJy b3Igd2FzIGV4cGVjdGVkIHZhbHVlOiBJTlZBTElEX1ZBTFVFIDogCiBQQVNTIGdsLmdldEF0dGFj aGVkU2hhZGVycyhzdGFuZGFyZFZlcnQpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IFR5cGUg ZXJyb3IuCiBQQVNTIGdldEVycm9yIHdhcyBleHBlY3RlZCB2YWx1ZTogTk9fRVJST1IgOiAKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2dsLW9iamVjdC1nZXQtY2Fs bHMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2dsLW9iamVjdC1nZXQtY2Fs bHMuaHRtbAppbmRleCA1NjQzOWRiZTc1Y2FmNGI0ZWMyNWZhOTU5Zjk0Yjk5ZTFiY2Y0NjljLi5j ZGRkZWZlMTU2YTU0NmU2YWZlOThjNjBlOWExYTY4YTZmOWYzZWQ5IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC1vYmplY3QtZ2V0LWNhbGxzLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZ2wtb2JqZWN0LWdldC1jYWxscy5odG1sCkBA IC00MCw3ICs0MCw3IEBAIHZhciBzaGFkZXJzID0gZ2wuZ2V0QXR0YWNoZWRTaGFkZXJzKHN0YW5k YXJkUHJvZ3JhbSk7CiBzaG91bGRCZSgnc2hhZGVycy5sZW5ndGgnLCAnMicpOwogc2hvdWxkQmVU cnVlKCdzaGFkZXJzWzBdID09IHN0YW5kYXJkVmVydCAmJiBzaGFkZXJzWzFdID09IHN0YW5kYXJk RnJhZyB8fCBzaGFkZXJzWzFdID09IHN0YW5kYXJkVmVydCAmJiBzaGFkZXJzWzBdID09IHN0YW5k YXJkRnJhZycpOwogZ2xFcnJvclNob3VsZEJlKGdsLCBnbC5OT19FUlJPUik7Ci1zaG91bGRCZVRy dWUoJ2dsLmdldEF0dGFjaGVkU2hhZGVycyhudWxsKSA9PSB1bmRlZmluZWQnKTsKK3Nob3VsZEJl TnVsbCgnZ2wuZ2V0QXR0YWNoZWRTaGFkZXJzKG51bGwpJyk7CiBnbEVycm9yU2hvdWxkQmUoZ2ws IGdsLklOVkFMSURfVkFMVUUpOwogc2hvdWxkVGhyb3coJ2dsLmdldEF0dGFjaGVkU2hhZGVycyhz dGFuZGFyZFZlcnQpJyk7CiBnbEVycm9yU2hvdWxkQmUoZ2wsIGdsLk5PX0VSUk9SKTsK