49229 2010-11-08 18:07:25 -0800 Add ENABLE(INSPECTOR) guards 2010-11-14 16:09:56 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED DUPLICATE 49500 P2 Normal --- 0 skyul webkit-unassigned oldest_to_newest 306531 0 skyul 2010-11-08 18:07:25 -0800 Build fix. Add ENABLE(INSPECTOR) to ConsoleMessage, ScriptCallFrame and ScriptCallStack. 306535 1 73326 skyul 2010-11-08 18:14:26 -0800 Created attachment 73326 Patch 307261 2 73326 laszlo.gombos 2010-11-10 02:10:28 -0800 Comment on attachment 73326 Patch The approach so far has been to flag the dependencies only in the body so that the flag does not bleed over. I'd like to continue this approach. Would it be possible to address the build problem without changing the following headers: inspector/ConsoleMessage.h inspector/ScriptCallFrame.h inspector/ScriptCallStack.h 309022 3 skyul 2010-11-13 16:09:50 -0800 *** This bug has been marked as a duplicate of bug 49500 *** 73326 2010-11-08 18:14:26 -0800 2010-11-14 16:09:56 -0800 Patch inspector.patch text/plain 4536 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTU5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTEtMDggIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgRU5BQkxFKElOU1BFQ1RPUikgZ3VhcmRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTIyOQorCisgICAgICAgIEJ1aWxkIGZpeC4gQWRkIEVO QUJMRShJTlNQRUNUT1IpIHRvIENvbnNvbGVNZXNzYWdlLCBTY3JpcHRDYWxsRnJhbWUgYW5kIFNj cmlwdENhbGxTdGFjay4KKworICAgICAgICAqIGluc3BlY3Rvci9Db25zb2xlTWVzc2FnZS5jcHA6 CisgICAgICAgICogaW5zcGVjdG9yL0NvbnNvbGVNZXNzYWdlLmg6CisgICAgICAgICogaW5zcGVj dG9yL1NjcmlwdENhbGxGcmFtZS5jcHA6CisgICAgICAgICogaW5zcGVjdG9yL1NjcmlwdENhbGxG cmFtZS5oOgorICAgICAgICAqIGluc3BlY3Rvci9TY3JpcHRDYWxsU3RhY2suY3BwOgorICAgICAg ICAqIGluc3BlY3Rvci9TY3JpcHRDYWxsU3RhY2suaDoKKwogMjAxMC0xMS0wOCAgTmVkIEhvbGJy b29rICA8bmhvbGJyb29rQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJh cnRoLgpJbmRleDogV2ViQ29yZS9pbnNwZWN0b3IvQ29uc29sZU1lc3NhZ2UuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvaW5zcGVjdG9yL0NvbnNvbGVNZXNzYWdlLmNwcAkocmV2aXNpb24gNzE1 ODApCisrKyBXZWJDb3JlL2luc3BlY3Rvci9Db25zb2xlTWVzc2FnZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTc0LDYgKzc0LDggQEAgQ29uc29sZU1lc3NhZ2U6OkNvbnNvbGVNZXNzYWdlKE1lc3Nh Z2VTbwogICAgICAgICBtX2NhbGxTdGFjay5jbGVhcigpOwogfQogCisjaWYgRU5BQkxFKElOU1BF Q1RPUikKKwogdm9pZCBDb25zb2xlTWVzc2FnZTo6YWRkVG9Gcm9udGVuZChJbnNwZWN0b3JGcm9u dGVuZCogZnJvbnRlbmQsIEluamVjdGVkU2NyaXB0SG9zdCogaW5qZWN0ZWRTY3JpcHRIb3N0KQog ewogICAgIFJlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IGpzb25PYmogPSBJbnNwZWN0b3JPYmplY3Q6 OmNyZWF0ZSgpOwpAQCAtMTEwLDYgKzExMiw4IEBAIHZvaWQgQ29uc29sZU1lc3NhZ2U6OnVwZGF0 ZVJlcGVhdENvdW50SW4KICAgICBmcm9udGVuZC0+dXBkYXRlQ29uc29sZU1lc3NhZ2VSZXBlYXRD b3VudChtX3JlcGVhdENvdW50KTsKIH0KIAorI2VuZGlmCisKIGJvb2wgQ29uc29sZU1lc3NhZ2U6 OmlzRXF1YWwoQ29uc29sZU1lc3NhZ2UqIG1zZykgY29uc3QKIHsKICAgICBpZiAobV9hcmd1bWVu dHMpIHsKSW5kZXg6IFdlYkNvcmUvaW5zcGVjdG9yL0NvbnNvbGVNZXNzYWdlLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9pbnNwZWN0b3IvQ29uc29sZU1lc3NhZ2UuaAkocmV2aXNpb24gNzE1ODAp CisrKyBXZWJDb3JlL2luc3BlY3Rvci9Db25zb2xlTWVzc2FnZS5oCSh3b3JraW5nIGNvcHkpCkBA IC01MSw4ICs1MSwxMCBAQCBwdWJsaWM6CiAgICAgQ29uc29sZU1lc3NhZ2UoTWVzc2FnZVNvdXJj ZSwgTWVzc2FnZVR5cGUsIE1lc3NhZ2VMZXZlbCwgY29uc3QgU3RyaW5nJiBtLCB1bnNpZ25lZCBs aSwgY29uc3QgU3RyaW5nJiB1LCB1bnNpZ25lZCBnKTsKICAgICBDb25zb2xlTWVzc2FnZShNZXNz YWdlU291cmNlLCBNZXNzYWdlVHlwZSwgTWVzc2FnZUxldmVsLCBjb25zdCBTdHJpbmcmIG0sIFBh c3NPd25QdHI8U2NyaXB0QXJndW1lbnRzPiwgUGFzc093blB0cjxTY3JpcHRDYWxsU3RhY2s+LCB1 bnNpZ25lZCBnKTsKIAorI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgdm9pZCBhZGRUb0Zyb250 ZW5kKEluc3BlY3RvckZyb250ZW5kKiwgSW5qZWN0ZWRTY3JpcHRIb3N0Kik7CiAgICAgdm9pZCB1 cGRhdGVSZXBlYXRDb3VudEluQ29uc29sZShJbnNwZWN0b3JGcm9udGVuZCogZnJvbnRlbmQpOwor I2VuZGlmCiAgICAgdm9pZCBpbmNyZW1lbnRDb3VudCgpIHsgKyttX3JlcGVhdENvdW50OyB9CiAg ICAgYm9vbCBpc0VxdWFsKENvbnNvbGVNZXNzYWdlKiBtc2cpIGNvbnN0OwogCkluZGV4OiBXZWJD b3JlL2luc3BlY3Rvci9TY3JpcHRDYWxsRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv aW5zcGVjdG9yL1NjcmlwdENhbGxGcmFtZS5jcHAJKHJldmlzaW9uIDcxNTgwKQorKysgV2ViQ29y ZS9pbnNwZWN0b3IvU2NyaXB0Q2FsbEZyYW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTQsNiAr NTQsOCBAQCBib29sIFNjcmlwdENhbGxGcmFtZTo6aXNFcXVhbChjb25zdCBTY3JpCiAgICAgICAg ICYmIG1fbGluZU51bWJlciA9PSBvLm1fbGluZU51bWJlcjsKIH0KIAorI2lmIEVOQUJMRShJTlNQ RUNUT1IpCisKIFBhc3NSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBTY3JpcHRDYWxsRnJhbWU6OmJ1 aWxkSW5zcGVjdG9yT2JqZWN0KCkgY29uc3QKIHsKICAgICBSZWZQdHI8SW5zcGVjdG9yT2JqZWN0 PiBmcmFtZSA9IEluc3BlY3Rvck9iamVjdDo6Y3JlYXRlKCk7CkBAIC02Myw0ICs2NSw2IEBAIFBh c3NSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBTY3JpcHRDYWxsRnIKICAgICByZXR1cm4gZnJhbWU7 CiB9CiAKKyNlbmRpZgorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBXZWJDb3JlL2lu c3BlY3Rvci9TY3JpcHRDYWxsRnJhbWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rv ci9TY3JpcHRDYWxsRnJhbWUuaAkocmV2aXNpb24gNzE1ODApCisrKyBXZWJDb3JlL2luc3BlY3Rv ci9TY3JpcHRDYWxsRnJhbWUuaAkod29ya2luZyBjb3B5KQpAQCAtNDgsNyArNDgsOSBAQCBwdWJs aWM6CiAgICAgdW5zaWduZWQgbGluZU51bWJlcigpIGNvbnN0IHsgcmV0dXJuIG1fbGluZU51bWJl cjsgfQogCiAgICAgYm9vbCBpc0VxdWFsKGNvbnN0IFNjcmlwdENhbGxGcmFtZSYpIGNvbnN0Owor I2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgUGFzc1JlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IGJ1 aWxkSW5zcGVjdG9yT2JqZWN0KCkgY29uc3Q7CisjZW5kaWYKIAogcHJpdmF0ZToKICAgICBTdHJp bmcgbV9mdW5jdGlvbk5hbWU7CkluZGV4OiBXZWJDb3JlL2luc3BlY3Rvci9TY3JpcHRDYWxsU3Rh Y2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaW5zcGVjdG9yL1NjcmlwdENhbGxTdGFjay5j cHAJKHJldmlzaW9uIDcxNTgwKQorKysgV2ViQ29yZS9pbnNwZWN0b3IvU2NyaXB0Q2FsbFN0YWNr LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzIsNiArNzIsOCBAQCBib29sIFNjcmlwdENhbGxTdGFj azo6aXNFcXVhbChTY3JpcHRDYWxsCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKKyNpZiBFTkFCTEUo SU5TUEVDVE9SKQorCiBQYXNzUmVmUHRyPEluc3BlY3RvckFycmF5PiBTY3JpcHRDYWxsU3RhY2s6 OmJ1aWxkSW5zcGVjdG9yT2JqZWN0KCkgY29uc3QKIHsKICAgICBSZWZQdHI8SW5zcGVjdG9yQXJy YXk+IGZyYW1lcyA9IEluc3BlY3RvckFycmF5OjpjcmVhdGUoKTsKQEAgLTgwLDQgKzgyLDYgQEAg UGFzc1JlZlB0cjxJbnNwZWN0b3JBcnJheT4gU2NyaXB0Q2FsbFN0YQogICAgIHJldHVybiBmcmFt ZXM7CiB9CiAKKyNlbmRpZgorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBXZWJDb3Jl L2luc3BlY3Rvci9TY3JpcHRDYWxsU3RhY2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2luc3Bl Y3Rvci9TY3JpcHRDYWxsU3RhY2suaAkocmV2aXNpb24gNzE1ODApCisrKyBXZWJDb3JlL2luc3Bl Y3Rvci9TY3JpcHRDYWxsU3RhY2suaAkod29ya2luZyBjb3B5KQpAQCAtNTEsNyArNTEsOSBAQCBw dWJsaWM6CiAgICAgc3RhdGljIGJvb2wgc3RhY2tUcmFjZShpbnQsIGNvbnN0IFJlZlB0cjxJbnNw ZWN0b3JBcnJheT4mKTsKIAogICAgIGJvb2wgaXNFcXVhbChTY3JpcHRDYWxsU3RhY2sqKSBjb25z dDsKKyNpZiBFTkFCTEUoSU5TUEVDVE9SKQogICAgIFBhc3NSZWZQdHI8SW5zcGVjdG9yQXJyYXk+ IGJ1aWxkSW5zcGVjdG9yT2JqZWN0KCkgY29uc3Q7CisjZW5kaWYKIAogcHJpdmF0ZToKICAgICBW ZWN0b3I8U2NyaXB0Q2FsbEZyYW1lPiBtX2ZyYW1lczsK