49221 2010-11-08 16:21:10 -0800 Chromium regression (r71562): 2 http/tests/appcache/ tests failing 2010-11-08 22:15:45 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 japhet japhet abarth ap commit-queue koivisto michaeln oldest_to_newest 306443 0 japhet 2010-11-08 16:21:10 -0800 http/tests/appcache/fallback.html and http/tests/appcache/offline-access.html are failing after http://trac.webkit.org/changeset/71562 It appears that, in chromium, ApplicationCacheHost::maybeLoadResource() can modify its ResourceRequest parameter. Before r71562, we then immediately called ResourceHandle::create() with the modified ResourceRequest. Now, the ResourceRequest changes are lost. I think that the call to maybeLoadResource() should be in ResourceLoader::start() instead of ResourceLoader::load(), similar to the call to DocumentLoader::scheduleArchiveLoad(). 306445 1 73303 japhet 2010-11-08 16:22:21 -0800 Created attachment 73303 patch 306463 2 73303 michaeln 2010-11-08 16:48:00 -0800 Comment on attachment 73303 patch this fix looks good to me 306466 3 73303 abarth 2010-11-08 16:50:01 -0800 Comment on attachment 73303 patch Ok. This change is slightly mysterious to me, but it seems ok. 306467 4 abarth 2010-11-08 16:50:24 -0800 > this fix looks good to me Thanks Michael. 306605 5 73303 commit-queue 2010-11-08 21:46:10 -0800 Comment on attachment 73303 patch Rejecting patch 73303 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73303]" exit_code: 1 Traceback (most recent call last): File "./WebKitTools/Scripts/webkit-patch", line 70, in <module> main() File "./WebKitTools/Scripts/webkit-patch", line 63, in main from webkitpy.tool.main import WebKitPatch File "/Users/abarth/git/webkit-queue/WebKitTools/Scripts/webkitpy/tool/main.py", line 42, in <module> from webkitpy.common.net.rietveld import Rietveld ImportError: No module named rietveld Full output: http://queues.webkit.org/results/5569015 306611 6 73303 abarth 2010-11-08 21:54:45 -0800 Comment on attachment 73303 patch wah? 306615 7 73303 commit-queue 2010-11-08 22:15:40 -0800 Comment on attachment 73303 patch Clearing flags on attachment: 73303 Committed r71606: <http://trac.webkit.org/changeset/71606> 306616 8 commit-queue 2010-11-08 22:15:45 -0800 All reviewed patches have been landed. Closing bug. 73303 2010-11-08 16:22:21 -0800 2010-11-08 22:15:40 -0800 patch patch.txt text/plain 1806 japhet SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTU4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTAtMTEtMDggIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD YWxsIEFwcGxpY2F0aW9uQ2FjaGVIb3N0OjptYXliZUxvYWRSZXNvdXJjZSgpIGluCisgICAgICAg IFJlc291cmNlTG9hZGVyOjpzdGFydCgpIGluc3RlYWQgb2YgUmVzb3VyY2VMb2FkZXI6OmxvYWQo KS4KKyAgICAgICAgbWF5YmVMb2FkUmVzb3VyY2UoKSBtaWdodCBtdXRhdGUgdGhlIFJlc291cmNl UmVxdWVzdCwgYW5kCisgICAgICAgIGluIGl0cyBjdXJyZW50IGxvY2F0aW9uIGFueSBtb2RpZmlj YXRpb25zIGFyZSBsb3N0LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00OTIyMQorCisgICAgICAgIEZpeGVzIGEgY291cGxlIG9mIGh0dHAvdGVzdHMv YXBwY2FjaGUgdGVzdHMKKyAgICAgICAgZmFpbGluZyBvbiBjaHJvbWl1bS4KKworICAgICAgICAq IGxvYWRlci9SZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUxv YWRlcjo6bG9hZCk6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUxvYWRlcjo6c3RhcnQpOgor CiAyMDEwLTExLTA4ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxv YWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3Bw CShyZXZpc2lvbiA3MTU4MykKKysrIFdlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTMzLDExICsxMzMsNiBAQAogICAgICAgICBkaWRGYWlsKGZyYW1l TG9hZGVyKCktPmNhbmNlbGxlZEVycm9yKHIpKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAg IH0KLSAgICAKLSNpZiBFTkFCTEUoT0ZGTElORV9XRUJfQVBQTElDQVRJT05TKQotICAgIGlmICht X2RvY3VtZW50TG9hZGVyLT5hcHBsaWNhdGlvbkNhY2hlSG9zdCgpLT5tYXliZUxvYWRSZXNvdXJj ZSh0aGlzLCBjbGllbnRSZXF1ZXN0LCByLnVybCgpKSkKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0j ZW5kaWYKIAogICAgIGlmIChtX2RlZmVyc0xvYWRpbmcpCiAgICAgICAgIG1fZGVmZXJyZWRSZXF1 ZXN0ID0gY2xpZW50UmVxdWVzdDsKQEAgLTE1NCw2ICsxNDksMTEgQEAKICAgICAKICAgICBpZiAo bV9kb2N1bWVudExvYWRlci0+c2NoZWR1bGVBcmNoaXZlTG9hZCh0aGlzLCBtX3JlcXVlc3QsIG1f cmVxdWVzdC51cmwoKSkpCiAgICAgICAgIHJldHVybiB0cnVlOworICAgIAorI2lmIEVOQUJMRShP RkZMSU5FX1dFQl9BUFBMSUNBVElPTlMpCisgICAgaWYgKG1fZG9jdW1lbnRMb2FkZXItPmFwcGxp Y2F0aW9uQ2FjaGVIb3N0KCktPm1heWJlTG9hZFJlc291cmNlKHRoaXMsIG1fcmVxdWVzdCwgbV9y ZXF1ZXN0LnVybCgpKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisjZW5kaWYKIAogICAgIGlmICht X2RlZmVyc0xvYWRpbmcpCiAgICAgICAgIHJldHVybiBmYWxzZTsK