49219 2010-11-08 16:01:55 -0800 Find in Page: scrolling the page with the scrollbar while overlay is up dismisses the overlay 2010-11-08 16:10:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 andersca andersca oldest_to_newest 306430 0 andersca 2010-11-08 16:01:55 -0800 Find in Page: scrolling the page with the scrollbar while overlay is up dismisses the overlay 306432 1 andersca 2010-11-08 16:02:26 -0800 <rdar://problem/8569550> 306434 2 73302 andersca 2010-11-08 16:03:26 -0800 Created attachment 73302 Patch 306436 3 73302 sullivan 2010-11-08 16:06:02 -0800 Comment on attachment 73302 Patch I think it's worth a comment in FindPageOverlay::mouseEvent about why the bounds() check is needed. 306437 4 andersca 2010-11-08 16:10:00 -0800 Committed r71583: <http://trac.webkit.org/changeset/71583> 73302 2010-11-08 16:03:26 -0800 2010-11-08 16:06:02 -0800 Patch bug-49219-20101108160325.patch text/plain 3649 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZjMyOWFlMTBiNzUwMzFkMjY2YjY5MTgwYTFhNTQxZDVlNWY2MjBmNi4uNWY0YTAwZTY1YWZiZGU2 ZjljYmI5NGJhYTA4M2JkODNhOWIwNzhhNCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAxMC0xMS0wOCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpbmQgaW4gUGFnZTogc2Nyb2xsaW5nIHRoZSBw YWdlIHdpdGggdGhlIHNjcm9sbGJhciB3aGlsZSBvdmVybGF5IGlzIHVwIGRpc21pc3NlcyB0aGUg b3ZlcmxheQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDkyMTkKKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9GaW5kUGFnZU92ZXJsYXkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpGaW5kUGFnZU92ZXJsYXk6OmJvdW5kcyk6CisgICAgICAgIFJl dHVybiB0aGUgYm91bmRzIG9mIHRoZSBmaW5kIHBhZ2Ugb3ZlcmxheSwgZXhjbHVkaW5nIGFueSBz Y3JvbGxiYXJzLgorCisgICAgICAgIChXZWJLaXQ6OkZpbmRQYWdlT3ZlcmxheTo6ZHJhd1JlY3Qp OgorICAgICAgICBDYWxsIGJvdW5kcy4KKworICAgICAgICAoV2ViS2l0OjpGaW5kUGFnZU92ZXJs YXk6Om1vdXNlRXZlbnQpOgorICAgICAgICBPbmx5IGRpc21pc3MgdGhlIGZpbmQgVUkgaWYgdGhl IG1vdXNlIGN1cnNvciBpcyBpbnNpZGUgdGhlIGJvdW5kcy4KKworMjAxMC0xMS0wOCAgQW5kZXJz IENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFk YW0gUm9iZW4uCiAKICAgICAgICAgQWRkIHRoZSBhYmlsaXR5IHRvIHNlbmQgbWVzc2FnZXMgdG8g RG93bmxvYWRQcm94eSBvYmplY3RzCmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9GaW5kUGFnZU92ZXJsYXkuY3BwIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmlu ZFBhZ2VPdmVybGF5LmNwcAppbmRleCA2YWYzY2FkZWUzMGRhOTRmMDllNzQwYjE0YmM0YTgxZmU3 M2MyOTM2Li5jNzFmZjdhNDhkZThhMTFhNDRlYTE3ZWI3ODY0YWM4ZjM5NjNmNjgyIDEwMDY0NAot LS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kUGFnZU92ZXJsYXkuY3BwCisrKyBi L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRQYWdlT3ZlcmxheS5jcHAKQEAgLTg1LDE2 ICs4NSw4IEBAIFZlY3RvcjxJbnRSZWN0PiBGaW5kUGFnZU92ZXJsYXk6OnJlY3RzRm9yVGV4dE1h dGNoZXMoKQogICAgIHJldHVybiByZWN0czsKIH0KIAotc3RhdGljIENvbG9yIG92ZXJsYXlCYWNr Z3JvdW5kQ29sb3IoKQotewotICAgIHJldHVybiBDb2xvcihvdmVybGF5QmFja2dyb3VuZFJlZCwg b3ZlcmxheUJhY2tncm91bmRHcmVlbiwgb3ZlcmxheUJhY2tncm91bmRCbHVlLCBvdmVybGF5QmFj a2dyb3VuZEFscGhhKTsKLX0KLQotdm9pZCBGaW5kUGFnZU92ZXJsYXk6OmRyYXdSZWN0KEdyYXBo aWNzQ29udGV4dCYgZ3JhcGhpY3NDb250ZXh0LCBjb25zdCBJbnRSZWN0JiBkaXJ0eVJlY3QpCitJ bnRSZWN0IEZpbmRQYWdlT3ZlcmxheTo6Ym91bmRzKCkKIHsKLSAgICBWZWN0b3I8SW50UmVjdD4g cmVjdHMgPSByZWN0c0ZvclRleHRNYXRjaGVzKCk7Ci0gICAgQVNTRVJUKCFyZWN0cy5pc0VtcHR5 KCkpOwotCiAgICAgRnJhbWVWaWV3KiBmcmFtZVZpZXcgPSB3ZWJQYWdlKCktPmNvcmVQYWdlKCkt Pm1haW5GcmFtZSgpLT52aWV3KCk7CiAKICAgICBpbnQgd2lkdGggPSBmcmFtZVZpZXctPndpZHRo KCk7CkBAIC0xMDQsNyArOTYsMjAgQEAgdm9pZCBGaW5kUGFnZU92ZXJsYXk6OmRyYXdSZWN0KEdy YXBoaWNzQ29udGV4dCYgZ3JhcGhpY3NDb250ZXh0LCBjb25zdCBJbnRSZWN0JgogICAgIGlmIChm cmFtZVZpZXctPmhvcml6b250YWxTY3JvbGxiYXIoKSkKICAgICAgICAgaGVpZ2h0IC09IGZyYW1l Vmlldy0+aG9yaXpvbnRhbFNjcm9sbGJhcigpLT5oZWlnaHQoKTsKICAgICAKLSAgICBJbnRSZWN0 IHBhaW50UmVjdCA9IGludGVyc2VjdGlvbihkaXJ0eVJlY3QsIEludFJlY3QoMCwgMCwgd2lkdGgs IGhlaWdodCkpOworICAgIHJldHVybiBJbnRSZWN0KDAsIDAsIHdpZHRoLCBoZWlnaHQpOworfQor CitzdGF0aWMgQ29sb3Igb3ZlcmxheUJhY2tncm91bmRDb2xvcigpCit7CisgICAgcmV0dXJuIENv bG9yKG92ZXJsYXlCYWNrZ3JvdW5kUmVkLCBvdmVybGF5QmFja2dyb3VuZEdyZWVuLCBvdmVybGF5 QmFja2dyb3VuZEJsdWUsIG92ZXJsYXlCYWNrZ3JvdW5kQWxwaGEpOworfQorCit2b2lkIEZpbmRQ YWdlT3ZlcmxheTo6ZHJhd1JlY3QoR3JhcGhpY3NDb250ZXh0JiBncmFwaGljc0NvbnRleHQsIGNv bnN0IEludFJlY3QmIGRpcnR5UmVjdCkKK3sKKyAgICBWZWN0b3I8SW50UmVjdD4gcmVjdHMgPSBy ZWN0c0ZvclRleHRNYXRjaGVzKCk7CisgICAgQVNTRVJUKCFyZWN0cy5pc0VtcHR5KCkpOworCisg ICAgSW50UmVjdCBwYWludFJlY3QgPSBpbnRlcnNlY3Rpb24oZGlydHlSZWN0LCBib3VuZHMoKSk7 CiAgICAgaWYgKHBhaW50UmVjdC5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKIApAQCAtMTQy LDcgKzE0Nyw3IEBAIHZvaWQgRmluZFBhZ2VPdmVybGF5OjpkcmF3UmVjdChHcmFwaGljc0NvbnRl eHQmIGdyYXBoaWNzQ29udGV4dCwgY29uc3QgSW50UmVjdCYKIAogYm9vbCBGaW5kUGFnZU92ZXJs YXk6Om1vdXNlRXZlbnQoY29uc3QgV2ViTW91c2VFdmVudCYgZXZlbnQpCiB7Ci0gICAgaWYgKGV2 ZW50LnR5cGUoKSA9PSBXZWJFdmVudDo6TW91c2VEb3duKSB7CisgICAgaWYgKGV2ZW50LnR5cGUo KSA9PSBXZWJFdmVudDo6TW91c2VEb3duICYmIGJvdW5kcygpLmNvbnRhaW5zKGV2ZW50LnBvc2l0 aW9uKCkpKSB7CiAgICAgICAgIC8vIERpc21pc3MgdGhlIG92ZXJsYXkuCiAgICAgICAgIG1fZmlu ZENvbnRyb2xsZXItPmhpZGVGaW5kVUkoKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0t Z2l0IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmluZFBhZ2VPdmVybGF5LmggYi9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kUGFnZU92ZXJsYXkuaAppbmRleCA3MmZiMWI0M2Y0 N2U5OWI0NTdlODJmYTc1NGQyNzhhZThlODk1YWYxLi4yNDNlOGEyNTg0Y2M2NTlmM2UxMzhiYzcy M2M2YTZiNGNhYWM1ZjhjIDEwMDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9G aW5kUGFnZU92ZXJsYXkuaAorKysgYi9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kUGFn ZU92ZXJsYXkuaApAQCAtNDMsNiArNDMsNyBAQCBwcml2YXRlOgogICAgIGV4cGxpY2l0IEZpbmRQ YWdlT3ZlcmxheShGaW5kQ29udHJvbGxlciopOwogCiAgICAgVmVjdG9yPFdlYkNvcmU6OkludFJl Y3Q+IHJlY3RzRm9yVGV4dE1hdGNoZXMoKTsKKyAgICBXZWJDb3JlOjpJbnRSZWN0IGJvdW5kcygp OwogCiAgICAgLy8gUGFnZU92ZXJsYXkuCiAgICAgdmlydHVhbCB2b2lkIGRyYXdSZWN0KFdlYkNv cmU6OkdyYXBoaWNzQ29udGV4dCYsIGNvbnN0IFdlYkNvcmU6OkludFJlY3QmIGRpcnR5UmVjdCk7 Cg==