49217 2010-11-08 15:54:31 -0800 REGRESSION: Two layout tests failing after positionForPoint changes. 2010-12-14 01:43:57 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P1 Normal --- 49243 1 hyatt hyatt abarth eric ossy webkit.review.bot oldest_to_newest 306422 0 hyatt 2010-11-08 15:54:31 -0800 Two layout tests failing after positionForPoint changes. 306424 1 73300 hyatt 2010-11-08 15:57:03 -0800 Created attachment 73300 Patch 306428 2 hyatt 2010-11-08 16:00:06 -0800 Fixed in r71582. 306442 3 webkit.review.bot 2010-11-08 16:20:45 -0800 http://trac.webkit.org/changeset/71582 might have broken Qt Linux Release 306649 4 ossy 2010-11-09 00:43:20 -0800 (In reply to comment #3) > http://trac.webkit.org/changeset/71582 might have broken Qt Linux Release It fixed the two broken tests: editing/selection/move-by-line-003.html and fast/dom/Document/CaretRangeFromPoint/replace-element.html on all bot, but unfortunately it broke two another tests on Qt bot: - editing/deleting/delete-line-011.html - editing/pasteboard/paste-4039777-fix.html - link: http://build.webkit.org/results/Qt%20Linux%20Release/r71582%20%2823376%29/results.html 306673 5 ossy 2010-11-09 02:14:06 -0800 New bug filed for new regression: https://bugs.webkit.org/show_bug.cgi?id=49243 321805 6 eric 2010-12-14 01:43:57 -0800 Looks like this was fixed? 73300 2010-11-08 15:57:03 -0800 2010-11-08 15:58:20 -0800 Patch patch.txt text/plain 4534 hyatt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTU4MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTEtMDggIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5lZWQg YSBzaG9ydCBkZXNjcmlwdGlvbiBhbmQgYnVnIFVSTCAoT09QUyEpCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyUmVwbGFjZWQ6OnBvc2l0aW9uRm9yUG9pbnQpOgor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlclRleHQ6OnBvc2l0aW9uRm9yUG9pbnQpOgorCiAyMDEwLTExLTA4ICBTdGV2ZSBCbG9jayAg PHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZp bi4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlcGxhY2VkLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZXBsYWNlZC5jcHAJKHJldmlzaW9uIDcxNTYz KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yOTcsNyArMjk3LDcgQEAgVmlzaWJsZVBvc2l0aW9uIFJlbmRlclJlcGxhY2VkOjpwb3Np dGlvbgogICAgICAgICByZXR1cm4gY3JlYXRlVmlzaWJsZVBvc2l0aW9uKGNhcmV0TWF4T2Zmc2V0 KCksIERPV05TVFJFQU0pOyAvLyBjb29yZGluYXRlcyBhcmUgYmVsb3cKICAgICAKICAgICBpZiAo bm9kZSgpKSB7Ci0gICAgICAgIGlmIChsaW5lRGlyZWN0aW9uUG9zaXRpb24gPD0gYm94LT5sb2dp Y2FsV2lkdGgoKSAvIDIpCisgICAgICAgIGlmIChsaW5lRGlyZWN0aW9uUG9zaXRpb24gPD0gYm94 LT5sb2dpY2FsTGVmdCgpICsgKGJveC0+bG9naWNhbFdpZHRoKCkgLyAyKSkKICAgICAgICAgICAg IHJldHVybiBjcmVhdGVWaXNpYmxlUG9zaXRpb24oMCwgRE9XTlNUUkVBTSk7CiAgICAgICAgIHJl dHVybiBjcmVhdGVWaXNpYmxlUG9zaXRpb24oMSwgRE9XTlNUUkVBTSk7CiAgICAgfQpJbmRleDog V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAJKHJldmlzaW9uIDcxNTYzKQorKysgV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzNyw4ICs0MzcsMTEgQEAg VmlzaWJsZVBvc2l0aW9uIFJlbmRlclRleHQ6OnBvc2l0aW9uRm9yUAogCiAgICAgSW5saW5lVGV4 dEJveCogbGFzdEJveEFib3ZlID0gMDsKICAgICBmb3IgKElubGluZVRleHRCb3gqIGJveCA9IGZp cnN0VGV4dEJveCgpOyBib3g7IGJveCA9IGJveC0+bmV4dFRleHRCb3goKSkgewotICAgICAgICBp ZiAocG9pbnRCbG9ja0RpcmVjdGlvbiA+PSBib3gtPnJvb3QoKS0+bGluZVRvcCgpKSB7Ci0gICAg ICAgICAgICBpbnQgYm90dG9tID0gYm94LT5yb290KCktPm5leHRSb290Qm94KCkgPyBib3gtPnJv b3QoKS0+bmV4dFJvb3RCb3goKS0+c2VsZWN0aW9uVG9wKCkgOiBib3gtPnJvb3QoKS0+c2VsZWN0 aW9uQm90dG9tKCk7CisgICAgICAgIFJvb3RJbmxpbmVCb3gqIHJvb3RCb3ggPSBib3gtPnJvb3Qo KTsKKyAgICAgICAgaWYgKHBvaW50QmxvY2tEaXJlY3Rpb24gPj0gcm9vdEJveC0+c2VsZWN0aW9u VG9wKCkpIHsKKyAgICAgICAgICAgIGludCBib3R0b20gPSByb290Qm94LT5zZWxlY3Rpb25Cb3R0 b20oKTsKKyAgICAgICAgICAgIGlmIChyb290Qm94LT5uZXh0Um9vdEJveCgpKQorICAgICAgICAg ICAgICAgIGJvdHRvbSA9IG1pbihib3R0b20sIHJvb3RCb3gtPm5leHRSb290Qm94KCktPmxpbmVU b3AoKSk7CiAgICAgICAgICAgICBpZiAocG9pbnRCbG9ja0RpcmVjdGlvbiA8IGJvdHRvbSkgewog ICAgICAgICAgICAgICAgIG9mZnNldCA9IGJveC0+b2Zmc2V0Rm9yUG9zaXRpb24ocG9pbnRMaW5l RGlyZWN0aW9uKTsKIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNzE1ODEpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMS0wOCAgRGF2 aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ5MjE3CisgICAgICAgIAorICAgICAgICBGaXggY29vcmRpbmF0ZSBzcGFjZSBtaXNtYXRj aCBpbiBSZW5kZXJSZXBsYWNlZCBhbmQgbWFrZSBzdXJlIFJlbmRlclRleHQgcmV0YWlucyBpdHMg b2xkIGJlaGF2aW9yIG9mCisgICAgICAgIHByZWZlcnJpbmcgbGF0ZXIgbGluZXMgd2hlbiB0aGVy ZSBpcyBvdmVybGFwLgorCisgICAgICAgICogZmFzdC9kb20vRG9jdW1lbnQvQ2FyZXRSYW5nZUZy b21Qb2ludC9yZXBsYWNlLWVsZW1lbnQtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZG9t L0RvY3VtZW50L0NhcmV0UmFuZ2VGcm9tUG9pbnQvcmVwbGFjZS1lbGVtZW50Lmh0bWw6CisKIDIw MTAtMTEtMDggIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkIGJvdCBmaXguCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9E b2N1bWVudC9DYXJldFJhbmdlRnJvbVBvaW50L3JlcGxhY2UtZWxlbWVudC1leHBlY3RlZC50eHQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vRG9jdW1lbnQvQ2FyZXRSYW5nZUZy b21Qb2ludC9yZXBsYWNlLWVsZW1lbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA3MTQ2NikKKysr IExheW91dFRlc3RzL2Zhc3QvZG9tL0RvY3VtZW50L0NhcmV0UmFuZ2VGcm9tUG9pbnQvcmVwbGFj ZS1lbGVtZW50LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtNSw2ICs1LDYgQEAgVGVz dGluZyByaWdodCBvZiB0aGUgaW1hZ2UKIFBBU1M6IHJhbmdlLnN0YXJ0Q29udGFpbmVyID09IGlt YWdlLm5leHRTaWJsaW5nLgogUEFTUzogcmFuZ2Uuc3RhcnRPZmZzZXQgPT0gMS4KIFRlc3Rpbmcg b24gdGhlIGltYWdlCi1QQVNTOiByYW5nZS5zdGFydENvbnRhaW5lciA9PSBpbWFnZS5wcmV2aW91 c1NpYmxpbmcuCi1QQVNTOiByYW5nZS5zdGFydE9mZnNldCA9PSAzNS4KK1BBU1M6IHJhbmdlLnN0 YXJ0Q29udGFpbmVyID09IGltYWdlLnBhcmVudE5vZGUuCitQQVNTOiByYW5nZS5zdGFydE9mZnNl dCA9PSAyLgogCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9Eb2N1bWVudC9DYXJldFJhbmdl RnJvbVBvaW50L3JlcGxhY2UtZWxlbWVudC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvZG9tL0RvY3VtZW50L0NhcmV0UmFuZ2VGcm9tUG9pbnQvcmVwbGFjZS1lbGVtZW50Lmh0 bWwJKHJldmlzaW9uIDcxNDY2KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vRG9jdW1lbnQvQ2Fy ZXRSYW5nZUZyb21Qb2ludC9yZXBsYWNlLWVsZW1lbnQuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt NjYsNyArNjYsNyBAQAogICAgICAgICAgICAgdGVzdCgoaW1hZ2VSZWN0LmxlZnQgKyBpbWFnZVJl Y3Qud2lkdGgpICsgMTAsIChpbWFnZVJlY3QudG9wICsgaW1hZ2VSZWN0LmhlaWdodCkgLSA1LCAi aW1hZ2UubmV4dFNpYmxpbmciLCAiMSIpOwogCiAgICAgICAgICAgICBsb2coIlRlc3Rpbmcgb24g dGhlIGltYWdlIik7Ci0gICAgICAgICAgICB0ZXN0KChpbWFnZVJlY3QubGVmdCArIChpbWFnZVJl Y3Qud2lkdGggLyAyKSkgLCAoaW1hZ2VSZWN0LnRvcCArIGltYWdlUmVjdC5oZWlnaHQpIC0gNSwg ImltYWdlLnByZXZpb3VzU2libGluZyIsICIzNSIpOworICAgICAgICAgICAgdGVzdCgoaW1hZ2VS ZWN0LmxlZnQgKyAoaW1hZ2VSZWN0LndpZHRoIC8gMikgKyAxKSAsIChpbWFnZVJlY3QudG9wICsg aW1hZ2VSZWN0LmhlaWdodCkgLSA1LCAiaW1hZ2UucGFyZW50Tm9kZSIsICIyIik7CiAKICAgICAg ICAgICAgIHN3YXBJbkxvZygpOwogICAgICAgICB9Cg==