49209 2010-11-08 14:18:03 -0800 WebKit2 should exit auto scrolling mode when losing focus 2010-12-17 16:34:10 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein abarth aroben eric webkit.review.bot oldest_to_newest 306363 0 bweinstein 2010-11-08 14:18:03 -0800 We do not exit pan scrolling mode when switching tabs in WebKit2. In WebKit1, this was fixed by http://trac.webkit.org/changeset/50007, but the bug still exists in WebKit2. Steps to reproduce: 1) Open two tabs, one that can scroll 2) Start panscrolling in the tab that can scroll 3) Switch focus to the other tab. The pan scrolling icon stays active, even though it shouldn't. 306372 1 73285 bweinstein 2010-11-08 14:25:05 -0800 Created attachment 73285 [PATCH] Fix 306375 2 73285 aroben 2010-11-08 14:27:57 -0800 Comment on attachment 73285 [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=73285&action=review Is it possible to make a test for this using TestWebKitAPI? You'd have to add code that can simulate a middle-click, and a way to make the WebView lose focus, and a way to detect whether the autoscroll timer was stopped. > WebKit2/WebProcess/WebPage/WebPage.cpp:671 > + FocusController* focusController = m_page->focusController(); > + if (!isFocused) > + focusController->focusedOrMainFrame()->eventHandler()->stopAutoscrollTimer(); > + focusController->setFocused(isFocused); Should this code be in FocusController::setFocused instead? 306387 3 bweinstein 2010-11-08 14:44:59 -0800 (In reply to comment #2) > (From update of attachment 73285 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=73285&action=review > > Is it possible to make a test for this using TestWebKitAPI? You'd have to add code that can simulate a middle-click, and a way to make the WebView lose focus, and a way to detect whether the autoscroll timer was stopped. If it was a windows specific test, I could make sure the autoscroll timer was stopped by checking the scroll position before and after the timer was supposed to be killed, but I don't know if it's possible to test the gaining and losing focus of the web view. > > > WebKit2/WebProcess/WebPage/WebPage.cpp:671 > > + FocusController* focusController = m_page->focusController(); > > + if (!isFocused) > > + focusController->focusedOrMainFrame()->eventHandler()->stopAutoscrollTimer(); > > + focusController->setFocused(isFocused); > > Should this code be in FocusController::setFocused instead? No reason it shouldn't be, then it wouldn't be something that would need to be duplicated across WebKit platforms. 322996 4 76725 bweinstein 2010-12-15 18:20:53 -0800 Created attachment 76725 [PATCH] Fix in WebCore 323461 5 webkit.review.bot 2010-12-16 15:37:48 -0800 http://trac.webkit.org/changeset/74170 might have broken Leopard Intel Debug (Tests) 324034 6 eric 2010-12-17 16:34:10 -0800 Looks like this was landed but not closed. 73285 2010-11-08 14:25:05 -0800 2010-12-15 18:20:53 -0800 [PATCH] Fix pan_scroll_exit.patch text/plain 1585 bweinstein SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTU2OSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTEtMDggIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlYktpdDIgc2hvdWxkIGV4aXQgcGFuIHNjcm9sbGluZyBtb2RlIHdoZW4gc3dpdGNoaW5n IHRhYnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5 MjA5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NDI4NDA0PgorICAgICAgICAKKyAgICAgICAg V2hlbiBhIHBhZ2UgbG9zZXMgZm9jdXMsIG1ha2Ugc3VyZSB0aGF0IHdlIGtpbGwgdGhlIGF1dG9z Y3JvbGwgdGltZXIgdG8gcHJldmVudCBhbnkgc2Nyb2xsaW5nCisgICAgICAgIChwYW4tc2Nyb2xs aW5nIG9yIG90aGVyd2lzZSkgd2hlbiB0aGUgcGFnZSBsb3NlcyBmb2N1cy4KKyAgICAgICAgCisg ICAgICAgIFRoaXMgbWF0Y2hlcyB0aGUgZml4IGZvciBXZWJLaXQxIHRoYXQgd2FzIG1hZGUgaW4g aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNTAwMDcuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnNl dEZvY3VzZWQpOgorCiAyMDEwLTExLTA4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHJldmlzaW9uIDcxNTQwKQorKysgV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY2NSw3ICs2 NjUsMTAgQEAgdm9pZCBXZWJQYWdlOjpzZXRBY3RpdmUoYm9vbCBpc0FjdGl2ZSkKIAogdm9pZCBX ZWJQYWdlOjpzZXRGb2N1c2VkKGJvb2wgaXNGb2N1c2VkKQogewotICAgIG1fcGFnZS0+Zm9jdXND b250cm9sbGVyKCktPnNldEZvY3VzZWQoaXNGb2N1c2VkKTsKKyAgICBGb2N1c0NvbnRyb2xsZXIq IGZvY3VzQ29udHJvbGxlciA9IG1fcGFnZS0+Zm9jdXNDb250cm9sbGVyKCk7CisgICAgaWYgKCFp c0ZvY3VzZWQpCisgICAgICAgIGZvY3VzQ29udHJvbGxlci0+Zm9jdXNlZE9yTWFpbkZyYW1lKCkt PmV2ZW50SGFuZGxlcigpLT5zdG9wQXV0b3Njcm9sbFRpbWVyKCk7CisgICAgZm9jdXNDb250cm9s bGVyLT5zZXRGb2N1c2VkKGlzRm9jdXNlZCk7CiB9CiAKIHZvaWQgV2ViUGFnZTo6c2V0V2luZG93 UmVzaXplclNpemUoY29uc3QgSW50U2l6ZSYgd2luZG93UmVzaXplclNpemUpCg== 76725 2010-12-15 18:20:53 -0800 2010-12-15 18:24:49 -0800 [PATCH] Fix in WebCore webkit2_exit_autoscroll.patch text/plain 2177 bweinstein SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDE2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTItMTUgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlYktpdDIgc2hvdWxkIGV4aXQgYXV0byBzY3JvbGxpbmcgbW9kZSB3aGVuIGxvc2luZyBm b2N1cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDky MDkKKyAgICAgICAgCisgICAgICAgIFdoZW4gYSBwYWdlIGxvc2VzIGZvY3VzLCBtYWtlIHN1cmUg dGhhdCB3ZSBzdG9wIHRoZSBhdXRvc2Nyb2xsIHRpbWVyLCB3aGljaCBleGl0cyBwYW4gc2Nyb2xs aW5nIG1vZGUuIFdlCisgICAgICAgIGRvbid0IHdhbnQgdG8gYXV0b21hdGljYWxseSBzY3JvbGwg d2hlbiBhIHBhZ2UgZG9lc24ndCBoYXZlIGZvY3VzLgorCisgICAgICAgIFVwZGF0ZWQgbWFudWFs LXRlc3RzL2F1dG9zY3JvbGwuaHRtbCB3aXRoIGluc3RydWN0aW9ucyB0byB0ZXN0IHRoaXMgYnVn LgorCisgICAgICAgICogbWFudWFsLXRlc3RzL2F1dG9zY3JvbGwuaHRtbDoKKyAgICAgICAgKiBw YWdlL0ZvY3VzQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb2N1c0NvbnRyb2xs ZXI6OnNldEZvY3VzZWQpOgorCiAyMDEwLTEyLTE1ICBCZXRoIERha2luICA8YmRha2luQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUv bWFudWFsLXRlc3RzL2F1dG9zY3JvbGwuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL21hbnVh bC10ZXN0cy9hdXRvc2Nyb2xsLmh0bWwJKHJldmlzaW9uIDc0MTYxKQorKysgV2ViQ29yZS9tYW51 YWwtdGVzdHMvYXV0b3Njcm9sbC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yMCw2ICsyMCwxMCBA QCBXaGVuIEkgbW91c2UgdXAgYWZ0ZXIgZHJhZ2dpbmcgYSBzZWxlY3RpCiBBdXRvc2Nyb2xsaW5n IHNob3VsZCBzdG9wIHdoZW4geW91IHJlbGVhc2UgdGhlIG1vdXNlIGJ1dHRvbiBvdXRzaWRlIHRo ZSBmcmFtZSAoaW4gdGhlIG1haW4gZnJhbWUsIAogaW4gYW5vdGhlciBzdWJmcmFtZSwgb3IganVz dCBvdXRzaWRlIHRoZSB3aW5kb3cpLjwvcD4KIAorPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MjA5Ij5idWcgNDkyMDk8L2E+Ogor T3BlbiBhbm90aGVyIHBhZ2UgaW4gYSBkaWZmZXJlbnQgdGFiLCBtaWRkbGUgY2xpY2sgaW4gdGhl IGZpcnN0IGlmcmFtZSwgc2Nyb2xsIHVwLCBhbmQgc2VsZWN0IHRoZSBvdGhlciB0YWIuIFRoZSBw YW4gc2Nyb2xsaW5nCitjdXJzb3Igc2hvdWxkIGRpc2FwcGVhciwgYW5kIHlvdSBzaG91bGQgZXhp dCBwYW4gc2Nyb2xsaW5nIG1vZGUuPC9wPgorCiA8SUZSQU1FIEZSQU1FQk9SREVSPTE+PC9JRlJB TUU+CiA8YnI+CiA8SUZSQU1FIEZSQU1FQk9SREVSPTE+PC9JRlJBTUU+CkluZGV4OiBXZWJDb3Jl L3BhZ2UvRm9jdXNDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRm9j dXNDb250cm9sbGVyLmNwcAkocmV2aXNpb24gNzQxNjEpCisrKyBXZWJDb3JlL3BhZ2UvRm9jdXND b250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTMwLDYgKzEzMCw5IEBAIHZvaWQgRm9j dXNDb250cm9sbGVyOjpzZXRGb2N1c2VkKGJvb2wgZm8KICAgICAKICAgICBtX2lzRm9jdXNlZCA9 IGZvY3VzZWQ7CiAKKyAgICBpZiAoIW1faXNGb2N1c2VkKQorICAgICAgICBmb2N1c2VkT3JNYWlu RnJhbWUoKS0+ZXZlbnRIYW5kbGVyKCktPnN0b3BBdXRvc2Nyb2xsVGltZXIoKTsKKwogICAgIGlm ICghbV9mb2N1c2VkRnJhbWUpCiAgICAgICAgIHNldEZvY3VzZWRGcmFtZShtX3BhZ2UtPm1haW5G cmFtZSgpKTsKIAo=