49203 2010-11-08 14:00:51 -0800 Crash zooming into Word document at office.live.com 2010-11-08 14:49:45 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mitz webkit-unassigned oldest_to_newest 306344 0 mitz 2010-11-08 14:00:51 -0800 <rdar://problem/8119781> Patch forthcoming 306362 1 73283 mitz 2010-11-08 14:16:40 -0800 Created attachment 73283 Stop RenderBox::styleDidChange() from triggering layout 306369 2 73283 darin 2010-11-08 14:22:31 -0800 Comment on attachment 73283 Stop RenderBox::styleDidChange() from triggering layout Is it OK to have renderer functions that can trigger layout? It seems it’s only safe to call those functions if they are the very last ones you call. 306389 3 mitz 2010-11-08 14:49:45 -0800 Fixed in <http://trac.webkit.org/changeset/71576>. 73283 2010-11-08 14:16:40 -0800 2010-11-08 14:22:31 -0800 Stop RenderBox::styleDidChange() from triggering layout 8119781_r1.diff text/plain 4377 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTU2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTEtMDggIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8cmRh cjovL3Byb2JsZW0vODExOTc4MT4gQ3Jhc2ggem9vbWluZyBpbnRvIFdvcmQgZG9jdW1lbnQgYXQg b2ZmaWNlLmxpdmUuY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00OTIwMworCisgICAgICAgIFRlc3Q6IGZhc3QvY3NzL3pvb20tY2hhbmdlLXRyaWdn ZXJpbmctbGF5b3V0Lmh0bWwKKworICAgICAgICBSZW5kZXJCb3g6OnN0eWxlRGlkQ2hhbmdlKCkg d2FzIGNhbGxpbmcgc2Nyb2xsTGVmdCgpIGFuZCBzY3JvbGxUb3AoKSwgd2hvc2UgUmVuZGVyVGV4 dENvbnRyb2xTaW5nbGVMaW5lCisgICAgICAgIG92ZXJyaWRlcyBjYW4gdHJpZ2dlciBsYXlvdXQu CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckJveDo6c3R5bGVEaWRDaGFuZ2UpOiBVc2UgdGhlIGxheWVyIGRpcmVjdGx5IGZvciB1 cGRhdGluZyB0aGUgc2Nyb2xsIG9mZnNldHMgd2hlbgorICAgICAgICB0aGUgem9vbSBmYWN0b3Ig Y2hhbmdlcy4KKwogMjAxMC0xMS0wOCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQm94LmNwcAkocmV2aXNpb24gNzE1MzQpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTAsMTUgKzI5MCwxMyBAQCB2b2lkIFJl bmRlckJveDo6c3R5bGVEaWRDaGFuZ2UoU3R5bGVEaWZmCiAgICAgLy8gSWYgb3VyIHpvb20gZmFj dG9yIGNoYW5nZXMgYW5kIHdlIGhhdmUgYSBkZWZpbmVkIHNjcm9sbExlZnQvVG9wLCB3ZSBuZWVk IHRvIGFkanVzdCB0aGF0IHZhbHVlIGludG8gdGhlCiAgICAgLy8gbmV3IHpvb21lZCBjb29yZGlu YXRlIHNwYWNlLgogICAgIGlmIChoYXNPdmVyZmxvd0NsaXAoKSAmJiBvbGRTdHlsZSAmJiBzdHls ZSgpICYmIG9sZFN0eWxlLT5lZmZlY3RpdmVab29tKCkgIT0gc3R5bGUoKS0+ZWZmZWN0aXZlWm9v bSgpKSB7Ci0gICAgICAgIGludCBsZWZ0ID0gc2Nyb2xsTGVmdCgpOwotICAgICAgICBpZiAobGVm dCkgeworICAgICAgICBpZiAoaW50IGxlZnQgPSBsYXllcigpLT5zY3JvbGxYT2Zmc2V0KCkpIHsK ICAgICAgICAgICAgIGxlZnQgPSAobGVmdCAvIG9sZFN0eWxlLT5lZmZlY3RpdmVab29tKCkpICog c3R5bGUoKS0+ZWZmZWN0aXZlWm9vbSgpOwotICAgICAgICAgICAgc2V0U2Nyb2xsTGVmdChsZWZ0 KTsKKyAgICAgICAgICAgIGxheWVyKCktPnNjcm9sbFRvWE9mZnNldChsZWZ0KTsKICAgICAgICAg fQotICAgICAgICBpbnQgdG9wID0gc2Nyb2xsVG9wKCk7Ci0gICAgICAgIGlmICh0b3ApIHsKKyAg ICAgICAgaWYgKGludCB0b3AgPSBsYXllcigpLT5zY3JvbGxZT2Zmc2V0KCkpIHsKICAgICAgICAg ICAgIHRvcCA9ICh0b3AgLyBvbGRTdHlsZS0+ZWZmZWN0aXZlWm9vbSgpKSAqIHN0eWxlKCktPmVm ZmVjdGl2ZVpvb20oKTsKLSAgICAgICAgICAgIHNldFNjcm9sbFRvcCh0b3ApOworICAgICAgICAg ICAgbGF5ZXIoKS0+c2Nyb2xsVG9ZT2Zmc2V0KHRvcCk7CiAgICAgICAgIH0KICAgICB9CiAKSW5k ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHJldmlzaW9uIDcxNTY4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMDggIERhbiBCZXJuc3RlaW4gIDxtaXR6 QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICA8cmRhcjovL3Byb2JsZW0vODExOTc4MT4gQ3Jhc2ggem9vbWluZyBpbnRvIFdvcmQgZG9j dW1lbnQgYXQgb2ZmaWNlLmxpdmUuY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00OTIwMworCisgICAgICAgICogZmFzdC9jc3Mvem9vbS1jaGFuZ2Ut dHJpZ2dlcmluZy1sYXlvdXQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nz cy96b29tLWNoYW5nZS10cmlnZ2VyaW5nLWxheW91dC5odG1sOiBBZGRlZC4KKwogMjAxMC0xMS0w OCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY3NzL3pvb20t Y2hhbmdlLXRyaWdnZXJpbmctbGF5b3V0LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2Nzcy96b29tLWNoYW5nZS10cmlnZ2VyaW5nLWxheW91dC1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy96b29tLWNoYW5nZS10cmln Z2VyaW5nLWxheW91dC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNSBAQAor VGVzdCBmb3IgcmRhcjovL3Byb2JsZW0vODExOTc4MSBDcmFzaCB6b29taW5nIGludG8gV29yZCBk b2N1bWVudCBhdCBvZmZpY2UubGl2ZS5jb20uCisKK1RoZSB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vz IG5vdCBjcmFzaC4gVG8gdGVzdCBpbiBTYWZhcmksIG1ha2Ugc3VyZSBWaWV3ID4gWm9vbSBUZXh0 IE9ubHkgaXMgbm90IHNlbGVjdGVkLCB0aGVuIGNob29zZSBWaWV3ID4gWm9vbSBJbi4KKworCklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy96b29tLWNoYW5nZS10cmlnZ2VyaW5nLWxheW91dC5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3NzL3pvb20tY2hhbmdlLXRyaWdn ZXJpbmctbGF5b3V0Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy96 b29tLWNoYW5nZS10cmlnZ2VyaW5nLWxheW91dC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDI1IEBACis8cD4KKyAgICBUZXN0IGZvciA8aT48YSBocmVmPSJyZGFyOi8vcHJvYmxlbS84MTE5 NzgxIj5yZGFyOi8vcHJvYmxlbS84MTE5NzgxPC9hPgorICAgIENyYXNoIHpvb21pbmcgaW50byBX b3JkIGRvY3VtZW50IGF0IG9mZmljZS5saXZlLmNvbTwvaT4uCis8L3A+Cis8cD4KKyAgICBUaGUg dGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2guIFRvIHRlc3QgaW4gU2FmYXJpLCBtYWtl IHN1cmUgVmlldyA+IFpvb20gVGV4dCBPbmx5IGlzIDxpPm5vdDwvaT4gc2VsZWN0ZWQsCisgICAg dGhlbiBjaG9vc2UgVmlldyA+IFpvb20gSW4uCis8L3A+Cis8aWZyYW1lIGlkPSJpZnJhbWUiPjwv aWZyYW1lPgorPHNjcmlwdD4KKyAgICB2YXIgaWZyYW1lID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoImlmcmFtZSIpOworICAgIHZhciB0YXJnZXQgPSBpZnJhbWUuY29udGVudERvY3VtZW50LmJv ZHkuYXBwZW5kQ2hpbGQoaWZyYW1lLmNvbnRlbnREb2N1bWVudC5jcmVhdGVFbGVtZW50KCJpbnB1 dCIpKTsKKyAgICB0YXJnZXQuc3R5bGUub3ZlcmZsb3cgPSAiaGlkZGVuIjsKKyAgICBpZnJhbWUu Y29udGVudFdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJyZXNpemUiLCBmdW5jdGlvbihldmVudCkg eworICAgICAgICBpZiAodGFyZ2V0LnBhcmVudE5vZGUpCisgICAgICAgICAgICB0YXJnZXQucGFy ZW50Tm9kZS5yZW1vdmVDaGlsZCh0YXJnZXQpOworICAgIH0sIGZhbHNlKTsKKworICAgIGRvY3Vt ZW50LmJvZHkub2Zmc2V0VG9wOworCisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikgeworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAg IGV2ZW50U2VuZGVyLnpvb21QYWdlSW4oKTsKKyAgICB9Cis8L3NjcmlwdD4K