49195 2010-11-08 11:28:36 -0800 webkit-patch failure-reason explodes if a build is missing 2010-11-08 14:19:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth aroben eric oldest_to_newest 306243 0 eric 2010-11-08 11:28:36 -0800 webkit-patch failure-reason explodes if a build is missing 306244 1 73257 eric 2010-11-08 11:29:27 -0800 Created attachment 73257 Patch 306246 2 73257 aroben 2010-11-08 11:30:47 -0800 Comment on attachment 73257 Patch Looks fine to me but I don't feel qualified to r+ it. 306249 3 eric 2010-11-08 11:32:51 -0800 This is what the explosion looks like: Traceback (most recent call last): File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 70, in <module> main() File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 65, in main WebKitPatch(__file__).main() File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/queries.py", line 287, in execute return self._explain_failures_for_builder(builder, start_revision=int(start_revision)) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/queries.py", line 244, in _explain_failures_for_builder latest_results = build.layout_test_results() File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/net/buildbot.py", line 232, in layout_test_results self._layout_test_results = LayoutTestResults.results_from_string(self._fetch_results_html()) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/net/layouttestresults.py", line 75, in results_from_string parsed_results = cls._parse_results_html(string) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/net/layouttestresults.py", line 62, in _parse_results_html tables = BeautifulSoup(page).findAll("table") File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1499, in __init__ BeautifulStoneSoup.__init__(self, *args, **kwargs) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1230, in __init__ self._feed(isHTML=isHTML) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1245, in _feed smartQuotesTo=self.smartQuotesTo, isHTML=isHTML) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1751, in __init__ self._detectEncoding(markup, isHTML) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1899, in _detectEncoding xml_encoding_match = re.compile(xml_encoding_re).match(xml_data) TypeError: expected string or buffer 306339 4 73276 eric 2010-11-08 13:56:08 -0800 Created attachment 73276 Add a comment explaining why it might return None 306347 5 73276 abarth 2010-11-08 14:03:14 -0800 Comment on attachment 73276 Add a comment explaining why it might return None View in context: https://bugs.webkit.org/attachment.cgi?id=73276&action=review > WebKitTools/Scripts/webkitpy/common/net/buildbot.py:223 > + # It seems this can return None if the url redirects and then returns 404. Do other clients of this method need to understand that case? 306353 6 eric 2010-11-08 14:08:42 -0800 (In reply to comment #5) > (From update of attachment 73276 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=73276&action=review > > > WebKitTools/Scripts/webkitpy/common/net/buildbot.py:223 > > + # It seems this can return None if the url redirects and then returns 404. > > Do other clients of this method need to understand that case? They all do already. This was the one outlier. 306366 7 eric 2010-11-08 14:19:51 -0800 Committed r71571: <http://trac.webkit.org/changeset/71571> 73257 2010-11-08 11:29:27 -0800 2010-11-08 13:56:04 -0800 Patch bug-49195-20101108112926.patch text/plain 2579 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2YWVmMWNkMDk2MjMzNTZhOWM3OWVlODE1YmM5ZmJiZTVjZjM3NDM2Li43NDAwZmEy MTkzZDUxZjU0NTc2YTY0ZWRkMWU3MGM2YTU2MDBjMDljIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMTEtMDggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdlYmtpdC1wYXRjaCBmYWlsdXJl LXJlYXNvbiBleHBsb2RlcyBpZiBhIGJ1aWxkIGlzIG1pc3NpbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MTk1CisKKyAgICAgICAgVGhpcyBpcyBs aWtlbHkgYSByZWNlbnQgcmVncmVzc2lvbi4gIEFkZGluZyBhIHVuaXQgdGVzdCBmb3IgdGhpcyBj YXNlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90LnB5 OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdF91bml0dGVz dC5weToKKwogMjAxMC0xMS0wOCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QucHkgYi9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QucHkKaW5kZXggYTE0YmM3ZjAwNmRjMWRj ODg5N2ZlZmFjZjE2YWQyNDA0MGQ3MzVhYi4uMTI2MzdkMDZkNTM5YTc0MDEyYTA2YmU5MjliOTk3 MmUzMWI5ZWY5MCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vbmV0L2J1aWxkYm90LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL25ldC9idWlsZGJvdC5weQpAQCAtMjI4LDcgKzIyOCwxMCBAQCBjbGFzcyBCdWlsZChvYmpl Y3QpOgogICAgIGRlZiBsYXlvdXRfdGVzdF9yZXN1bHRzKHNlbGYpOgogICAgICAgICBpZiBub3Qg c2VsZi5fbGF5b3V0X3Rlc3RfcmVzdWx0czoKICAgICAgICAgICAgICMgRklYTUU6IFRoaXMgc2hv dWxkIGNhY2hlIHRoYXQgdGhlIHJlc3VsdCB3YXMgYSA0MDQgYW5kIHN0b3AgaGl0dGluZyB0aGUg bmV0d29yay4KLSAgICAgICAgICAgIHNlbGYuX2xheW91dF90ZXN0X3Jlc3VsdHMgPSBMYXlvdXRU ZXN0UmVzdWx0cy5yZXN1bHRzX2Zyb21fc3RyaW5nKHNlbGYuX2ZldGNoX3Jlc3VsdHNfaHRtbCgp KQorICAgICAgICAgICAgcmVzdWx0c19odG1sID0gc2VsZi5fZmV0Y2hfcmVzdWx0c19odG1sKCkK KyAgICAgICAgICAgIGlmIG5vdCByZXN1bHRzX2h0bWw6CisgICAgICAgICAgICAgICAgcmV0dXJu IE5vbmUKKyAgICAgICAgICAgIHNlbGYuX2xheW91dF90ZXN0X3Jlc3VsdHMgPSBMYXlvdXRUZXN0 UmVzdWx0cy5yZXN1bHRzX2Zyb21fc3RyaW5nKHJlc3VsdHNfaHRtbCkKICAgICAgICAgcmV0dXJu IHNlbGYuX2xheW91dF90ZXN0X3Jlc3VsdHMKIAogICAgIGRlZiBidWlsZGVyKHNlbGYpOgpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90 X3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1 aWxkYm90X3VuaXR0ZXN0LnB5CmluZGV4IGFmYzlhMzlhOWU3MTI5YzY3MmU1MTk2Zjk0NjJiZDhi YmIyZTI0M2EuLjRmZGYyNGNmZDZhNmZiNGNhNGNhMDJmOWYxYWM4NzkxMzBmZTEzYTIgMTAwNjQ0 Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdF91 bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQv YnVpbGRib3RfdW5pdHRlc3QucHkKQEAgLTExMSw2ICsxMTEsMTQgQEAgY2xhc3MgQnVpbGRlclRl c3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzZWxm LmJ1aWxkZXIuX3JldmlzaW9uX2FuZF9idWlsZF9mb3JfZmlsZW5hbWUoZmlsZW5hbWUpLCByZXZp c2lvbl9hbmRfYnVpbGQpCiAKIAorY2xhc3MgQnVpbGRUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToK KyAgICBkZWYgdGVzdF9sYXlvdXRfdGVzdF9yZXN1bHRzKHNlbGYpOgorICAgICAgICBidWlsZCA9 IEJ1aWxkKE5vbmUsIE5vbmUsIE5vbmUsIE5vbmUpCisgICAgICAgIGJ1aWxkLl9mZXRjaF9yZXN1 bHRzX2h0bWwgPSBsYW1iZGE6IE5vbmUKKyAgICAgICAgIyBUZXN0IHRoYXQgbGF5b3V0X3Rlc3Rf cmVzdWx0cygpIHJldHVybnMgTm9uZSBpZiB0aGUgZmV0Y2ggZmFpbHMuCisgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWwoYnVpbGQubGF5b3V0X3Rlc3RfcmVzdWx0cygpLCBOb25lKQorCisKIGNsYXNz IEJ1aWxkQm90VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKICAgICBfZXhhbXBsZV9vbmVfYm94 X3N0YXR1cyA9ICcnJwo= 73276 2010-11-08 13:56:08 -0800 2010-11-08 14:03:14 -0800 Add a comment explaining why it might return None bug-49195-20101108135606.patch text/plain 2991 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2YWVmMWNkMDk2MjMzNTZhOWM3OWVlODE1YmM5ZmJiZTVjZjM3NDM2Li43NDAwZmEy MTkzZDUxZjU0NTc2YTY0ZWRkMWU3MGM2YTU2MDBjMDljIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMTEtMDggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdlYmtpdC1wYXRjaCBmYWlsdXJl LXJlYXNvbiBleHBsb2RlcyBpZiBhIGJ1aWxkIGlzIG1pc3NpbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MTk1CisKKyAgICAgICAgVGhpcyBpcyBs aWtlbHkgYSByZWNlbnQgcmVncmVzc2lvbi4gIEFkZGluZyBhIHVuaXQgdGVzdCBmb3IgdGhpcyBj YXNlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90LnB5 OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdF91bml0dGVz dC5weToKKwogMjAxMC0xMS0wOCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QucHkgYi9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QucHkKaW5kZXggYTE0YmM3ZjAwNmRjMWRj ODg5N2ZlZmFjZjE2YWQyNDA0MGQ3MzVhYi4uNmYwYjJmNWU3MmRkMWE3ODE4Mzg5YWUwNDczZjll ODBiZjU4NDliNiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vbmV0L2J1aWxkYm90LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL25ldC9idWlsZGJvdC5weQpAQCAtMjIwLDYgKzIyMCw3IEBAIGNsYXNzIEJ1aWxkKG9iamVj dCk6CiAgICAgICAgIHJlc3VsdHNfaHRtbCA9ICIlcy9yZXN1bHRzLmh0bWwiICUgKHNlbGYucmVz dWx0c191cmwoKSkKICAgICAgICAgIyBGSVhNRTogVGhpcyBzaG91bGQgdXNlIE5ldHdvcmtUcmFu c2FjdGlvbidzIDQwNCBoYW5kbGluZyBpbnN0ZWFkLgogICAgICAgICB0cnk6CisgICAgICAgICAg ICAjIEl0IHNlZW1zIHRoaXMgY2FuIHJldHVybiBOb25lIGlmIHRoZSB1cmwgcmVkaXJlY3RzIGFu ZCB0aGVuIHJldHVybnMgNDA0LgogICAgICAgICAgICAgcmV0dXJuIHVybGxpYjIudXJsb3Blbihy ZXN1bHRzX2h0bWwpCiAgICAgICAgIGV4Y2VwdCB1cmxsaWIyLkhUVFBFcnJvciwgZXJyb3I6CiAg ICAgICAgICAgICBpZiBlcnJvci5jb2RlICE9IDQwNDoKQEAgLTIyOCw3ICsyMjksMTAgQEAgY2xh c3MgQnVpbGQob2JqZWN0KToKICAgICBkZWYgbGF5b3V0X3Rlc3RfcmVzdWx0cyhzZWxmKToKICAg ICAgICAgaWYgbm90IHNlbGYuX2xheW91dF90ZXN0X3Jlc3VsdHM6CiAgICAgICAgICAgICAjIEZJ WE1FOiBUaGlzIHNob3VsZCBjYWNoZSB0aGF0IHRoZSByZXN1bHQgd2FzIGEgNDA0IGFuZCBzdG9w IGhpdHRpbmcgdGhlIG5ldHdvcmsuCi0gICAgICAgICAgICBzZWxmLl9sYXlvdXRfdGVzdF9yZXN1 bHRzID0gTGF5b3V0VGVzdFJlc3VsdHMucmVzdWx0c19mcm9tX3N0cmluZyhzZWxmLl9mZXRjaF9y ZXN1bHRzX2h0bWwoKSkKKyAgICAgICAgICAgIHJlc3VsdHNfaHRtbCA9IHNlbGYuX2ZldGNoX3Jl c3VsdHNfaHRtbCgpCisgICAgICAgICAgICBpZiBub3QgcmVzdWx0c19odG1sOgorICAgICAgICAg ICAgICAgIHJldHVybiBOb25lCisgICAgICAgICAgICBzZWxmLl9sYXlvdXRfdGVzdF9yZXN1bHRz ID0gTGF5b3V0VGVzdFJlc3VsdHMucmVzdWx0c19mcm9tX3N0cmluZyhyZXN1bHRzX2h0bWwpCiAg ICAgICAgIHJldHVybiBzZWxmLl9sYXlvdXRfdGVzdF9yZXN1bHRzCiAKICAgICBkZWYgYnVpbGRl cihzZWxmKToKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L25ldC9idWlsZGJvdF91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL25ldC9idWlsZGJvdF91bml0dGVzdC5weQppbmRleCBhZmM5YTM5YTllNzEyOWM2NzJl NTE5NmY5NDYyYmQ4YmJiMmUyNDNhLi40ZmRmMjRjZmQ2YTZmYjRjYTRjYTAyZjlmMWFjODc5MTMw ZmUxM2EyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvYnVpbGRib3RfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vbmV0L2J1aWxkYm90X3VuaXR0ZXN0LnB5CkBAIC0xMTEsNiArMTExLDE0IEBAIGNs YXNzIEJ1aWxkZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWwoc2VsZi5idWlsZGVyLl9yZXZpc2lvbl9hbmRfYnVpbGRfZm9yX2ZpbGVuYW1lKGZp bGVuYW1lKSwgcmV2aXNpb25fYW5kX2J1aWxkKQogCiAKK2NsYXNzIEJ1aWxkVGVzdCh1bml0dGVz dC5UZXN0Q2FzZSk6CisgICAgZGVmIHRlc3RfbGF5b3V0X3Rlc3RfcmVzdWx0cyhzZWxmKToKKyAg ICAgICAgYnVpbGQgPSBCdWlsZChOb25lLCBOb25lLCBOb25lLCBOb25lKQorICAgICAgICBidWls ZC5fZmV0Y2hfcmVzdWx0c19odG1sID0gbGFtYmRhOiBOb25lCisgICAgICAgICMgVGVzdCB0aGF0 IGxheW91dF90ZXN0X3Jlc3VsdHMoKSByZXR1cm5zIE5vbmUgaWYgdGhlIGZldGNoIGZhaWxzLgor ICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGJ1aWxkLmxheW91dF90ZXN0X3Jlc3VsdHMoKSwgTm9u ZSkKKworCiBjbGFzcyBCdWlsZEJvdFRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogCiAgICAgX2V4 YW1wbGVfb25lX2JveF9zdGF0dXMgPSAnJycK