49191 2010-11-08 10:59:12 -0800 [Qt] image borders do not render correctly 2010-11-09 00:04:48 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 smagnuso webkit-unassigned commit-queue oldest_to_newest 306220 0 smagnuso 2010-11-08 10:59:12 -0800 The image border tests did not pass, and I believe further background tiling use cases would have been broken. This can easily be seen with LayoutTests/fast/borders/border-image-01.html. 306221 1 73253 smagnuso 2010-11-08 11:02:19 -0800 Created attachment 73253 Patch 306625 2 73253 kling 2010-11-08 23:16:53 -0800 Comment on attachment 73253 Patch r=me 306635 3 73253 commit-queue 2010-11-09 00:04:42 -0800 Comment on attachment 73253 Patch Clearing flags on attachment: 73253 Committed r71611: <http://trac.webkit.org/changeset/71611> 306636 4 commit-queue 2010-11-09 00:04:48 -0800 All reviewed patches have been landed. Closing bug. 73253 2010-11-08 11:02:19 -0800 2010-11-09 00:04:42 -0800 Patch bug-49191-20101108110640.patch text/plain 2352 smagnuso ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTI5Y2U2OWZiY2E1MjE1NWQxNGY4MzAzNzEwZDhlM2RjMTQyZTJmOS4uMGJjNzk3N2FjOTE4MWY1 NjM5MmEyNzc5Yjg0MmI3MDYyOTlkNWI4YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMS0wOCAgU2Ft IE1hZ251c29uICA8c21hZ251c29uQG5ldGZsaXguY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gaW1hZ2UgYm9yZGVycyBkbyBub3QgcmVu ZGVyIGNvcnJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDkxOTEKKworICAgICAgICBUZXN0OiBmYXN0L2JvcmRlcnMvYm9yZGVyLWltYWdlLTAx Lmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlUXQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SW1hZ2U6OmRyYXdQYXR0ZXJuKToKKwogMjAxMC0xMS0wOCAgU2ltb24g RnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT YW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFn ZVF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VRdC5jcHAKaW5kZXgg YzBjZmFlNGU2MDBhYmVjZTgwYzlhMzMwOWM1YzNmMjI4ZDc3MzVmMy4uN2I0NmI3MWUzZmI3Yzcz NmZmOGZlZmY5NDdlMzFhYjQyODZjNzQxMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9JbWFnZVF0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0 L0ltYWdlUXQuY3BwCkBAIC0xMDIsMjAgKzEwMiwzMSBAQCB2b2lkIEltYWdlOjpkcmF3UGF0dGVy bihHcmFwaGljc0NvbnRleHQqIGN0eHQsIGNvbnN0IEZsb2F0UmVjdCYgdGlsZVJlY3QsIGNvbnN0 CiAgICAgaWYgKCFmcmFtZVBpeG1hcCkgLy8gSWYgaXQncyB0b28gZWFybHkgd2Ugd29uJ3QgaGF2 ZSBhbiBpbWFnZSB5ZXQuCiAgICAgICAgIHJldHVybjsKIAorICAgIFFSZWN0RiBkciA9IFFSZWN0 RihkZXN0UmVjdCkubm9ybWFsaXplZCgpOworICAgIGlmICghZHIud2lkdGgoKSB8fCAhZHIuaGVp Z2h0KCkpIC8vIFF0IGludGVycHJldHMgMCB3aWR0aC9oZWlnaHQgYXMgZnVsbCB3aWR0aC9oZWln aHQgc28ganVzdCBzaG9ydCBjaXJjdWl0LgorICAgICAgICByZXR1cm47CisKICAgICBRUGl4bWFw IHBpeG1hcCA9ICpmcmFtZVBpeG1hcDsKLSAgICBRUmVjdCB0ciA9IFFSZWN0Rih0aWxlUmVjdCku dG9SZWN0KCk7CisgICAgUVJlY3QgdHIgPSBRUmVjdEYodGlsZVJlY3QpLnRvUmVjdCgpLm5vcm1h bGl6ZWQoKTsKICAgICBpZiAodHIueCgpIHx8IHRyLnkoKSB8fCB0ci53aWR0aCgpICE9IHBpeG1h cC53aWR0aCgpIHx8IHRyLmhlaWdodCgpICE9IHBpeG1hcC5oZWlnaHQoKSkKICAgICAgICAgcGl4 bWFwID0gcGl4bWFwLmNvcHkodHIpOwogCi0gICAgUUJydXNoIGIocGl4bWFwKTsKLSAgICBiLnNl dFRyYW5zZm9ybShwYXR0ZXJuVHJhbnNmb3JtKTsKICAgICBjdHh0LT5zYXZlKCk7CisKICAgICBj dHh0LT5zZXRDb21wb3NpdGVPcGVyYXRpb24ob3ApOwogICAgIFFQYWludGVyKiBwID0gY3R4dC0+ cGxhdGZvcm1Db250ZXh0KCk7CiAgICAgaWYgKCFwaXhtYXAuaGFzQWxwaGEoKSAmJiBwLT5jb21w b3NpdGlvbk1vZGUoKSA9PSBRUGFpbnRlcjo6Q29tcG9zaXRpb25Nb2RlX1NvdXJjZU92ZXIpCiAg ICAgICAgIHAtPnNldENvbXBvc2l0aW9uTW9kZShRUGFpbnRlcjo6Q29tcG9zaXRpb25Nb2RlX1Nv dXJjZSk7Ci0gICAgcC0+c2V0QnJ1c2hPcmlnaW4ocGhhc2UpOwotICAgIHAtPmZpbGxSZWN0KGRl c3RSZWN0LCBiKTsKKworICAgIC8qIFRyYW5zbGF0ZSB0aGUgY29vcmRpbmF0ZXMgYXMgcGhhc2Ug aXMgbm90IGluIHdvcmxkIG1hdHJpeCBjb29yZGluYXRlIHNwYWNlIGJ1dCB0aGUgdGlsZSByZWN0 IG9yaWdpbiBpcy4gKi8KKyAgICBRVHJhbnNmb3JtIHRyYW5zZm9ybShwYXR0ZXJuVHJhbnNmb3Jt KTsKKyAgICB0cmFuc2Zvcm0gKj0gUVRyYW5zZm9ybSgpLnRyYW5zbGF0ZShwaGFzZS54KCksIHBo YXNlLnkoKSk7CisgICAgdHJhbnNmb3JtLnRyYW5zbGF0ZSh0ci54KCksIHRyLnkoKSk7CisKKyAg ICBRQnJ1c2ggYihwaXhtYXApOworICAgIGIuc2V0VHJhbnNmb3JtKHRyYW5zZm9ybSk7CisgICAg cC0+ZmlsbFJlY3QoZHIsIGIpOworCiAgICAgY3R4dC0+cmVzdG9yZSgpOwogCiAgICAgaWYgKGlt YWdlT2JzZXJ2ZXIoKSkK