49190 2010-11-08 10:45:41 -0800 Correctly convert NPObjectProxy to NPVariantData 2010-11-08 11:06:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 306209 0 andersca 2010-11-08 10:45:41 -0800 Correctly convert NPObjectProxy to NPVariantData 306216 1 73251 andersca 2010-11-08 10:50:59 -0800 Created attachment 73251 Patch 306219 2 73251 sullivan 2010-11-08 10:58:40 -0800 Comment on attachment 73251 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73251&action=review > WebKit2/Shared/Plugins/NPRemoteObjectMap.cpp:120 > + // Figure out how to avoid that. If this needs to be fixed before WebKit2 is shippable, please use FIXME (WebKit2) and add a bug number. 306223 3 andersca 2010-11-08 11:06:12 -0800 Committed r71546: <http://trac.webkit.org/changeset/71546> 73251 2010-11-08 10:50:59 -0800 2010-11-08 10:58:40 -0800 Patch bug-49190-20101108105058.patch text/plain 7314 andersca ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZWRkOTFhZmUwNDU1MWM5N2IzYTcxYjg2Y2I2MWQ1NDA4OTAzMzlhLi5jMjNhODZm ODg0MzA0MWM2N2E3MDkxMTFiODk1NTc3NjQ3MDMzNzU3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMTEtMDggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3JyZWN0bHkgY29u dmVydCBOUE9iamVjdFByb3h5IHRvIE5QVmFyaWFudERhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MTkwCisKKyAgICAgICAgUmVtb3ZlIG5vdyBw YXNzaW5nIHRlc3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1NraXBwZWQ6CisKIDIw MTAtMTEtMDggIE5vYW0gUm9zZW50aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjLXdrMi9Ta2lwcGVkCmluZGV4IDgyNzA2ZDI0YmM2OGMyMTRlNmM5NWE1NzdjZGNh M2NjZGI5YmI0OWEuLmVjM2RkMWI4OWIzZmM1ZDU5MDNmMjFkNWI0NzljZTM5YTI1NzE5NWUgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvU2tpcHBlZAorKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1NraXBwZWQKQEAgLTE3NDEsNyArMTc0MSw2IEBAIHBs dWdpbnMvbnBydW50aW1lL2ludm9rZS1icm93c2VyZnVuY3MuaHRtbAogcGx1Z2lucy9ucHJ1bnRp bWUvaW52b2tlLWRlZmF1bHQuaHRtbAogcGx1Z2lucy9ucHJ1bnRpbWUvbnBydW50aW1lLmh0bWwK IHBsdWdpbnMvbnBydW50aW1lL3BsdWdpbi1zY3JpcHRhYmxlLW9iamVjdC1pbnZva2UtZGVmYXVs dC5odG1sCi1wbHVnaW5zL25wcnVudGltZS9yb3VuZC10cmlwLW5wb2JqZWN0Lmh0bWwKICAKICMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMKIApkaWZmIC0tZ2l0IGEvV2Vi S2l0Mi9DaGFuZ2VMb2cgYi9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAwMzFmYzI2NTIyNjQzNTcz NmFlZmVjMzdhYWU0ZjQyNTI0ZDBlZGIyLi5iZTczNDY4Y2ZmODFmYjZjNTU4MzI2MmE0OWJmOTIw YjRmZDQyZmNkIDEwMDY0NAotLS0gYS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9XZWJLaXQyL0No YW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEwLTExLTA4ICBBbmRlcnMgQ2FybHNzb24gIDxh bmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ29ycmVjdGx5IGNvbnZlcnQgTlBPYmplY3RQcm94eSB0byBOUFZhcmlhbnRE YXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTE5 MAorCisgICAgICAgICogU2hhcmVkL1BsdWdpbnMvTlBPYmplY3RNZXNzYWdlUmVjZWl2ZXIuaDoK KyAgICAgICAgKFdlYktpdDo6TlBPYmplY3RNZXNzYWdlUmVjZWl2ZXI6Om5wT2JqZWN0KToKKyAg ICAgICAgQWRkIE5QT2JqZWN0IGdldHRlci4KKworICAgICAgICAqIFNoYXJlZC9QbHVnaW5zL05Q T2JqZWN0UHJveHkuaDoKKyAgICAgICAgKFdlYktpdDo6TlBPYmplY3RQcm94eTo6bnBPYmplY3RJ RCk6CisgICAgICAgIEFkZCBOUE9iamVjdElEIGdldHRlci4KKworICAgICAgICAqIFNoYXJlZC9Q bHVnaW5zL05QUmVtb3RlT2JqZWN0TWFwLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TlBSZW1vdGVP YmplY3RNYXA6Om5wVmFyaWFudFRvTlBWYXJpYW50RGF0YSk6CisgICAgICAgIEhhbmRsZSB0aGUg Y2FzZSB3aGVyZSB0aGUgTlBPYmplY3QgaXMgYW4gTlBPYmplY3RQcm94eS4KKworICAgICAgICAo V2ViS2l0OjpOUFJlbW90ZU9iamVjdE1hcDo6bnBWYXJpYW50RGF0YVRvTlBWYXJpYW50KToKKyAg ICAgICAgSGFuZGxlIE5QVmFyaWFudERhdGE6OkxvY2FsTlBPYmplY3RJRC4KKworICAgICAgICAq IFNoYXJlZC9QbHVnaW5zL05QVmFyaWFudERhdGEuY3BwOgorICAgICAgICAoV2ViS2l0OjpOUFZh cmlhbnREYXRhOjptYWtlUmVtb3RlTlBPYmplY3RJRCk6CisgICAgICAgICogU2hhcmVkL1BsdWdp bnMvTlBWYXJpYW50RGF0YS5oOgorICAgICAgICBOZXcgZnVuY3Rpb24gZm9yIGNyZWF0aW5nIGFu IE5QVmFyaWFudERhdGEgdGhhdCBjb250YWlucyBhIHJlbW90ZSBOUE9iamVjdCBJRC4KKwogMjAx MC0xMS0wNyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9O UE9iamVjdE1lc3NhZ2VSZWNlaXZlci5oIGIvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9OUE9iamVj dE1lc3NhZ2VSZWNlaXZlci5oCmluZGV4IDFmNWNkMDZhNDMxZmVmMGE0YTljYTU4N2NkZDAzOWU2 MDk0ZWYxZDQuLmNiZmEwMjBkZDEzNmQ5YzM3ZDQ5OWQwNDZkNzQ5N2Q0ZmE2NjAwNjYgMTAwNjQ0 Ci0tLSBhL1dlYktpdDIvU2hhcmVkL1BsdWdpbnMvTlBPYmplY3RNZXNzYWdlUmVjZWl2ZXIuaAor KysgYi9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05QT2JqZWN0TWVzc2FnZVJlY2VpdmVyLmgKQEAg LTQ3LDYgKzQ3LDggQEAgcHVibGljOgogICAgIH5OUE9iamVjdE1lc3NhZ2VSZWNlaXZlcigpOwog CiAgICAgQ29yZUlQQzo6U3luY1JlcGx5TW9kZSBkaWRSZWNlaXZlU3luY05QT2JqZWN0TWVzc2Fn ZVJlY2VpdmVyTWVzc2FnZShDb3JlSVBDOjpDb25uZWN0aW9uKiwgQ29yZUlQQzo6TWVzc2FnZUlE LCBDb3JlSVBDOjpBcmd1bWVudERlY29kZXIqLCBDb3JlSVBDOjpBcmd1bWVudEVuY29kZXIqKTsK KworICAgIE5QT2JqZWN0KiBucE9iamVjdCgpIGNvbnN0IHsgcmV0dXJuIG1fbnBPYmplY3Q7IH0K ICAgICAKIHByaXZhdGU6CiAgICAgTlBPYmplY3RNZXNzYWdlUmVjZWl2ZXIoTlBSZW1vdGVPYmpl Y3RNYXAqIG5wUmVtb3RlT2JqZWN0TWFwLCB1aW50NjRfdCBucE9iamVjdElELCBOUE9iamVjdCog bnBPYmplY3QpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9OUE9iamVjdFBy b3h5LmggYi9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05QT2JqZWN0UHJveHkuaAppbmRleCBiYzZj ZmIxOTk3NTY0MzU3MGVkZGJjYWY0NjYwMTlhMzIyMWMwY2FhLi40ZmMwMmNmMmY5MDFhMDdjN2Q2 OThjYjMxMWQ3M2QzOWRlOWUwZjA2IDEwMDY0NAotLS0gYS9XZWJLaXQyL1NoYXJlZC9QbHVnaW5z L05QT2JqZWN0UHJveHkuaAorKysgYi9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05QT2JqZWN0UHJv eHkuaApAQCAtNDksNiArNDksOCBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBzdGF0aWNfY2Fz dDxOUE9iamVjdFByb3h5Kj4obnBPYmplY3QpOwogICAgIH0KIAorICAgIHVpbnQ2NF90IG5wT2Jq ZWN0SUQoKSBjb25zdCB7IHJldHVybiBtX25wT2JqZWN0SUQ7IH0KKwogICAgIHZvaWQgaW52YWxp ZGF0ZSgpOwogCiBwcml2YXRlOgpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9O UFJlbW90ZU9iamVjdE1hcC5jcHAgYi9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05QUmVtb3RlT2Jq ZWN0TWFwLmNwcAppbmRleCBkY2E3YTI3MmM0MDJkY2U3NDZmYTczM2JhZmVjMzU2YWI1ZDQwODcz Li5hN2NhMWRjZDFmMmU4N2JiZDFmYTY1ZDRlZjY1ZDkxN2I1YzNhZmRlIDEwMDY0NAotLS0gYS9X ZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05QUmVtb3RlT2JqZWN0TWFwLmNwcAorKysgYi9XZWJLaXQy L1NoYXJlZC9QbHVnaW5zL05QUmVtb3RlT2JqZWN0TWFwLmNwcApAQCAtMTEyLDkgKzExMiwxNCBA QCBOUFZhcmlhbnREYXRhIE5QUmVtb3RlT2JqZWN0TWFwOjpucFZhcmlhbnRUb05QVmFyaWFudERh dGEoY29uc3QgTlBWYXJpYW50JiB2YXJpYQogICAgIGNhc2UgTlBWYXJpYW50VHlwZV9PYmplY3Q6 IHsKICAgICAgICAgTlBPYmplY3QqIG5wT2JqZWN0ID0gdmFyaWFudC52YWx1ZS5vYmplY3RWYWx1 ZTsKICAgICAgICAgaWYgKE5QT2JqZWN0UHJveHk6OmlzTlBPYmplY3RQcm94eShucE9iamVjdCkp IHsKLSAgICAgICAgICAgIC8vIEZJWE1FOiBIYW5kbGUgdGhpcy4KLSAgICAgICAgICAgIG5vdElt cGxlbWVudGVkKCk7Ci0gICAgICAgICAgICByZXR1cm4gTlBWYXJpYW50RGF0YTo6bWFrZVZvaWQo KTsKKyAgICAgICAgICAgIE5QT2JqZWN0UHJveHkqIG5wT2JqZWN0UHJveHkgPSBOUE9iamVjdFBy b3h5Ojp0b05QT2JqZWN0UHJveHkobnBPYmplY3QpOworCisgICAgICAgICAgICB1aW50NjRfdCBu cE9iamVjdElEID0gbnBPYmplY3RQcm94eS0+bnBPYmplY3RJRCgpOworCisgICAgICAgICAgICAv LyBGSVhNRTogVW5kZXIgc29tZSBjaXJjdW1zdGFuY2VzLCB0aGlzIG1pZ2h0IGxlYWsgdGhlIE5Q T2JqZWN0UHJveHkgb2JqZWN0LiAKKyAgICAgICAgICAgIC8vIEZpZ3VyZSBvdXQgaG93IHRvIGF2 b2lkIHRoYXQuCisgICAgICAgICAgICByZXRhaW5OUE9iamVjdChucE9iamVjdFByb3h5KTsKKyAg ICAgICAgICAgIHJldHVybiBOUFZhcmlhbnREYXRhOjptYWtlUmVtb3RlTlBPYmplY3RJRChucE9i amVjdElEKTsKICAgICAgICAgfQogCiAgICAgICAgIHVpbnQ2NF90IG5wT2JqZWN0SUQgPSByZWdp c3Rlck5QT2JqZWN0KG5wT2JqZWN0KTsKQEAgLTE1MiwxMCArMTU3LDI0IEBAIE5QVmFyaWFudCBO UFJlbW90ZU9iamVjdE1hcDo6bnBWYXJpYW50RGF0YVRvTlBWYXJpYW50KGNvbnN0IE5QVmFyaWFu dERhdGEmIG5wVmFyCiAgICAgICAgIFNUUklOR05fVE9fTlBWQVJJQU5UKG5wU3RyaW5nLlVURjhD aGFyYWN0ZXJzLCBucFN0cmluZy5VVEY4TGVuZ3RoLCBucFZhcmlhbnQpOwogICAgICAgICBicmVh azsKICAgICB9Ci0gICAgY2FzZSBOUFZhcmlhbnREYXRhOjpMb2NhbE5QT2JqZWN0SUQ6Ci0gICAg ICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgICAgIFZPSURfVE9fTlBWQVJJQU5UKG5wVmFyaWFu dCk7CisgICAgY2FzZSBOUFZhcmlhbnREYXRhOjpMb2NhbE5QT2JqZWN0SUQ6IHsKKyAgICAgICAg dWludDY0X3QgbnBPYmplY3RJRCA9IG5wVmFyaWFudERhdGEubG9jYWxOUE9iamVjdElEVmFsdWUo KTsKKyAgICAgICAgQVNTRVJUKG5wT2JqZWN0SUQpOworCisgICAgICAgIE5QT2JqZWN0TWVzc2Fn ZVJlY2VpdmVyKiBucE9iamVjdE1lc3NhZ2VSZWNlaXZlciA9IG1fcmVnaXN0ZXJlZE5QT2JqZWN0 cy5nZXQobnBPYmplY3RJRCk7CisgICAgICAgIGlmICghbnBPYmplY3RNZXNzYWdlUmVjZWl2ZXIp IHsKKyAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICAgICAgVk9JRF9U T19OUFZBUklBTlQobnBWYXJpYW50KTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisK KyAgICAgICAgTlBPYmplY3QqIG5wT2JqZWN0ID0gbnBPYmplY3RNZXNzYWdlUmVjZWl2ZXItPm5w T2JqZWN0KCk7CisgICAgICAgIEFTU0VSVChucE9iamVjdCk7CisKKyAgICAgICAgcmV0YWluTlBP YmplY3QobnBPYmplY3QpOworICAgICAgICBPQkpFQ1RfVE9fTlBWQVJJQU5UKG5wT2JqZWN0LCBu cFZhcmlhbnQpOwogICAgICAgICBicmVhazsKKyAgICB9CiAgICAgY2FzZSBOUFZhcmlhbnREYXRh OjpSZW1vdGVOUE9iamVjdElEOiB7CiAgICAgICAgIE5QT2JqZWN0KiBucE9iamVjdFByb3h5ID0g Y3JlYXRlTlBPYmplY3RQcm94eShucFZhcmlhbnREYXRhLnJlbW90ZU5QT2JqZWN0SURWYWx1ZSgp KTsKICAgICAgICAgT0JKRUNUX1RPX05QVkFSSUFOVChucE9iamVjdFByb3h5LCBucFZhcmlhbnQp OwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9OUFZhcmlhbnREYXRhLmNwcCBi L1dlYktpdDIvU2hhcmVkL1BsdWdpbnMvTlBWYXJpYW50RGF0YS5jcHAKaW5kZXggYmM2ZjBlMzRm MWE3N2E5NzhhYTkzODFiN2JkYzUwZWNkZTVkNDlmYS4uYjEwMDU4OWJmOTgxMWEwMzViZmQwYmE5 MGM1ZmUwYjA2NDA5ODAwMCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9OUFZh cmlhbnREYXRhLmNwcAorKysgYi9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05QVmFyaWFudERhdGEu Y3BwCkBAIC0xMDgsNiArMTA4LDE2IEBAIE5QVmFyaWFudERhdGEgTlBWYXJpYW50RGF0YTo6bWFr ZUxvY2FsTlBPYmplY3RJRCh1aW50NjRfdCB2YWx1ZSkKICAgICByZXR1cm4gbnBWYXJpYW50RGF0 YTsKIH0KIAorTlBWYXJpYW50RGF0YSBOUFZhcmlhbnREYXRhOjptYWtlUmVtb3RlTlBPYmplY3RJ RCh1aW50NjRfdCB2YWx1ZSkKK3sKKyAgICBOUFZhcmlhbnREYXRhIG5wVmFyaWFudERhdGE7CisK KyAgICBucFZhcmlhbnREYXRhLm1fdHlwZSA9IE5QVmFyaWFudERhdGE6OlJlbW90ZU5QT2JqZWN0 SUQ7CisgICAgbnBWYXJpYW50RGF0YS5tX3JlbW90ZU5QT2JqZWN0SURWYWx1ZSA9IHZhbHVlOwor CisgICAgcmV0dXJuIG5wVmFyaWFudERhdGE7Cit9CisKIHZvaWQgTlBWYXJpYW50RGF0YTo6ZW5j b2RlKENvcmVJUEM6OkFyZ3VtZW50RW5jb2RlciogZW5jb2RlcikgY29uc3QKIHsKICAgICBlbmNv ZGVyLT5lbmNvZGUobV90eXBlKTsKZGlmZiAtLWdpdCBhL1dlYktpdDIvU2hhcmVkL1BsdWdpbnMv TlBWYXJpYW50RGF0YS5oIGIvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9OUFZhcmlhbnREYXRhLmgK aW5kZXggMThkM2VjZjg4MjkzOTAwNDAwODZjODdiN2Y4N2FmOWQ5ZTZjOWMxZS4uODA1NjQwZTll N2RmNmM4MDcyOTFhZjlhZDM0YjcwYzNlYzgzZmQwMyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9TaGFy ZWQvUGx1Z2lucy9OUFZhcmlhbnREYXRhLmgKKysrIGIvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9O UFZhcmlhbnREYXRhLmgKQEAgLTYwLDYgKzYwLDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBOUFZh cmlhbnREYXRhIG1ha2VEb3VibGUoZG91YmxlIHZhbHVlKTsKICAgICBzdGF0aWMgTlBWYXJpYW50 RGF0YSBtYWtlU3RyaW5nKGNvbnN0IGNoYXIqIHN0cmluZywgdW5zaWduZWQgbGVuZ3RoKTsKICAg ICBzdGF0aWMgTlBWYXJpYW50RGF0YSBtYWtlTG9jYWxOUE9iamVjdElEKHVpbnQ2NF90IHZhbHVl KTsKKyAgICBzdGF0aWMgTlBWYXJpYW50RGF0YSBtYWtlUmVtb3RlTlBPYmplY3RJRCh1aW50NjRf dCB2YWx1ZSk7CiAKICAgICBUeXBlIHR5cGUoKSBjb25zdCB7IHJldHVybiBzdGF0aWNfY2FzdDxU eXBlPihtX3R5cGUpOyB9CiAK