49189 2010-11-08 10:45:31 -0800 We should add a build step to comment out or remove the lines unsetting TEMP and TMP in the .bashrc file 2010-11-08 12:30:12 -0800 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) All Windows 7 RESOLVED FIXED P2 Normal --- 1 jberlin jberlin aroben jberlin sfalken oldest_to_newest 306208 0 jberlin 2010-11-08 10:45:31 -0800 The default .bashrc file (found at /etc/skel/.bashrc) has the following lines: # TMP and TEMP are defined in the Windows environment. Leaving # them set to the default Windows temporary directory can have # unexpected consequences. unset TMP unset TEMP This is causing Windows builds to fail due to the changes made in http://trac.webkit.org/changeset/71532, which used %TEMP% and did not expect it to be the empty string. Even if we roll out that patch, we actually want to pick up the TMP and TEMP paths from Windows (there is no good reason not to and those are the paths that will be used in released builds), so we should add a build step to comment out or remove those lines in the user's .bashrc file in tools.html. 306218 1 73252 jberlin 2010-11-08 10:55:54 -0800 Created attachment 73252 Patch 306226 2 73252 aroben 2010-11-08 11:09:27 -0800 Comment on attachment 73252 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73252&action=review > WebKitSite/building/tools.html:59 > +<p>If you are using a bash shell, comment out or remove the lines from your .bashrc file (found at /home/[username]/.bashrc) that unset TMP and unset TEMP. Those lines would prevent picking up the Windows TMP and TEMP environment variables.</p> I think it would be better to be more explicit. Something like: Remove the following lines from <code>/home/[username]/.bashrc</code>: <p class=code>unset TMP unset TEMP</p> 306264 3 jberlin 2010-11-08 11:57:19 -0800 (In reply to comment #2) > (From update of attachment 73252 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=73252&action=review > > > WebKitSite/building/tools.html:59 > > +<p>If you are using a bash shell, comment out or remove the lines from your .bashrc file (found at /home/[username]/.bashrc) that unset TMP and unset TEMP. Those lines would prevent picking up the Windows TMP and TEMP environment variables.</p> > > I think it would be better to be more explicit. Something like: > > Remove the following lines from <code>/home/[username]/.bashrc</code>: > <p class=code>unset TMP > unset TEMP</p> Changed to: <p>Remove the following lines from <code>/home/[username]/.bashrc</code>: <p class=code> <div>unset TMP</div> <div>unset TEMP</div> </p> Those lines would prevent picking up the Windows TMP and TEMP environment variables.</p> Thanks for the review! 306287 4 73252 jberlin 2010-11-08 12:29:49 -0800 Comment on attachment 73252 Patch Commited in r71557 http://trac.webkit.org/changeset/71557 73252 2010-11-08 10:55:54 -0800 2010-11-08 12:29:49 -0800 Patch addRecommendationToCommentOutUnsetTMPAndTEMPlines.patch text/plain 1813 jberlin SW5kZXg6IFdlYktpdFNpdGUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFNpdGUvQ2hh bmdlTG9nCShyZXZpc2lvbiA3MTU0MykKKysrIFdlYktpdFNpdGUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMDggIEplc3NpZSBCZXJsaW4gIDxqYmVy bGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXZSBzaG91bGQgYWRkIGEgYnVpbGQgc3RlcCB0byBjb21tZW50IG91dCBvciByZW1v dmUgdGhlIGxpbmVzIHVuc2V0dGluZyBURU1QIGFuZCBUTVAgaW4gdGhlCisgICAgICAgIC5iYXNo cmMgZmlsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ5MTg5CisKKyAgICAgICAgKiBidWlsZGluZy90b29scy5odG1sOgorICAgICAgICBBZGQgYSBs aW5lIHJlY29tbWVuZGluZyBiYXNoIHNoZWxsIHVzZXJzIHRvIGNvbW1lbnQgb3V0IG9yIHJlbW92 ZSB0aG9zZSBsaW5lcywgd2l0aCBhbgorICAgICAgICBleHBsYW5hdGlvbiBhcyB0byB3aHkuCisK IDIwMTAtMTEtMDQgIE9ybGFuZG8gTGVpdGUgIDxvcmxsZWl0ZUBnbWFpbC5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFdlYktpdFNpdGUvYnVpbGRpbmcvdG9v bHMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRTaXRlL2J1aWxkaW5nL3Rvb2xzLmh0bWwJKHJl dmlzaW9uIDcxNTM1KQorKysgV2ViS2l0U2l0ZS9idWlsZGluZy90b29scy5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC01Niw2ICs1Niw3IEBAIEtlZXAgYWxsIHRoZSBkZWZhdWx0IG9wdGlvbnMgYW5k IGNsaWNrIDwKIDxQPlZpc3RhIG1heSB3YXJuIHlvdSB0aGF0IEN5Z3dpbiBkaWQgbm90IGluc3Rh bGwgY29ycmVjdGx5LiBJZ25vcmUgdGhpcyB3YXJuaW5nIGFuZCB0ZWxsIFZpc3RhIHRoYXQgdGhl IGluc3RhbGwgd2FzIHN1Y2Nlc3NmdWwuPC9wPgogPHA+SWYgeW91IGFyZSBydW5uaW5nIFZpc3Rh LCBjbGljayBvbiB0aGUgU3RhcnQgbWVudSwgZW50ZXIgdGhlIGZvbGxvd2luZyBjb21tYW5kLCBh bmQgcHJlc3MgRW50ZXI6PC9wPgogPHAgY2xhc3M9ImNvZGUiPkM6XGN5Z3dpblxiaW5cYXNoIC1j IC9iaW4vcmViYXNlYWxsPC9wPgorPHA+SWYgeW91IGFyZSB1c2luZyBhIGJhc2ggc2hlbGwsIGNv bW1lbnQgb3V0IG9yIHJlbW92ZSB0aGUgbGluZXMgZnJvbSB5b3VyIC5iYXNocmMgZmlsZSAoZm91 bmQgYXQgL2hvbWUvW3VzZXJuYW1lXS8uYmFzaHJjKSB0aGF0IHVuc2V0IFRNUCBhbmQgdW5zZXQg VEVNUC4gVGhvc2UgbGluZXMgd291bGQgcHJldmVudCBwaWNraW5nIHVwIHRoZSBXaW5kb3dzIFRN UCBhbmQgVEVNUCBlbnZpcm9ubWVudCB2YXJpYWJsZXMuPC9wPgogCiA8bGk+PHA+SW5zdGFsbCBR dWlja1RpbWUgU0RLPC9wPgogPHA+RG93bmxvYWQgUXVpY2tUaW1lIFNESyBmb3IgV2luZG93cyBm cm9tIDxhIGhyZWY9Imh0dHA6Ly9kZXZlbG9wZXIuYXBwbGUuY29tL3F1aWNrdGltZS9kb3dubG9h ZC8iPmh0dHA6Ly9kZXZlbG9wZXIuYXBwbGUuY29tL3F1aWNrdGltZS9kb3dubG9hZC88L2E+IGFu ZCBpbnN0YWxsIGl0IHRvIHRoZSBkZWZhdWx0IGxvY2F0aW9uIChcUHJvZ3JhbSBGaWxlc1xRdWlj a1RpbWUgU0RLKS4gVGhpcyBpcyBuZWVkZWQgZm9yIG1lZGlhIHN1cHBvcnQuCg==