49175 2010-11-08 07:18:19 -0800 Building for Android generates several compiler warnings 2010-11-08 14:52:54 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned phanna steveblock oldest_to_newest 306108 0 steveblock 2010-11-08 07:18:19 -0800 These are due to signed/unsigned comparisons, assignment in if statements, braces in logical statements, and redefinition of macros. 306121 1 73239 steveblock 2010-11-08 07:46:17 -0800 Created attachment 73239 Patch 306236 2 73239 levin 2010-11-08 11:21:59 -0800 Comment on attachment 73239 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73239&action=review Please fix typos in changelog. > WebCore/ChangeLog:9 > + - PREFIX_FOR_WEBCORE was previously required for STL's algirithm, but is no typo: algirithm > WebCore/ChangeLog:15 > + No new tests, fixes compile arnings only. typo: arnings 306392 3 steveblock 2010-11-08 14:52:54 -0800 Committed r71578: <http://trac.webkit.org/changeset/71578> 73239 2010-11-08 07:46:17 -0800 2010-11-08 11:21:58 -0800 Patch bug-49175-20101108154615.patch text/plain 3951 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTUyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjUgQEAKKzIwMTAtMTEtMDggIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEJ1aWxkaW5nIGZvciBBbmRyb2lkIGdlbmVyYXRlcyBzZXZlcmFsIGNvbXBpbGVyIHdhcm5pbmdz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTE3NQor CisgICAgICAgIEZpeGVzIHRoZXNlIHdhcm5pbmdzLCBtb3N0IG9mIHdoaWNoIGFyZSB0cml2aWFs LgorICAgICAgICAtIFBSRUZJWF9GT1JfV0VCQ09SRSB3YXMgcHJldmlvdXNseSByZXF1aXJlZCBm b3IgU1RMJ3MgYWxnaXJpdGhtLCBidXQgaXMgbm8KKyAgICAgICAgICBsb25nZXIuIFNlZQorICAg ICAgICAgIGh0dHA6Ly9hbmRyb2lkLmdpdC5rZXJuZWwub3JnLz9wPXBsYXRmb3JtL2V4dGVybmFs L3dlYmtpdC5naXQ7YT1jb21taXQ7aD1hNDdhYjUyOTQyMTNjY2EyNzQxZjQ1M2I0NTBiMDI2NjZl MDhjYWM4CisgICAgICAgIC0gVGhlIGRlZmluaXRpb24gb2YgRVhQT1JUIGlzIHJlcXVpcmVkIG9u bHkgZm9yIHRoZSBKTkkgZW50cnkgcG9pbnQgaW4KKyAgICAgICAgICBXZWJLaXQvYW5kcm9pZCwg c28gZG9lcyBub3QgbmVlZCB0byBiZSBpbiBXZWJDb3JlUHJlZml4LmgKKworICAgICAgICBObyBu ZXcgdGVzdHMsIGZpeGVzIGNvbXBpbGUgYXJuaW5ncyBvbmx5LgorCisgICAgICAgICogV2ViQ29y ZVByZWZpeC5oOgorICAgICAgICAqIGJyaWRnZS9qbmkvanNjL0pOSVV0aWxpdHlQcml2YXRlLmNw cDoKKyAgICAgICAgKEpTQzo6QmluZGluZ3M6OmNvbnZlcnRWYWx1ZVRvSlZhbHVlKToKKyAgICAg ICAgKiBwbGF0Zm9ybS9hbmRyb2lkL0ZpbGVTeXN0ZW1BbmRyb2lkLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Omxpc3REaXJlY3RvcnkpOgorCiAyMDEwLTExLTA4ICBZdXJ5IFNlbWlraGF0c2t5ICA8 eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4u CkluZGV4OiBXZWJDb3JlL1dlYkNvcmVQcmVmaXguaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dl YkNvcmVQcmVmaXguaAkocmV2aXNpb24gNzE1MTkpCisrKyBXZWJDb3JlL1dlYkNvcmVQcmVmaXgu aAkod29ya2luZyBjb3B5KQpAQCAtNjQsMTQgKzY0LDYgQEAKICNlbmRpZgogI2VuZGlmIC8vIGRl ZmluZWQoV0lOMzIpIHx8IGRlZmluZWQoX1dJTjMyKQogCi0jaWYgZGVmaW5lZChBTkRST0lEKQot I2lmZGVmIF9fY3BsdXNwbHVzCi0vLyBNdXN0IGNvbWUgYmVmb3JlIGluY2x1ZGUgb2YgYWxnb3Jp dGhtLgotI2RlZmluZSBQUkVGSVhfRk9SX1dFQkNPUkUgMQotI2RlZmluZSBFWFBPUlQgX19hdHRy aWJ1dGVfXygodmlzaWJpbGl0eSgiZGVmYXVsdCIpKSkKLSNlbmRpZgotI2VuZGlmCi0KICNpZiAh ZGVmaW5lZChCVUlMRElOR19CUkVXTVBfXykKICNpbmNsdWRlIDxzeXMvdHlwZXMuaD4KICNpbmNs dWRlIDxmY250bC5oPgpJbmRleDogV2ViQ29yZS9icmlkZ2Uvam5pL2pzYy9KTklVdGlsaXR5UHJp dmF0ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9icmlkZ2Uvam5pL2pzYy9KTklVdGlsaXR5 UHJpdmF0ZS5jcHAJKHJldmlzaW9uIDcxNTE5KQorKysgV2ViQ29yZS9icmlkZ2Uvam5pL2pzYy9K TklVdGlsaXR5UHJpdmF0ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwMCw3ICsyMDAsOCBAQCBq dmFsdWUgY29udmVydFZhbHVlVG9KVmFsdWUoRXhlY1N0YXRlKiBlCiAgICAgICAgICAgICAgICAg fSBlbHNlIGlmIChvYmplY3QtPmNsYXNzSW5mbygpID09ICZKU0FycmF5OjppbmZvKSB7CiAgICAg ICAgICAgICAgICAgICAgIC8vIElucHV0IGlzIGEgSmF2YXNjcmlwdCBBcnJheS4gV2UgbmVlZCB0 byBjcmVhdGUgaXQgdG8gYSBKYXZhIEFycmF5LgogICAgICAgICAgICAgICAgICAgICByZXN1bHQu bCA9IGNvbnZlcnRBcnJheUluc3RhbmNlVG9KYXZhQXJyYXkoZXhlYywgYXNBcnJheSh2YWx1ZSks IGphdmFDbGFzc05hbWUpOwotICAgICAgICAgICAgICAgIH0gZWxzZSBpZiAoIXJlc3VsdC5sICYm ICghc3RyY21wKGphdmFDbGFzc05hbWUsICJqYXZhLmxhbmcuT2JqZWN0IikpIHx8ICghc3RyY21w KGphdmFDbGFzc05hbWUsICJuZXRzY2FwZS5qYXZhc2NyaXB0LkpTT2JqZWN0IikpKSB7CisgICAg ICAgICAgICAgICAgfSBlbHNlIGlmICgoIXJlc3VsdC5sICYmICghc3RyY21wKGphdmFDbGFzc05h bWUsICJqYXZhLmxhbmcuT2JqZWN0IikpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgfHwg KCFzdHJjbXAoamF2YUNsYXNzTmFtZSwgIm5ldHNjYXBlLmphdmFzY3JpcHQuSlNPYmplY3QiKSkp IHsKICAgICAgICAgICAgICAgICAgICAgLy8gV3JhcCBvYmplY3RzIGluIEpTT2JqZWN0IGluc3Rh bmNlcy4KICAgICAgICAgICAgICAgICAgICAgSk5JRW52KiBlbnYgPSBnZXRKTklFbnYoKTsKICAg ICAgICAgICAgICAgICAgICAgamNsYXNzIGpzT2JqZWN0Q2xhc3MgPSBlbnYtPkZpbmRDbGFzcygi c3VuL3BsdWdpbi9qYXZhc2NyaXB0L3dlYmtpdC9KU09iamVjdCIpOwpJbmRleDogV2ViQ29yZS9w bGF0Zm9ybS9hbmRyb2lkL0ZpbGVTeXN0ZW1BbmRyb2lkLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3BsYXRmb3JtL2FuZHJvaWQvRmlsZVN5c3RlbUFuZHJvaWQuY3BwCShyZXZpc2lvbiA3MTUx OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vYW5kcm9pZC9GaWxlU3lzdGVtQW5kcm9pZC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTg4LDE3ICs4OCwxNSBAQCBWZWN0b3I8U3RyaW5nPiBsaXN0RGlyZWN0 b3J5KGNvbnN0IFN0cmluCiAgICAgRElSKiBkaXIgPSBvcGVuZGlyKGNwYXRoLmRhdGEoKSk7CiAg ICAgaWYgKGRpcikgewogICAgICAgICBzdHJ1Y3QgZGlyZW50KiBkcDsKLSAgICAgICAgd2hpbGUg KGRwID0gcmVhZGRpcihkaXIpKSB7CisgICAgICAgIHdoaWxlICgoZHAgPSByZWFkZGlyKGRpcikp KSB7CiAgICAgICAgICAgICBjb25zdCBjaGFyKiBuYW1lID0gZHAtPmRfbmFtZTsKICAgICAgICAg ICAgIGlmICghc3RyY21wKG5hbWUsICIuIikgfHwgIXN0cmNtcChuYW1lLCAiLi4iKSkKICAgICAg ICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgIGlmIChmbm1hdGNoKGNmaWx0ZXIuZGF0 YSgpLCBuYW1lLCAwKSkKICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgIGNo YXIgZmlsZVBhdGhbMTAyNF07Ci0gICAgICAgICAgICBpZiAoKGludCkgKHNpemVvZihmaWxlUGF0 aCkgLSAxKSA8IHNucHJpbnRmKGZpbGVQYXRoLAotICAgICAgICAgICAgICAgICAgICBzaXplb2Yo ZmlsZVBhdGgpLCAiJXMvJXMiLCBjcGF0aC5kYXRhKCksIG5hbWUpKSB7CisgICAgICAgICAgICBp ZiAoc3RhdGljX2Nhc3Q8aW50PihzaXplb2YoZmlsZVBhdGgpIC0gMSkgPCBzbnByaW50ZihmaWxl UGF0aCwgc2l6ZW9mKGZpbGVQYXRoKSwgIiVzLyVzIiwgY3BhdGguZGF0YSgpLCBuYW1lKSkKICAg ICAgICAgICAgICAgICBjb250aW51ZTsgLy8gYnVmZmVyIG92ZXJmbG93Ci0gICAgICAgICAgICB9 CiAgICAgICAgICAgICBlbnRyaWVzLmFwcGVuZChmaWxlUGF0aCk7CiAgICAgICAgIH0KICAgICAg ICAgY2xvc2VkaXIoZGlyKTsK