49161 2010-11-08 00:03:02 -0800 Web Inspector: Provide context menu item 'Reveal in Elements Panel' on elements in inspector UI. 2010-11-11 05:47:03 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman apavlov bweinstein commit-queue joepeck keishi loislo pfeldman phnixwxz pmuellr rik timothy yurys oldest_to_newest 306034 0 pfeldman 2010-11-08 00:03:02 -0800 This should include both: formatted JS objects that are dom wrappers by nature (of type 'node' in internal inspector terms) and formatted element tree structures. 306823 1 73384 pfeldman 2010-11-09 09:11:09 -0800 Created attachment 73384 [PATCH] Proposed change. 307794 2 73384 commit-queue 2010-11-11 02:20:59 -0800 Comment on attachment 73384 [PATCH] Proposed change. Rejecting patch 73384 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73384]" exit_code: 2 Last 500 characters of output: ntains a binary file without the binary data in line: "Binary files a/WebCore/English.lproj/localizedStrings.js and b/WebCore/English.lproj/localizedStrings.js differ". Be sure to use the --binary flag when invoking "git diff" with diffs containing binary files. at /Users/abarth/git/webkit-queue/WebKitTools/Scripts/VCSUtils.pm line 567, <ARGV> line 31. Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Yury Semikhatsky', u'--force']" exit_code: 9 Full output: http://queues.webkit.org/results/5539099 307860 3 pfeldman 2010-11-11 05:47:03 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ElementsTreeOutline.js M WebCore/inspector/front-end/ObjectPropertiesSection.js Committed r71812 73384 2010-11-09 09:11:09 -0800 2010-11-11 02:20:59 -0800 [PATCH] Proposed change. reveal_in_elements text/plain 5779 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWRlZTg2ZS4uMDZiOTdjOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMyBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFByb3ZpZGUgY29udGV4dCBt ZW51IGl0ZW0gJ1JldmVhbCBpbiBFbGVtZW50cyBQYW5lbCcKKyAgICAgICAgb24gZWxlbWVudHMg aW4gaW5zcGVjdG9yIFVJLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDkxNjEKKworICAgICAgICAqIEVuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5n cy5qczoKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlT3V0bGluZS5wcm90b3R5cGUu X2NvbnRleHRNZW51RXZlbnRGaXJlZC5mb2N1c0VsZW1lbnQpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkVsZW1lbnRzVHJlZU91dGxpbmUucHJvdG90eXBlLl9jb250ZXh0TWVudUV2ZW50RmlyZWQp OgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvT2JqZWN0UHJvcGVydGllc1NlY3Rpb24u anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuT2JqZWN0UHJvcGVydHlUcmVlRWxlbWVudC5wcm90 b3R5cGUudXBkYXRlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5PYmplY3RQcm9wZXJ0eVRyZWVF bGVtZW50LnByb3RvdHlwZS5fY29udGV4dE1lbnVFdmVudEZpcmVkKToKKyAgICAgICAgKFdlYklu c3BlY3Rvci5PYmplY3RQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZS5fY29udGV4dE1lbnVF dmVudEZpcmVkLnJldmVhbEVsZW1lbnQpOgorCisyMDEwLTExLTA5ICBQYXZlbCBGZWxkbWFuICA8 cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHNpemUgb2YgcmVzb3VyY2VzIGluIHN1bW1h cnkgaXMgMAogICAgICAgICB3aGVuIHRoZXJlIGFyZSByZWRpcmVjdHMuCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTI0MgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9XZWJDb3JlL0VuZ2xpc2gu bHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwppbmRleCAwMmUyMTQzLi4xMDI0MDBmIDEwMDY0NApC aW5hcnkgZmlsZXMgYS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBh bmQgYi9XZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBkaWZmZXIKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5l LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMK aW5kZXggNDQwNDA1MS4uYTlkODZlNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKQEAgLTI2NSwyMSArMjY1LDI4IEBAIFdlYklu c3BlY3Rvci5FbGVtZW50c1RyZWVPdXRsaW5lLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHJl dHVybjsKIAogICAgICAgICB2YXIgY29udGV4dE1lbnUgPSBuZXcgV2ViSW5zcGVjdG9yLkNvbnRl eHRNZW51KCk7Ci0KLSAgICAgICAgdmFyIGhyZWYgPSBldmVudC50YXJnZXQuZW5jbG9zaW5nTm9k ZU9yU2VsZldpdGhDbGFzcygid2Via2l0LWh0bWwtcmVzb3VyY2UtbGluayIpIHx8IGV2ZW50LnRh cmdldC5lbmNsb3NpbmdOb2RlT3JTZWxmV2l0aENsYXNzKCJ3ZWJraXQtaHRtbC1leHRlcm5hbC1s aW5rIik7Ci0gICAgICAgIHZhciB0YWcgPSBldmVudC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2Vs ZldpdGhDbGFzcygid2Via2l0LWh0bWwtdGFnIik7Ci0gICAgICAgIHZhciB0ZXh0Tm9kZSA9IGV2 ZW50LnRhcmdldC5lbmNsb3NpbmdOb2RlT3JTZWxmV2l0aENsYXNzKCJ3ZWJraXQtaHRtbC10ZXh0 LW5vZGUiKTsKLSAgICAgICAgdmFyIG5lZWRTZXBhcmF0b3I7Ci0gICAgICAgIGlmIChocmVmKQot ICAgICAgICAgICAgbmVlZFNlcGFyYXRvciA9IFdlYkluc3BlY3Rvci5wYW5lbHMuZWxlbWVudHMu cG9wdWxhdGVIcmVmQ29udGV4dE1lbnUoY29udGV4dE1lbnUsIGV2ZW50LCBocmVmKTsKLSAgICAg ICAgaWYgKHRhZyAmJiBsaXN0SXRlbS50cmVlRWxlbWVudC5fcG9wdWxhdGVUYWdDb250ZXh0TWVu dSkgewotICAgICAgICAgICAgaWYgKG5lZWRTZXBhcmF0b3IpCi0gICAgICAgICAgICAgICAgY29u dGV4dE1lbnUuYXBwZW5kU2VwYXJhdG9yKCk7Ci0gICAgICAgICAgICBsaXN0SXRlbS50cmVlRWxl bWVudC5fcG9wdWxhdGVUYWdDb250ZXh0TWVudShjb250ZXh0TWVudSwgZXZlbnQpOwotICAgICAg ICB9IGVsc2UgaWYgKHRleHROb2RlICYmIGxpc3RJdGVtLnRyZWVFbGVtZW50Ll9wb3B1bGF0ZVRl eHRDb250ZXh0TWVudSkgewotICAgICAgICAgICAgaWYgKG5lZWRTZXBhcmF0b3IpCi0gICAgICAg ICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kU2VwYXJhdG9yKCk7Ci0gICAgICAgICAgICBsaXN0 SXRlbS50cmVlRWxlbWVudC5fcG9wdWxhdGVUZXh0Q29udGV4dE1lbnUoY29udGV4dE1lbnUsIHRl eHROb2RlKTsKKyAgICAgICAgaWYgKHRoaXMuc2hvd0luRWxlbWVudHNQYW5lbEVuYWJsZWQpIHsK KyAgICAgICAgICAgIGZ1bmN0aW9uIGZvY3VzRWxlbWVudCgpCisgICAgICAgICAgICB7CisgICAg ICAgICAgICAgICAgV2ViSW5zcGVjdG9yLnBhbmVscy5lbGVtZW50cy5mb2N1c2VkRE9NTm9kZSA9 IGxpc3RJdGVtLnRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0OworICAgICAgICAgICAgfQor ICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlTdHJpbmco IlJldmVhbCBpbiBFbGVtZW50cyBQYW5lbCIpLCBmb2N1c0VsZW1lbnQuYmluZCh0aGlzKSk7Cisg ICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICB2YXIgaHJlZiA9IGV2ZW50LnRhcmdldC5lbmNs b3NpbmdOb2RlT3JTZWxmV2l0aENsYXNzKCJ3ZWJraXQtaHRtbC1yZXNvdXJjZS1saW5rIikgfHwg ZXZlbnQudGFyZ2V0LmVuY2xvc2luZ05vZGVPclNlbGZXaXRoQ2xhc3MoIndlYmtpdC1odG1sLWV4 dGVybmFsLWxpbmsiKTsKKyAgICAgICAgICAgIHZhciB0YWcgPSBldmVudC50YXJnZXQuZW5jbG9z aW5nTm9kZU9yU2VsZldpdGhDbGFzcygid2Via2l0LWh0bWwtdGFnIik7CisgICAgICAgICAgICB2 YXIgdGV4dE5vZGUgPSBldmVudC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhDbGFzcygi d2Via2l0LWh0bWwtdGV4dC1ub2RlIik7CisgICAgICAgICAgICB2YXIgbmVlZFNlcGFyYXRvcjsK KyAgICAgICAgICAgIGlmIChocmVmKQorICAgICAgICAgICAgICAgIG5lZWRTZXBhcmF0b3IgPSBX ZWJJbnNwZWN0b3IucGFuZWxzLmVsZW1lbnRzLnBvcHVsYXRlSHJlZkNvbnRleHRNZW51KGNvbnRl eHRNZW51LCBldmVudCwgaHJlZik7CisgICAgICAgICAgICBpZiAodGFnICYmIGxpc3RJdGVtLnRy ZWVFbGVtZW50Ll9wb3B1bGF0ZVRhZ0NvbnRleHRNZW51KSB7CisgICAgICAgICAgICAgICAgaWYg KG5lZWRTZXBhcmF0b3IpCisgICAgICAgICAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZFNl cGFyYXRvcigpOworICAgICAgICAgICAgICAgIGxpc3RJdGVtLnRyZWVFbGVtZW50Ll9wb3B1bGF0 ZVRhZ0NvbnRleHRNZW51KGNvbnRleHRNZW51LCBldmVudCk7CisgICAgICAgICAgICB9IGVsc2Ug aWYgKHRleHROb2RlICYmIGxpc3RJdGVtLnRyZWVFbGVtZW50Ll9wb3B1bGF0ZVRleHRDb250ZXh0 TWVudSkgeworICAgICAgICAgICAgICAgIGlmIChuZWVkU2VwYXJhdG9yKQorICAgICAgICAgICAg ICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRTZXBhcmF0b3IoKTsKKyAgICAgICAgICAgICAgICBs aXN0SXRlbS50cmVlRWxlbWVudC5fcG9wdWxhdGVUZXh0Q29udGV4dE1lbnUoY29udGV4dE1lbnUs IHRleHROb2RlKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgICBjb250ZXh0TWVu dS5zaG93KGV2ZW50KTsKICAgICB9CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvT2JqZWN0UHJvcGVydGllc1NlY3Rpb24uanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvT2JqZWN0UHJvcGVydGllc1NlY3Rpb24uanMKaW5kZXggMDE1MDM5Yy4uNjEwZGM0MSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL09iamVjdFByb3BlcnRpZXNT ZWN0aW9uLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3RQcm9wZXJ0 aWVzU2VjdGlvbi5qcwpAQCAtMTg2LDYgKzE4Niw4IEBAIFdlYkluc3BlY3Rvci5PYmplY3RQcm9w ZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMudmFsdWVFbGVt ZW50LmFkZFN0eWxlQ2xhc3MoImVycm9yIik7CiAgICAgICAgIGlmICh0aGlzLnByb3BlcnR5LnZh bHVlLnR5cGUpCiAgICAgICAgICAgICB0aGlzLnZhbHVlRWxlbWVudC5hZGRTdHlsZUNsYXNzKCJj b25zb2xlLWZvcm1hdHRlZC0iICsgdGhpcy5wcm9wZXJ0eS52YWx1ZS50eXBlKTsKKyAgICAgICAg aWYgKHRoaXMucHJvcGVydHkudmFsdWUudHlwZSA9PT0gIm5vZGUiKQorICAgICAgICAgICAgdGhp cy52YWx1ZUVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY29udGV4dG1lbnUiLCB0aGlzLl9jb250 ZXh0TWVudUV2ZW50RmlyZWQuYmluZCh0aGlzKSwgdHJ1ZSk7CiAKICAgICAgICAgdGhpcy5saXN0 SXRlbUVsZW1lbnQucmVtb3ZlQ2hpbGRyZW4oKTsKIApAQCAtMTk1LDYgKzE5NywyNCBAQCBXZWJJ bnNwZWN0b3IuT2JqZWN0UHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAgICAgICAg IHRoaXMuaGFzQ2hpbGRyZW4gPSB0aGlzLnByb3BlcnR5LnZhbHVlLmhhc0NoaWxkcmVuOwogICAg IH0sCiAKKyAgICBfY29udGV4dE1lbnVFdmVudEZpcmVkOiBmdW5jdGlvbigpCisgICAgeworICAg ICAgICBmdW5jdGlvbiBzZWxlY3ROb2RlKG5vZGVJZCkKKyAgICAgICAgeworICAgICAgICAgICAg aWYgKG5vZGVJZCkKKyAgICAgICAgICAgICAgICBXZWJJbnNwZWN0b3IucGFuZWxzLmVsZW1lbnRz LmZvY3VzZWRET01Ob2RlID0gV2ViSW5zcGVjdG9yLmRvbUFnZW50Lm5vZGVGb3JJZChub2RlSWQp OworICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gcmV2ZWFsRWxlbWVudCgpCisgICAgICAg IHsKKyAgICAgICAgICAgIHRoaXMucHJvcGVydHkudmFsdWUucHVzaE5vZGVUb0Zyb250ZW5kKHNl bGVjdE5vZGUpOworICAgICAgICB9CisKKyAgICAgICAgdmFyIGNvbnRleHRNZW51ID0gbmV3IFdl Ykluc3BlY3Rvci5Db250ZXh0TWVudSgpOworICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVt KFdlYkluc3BlY3Rvci5VSVN0cmluZygiUmV2ZWFsIGluIEVsZW1lbnRzIFBhbmVsIiksIHJldmVh bEVsZW1lbnQuYmluZCh0aGlzKSk7CisgICAgICAgIGNvbnRleHRNZW51LnNob3coZXZlbnQpOwor ICAgIH0sCisKICAgICB1cGRhdGVTaWJsaW5nczogZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAg aWYgKHRoaXMucGFyZW50LnJvb3QpCg==