49158 2010-11-07 20:38:35 -0800 webkit-patch suggest-reviewers dies when ChangeLogs are missing 2011-01-14 02:27:29 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 49156 1 eric webkit-unassigned abarth commit-queue eric mihaip mitz simon.fraser webkit.review.bot oldest_to_newest 305965 0 eric 2010-11-07 20:38:35 -0800 webkit-patch suggest-reviewers dies when ChangeLogs are missing Failed to run "[u'svn', u'cat', u'-r', u'20242', u'http://svn.webkit.org/repository/webkit/trunk/WebCore/ChangeLog']" exit_code: 1 svn: Unable to find repository location for 'http://svn.webkit.org/repository/webkit/trunk/WebCore/ChangeLog' in revision 20242 Failed to run "[u'svn', u'cat', u'-r', u'20242', u'http://svn.webkit.org/repository/webkit/trunk/WebCore/ChangeLog']" exit_code: 1 Traceback (most recent call last): File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 70, in <module> main() File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 65, in main WebKitPatch(__file__).main() File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/queries.py", line 57, in execute reviewers = tool.checkout().suggested_reviewers(options.git_commit) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 127, in suggested_reviewers commit_infos = self.recent_commit_infos_for_files(changed_files) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 123, in recent_commit_infos_for_files return set(map(self.commit_info_for_revision, revisions)) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/memoized.py", line 45, in __call__ result = self._function(*args) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 66, in commit_info_for_revision changelog_entries = self.changelog_entries_for_revision(revision) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 61, in changelog_entries_for_revision return [self._latest_entry_for_changelog_at_revision(path, revision) for path in changed_files if self._is_path_to_changelog(path)] File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 52, in _latest_entry_for_changelog_at_revision changelog_contents = self._scm.contents_at_revision(changelog_path, revision) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm.py", line 480, in contents_at_revision return self.run(["svn", "cat", "-r", revision, remote_path], decode_output=False) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm.py", line 159, in run decode_output=decode_output) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 92, in run_command return Executive().run_command(*args, **kwargs) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 375, in run_command (error_handler or self.default_error_handler)(script_error) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 291, in default_error_handler raise error webkitpy.common.system.executive.ScriptError: Failed to run "[u'svn', u'cat', u'-r', u'20242', u'http://svn.webkit.org/repository/webkit/trunk/WebCore/ChangeLog']" exit_code: 1 305966 1 eric 2010-11-07 20:41:05 -0800 Hmm... http://trac.webkit.org/changeset/20242 seems to have a ChangeLog. Not sure why this is failing. 305970 2 eric 2010-11-07 20:44:00 -0800 % svn cat -r 20242 http://svn.webkit.org/repository/webkit/trunk/WebCore/ChangeLog svn: Unable to find repository location for 'http://svn.webkit.org/repository/webkit/trunk/WebCore/ChangeLog' in revision 20242 The error makes no sense to me. Maybe Bill understands? 305973 3 eric 2010-11-07 20:45:41 -0800 svn cat -r 71493 http://svn.webkit.org/repository/webkit/trunk/WebCore/ChangeLog on the other hand works just fine. Suggesting this is some sort of svn-server-side mis-config. That change is old-enough that it may have come from the cvs-import. 316290 4 eric 2010-12-02 11:35:03 -0800 See also bug 50403. 334092 5 78885 eric 2011-01-13 20:12:08 -0800 Created attachment 78885 Patch 334093 6 eric 2011-01-13 20:13:36 -0800 We could also add an option to _latest_entry_for_changelog_at_revision to have it return None on error. That might be cleaner than this patch. 334098 7 78885 levin 2011-01-13 21:16:24 -0800 Comment on attachment 78885 Patch ok. 334107 8 78885 commit-queue 2011-01-13 21:40:33 -0800 Comment on attachment 78885 Patch Clearing flags on attachment: 78885 Committed r75769: <http://trac.webkit.org/changeset/75769> 334108 9 commit-queue 2011-01-13 21:40:40 -0800 All reviewed patches have been landed. Closing bug. 334127 10 webkit.review.bot 2011-01-13 22:35:34 -0800 http://trac.webkit.org/changeset/75769 might have broken Qt Linux Release 334187 11 eric 2011-01-14 01:52:58 -0800 Committed r75779: <http://trac.webkit.org/changeset/75779> 334212 12 webkit.review.bot 2011-01-14 02:27:29 -0800 http://trac.webkit.org/changeset/75779 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/xmlhttprequest/cross-origin-authorization.html 78885 2011-01-13 20:12:08 -0800 2011-01-13 21:40:33 -0800 Patch bug-49158-20110113201206.patch text/plain 5208 eric ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYmE5 ZWY0YjA5Mjg4NWEwNzJjZTg2Y2M3MjFkNWU4YjhkZDc3ZWMzLi4zNDZiNjEzMmEzZTg1YjMzMDNm YmI0MDIyMmYzMmRlNzA3ZDdkOTcyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzMgQEAKIDIwMTEtMDEtMTMgIEVyaWMgU2VpZGVs ICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIHdlYmtpdC1wYXRjaCBzdWdnZXN0LXJldmlld2VycyBkaWVzIHdoZW4gQ2hh bmdlTG9ncyBhcmUgbWlzc2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDkxNTgKKworICAgICAgICBUaGlzIGlzIG5vdCB0aGUgbW9zdCBlbGVnYW50 LCBidXQgaXQgaXMgYSB2ZXJ5IHNhZmUgZml4IHRvIHRoaXMgYnVnLgorICAgICAgICBPbmUgYWR2 YW50YWdlIG9mIGNhdGNoaW5nIFNjcmlwdEVycm9yIGxpa2UgdGhpcyBpbnN0ZWFkIG9mIGFkZGlu ZyBhCisgICAgICAgIG5ldyBhZGRlZF9vcl9tb2RpZmllZF9maWxlcyBvciBmaXhpbmcgYWxsIGNo YW5nZWRfZmlsZXMgY2FsbGVycworICAgICAgICB0byB1c2UgYSBtb3JlIHNwZWNpZmljIGNoYW5n ZV9maWxlcyB2YXJpYW50LCBpcyB0aGF0IHdlIGNhdGNoCisgICAgICAgIGFsbCBraW5kcyBvZiBT Y3JpcHRFcnJvcnMgd2hpY2ggbWlnaHQgY2F1c2Ugb3VyIChub24tZXNzZW50aWFsKQorICAgICAg ICBzdWdnZXN0LXJldmlld2VycyBjb2RlIHRvIGZhaWwgb3V0LiAgVGhpcyBzaG91bGQgbWFrZSBw YXNzaW5nCisgICAgICAgIC0tc3VnZ2VzdC1yZXZpZXdlcnMgdG8gd2Via2l0LXBhdGNoIHVwbG9h ZCBtdWNoIG1vcmUgcm9idXN0CisgICAgICAgIGFuZCBtYXkgZXZlbiBtYWtlIGl0IHBvc3NpYmxl IGZvciB1cyB0byBtYWtlIGl0IGRlZmF1bHQuCisKKyAgICAgICAgVGhlIHJvb3Qgb2YgdGhlIHBy b2JsZW0gaGVyZSBpcyB0aGF0IFNDTS5jaGFuZ2VkX2ZpbGVzIGluY2x1ZGVzCisgICAgICAgIGRl bGV0ZWQgQ2hhbmdlTG9nIHBhdGhzIChmcm9tIG1vdmVzLCBldGMpIHdoaWNoIHRoZW4gd2hlbiB3 ZSBhc2sKKyAgICAgICAgU1ZOL0dpdCBmb3IgdGhlIGNvbnRlbnRzIG9mIHRoZSBmaWxlIGF0IHRo YXQgcmV2aXNpb24sIHRoZSBjb21tYW5kCisgICAgICAgIGVycm9ycyBvdXQgYW5kIEV4ZWN1dGl2 ZS5ydW5fY29tbWFuZCByYWlzZXMgYSBTY3JpcHRFcnJvci4KKworICAgICAgICBJbiB0aGUgZnV0 dXJlIHdlIG1pZ2h0IGZpeCB0aGlzIGRpZmZlcmVudGx5IGJ5IG1ha2luZyBhbGwgY3VycmVudAor ICAgICAgICBjYWxsZXJzIG9mIGNoYWduZWRfZmlsZXMgdXNlIGEgbW9yZSBzcGVjaWZpYyBtZXRo b2QgZm9yIHJlcXVlc3RpbmcKKyAgICAgICAgd2hhdCB0eXBlcyBvZiBjaGFuZ2VzIHRoZXkncmUg aW50ZXJlc3RlZCBpbiAoYWRkcywgbW9kaWZpZXMsIGRlbGV0ZXMsIGV0Yy4pCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGkucHk6CisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvYXBpX3VuaXR0ZXN0LnB5OgorCisyMDExLTAx LTEzICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBi eSBNaWhhaSBQYXJwYXJpdGEuCiAKICAgICAgICAgd2Via2l0LXBhdGNoIHN1Z2dlc3QtcmV2aWV3 ZXJzIGZhaWxzIGR1ZSB0byBpbnZhbGlkIHV0ZjggaW4gQ2hhbmdlTG9nIGZpbGVzCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGkucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGkucHkKaW5kZXggYWI5M2MwYmE3 MmQ1MTQ5NDYzZjI3NDdhNDQ1NDdhN2QwY2E0NGRmMy4uYTg3YmI1YTUyOGE4ZWU3ZTlhODM5YWY5 NzEwNmQxYWU4MDY0NTQyMSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vY2hlY2tvdXQvYXBpLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2No ZWNrb3V0L2FwaS5weQpAQCAtNjIsNyArNjIsMTcgQEAgY2xhc3MgQ2hlY2tvdXQob2JqZWN0KToK ICAgICAgICAgY2hhbmdlZF9maWxlcyA9IHNlbGYuX3NjbS5jaGFuZ2VkX2ZpbGVzX2Zvcl9yZXZp c2lvbihyZXZpc2lvbikKICAgICAgICAgIyBGSVhNRTogVGhpcyBnZXRzIGNvbmZ1c2VkIGlmIENo YW5nZUxvZyBmaWxlcyBhcmUgbW92ZWQsIGFzCiAgICAgICAgICMgZGVsZXRlcyBhcmUgc3RpbGwg ImNoYW5nZWQgZmlsZXMiIHBlciBjaGFuZ2VkX2ZpbGVzX2Zvcl9yZXZpc2lvbi4KLSAgICAgICAg cmV0dXJuIFtzZWxmLl9sYXRlc3RfZW50cnlfZm9yX2NoYW5nZWxvZ19hdF9yZXZpc2lvbihwYXRo LCByZXZpc2lvbikgZm9yIHBhdGggaW4gY2hhbmdlZF9maWxlcyBpZiBzZWxmLmlzX3BhdGhfdG9f Y2hhbmdlbG9nKHBhdGgpXQorICAgICAgICAjIEZJWE1FOiBGb3Igbm93IHdlIGhhY2sgYXJvdW5k IHRoaXMgYnkgY2FjaGluZyBhbnkgZXhjZXB0aW9ucworICAgICAgICAjIHdoaWNoIHJlc3VsdCBm cm9tIGhhdmluZyBkZWxldGVkIGZpbGVzIGluY2x1ZGVkIHRoZSBjaGFuZ2VkX2ZpbGVzIGxpc3Qu CisgICAgICAgIGNoYW5nZWxvZ19lbnRyaWVzID0gW10KKyAgICAgICAgZm9yIHBhdGggaW4gY2hh bmdlZF9maWxlczoKKyAgICAgICAgICAgIGlmIG5vdCBzZWxmLmlzX3BhdGhfdG9fY2hhbmdlbG9n KHBhdGgpOgorICAgICAgICAgICAgICAgIGNvbnRpbnVlCisgICAgICAgICAgICB0cnk6CisgICAg ICAgICAgICAgICAgY2hhbmdlbG9nX2VudHJpZXMuYXBwZW5kKHNlbGYuX2xhdGVzdF9lbnRyeV9m b3JfY2hhbmdlbG9nX2F0X3JldmlzaW9uKHBhdGgsIHJldmlzaW9uKSkKKyAgICAgICAgICAgIGV4 Y2VwdCBTY3JpcHRFcnJvcjoKKyAgICAgICAgICAgICAgICBwYXNzCisgICAgICAgIHJldHVybiBj aGFuZ2Vsb2dfZW50cmllcwogCiAgICAgQG1lbW9pemVkCiAgICAgZGVmIGNvbW1pdF9pbmZvX2Zv cl9yZXZpc2lvbihzZWxmLCByZXZpc2lvbik6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGlfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGlfdW5pdHRlc3QucHkKaW5kZXggNmRjZWM2MTg5Yzk3 MzQ3ZTkxNDliYzk5YmYxZmE2Y2E4NDEzMzY3ZC4uNjI3NTA4MjQxZTQ2M2E5ODBjNjA3NWE4ZGZh NmZlZWEzMjg3YmU3MCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y2hlY2tvdXQvYXBpX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL2NoZWNrb3V0L2FwaV91bml0dGVzdC5weQpAQCAtMzgsNiArMzgsNyBAQCBmcm9tIHdlYmtp dHB5LmNvbW1vbi5jaGVja291dC5hcGkgaW1wb3J0IENoZWNrb3V0CiBmcm9tIHdlYmtpdHB5LmNv bW1vbi5jaGVja291dC5jaGFuZ2Vsb2cgaW1wb3J0IENoYW5nZUxvZ0VudHJ5CiBmcm9tIHdlYmtp dHB5LmNvbW1vbi5jaGVja291dC5zY20gaW1wb3J0IGRldGVjdF9zY21fc3lzdGVtLCBDb21taXRN ZXNzYWdlCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0ub3V0cHV0Y2FwdHVyZSBpbXBvcnQg T3V0cHV0Q2FwdHVyZQorZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmV4ZWN1dGl2ZSBpbXBv cnQgU2NyaXB0RXJyb3IKIGZyb20gd2Via2l0cHkudGhpcmRwYXJ0eS5tb2NrIGltcG9ydCBNb2Nr CiAKIApAQCAtMTM4LDYgKzEzOSwyNyBAQCBjbGFzcyBDaGVja291dFRlc3QodW5pdHRlc3QuVGVz dENhc2UpOgogICAgICAgICBlbnRyeSA9IGNoZWNrb3V0Ll9sYXRlc3RfZW50cnlfZm9yX2NoYW5n ZWxvZ19hdF9yZXZpc2lvbigiZm9vIiwgImJhciIpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwo ZW50cnkuY29udGVudHMoKSwgX2NoYW5nZWxvZzFlbnRyeTEpCiAKKyAgICAjIEZJWE1FOiBUaGlz IHRlc3RzIGEgaGFjayBhcm91bmQgb3VyIGN1cnJlbnQgY2hhbmdlZF9maWxlcyBoYW5kbGluZy4K KyAgICAjIFJpZ2h0IG5vdyBjaGFuZ2Vsb2dfZW50cmllc19mb3JfcmV2aXNpb24gdHJpZXMgdG8g ZmV0Y2ggZGVsZXRlZCBmaWxlcworICAgICMgZnJvbSByZXZpc2lvbnMsIHJlc3VsdGluZyBpbiBh IFNjcmlwdEVycm9yIGV4Y2VwdGlvbi4gIFRlc3QgdGhhdCB3ZQorICAgICMgcmVjb3ZlciBmcm9t IHRob3NlIGFuZCBzdGlsbCByZXR1cm4gdGhlIG90aGVyIENoYW5nZUxvZyBlbnRyaWVzLgorICAg IGRlZiB0ZXN0X2NoYW5nZWxvZ19lbnRyaWVzX2Zvcl9yZXZpc2lvbihzZWxmKToKKyAgICAgICAg c2NtID0gTW9jaygpCisgICAgICAgIHNjbS5jaGFuZ2VkX2ZpbGVzX2Zvcl9yZXZpc2lvbiA9IGxh bWJkYSByZXZpc2lvbjogWydmb28vQ2hhbmdlTG9nJywgJ2Jhci9DaGFuZ2VMb2cnXQorICAgICAg ICBjaGVja291dCA9IENoZWNrb3V0KHNjbSkKKworICAgICAgICBkZWYgbW9ja19sYXRlc3RfZW50 cnlfZm9yX2NoYW5nZWxvZ19hdF9yZXZpc2lvbihwYXRoLCByZXZpc2lvbik6CisgICAgICAgICAg ICBpZiBwYXRoID09ICJmb28vQ2hhbmdlTG9nIjoKKyAgICAgICAgICAgICAgICByZXR1cm4gJ2Zv bycKKyAgICAgICAgICAgIHJhaXNlIFNjcmlwdEVycm9yKCkKKworICAgICAgICBjaGVja291dC5f bGF0ZXN0X2VudHJ5X2Zvcl9jaGFuZ2Vsb2dfYXRfcmV2aXNpb24gPSBtb2NrX2xhdGVzdF9lbnRy eV9mb3JfY2hhbmdlbG9nX2F0X3JldmlzaW9uCisKKyAgICAgICAgIyBFdmVuIHRob3VnaCBmZXRj aGluZyBvbmUgb2YgdGhlIGVudHJpZXMgZmFpbGVkLCB0aGUgb3RoZXIgc2hvdWxkIHN1Y2NlZWQu CisgICAgICAgIGVudHJpZXMgPSBjaGVja291dC5jaGFuZ2Vsb2dfZW50cmllc19mb3JfcmV2aXNp b24oMSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChsZW4oZW50cmllcyksIDEpCisgICAgICAg IHNlbGYuYXNzZXJ0RXF1YWwoZW50cmllc1swXSwgJ2ZvbycpCisKICAgICBkZWYgdGVzdF9jb21t aXRfaW5mb19mb3JfcmV2aXNpb24oc2VsZik6CiAgICAgICAgIHNjbSA9IE1vY2soKQogICAgICAg ICBzY20uY29tbWl0dGVyX2VtYWlsX2Zvcl9yZXZpc2lvbiA9IGxhbWJkYSByZXZpc2lvbjogImNv bW1pdHRlckBleGFtcGxlLmNvbSIK