49152 2010-11-07 18:38:24 -0800 Assert that a non-null PassRefPtr<Document> has a non-null frame in Frame::setDocument() 2010-11-07 20:32:39 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates abarth ap commit-queue oldest_to_newest 305921 0 dbates 2010-11-07 18:38:24 -0800 We should assert that a non-null Document object has a non-null frame (i.e. that Document::frame() is not null) in Frame::setDocument(). 305922 1 73201 dbates 2010-11-07 18:48:18 -0800 Created attachment 73201 Patch This change does not cause any DRT regressions on my Mac. As far as I can tell from looking at the callers of Frame::setDocument() and the Document creation process, it doesn't make sense for Frame::setDocument() to be passed a non-null PassRefPtr<Document> whose Document has a null frame (i.e. Document::frame() == 0). 305923 2 73202 dbates 2010-11-07 18:49:56 -0800 Created attachment 73202 Patch Updated title of bug in change log. 305927 3 73202 abarth 2010-11-07 19:08:39 -0800 Comment on attachment 73202 Patch Thanks. 305958 4 73202 dbates 2010-11-07 20:18:16 -0800 Comment on attachment 73202 Patch Will land by hand. 305960 5 dbates 2010-11-07 20:32:39 -0800 Committed r71493: <http://trac.webkit.org/changeset/71493> 73201 2010-11-07 18:48:18 -0800 2010-11-07 18:49:56 -0800 Patch Bug49152.patch text/plain 1351 dbates SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTQ4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMTEtMDcgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzc2Vy dCB0aGF0IGEgbm9uLW51bGwgRG9jdW1lbnQgaGFzIGEgbm9uLW51bGwgZnJhbWUgaW4gRnJhbWU6 OnNldERvY3VtZW50KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ5MTUyCisKKyAgICAgICAgQWRkIGFuIEFTU0VSVCB0byBlbnN1cmUgdGhhdCBhIG5v bi1udWxsIERvY3VtZW50IGhhcyBhIG5vbi1udWxsIEZyYW1lCisgICAgICAgIGluIEZyYW1lOjpz ZXREb2N1bWVudCgpLgorCisgICAgICAgIEN1cnJlbnRseSwgd2hlbmV2ZXIgRnJhbWU6OnNldERv Y3VtZW50KCkgaXMgY2FsbGVkIHdpdGggYSBub24tbnVsbAorICAgICAgICBEb2N1bWVudCB0aGUg RG9jdW1lbnQgaGFzIGEgbm9uLW51bGwgRnJhbWUuIFdlIHNob3VsZCBhc3NlcnQgdGhpcworICAg ICAgICBpbnZhcmlhbnQuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lOjpzZXREb2N1bWVudCk6CisKIDIwMTAtMTEtMDcgIEpvaG4gUmVjayAgPGpy ZWNrQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3RldmUgQmxvY2suCkluZGV4 OiBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9GcmFt ZS5jcHAJKHJldmlzaW9uIDcxNDg0KQorKysgV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjc2LDYgKzI3Niw3IEBAIHZvaWQgRnJhbWU6OnNldFZpZXcoUGFzc1JlZlB0 cjxGcmFtZVZpZXcKIAogdm9pZCBGcmFtZTo6c2V0RG9jdW1lbnQoUGFzc1JlZlB0cjxEb2N1bWVu dD4gbmV3RG9jKQogeworICAgIEFTU0VSVCghbmV3RG9jIHx8IG5ld0RvYy0+ZnJhbWUoKSk7CiAg ICAgaWYgKG1fZG9jICYmIG1fZG9jLT5hdHRhY2hlZCgpICYmICFtX2RvYy0+aW5QYWdlQ2FjaGUo KSkgewogICAgICAgICAvLyBGSVhNRTogV2UgZG9uJ3QgY2FsbCB3aWxsUmVtb3ZlIGhlcmUuIFdo eSBpcyB0aGF0IE9LPwogICAgICAgICBtX2RvYy0+ZGV0YWNoKCk7Cg== 73202 2010-11-07 18:49:56 -0800 2010-11-07 20:18:16 -0800 Patch Bug49152.patch text/plain 1363 dbates SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTQ4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMTEtMDcgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzc2Vy dCB0aGF0IGEgbm9uLW51bGwgUGFzc1JlZlB0cjxEb2N1bWVudD4gaGFzIGEgbm9uLW51bGwgZnJh bWUgaW4gRnJhbWU6OnNldERvY3VtZW50KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ5MTUyCisKKyAgICAgICAgQWRkIGFuIEFTU0VSVCB0byBlbnN1 cmUgdGhhdCBhIG5vbi1udWxsIERvY3VtZW50IGhhcyBhIG5vbi1udWxsIEZyYW1lCisgICAgICAg IGluIEZyYW1lOjpzZXREb2N1bWVudCgpLgorCisgICAgICAgIEN1cnJlbnRseSwgd2hlbmV2ZXIg RnJhbWU6OnNldERvY3VtZW50KCkgaXMgY2FsbGVkIHdpdGggYSBub24tbnVsbAorICAgICAgICBE b2N1bWVudCB0aGUgRG9jdW1lbnQgaGFzIGEgbm9uLW51bGwgRnJhbWUuIFdlIHNob3VsZCBhc3Nl cnQgdGhpcworICAgICAgICBpbnZhcmlhbnQuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjpzZXREb2N1bWVudCk6CisKIDIwMTAtMTEtMDcgIEpv aG4gUmVjayAgPGpyZWNrQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3RldmUg QmxvY2suCkluZGV4OiBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGFnZS9GcmFtZS5jcHAJKHJldmlzaW9uIDcxNDg0KQorKysgV2ViQ29yZS9wYWdlL0ZyYW1l LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjc2LDYgKzI3Niw3IEBAIHZvaWQgRnJhbWU6OnNldFZp ZXcoUGFzc1JlZlB0cjxGcmFtZVZpZXcKIAogdm9pZCBGcmFtZTo6c2V0RG9jdW1lbnQoUGFzc1Jl ZlB0cjxEb2N1bWVudD4gbmV3RG9jKQogeworICAgIEFTU0VSVCghbmV3RG9jIHx8IG5ld0RvYy0+ ZnJhbWUoKSk7CiAgICAgaWYgKG1fZG9jICYmIG1fZG9jLT5hdHRhY2hlZCgpICYmICFtX2RvYy0+ aW5QYWdlQ2FjaGUoKSkgewogICAgICAgICAvLyBGSVhNRTogV2UgZG9uJ3QgY2FsbCB3aWxsUmVt b3ZlIGhlcmUuIFdoeSBpcyB0aGF0IE9LPwogICAgICAgICBtX2RvYy0+ZGV0YWNoKCk7Cg==