49150 2010-11-07 17:53:22 -0800 [GTK] LayoutTests/fast/events/spatial-navigation/snav-single-select.html fails on GTK 2010-11-08 21:24:19 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 47094 1 cshu cshu commit-queue mrobinson tonikitoo oldest_to_newest 305916 0 cshu 2010-11-07 17:53:22 -0800 The above test works on Qt but fails on GTK. It also hangs on Mac but skipped. Most likely it's because of the different implementations of select box on different platforms. 306117 1 cshu 2010-11-08 07:38:12 -0800 *** Bug 49176 has been marked as a duplicate of this bug. *** 306118 2 tonikitoo 2010-11-08 07:39:44 -0800 If a solution is not coming shortly, please skip it and unskip with the real patch. 306119 3 cshu 2010-11-08 07:42:39 -0800 (In reply to comment #2) > If a solution is not coming shortly, please skip it and unskip with the real patch. sure, I will see if I can get it done by end of today. 306259 4 73259 cshu 2010-11-08 11:53:26 -0800 Created attachment 73259 fix patch This could fix Mac, too. I will update the patch if this is the case. 306269 5 tonikitoo 2010-11-08 12:04:27 -0800 It looks nice. Could you please unskip the test in GTK+? 306289 6 73267 cshu 2010-11-08 12:32:55 -0800 Created attachment 73267 fix patch 2 306601 7 73267 commit-queue 2010-11-08 21:24:13 -0800 Comment on attachment 73267 fix patch 2 Clearing flags on attachment: 73267 Committed r71605: <http://trac.webkit.org/changeset/71605> 306602 8 commit-queue 2010-11-08 21:24:19 -0800 All reviewed patches have been landed. Closing bug. 73259 2010-11-08 11:53:26 -0800 2010-11-08 12:32:55 -0800 fix patch 49150_1.patch text/plain 2197 cshu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTU0OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTEtMDggIENoYW5nIFNodSAgPGNoYW5nLnNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNl IFNwYWNlIHRvIHRvZ2dsZSBhcnJvdyBrZXkgaGFuZGxpbmcgZm9yIHNlbGVjdGlvbiBjaGFuZ2Ug b3IKKyAgICAgICAgc3BhdGlhbCBuYXZpZ2F0aW9uLiBQdXQgdGhlIGxvZ2ljIGluIGNvbW1vbiBj b2RlIGZvciBhbGwgcGxhdGZvcm1zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDkxNTAKKworICAgICAgICBFeGlzdGluZyB0ZXN0OiBmYXN0L2V2ZW50 cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1zaW5nbGUtc2VsZWN0Lmh0bWwKKworICAgICAgICAq IGRvbS9TZWxlY3RFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdEVsZW1lbnQ6 Om1lbnVMaXN0RGVmYXVsdEV2ZW50SGFuZGxlcik6CisKIDIwMTAtMTEtMDggIERhcmluIEFkbGVy ICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3Vy eWFrb3YuCkluZGV4OiBXZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50LmNwcAkocmV2aXNpb24gNzE1NDApCisrKyBXZWJD b3JlL2RvbS9TZWxlY3RFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjA1LDYgKzYwNSwx MyBAQCB2b2lkIFNlbGVjdEVsZW1lbnQ6Om1lbnVMaXN0RGVmYXVsdEV2ZW50CiAgICAgICAgIGlu dCBrZXlDb2RlID0gc3RhdGljX2Nhc3Q8S2V5Ym9hcmRFdmVudCo+KGV2ZW50KS0+a2V5Q29kZSgp OwogICAgICAgICBib29sIGhhbmRsZWQgPSBmYWxzZTsKIAorICAgICAgICBpZiAoa2V5Q29kZSA9 PSAnICcgJiYgaXNTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQoZWxlbWVudC0+ZG9jdW1lbnQoKS0+ ZnJhbWUoKSkpIHsKKyAgICAgICAgICAgIC8vIFVzZSBzcGFjZSB0byB0b2dnbGUgYXJyb3cga2V5 IGhhbmRsaW5nIGZvciBzZWxlY3Rpb24gY2hhbmdlIG9yIHNwYXRpYWwgbmF2aWdhdGlvbi4KKyAg ICAgICAgICAgIGRhdGEuc2V0QWN0aXZlU2VsZWN0aW9uU3RhdGUoIWRhdGEuYWN0aXZlU2VsZWN0 aW9uU3RhdGUoKSk7CisgICAgICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKKyAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCiAjaWYgU1BBQ0VfT1JfUkVUVVJOX1BPUF9N RU5VCiAgICAgICAgIGlmIChrZXlDb2RlID09ICcgJyB8fCBrZXlDb2RlID09ICdccicpIHsKICAg ICAgICAgICAgIGVsZW1lbnQtPmZvY3VzKCk7CkBAIC02NDQsMTAgKzY1MSw2IEBAIHZvaWQgU2Vs ZWN0RWxlbWVudDo6bWVudUxpc3REZWZhdWx0RXZlbnQKICAgICAgICAgICAgIC8vIGxpc3RJbmRl eCBzaG91bGQgYWxyZWFkeSBiZSBzZWxlY3RlZCwgYnV0IHRoaXMgd2lsbCBmaXJlIHRoZSBvbmNo YW5nZSBoYW5kbGVyLgogICAgICAgICAgICAgc2V0U2VsZWN0ZWRJbmRleChkYXRhLCBlbGVtZW50 LCBsaXN0VG9PcHRpb25JbmRleChkYXRhLCBlbGVtZW50LCBsaXN0SW5kZXgpLCB0cnVlLCB0cnVl KTsKICAgICAgICAgICAgIGhhbmRsZWQgPSB0cnVlOwotICAgICAgICB9IGVsc2UgaWYgKGtleUNv ZGUgPT0gJyAnICYmIGlzU3BhdGlhbE5hdmlnYXRpb25FbmFibGVkKGVsZW1lbnQtPmRvY3VtZW50 KCktPmZyYW1lKCkpKSB7Ci0gICAgICAgICAgICAvLyBVc2Ugc3BhY2UgdG8gdHJpZ2dlciBhcnJv dyBrZXkgaGFuZGxpbmcgZm9yIHNlbGVjdGlvbiBjaGFuZ2Ugb3Igc3BhdGlhbCBuYXZpZ2F0aW9u LgotICAgICAgICAgICAgZGF0YS5zZXRBY3RpdmVTZWxlY3Rpb25TdGF0ZSghZGF0YS5hY3RpdmVT ZWxlY3Rpb25TdGF0ZSgpKTsKLSAgICAgICAgICAgIGhhbmRsZWQgPSB0cnVlOwogICAgICAgICB9 CiAjZW5kaWYKICAgICAgICAgaWYgKGhhbmRsZWQpCg== 73267 2010-11-08 12:32:55 -0800 2010-11-08 21:24:13 -0800 fix patch 2 49150_2.patch text/plain 3335 cshu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTU1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMTEtMDggIENoYW5nIFNodSAgPGNoYW5nLnNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dU S10gVXNlIFNwYWNlIHRvIHRvZ2dsZSBhcnJvdyBrZXkgaGFuZGxpbmcgZm9yIHNlbGVjdGlvbiBj aGFuZ2Ugb3IKKyAgICAgICAgc3BhdGlhbCBuYXZpZ2F0aW9uLiBQdXQgdGhlIGxvZ2ljIGluIGNv bW1vbiBjb2RlIHRvIHBhc3MgYm90aCBRdCBhbmQKKyAgICAgICAgR1RLLiBNYWMgd29uJ3Qgd29y ayBiZWNhdXNlIGFycm93IGtleXMgdHJpZ2dlciB0aGUgcG9wdXAuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTE1MAorCisgICAgICAgIEV4aXN0aW5n IHRlc3Q6IGZhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LXNpbmdsZS1zZWxlY3Qu aHRtbAorCisgICAgICAgICogZG9tL1NlbGVjdEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U2VsZWN0RWxlbWVudDo6bWVudUxpc3REZWZhdWx0RXZlbnRIYW5kbGVyKToKKwogMjAxMC0x MS0wOCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvZG9tL1NlbGVjdEVsZW1lbnQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1NlbGVjdEVsZW1lbnQuY3BwCShyZXZpc2lvbiA3MTU0 MCkKKysrIFdlYkNvcmUvZG9tL1NlbGVjdEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02 MDUsNiArNjA1LDEzIEBAIHZvaWQgU2VsZWN0RWxlbWVudDo6bWVudUxpc3REZWZhdWx0RXZlbnQK ICAgICAgICAgaW50IGtleUNvZGUgPSBzdGF0aWNfY2FzdDxLZXlib2FyZEV2ZW50Kj4oZXZlbnQp LT5rZXlDb2RlKCk7CiAgICAgICAgIGJvb2wgaGFuZGxlZCA9IGZhbHNlOwogCisgICAgICAgIGlm IChrZXlDb2RlID09ICcgJyAmJiBpc1NwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZChlbGVtZW50LT5k b2N1bWVudCgpLT5mcmFtZSgpKSkgeworICAgICAgICAgICAgLy8gVXNlIHNwYWNlIHRvIHRvZ2ds ZSBhcnJvdyBrZXkgaGFuZGxpbmcgZm9yIHNlbGVjdGlvbiBjaGFuZ2Ugb3Igc3BhdGlhbCBuYXZp Z2F0aW9uLgorICAgICAgICAgICAgZGF0YS5zZXRBY3RpdmVTZWxlY3Rpb25TdGF0ZSghZGF0YS5h Y3RpdmVTZWxlY3Rpb25TdGF0ZSgpKTsKKyAgICAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFu ZGxlZCgpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKICNpZiBTUEFDRV9PUl9S RVRVUk5fUE9QX01FTlUKICAgICAgICAgaWYgKGtleUNvZGUgPT0gJyAnIHx8IGtleUNvZGUgPT0g J1xyJykgewogICAgICAgICAgICAgZWxlbWVudC0+Zm9jdXMoKTsKQEAgLTY0NCwxMCArNjUxLDYg QEAgdm9pZCBTZWxlY3RFbGVtZW50OjptZW51TGlzdERlZmF1bHRFdmVudAogICAgICAgICAgICAg Ly8gbGlzdEluZGV4IHNob3VsZCBhbHJlYWR5IGJlIHNlbGVjdGVkLCBidXQgdGhpcyB3aWxsIGZp cmUgdGhlIG9uY2hhbmdlIGhhbmRsZXIuCiAgICAgICAgICAgICBzZXRTZWxlY3RlZEluZGV4KGRh dGEsIGVsZW1lbnQsIGxpc3RUb09wdGlvbkluZGV4KGRhdGEsIGVsZW1lbnQsIGxpc3RJbmRleCks IHRydWUsIHRydWUpOwogICAgICAgICAgICAgaGFuZGxlZCA9IHRydWU7Ci0gICAgICAgIH0gZWxz ZSBpZiAoa2V5Q29kZSA9PSAnICcgJiYgaXNTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQoZWxlbWVu dC0+ZG9jdW1lbnQoKS0+ZnJhbWUoKSkpIHsKLSAgICAgICAgICAgIC8vIFVzZSBzcGFjZSB0byB0 cmlnZ2VyIGFycm93IGtleSBoYW5kbGluZyBmb3Igc2VsZWN0aW9uIGNoYW5nZSBvciBzcGF0aWFs IG5hdmlnYXRpb24uCi0gICAgICAgICAgICBkYXRhLnNldEFjdGl2ZVNlbGVjdGlvblN0YXRlKCFk YXRhLmFjdGl2ZVNlbGVjdGlvblN0YXRlKCkpOwotICAgICAgICAgICAgaGFuZGxlZCA9IHRydWU7 CiAgICAgICAgIH0KICNlbmRpZgogICAgICAgICBpZiAoaGFuZGxlZCkKSW5kZXg6IExheW91dFRl c3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlz aW9uIDcxNTU2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTAtMTEtMDggIENoYW5nIFNodSAgPGNoYW5nLnNodUBub2tpYS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5za2lw IHRlc3QgdGhhdCBpcyBwYXNzaW5nIG5vdy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ5MTUwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2tpcHBl ZDoKKwogMjAxMC0xMS0wOCAgRHVtaXRydSBEYW5pbGl1YyAgPGR1bWlAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHVwZGF0aW5nIENocm9taXVtIGV4cGVjdGF0aW9ucy4KSW5k ZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCShyZXZpc2lvbiA3MTU0MCkKKysrIExheW91dFRl c3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC01NjgwLDkgKzU2ODAs NiBAQCBtYXRobWwvcHJlc2VudGF0aW9uCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00OTA1MgogZmFzdC9jYW52YXMvcG9pbnRJblBhdGguaHRtbAogCi0jIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTE3NgotZmFzdC9ldmVudHMvc3Bh dGlhbC1uYXZpZ2F0aW9uL3NuYXYtc2luZ2xlLXNlbGVjdC5odG1sCi0KICMgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MTc3CiBmYXN0L2V2ZW50cy9zY3JvbGwtYWZ0 ZXItY2xpY2stb24tdGFiLWluZGV4Lmh0bWwKIAo=