49148 2010-11-07 15:25:38 -0800 [GTK] Error page templates are not filled properly 2010-11-08 08:48:26 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned oldest_to_newest 305898 0 mrobinson 2010-11-07 15:25:38 -0800 A recent switch from String::format to makeString r69850, mistakenly broke some legitmate formatting behavior. This patch tracking switching back to String::format. 305905 1 73200 mrobinson 2010-11-07 15:37:44 -0800 Created attachment 73200 Fix for this issue 305911 2 73200 kling 2010-11-07 17:01:21 -0800 Comment on attachment 73200 Fix for this issue LGTM. 306138 3 73200 mrobinson 2010-11-08 08:48:20 -0800 Comment on attachment 73200 Fix for this issue Clearing flags on attachment: 73200 Committed r71529: <http://trac.webkit.org/changeset/71529> 306139 4 mrobinson 2010-11-08 08:48:26 -0800 All reviewed patches have been landed. Closing bug. 73200 2010-11-07 15:37:44 -0800 2010-11-08 08:48:20 -0800 Fix for this issue bug-49148-20101107183743.patch text/plain 1648 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggMmQ0OWQ2NDhjNWYyYjc2Y2M0NDc5ZTE1YjY4ZDA4YmI2NzBlZmJiYS4uYjQ5NTU5NWE3 MjY2ZmVkYjU4OTMxYTM4OWZlN2YwOTZkMjdhNDZjYiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAx MC0xMS0wNyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRXJyb3IgcGFn ZSB0ZW1wbGF0ZXMgYXJlIG5vdCBmaWxsZWQgcHJvcGVybHkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MTQ4CisKKyAgICAgICAgUmVwbGFjZSBhIGNh bGwgdG8gbWFrZVN0cmluZyB3aXRoIFN0cmluZzo6Zm9ybWF0LiBUaGlzIHdhcyBtaXN0YWtlbmx5 CisgICAgICAgIGNoYW5nZWQgdG8gbWFrZVN0cmluZyBpbiBhbiBlYXJsaWVyIGNvbW1pdC4KKwor ICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6RnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkRmFpbExvYWQpOgorCiAy MDEwLTExLTA1ICBOaWNvbGFzIER1ZnJlc25lICA8bmljb2xhcy5kdWZyZXNuZUBjb2xsYWJvcmEu Y28udWs+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAgYi9X ZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcAppbmRleCBi YzJiNWQ5NGE3ZTFmZDlkMWExYTMxZDQ3MWExZGZiNmFkOTIwZDQyLi5iMjNiZDcwYzdiNzQyYTFl ZmQ5NjAyYTlkYjhiNzM0NDJiYjliMWZlIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dlYkNvcmVT dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVT dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcApAQCAtMTEzOSw3ICsxMTM5LDcgQEAgdm9p ZCBGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEaWRGYWlsTG9hZChjb25zdCBSZXNvdXJjZUVy cm9yJiBlcnJvcikKICAgICAgICAgaWYgKCFsb2FkZWQpCiAgICAgICAgICAgICBjb250ZW50ID0g bWFrZVN0cmluZygiPGh0bWw+PGJvZHk+Iiwgd2ViRXJyb3ItPm1lc3NhZ2UsICI8L2JvZHk+PC9o dG1sPiIpOwogICAgICAgICBlbHNlCi0gICAgICAgICAgICBjb250ZW50ID0gbWFrZVN0cmluZyhm aWxlQ29udGVudCwgZXJyb3IuZmFpbGluZ1VSTCgpLCB3ZWJFcnJvci0+bWVzc2FnZSk7CisgICAg ICAgICAgICBjb250ZW50ID0gU3RyaW5nOjpmb3JtYXQoZmlsZUNvbnRlbnQsIGVycm9yLmZhaWxp bmdVUkwoKS51dGY4KCkuZGF0YSgpLCB3ZWJFcnJvci0+bWVzc2FnZSk7CiAgICAgfQogCiAgICAg d2Via2l0X3dlYl9mcmFtZV9sb2FkX2FsdGVybmF0ZV9zdHJpbmcobV9mcmFtZSwgY29udGVudC51 dGY4KCkuZGF0YSgpLCAwLCBlcnJvci5mYWlsaW5nVVJMKCkudXRmOCgpLmRhdGEoKSk7Cg==