49129 2010-11-06 12:26:14 -0700 [Qt][WK2] WebKitTestRunner is dead 2010-11-09 04:54:01 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 kbalazs webkit-unassigned oldest_to_newest 305803 0 kbalazs 2010-11-06 12:26:14 -0700 Poor WTR is always crashing on termination. This is a regression since r71409. The killer is me. In r71409 I haved connected the QSharedMemory object's deleteLater slot to QCoreApplication::aboutToQuit to force deletion when the SharedMemory is leaking on termination. The unsafeness of this approach is appearing when the SharedMemory's dtor is called after aboutToQuit had been emitted. In that case we are trying to delete an already deleted object and ending up in a crash. This is the situation in WTR when the UI process is terminating. (Ok, it is not really a UI process). 305815 1 73177 kbalazs 2010-11-06 14:49:11 -0700 Created attachment 73177 Patch 305816 2 kbalazs 2010-11-06 14:50:41 -0700 No crashes in run-webkit-tests. 305829 3 73177 kbalazs 2010-11-06 18:23:50 -0700 Comment on attachment 73177 Patch Clearing flags on attachment: 73177 Committed r71471: <http://trac.webkit.org/changeset/71471> 305830 4 kbalazs 2010-11-06 18:23:58 -0700 All reviewed patches have been landed. Closing bug. 305831 5 kbalazs 2010-11-06 18:24:46 -0700 Thanks for the nightly review! :) 306695 6 kbalazs 2010-11-09 04:20:32 -0800 The ASSERT need to be moved in the if as well... Crashing in fast/frames/iframe-reparenting-new-page.html 306704 7 73357 kbalazs 2010-11-09 04:32:13 -0800 Created attachment 73357 Patch 306708 8 73357 kling 2010-11-09 04:39:06 -0800 Comment on attachment 73357 Patch D'oh, r=me 306714 9 73357 kbalazs 2010-11-09 04:53:52 -0800 Comment on attachment 73357 Patch Clearing flags on attachment: 73357 Committed r71624: <http://trac.webkit.org/changeset/71624> 306715 10 kbalazs 2010-11-09 04:54:01 -0800 All reviewed patches have been landed. Closing bug. 73177 2010-11-06 14:49:11 -0700 2010-11-09 04:32:07 -0800 Patch bug-49129-20101106224909.patch text/plain 1399 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MTE5YWRhZTNmMjYwN2MxNDhiN2VlOWYyNjViN2RiNjI4MTc3YjFmNC4uZjQ5MjA2YTZlZDJhNWU3 YWZiOGVmZGI0NTRlZTgxZWJmZGM5YmMyNiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMS0wNiAgQmFs YXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XVtXSzJdIFdlYktpdFRlc3RSdW5uZXIgaXMg ZGVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkx MjkKKworICAgICAgICAqIFBsYXRmb3JtL3F0L1NoYXJlZE1lbW9yeVF0LmNwcDoKKyAgICAgICAg KFdlYktpdDo6U2hhcmVkTWVtb3J5Ojp+U2hhcmVkTWVtb3J5KToKKyAgICAgICAgQXZvaWQgZG91 YmxlIGRlbGV0aW9uIHdoZW4gZGVsZXRlTGF0ZXIgaGFzCisgICAgICAgIGFscmVhZHkgYmVlbiBj YWxsZWQuCisKIDIwMTAtMTEtMDUgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KZGlmZiAtLWdpdCBhL1dlYktpdDIv UGxhdGZvcm0vcXQvU2hhcmVkTWVtb3J5UXQuY3BwIGIvV2ViS2l0Mi9QbGF0Zm9ybS9xdC9TaGFy ZWRNZW1vcnlRdC5jcHAKaW5kZXggMTNlYTRiZWE5OWRhZjU0MzE2NTMzYTZkMTJlZDYyMzZhMzkz ZTM1OC4uNTM3ZDQzY2U3ZDgyMGNjYmNmMDYyMDYzOGJlNmY0ZDAwYWI0MmFmOSAxMDA2NDQKLS0t IGEvV2ViS2l0Mi9QbGF0Zm9ybS9xdC9TaGFyZWRNZW1vcnlRdC5jcHAKKysrIGIvV2ViS2l0Mi9Q bGF0Zm9ybS9xdC9TaGFyZWRNZW1vcnlRdC5jcHAKQEAgLTE0Nyw3ICsxNDcsMTEgQEAgU2hhcmVk TWVtb3J5Ojp+U2hhcmVkTWVtb3J5KCkKIHsKICAgICAvLyBtX2ltcGwgbXVzdCBiZSBub24tbnVs bCBhbmQgaXQgbXVzdCBwb2ludCB0byBhIHZhbGlkIFFTaGFyZWRNZW1vcnkgb2JqZWN0LgogICAg IEFTU0VSVChxb2JqZWN0X2Nhc3Q8UVNoYXJlZE1lbW9yeSo+KG1faW1wbCkpOwotICAgIGRlbGV0 ZSBtX2ltcGw7CisKKyAgICAvLyBBdm9pZCBkb3VibGUgZGVsZXRpb24gd2hlbiBkZWxldGVMYXRl ciBoYXMgYWxyZWFkeSBiZWVuIGNhbGxlZCB0aHJvdWdoIHRoZSBzaWduYWwtc2xvdCBjb25uZWN0 aW9uLgorICAgIGlmIChRQ29yZUFwcGxpY2F0aW9uOjppbnN0YW5jZSgpLT5kaXNjb25uZWN0KG1f aW1wbCkpCisgICAgICAgIGRlbGV0ZSBtX2ltcGw7CisKICAgICBDcmFzaEhhbmRsZXI6Omluc3Rh bmNlKCktPmRpZERlbGV0ZShtX2ltcGwpOwogfQogCg== 73357 2010-11-09 04:32:13 -0800 2010-11-09 04:53:52 -0800 Patch bug-49129-20101109133211.patch text/plain 1715 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZWEyMjU1MjM1NmMyZGNlNTAyNmMwNTJlODhiYjhmNDI5MmQ2MGU5MS4uZmVhYmQwMmY0NGYyZTJk ZGI0MDRhZDBjYWNiOTZmMGJmYTk5YzYzNyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMS0wOSAgQmFs YXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XVtXSzJdIFdlYktpdFRlc3RSdW5uZXIgaXMg ZGVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkx MjkKKworICAgICAgICAqIFBsYXRmb3JtL3F0L1NoYXJlZE1lbW9yeVF0LmNwcDoKKyAgICAgICAg KFdlYktpdDo6U2hhcmVkTWVtb3J5Ojp+U2hhcmVkTWVtb3J5KToKKyAgICAgICAgRm9sbG93IHVw IGZpeDogZG8gbm90IGFjY2VzcyB0aGUgUVNoYXJlZE1lbW9yeSBvYmplY3QKKyAgICAgICAgaW4g YW4gYXNzZXJ0IGlmIGl0IGhhcyBiZWVuIGRlbGV0ZWQuCisKIDIwMTAtMTEtMDggIEtlbm5ldGgg Um9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9XZWJLaXQyL1BsYXRmb3JtL3F0L1No YXJlZE1lbW9yeVF0LmNwcCBiL1dlYktpdDIvUGxhdGZvcm0vcXQvU2hhcmVkTWVtb3J5UXQuY3Bw CmluZGV4IDUzN2Q0M2NlN2Q4MjBjY2JjZjA2MjA2MzhiZTZmNGQwMGFiNDJhZjkuLmNhOTk3YzVi NWEyY2JmOTg2ZWE4OWFlMGMxNTI5Y2JlNjliMTliM2EgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvUGxh dGZvcm0vcXQvU2hhcmVkTWVtb3J5UXQuY3BwCisrKyBiL1dlYktpdDIvUGxhdGZvcm0vcXQvU2hh cmVkTWVtb3J5UXQuY3BwCkBAIC0xNDUsMTIgKzE0NSwxMiBAQCBQYXNzUmVmUHRyPFNoYXJlZE1l bW9yeT4gU2hhcmVkTWVtb3J5OjpjcmVhdGUoY29uc3QgSGFuZGxlJiBoYW5kbGUsIFByb3RlY3Rp b24gcAogCiBTaGFyZWRNZW1vcnk6On5TaGFyZWRNZW1vcnkoKQogewotICAgIC8vIG1faW1wbCBt dXN0IGJlIG5vbi1udWxsIGFuZCBpdCBtdXN0IHBvaW50IHRvIGEgdmFsaWQgUVNoYXJlZE1lbW9y eSBvYmplY3QuCi0gICAgQVNTRVJUKHFvYmplY3RfY2FzdDxRU2hhcmVkTWVtb3J5Kj4obV9pbXBs KSk7Ci0KICAgICAvLyBBdm9pZCBkb3VibGUgZGVsZXRpb24gd2hlbiBkZWxldGVMYXRlciBoYXMg YWxyZWFkeSBiZWVuIGNhbGxlZCB0aHJvdWdoIHRoZSBzaWduYWwtc2xvdCBjb25uZWN0aW9uLgot ICAgIGlmIChRQ29yZUFwcGxpY2F0aW9uOjppbnN0YW5jZSgpLT5kaXNjb25uZWN0KG1faW1wbCkp CisgICAgaWYgKFFDb3JlQXBwbGljYXRpb246Omluc3RhbmNlKCktPmRpc2Nvbm5lY3QobV9pbXBs KSkgeworICAgICAgICAvLyBtX2ltcGwgbXVzdCBiZSBub24tbnVsbCBhbmQgaXQgbXVzdCBwb2lu dCB0byBhIHZhbGlkIFFTaGFyZWRNZW1vcnkgb2JqZWN0LgorICAgICAgICBBU1NFUlQocW9iamVj dF9jYXN0PFFTaGFyZWRNZW1vcnkqPihtX2ltcGwpKTsKICAgICAgICAgZGVsZXRlIG1faW1wbDsK KyAgICB9CiAKICAgICBDcmFzaEhhbmRsZXI6Omluc3RhbmNlKCktPmRpZERlbGV0ZShtX2ltcGwp OwogfQo=