49124 2010-11-05 21:38:40 -0700 Inline some DeprecatedPtrListImplIterator methods for performance 2010-12-20 22:58:53 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 NEW P2 Normal --- 1 simon.fraser simon.fraser eric simon.fraser webkit.review.bot oldest_to_newest 305718 0 simon.fraser 2010-11-05 21:38:40 -0700 Inline some DeprecatedPtrListImplIterator methods for performance 305719 1 73163 simon.fraser 2010-11-05 21:39:15 -0700 Created attachment 73163 Patch 305720 2 73163 hyatt 2010-11-05 21:40:29 -0700 Comment on attachment 73163 Patch r=me 305721 3 webkit.review.bot 2010-11-05 21:42:39 -0700 Attachment 73163 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/DeprecatedPtrListImpl.cpp', u'WebCore/platform/DeprecatedPtrListImpl.h']" exit_code: 1 WebCore/platform/DeprecatedPtrListImpl.h:96: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 305722 4 eric 2010-11-05 21:44:42 -0700 Attachment 73163 did not build on mac: Build output: http://queues.webkit.org/results/5302025 305723 5 simon.fraser 2010-11-05 21:56:19 -0700 http://trac.webkit.org/changeset/71462 305733 6 simon.fraser 2010-11-05 22:35:10 -0700 I backed this out because of weird linker errors. 305735 7 simon.fraser 2010-11-05 22:35:32 -0700 e.g. http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Build%29/builds/24579/steps/compile-webkit/logs/stdio 321812 8 eric 2010-12-14 01:45:44 -0800 Curious what the status here is. 321983 9 simon.fraser 2010-12-14 08:32:13 -0800 Replace DeprecatedListPtr use for floats with a <vector> or something else. 324833 10 eric 2010-12-20 22:56:03 -0800 r71462. Please close bugs after landing. webkit-patch land will do this automatically for you. :) 324837 11 simon.fraser 2010-12-20 22:58:42 -0800 The patch was backed out because of linker issues. 73163 2010-11-05 21:39:15 -0700 2010-12-20 22:58:23 -0800 Patch bug-49124-20101105213914.patch text/plain 3513 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODZkYTgzNzhhMmY1MGI0YmYxNjg4MDEzNjE5MmQ2MjMxYWRkOWRlNC4uYzA4OTI5ZDUxZGM3Yjc4 MzIwMmVmNDEwNzlkYWIzOWU0M2ZhMGFkZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMS0wNSAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbmxpbmUgc29tZSBEZXByZWNhdGVkUHRyTGlz dEltcGxJdGVyYXRvciBtZXRob2RzIGZvciBwZXJmb3JtYW5jZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkxMjQKKworICAgICAgICBUaGlzIGlzIGEg fjQlIHBlcmZvcm1hbmNlIGltcHJvdmVtZW50IG9uIHNvbWUgUGVhY2VrZWVwciAiQ29tbXVuaXR5 IiB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL0RlcHJlY2F0ZWRQdHJMaXN0SW1wbC5jcHA6 CisgICAgICAgICogcGxhdGZvcm0vRGVwcmVjYXRlZFB0ckxpc3RJbXBsLmg6CisgICAgICAgIChX ZWJDb3JlOjpEZXByZWNhdGVkTGlzdE5vZGU6OkRlcHJlY2F0ZWRMaXN0Tm9kZSk6CisgICAgICAg IChXZWJDb3JlOjpEZXByZWNhdGVkUHRyTGlzdEltcGxJdGVyYXRvcjo6Y3VycmVudCk6CisgICAg ICAgIChXZWJDb3JlOjpEZXByZWNhdGVkUHRyTGlzdEltcGxJdGVyYXRvcjo6b3BlcmF0b3IrKyk6 CisKIDIwMTAtMTEtMDUgIElseWEgU2hlcm1hbiAgPGlzaGVybWFuQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs YXRmb3JtL0RlcHJlY2F0ZWRQdHJMaXN0SW1wbC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL0RlcHJl Y2F0ZWRQdHJMaXN0SW1wbC5jcHAKaW5kZXggOTZmZDUxMzgzZmVjYTQyZWQ4M2U4MmExYjhkN2Yz ZjVmYzIxYThhZC4uZTZiNTM2ZDFjOTY4YTVlNjA4NDM2MDM1MmY0N2IwODk4MDA5N2VhZCAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9EZXByZWNhdGVkUHRyTGlzdEltcGwuY3BwCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vRGVwcmVjYXRlZFB0ckxpc3RJbXBsLmNwcApAQCAtMjksMjEgKzI5 LDkgQEAKICNpbmNsdWRlIDxjc3RkZGVmPgogI2luY2x1ZGUgPGFsZ29yaXRobT4KICNpbmNsdWRl IDx3dGYvQXNzZXJ0aW9ucy5oPgotI2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKLWNsYXNzIERlcHJlY2F0ZWRMaXN0Tm9kZSA6IHB1YmxpYyBOb25j b3B5YWJsZQotewotcHVibGljOgotICAgIERlcHJlY2F0ZWRMaXN0Tm9kZSh2b2lkICpkKSA6IGRh dGEoZCksIG5leHQoMCksIHByZXYoMCkgeyB9Ci0KLSAgICB2b2lkICpkYXRhOwotICAgIERlcHJl Y2F0ZWRMaXN0Tm9kZSAqbmV4dDsKLSAgICBEZXByZWNhdGVkTGlzdE5vZGUgKnByZXY7Ci19Owot Ci0KIHN0YXRpYyBEZXByZWNhdGVkTGlzdE5vZGUgKmNvcHlMaXN0KERlcHJlY2F0ZWRMaXN0Tm9k ZSAqbCwgRGVwcmVjYXRlZExpc3ROb2RlIComdGFpbCkKIHsKICAgICBEZXByZWNhdGVkTGlzdE5v ZGUgKm5vZGUgPSBsOwpAQCAtNDc1LDExICs0NjMsNiBAQCB2b2lkICpEZXByZWNhdGVkUHRyTGlz dEltcGxJdGVyYXRvcjo6dG9MYXN0KCkKICAgICByZXR1cm4gY3VycmVudCgpOwogfQogCi12b2lk ICpEZXByZWNhdGVkUHRyTGlzdEltcGxJdGVyYXRvcjo6Y3VycmVudCgpIGNvbnN0Ci17Ci0gICAg cmV0dXJuIG5vZGUgPT0gMCA/IDAgOiBub2RlLT5kYXRhOwotfQotCiB2b2lkICpEZXByZWNhdGVk UHRyTGlzdEltcGxJdGVyYXRvcjo6b3BlcmF0b3ItLSgpCiB7CiAgICAgaWYgKG5vZGUpIHsKQEAg LTQ4OCwxNCArNDcxLDYgQEAgdm9pZCAqRGVwcmVjYXRlZFB0ckxpc3RJbXBsSXRlcmF0b3I6Om9w ZXJhdG9yLS0oKQogICAgIHJldHVybiBjdXJyZW50KCk7CiB9CiAKLXZvaWQgKkRlcHJlY2F0ZWRQ dHJMaXN0SW1wbEl0ZXJhdG9yOjpvcGVyYXRvcisrKCkKLXsKLSAgICBpZiAobm9kZSkgewotICAg ICAgICBub2RlID0gbm9kZS0+bmV4dDsKLSAgICB9Ci0gICAgcmV0dXJuIGN1cnJlbnQoKTsKLX0K LQogRGVwcmVjYXRlZFB0ckxpc3RJbXBsSXRlcmF0b3IgJkRlcHJlY2F0ZWRQdHJMaXN0SW1wbEl0 ZXJhdG9yOjpvcGVyYXRvcj0oY29uc3QgRGVwcmVjYXRlZFB0ckxpc3RJbXBsSXRlcmF0b3IgJmlt cGwpCiB7CiAgICAgaWYgKGxpc3QpIHsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vRGVw cmVjYXRlZFB0ckxpc3RJbXBsLmggYi9XZWJDb3JlL3BsYXRmb3JtL0RlcHJlY2F0ZWRQdHJMaXN0 SW1wbC5oCmluZGV4IDVlNDEyMWJlMDYxMjEzOTZlY2JmMmZkMWMxZWEyYTZkYjlkMGQ1YjYuLmMz M2RkODdkNmMzYzEzNTQ3ZWNjYWUyMWVkMTQ0MDMxMzM3NjZjOTIgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vRGVwcmVjYXRlZFB0ckxpc3RJbXBsLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9y bS9EZXByZWNhdGVkUHRyTGlzdEltcGwuaApAQCAtMjYsNiArMjYsOCBAQAogI2lmbmRlZiBEZXBy ZWNhdGVkUHRyTGlzdEltcGxfaAogI2RlZmluZSBEZXByZWNhdGVkUHRyTGlzdEltcGxfaAogCisj aW5jbHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xh c3MgRGVwcmVjYXRlZExpc3ROb2RlOwpAQCAtOTAsNiArOTIsMTUgQEAgcHVibGljOgogICAgIGZy aWVuZCBjbGFzcyBEZXByZWNhdGVkUHRyTGlzdEltcGxJdGVyYXRvcjsKIH07CiAKK2NsYXNzIERl cHJlY2F0ZWRMaXN0Tm9kZSA6IHB1YmxpYyBOb25jb3B5YWJsZQoreworcHVibGljOgorICAgIERl cHJlY2F0ZWRMaXN0Tm9kZSh2b2lkICpkKSA6IGRhdGEoZCksIG5leHQoMCksIHByZXYoMCkgeyB9 CisKKyAgICB2b2lkICpkYXRhOworICAgIERlcHJlY2F0ZWRMaXN0Tm9kZSAqbmV4dDsKKyAgICBE ZXByZWNhdGVkTGlzdE5vZGUgKnByZXY7Cit9OwogCiBjbGFzcyBEZXByZWNhdGVkUHRyTGlzdElt cGxJdGVyYXRvciB7CiBwdWJsaWM6CkBAIC0xMDMsMTAgKzExNCwxNiBAQCBwdWJsaWM6CiAgICAg dW5zaWduZWQgY291bnQoKSBjb25zdDsKICAgICB2b2lkICp0b0ZpcnN0KCk7CiAgICAgdm9pZCAq dG9MYXN0KCk7Ci0gICAgdm9pZCAqY3VycmVudCgpIGNvbnN0OworICAgIHZvaWQgKmN1cnJlbnQo KSBjb25zdCB7IHJldHVybiBub2RlID8gbm9kZS0+ZGF0YSA6IDA7IH0KIAogICAgIHZvaWQgKm9w ZXJhdG9yLS0oKTsKLSAgICB2b2lkICpvcGVyYXRvcisrKCk7CisgICAgdm9pZCAqb3BlcmF0b3Ir KygpCisgICAgeworICAgICAgICBpZiAobm9kZSkKKyAgICAgICAgICAgIG5vZGUgPSBub2RlLT5u ZXh0OworCisgICAgICAgIHJldHVybiBjdXJyZW50KCk7CisgICAgfQogCiBwcml2YXRlOgogICAg IGNvbnN0IERlcHJlY2F0ZWRQdHJMaXN0SW1wbCAqbGlzdDsK