49114 2010-11-05 16:52:58 -0700 [Qt] make install does not cause JavaScriptCore to be built 2010-11-07 19:09:05 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 smagnuso webkit-unassigned kling oldest_to_newest 305638 0 smagnuso 2010-11-05 16:52:58 -0700 When I do a make install at the root directory it will not build JavaScriptCore if there are changes (because libjs is just a .a). I've added an install target just so it will get compiled on a make install. 305646 1 73145 smagnuso 2010-11-05 17:02:24 -0700 Created attachment 73145 patch 305647 2 73146 smagnuso 2010-11-05 17:03:45 -0700 Created attachment 73146 patch Remove extraneous / in changelog. 305926 3 73146 kling 2010-11-07 19:07:21 -0800 Comment on attachment 73146 patch LGTM. This has itched me on occasion, thanks for the fix! 305928 4 73146 kling 2010-11-07 19:08:56 -0800 Comment on attachment 73146 patch Clearing flags on attachment: 73146 Committed r71489: <http://trac.webkit.org/changeset/71489> 305929 5 kling 2010-11-07 19:09:05 -0800 All reviewed patches have been landed. Closing bug. 73145 2010-11-05 17:02:24 -0700 2010-11-05 17:03:45 -0700 patch patch.diff text/plain 1122 smagnuso Y29tbWl0IGVjN2JkMDZjMTI4MzVjZGNhNGRhY2FkYTM1YWFjN2JiYWNjODE0N2UKQXV0aG9yOiBT YW0gTWFnbnVzb24gPHNtYWdudXNvbkBuZXRmbGl4LmNvbT4KRGF0ZTogICBGcmkgTm92IDUgMTY6 NTk6MDYgMjAxMCAtMDcwMAoKICAgIFtRdF0gbWFrZSBpbnN0YWxsIGRvZXMgbm90IGNhdXNlIEph dmFTY3JpcHRDb3JlIHRvIGJlIGJ1aWx0CiAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDkxMTQKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cg Yi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggNzQzMWUwMi4uMGRmNDI1ZSAxMDA2NDQK LS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACitcMjAxMC0xMS0wNSAgU2FtIE1hZ251c29uICA8c21hZ251 c29uQG5ldGZsaXguY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gbWFrZSBpbnN0YWxsIGRvZXMgbm90IGNhdXNlIEphdmFTY3JpcHRDb3Jl IHRvIGJlIGJ1aWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00OTExNAorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUucHJvOgorCiAyMDEwLTExLTAy ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBXaW5kb3dzIGJ1aWxk IGZpeCBhZnRlciByNzExMjcKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRD b3JlLnBybyBiL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnBybwppbmRleCBmODNiZjRj Li41MzFiMjJjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcm8K KysrIGIvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJvCkBAIC02OCw2ICs2OCw4IEBA IHdpbmNlKiB7CiBpbmNsdWRlKHBjcmUvcGNyZS5wcmkpCiBpbmNsdWRlKHd0Zi93dGYucHJpKQog CitJTlNUQUxMREVQUyArPSBhbGwKKwogU09VUkNFUyArPSBcCiAgICAgQVBJL0pTQmFzZS5jcHAg XAogICAgIEFQSS9KU0NhbGxiYWNrQ29uc3RydWN0b3IuY3BwIFwK 73146 2010-11-05 17:03:45 -0700 2010-11-07 19:08:56 -0800 patch patch.diff text/plain 1121 smagnuso Y29tbWl0IDEwZGQwZmVkOGFhOGIyMWNjNzJhNTEzNDVhYTU4NGVhOTNhMTc1NjcKQXV0aG9yOiBT YW0gTWFnbnVzb24gPHNtYWdudXNvbkBuZXRmbGl4LmNvbT4KRGF0ZTogICBGcmkgTm92IDUgMTY6 NTk6MDYgMjAxMCAtMDcwMAoKICAgIFtRdF0gbWFrZSBpbnN0YWxsIGRvZXMgbm90IGNhdXNlIEph dmFTY3JpcHRDb3JlIHRvIGJlIGJ1aWx0CiAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDkxMTQKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cg Yi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggNzQzMWUwMi4uMDg3MTAzMyAxMDA2NDQK LS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEwLTExLTA1ICBTYW0gTWFnbnVzb24gIDxzbWFnbnVz b25AbmV0ZmxpeC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1F0XSBtYWtlIGluc3RhbGwgZG9lcyBub3QgY2F1c2UgSmF2YVNjcmlwdENvcmUg dG8gYmUgYnVpbHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ5MTE0CisKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS5wcm86CisKIDIwMTAtMTEtMDIg IEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFdpbmRvd3MgYnVpbGQg Zml4IGFmdGVyIHI3MTEyNwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENv cmUucHJvIGIvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJvCmluZGV4IGY4M2JmNGMu LjUzMWIyMmMgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnBybwor KysgYi9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcm8KQEAgLTY4LDYgKzY4LDggQEAg d2luY2UqIHsKIGluY2x1ZGUocGNyZS9wY3JlLnByaSkKIGluY2x1ZGUod3RmL3d0Zi5wcmkpCiAK K0lOU1RBTExERVBTICs9IGFsbAorCiBTT1VSQ0VTICs9IFwKICAgICBBUEkvSlNCYXNlLmNwcCBc CiAgICAgQVBJL0pTQ2FsbGJhY2tDb25zdHJ1Y3Rvci5jcHAgXAo=