49108 2010-11-05 16:07:28 -0700 [Chromium] crasher on Mac with select elements that remove themselves on the change event 2010-11-08 12:05:42 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned commit-queue fishd levin oldest_to_newest 305608 0 jcivelli 2010-11-05 16:07:28 -0700 In Chromium on Mac, open the attached page. Click the select, select an item. Chromium crashes. Notes: This happens because the select element removes himself from the DOM on the onchange event. 305610 1 73134 jcivelli 2010-11-05 16:07:56 -0700 Created attachment 73134 Test page to recreate the crasher. 305730 2 73165 jcivelli 2010-11-05 22:29:22 -0700 Created attachment 73165 Patch 305785 3 73165 tkent 2010-11-06 06:44:59 -0700 Comment on attachment 73165 Patch LGTM 305868 4 73165 commit-queue 2010-11-07 01:42:21 -0800 Comment on attachment 73165 Patch Clearing flags on attachment: 73165 Committed r71480: <http://trac.webkit.org/changeset/71480> 305869 5 commit-queue 2010-11-07 01:42:26 -0800 All reviewed patches have been landed. Closing bug. 305904 6 levin 2010-11-07 15:35:42 -0800 I hope a test a was added somewhere. 306271 7 jcivelli 2010-11-08 12:05:42 -0800 @levin Yes, we have a test for this in the Chromium tree https://bugs.webkit.org/show_bug.cgi?id=49108 It will go in as soon as this patch makes it to the Chromium tree. 73134 2010-11-05 16:07:56 -0700 2010-11-05 16:07:56 -0700 Test page to recreate the crasher. select_crash.html text/html 221 jcivelli PHNlbGVjdCBvbmNoYW5nZT0ic2VsZWN0Q2hhbmdlZCh0aGlzKSI+CiAgPG9wdGlvbj5IZWxsbzwv b3B0aW9uPgogIDxvcHRpb24+Qmlqb3VyPC9vcHRpb24+CiAgPG9wdGlvbj5TYWx1dDwvb3B0aW9u Pgo8L3NlbGVjdD4KIAo8c2NyaXB0PgpmdW5jdGlvbiBzZWxlY3RDaGFuZ2VkKHNlbGVjdCkgewpz ZWxlY3QucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChzZWxlY3QpOwp9Cjwvc2NyaXB0Pgo= 73165 2010-11-05 22:29:22 -0700 2010-11-07 01:42:21 -0800 Patch bug-49108-20101105222921.patch text/plain 2051 jcivelli ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDhjN2UxNzhjMDUyYjA0YzdlYmEyN2UzMWI1NmE0OWM0NTU3ZTBhMTIu LmQ5MjZhYmViMGQ4YzY4ZWY5OTgzYTlhNTY0ZDgxNDk4OWNmNWNkM2EgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTExLTA1ICBKYXkgQ2l2ZWxsaSAgPGpjaXZlbGxpQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXhpbmcgYSBjcmFzaGVyIHdpdGggdGhlIHNlbGVjdCBwb3B1cCBvbiBNYWMgdGhhdCBoYXBw ZW5zIHdoZW4gYQorICAgICAgICBwYWdlIHJlbW92ZXMgdGhlIHNlbGVjdCBub2RlIHdoZW4gdGhl IHNlbGVjdCBjaGFuZ2VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDkxMDgKKworICAgICAgICAqIHNyYy9FeHRlcm5hbFBvcHVwTWVudS5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OkV4dGVybmFsUG9wdXBNZW51OjpkaWRBY2NlcHRJbmRleCk6CisgICAg ICAgIChXZWJLaXQ6OkV4dGVybmFsUG9wdXBNZW51OjpkaWRDYW5jZWwpOgorCiAyMDEwLTExLTA1 ICBJbHlhIFNoZXJtYW4gIDxpc2hlcm1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgU2ltb24gRnJhc2VyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9FeHRl cm5hbFBvcHVwTWVudS5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0V4dGVybmFsUG9wdXBNZW51 LmNwcAppbmRleCBhMDI0M2ViYWE3MTAxOGY2NjUyNGUyYzlhNjI4Mjc3ZWE2NjZlM2ZiLi4wZjIw OGZiMGY4ODU0YjUyMGNlY2RhOTAzNjMwNWQ0ZjUwMjkyNTA3IDEwMDY0NAotLS0gYS9XZWJLaXQv Y2hyb21pdW0vc3JjL0V4dGVybmFsUG9wdXBNZW51LmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0v c3JjL0V4dGVybmFsUG9wdXBNZW51LmNwcApAQCAtOTgsMTUgKzk4LDI2IEBAIHZvaWQgRXh0ZXJu YWxQb3B1cE1lbnU6OmRpZENoYW5nZVNlbGVjdGlvbihpbnQgaW5kZXgpCiAKIHZvaWQgRXh0ZXJu YWxQb3B1cE1lbnU6OmRpZEFjY2VwdEluZGV4KGludCBpbmRleCkKIHsKKyAgICAvLyBDYWxsaW5n IG1ldGhvZHMgb24gdGhlIFBvcHVwTWVudUNsaWVudCBtaWdodCBsZWFkIHRvIHRoaXMgb2JqZWN0 IGJlaW5nCisgICAgLy8gZGVyZWZlZC4gVGhpcyBlbnN1cmVzIGl0IGRvZXMgbm90IGdldCBkZWxl dGVkIHdoaWxlIHdlIGFyZSBydW5uaW5nIHRoaXMKKyAgICAvLyBtZXRob2QuCisgICAgUmVmUHRy PEV4dGVybmFsUG9wdXBNZW51PiBndWFyZCh0aGlzKTsKKwogICAgIGlmIChtX3BvcHVwTWVudUNs aWVudCkgewogICAgICAgICBtX3BvcHVwTWVudUNsaWVudC0+dmFsdWVDaGFuZ2VkKGluZGV4KTsK LSAgICAgICAgbV9wb3B1cE1lbnVDbGllbnQtPnBvcHVwRGlkSGlkZSgpOworICAgICAgICAvLyBU aGUgY2FsbCB0byB2YWx1ZUNoYW5nZWQgYWJvdmUgbWlnaHQgaGF2ZSBsZWFkIHRvIGEgY2FsbCB0 bworICAgICAgICAvLyBkaXNjb25uZWN0Q2xpZW50LCBzbyB3ZSBtaWdodCBub3QgaGF2ZSBhIFBv cHVwTWVudUNsaWVudCBhbnltb3JlLgorICAgICAgICBpZiAobV9wb3B1cE1lbnVDbGllbnQpCisg ICAgICAgICAgICBtX3BvcHVwTWVudUNsaWVudC0+cG9wdXBEaWRIaWRlKCk7CiAgICAgfQogICAg IG1fd2ViRXh0ZXJuYWxQb3B1cE1lbnUgPSAwOwogfQogCiB2b2lkIEV4dGVybmFsUG9wdXBNZW51 OjpkaWRDYW5jZWwoKQogeworICAgIC8vIFNlZSBjb21tZW50IGluIGRpZEFjY2VwdEluZGV4IG9u IHdoeSB3ZSBuZWVkIHRoaXMuCisgICAgUmVmUHRyPEV4dGVybmFsUG9wdXBNZW51PiBndWFyZCh0 aGlzKTsKKwogICAgIGlmIChtX3BvcHVwTWVudUNsaWVudCkKICAgICAgICAgbV9wb3B1cE1lbnVD bGllbnQtPnBvcHVwRGlkSGlkZSgpOwogICAgIG1fd2ViRXh0ZXJuYWxQb3B1cE1lbnUgPSAwOwo=