49099 2010-11-05 14:58:47 -0700 Android's navigator.language hardcoded to "en" 2010-11-07 15:38:38 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 0 jreck webkit-unassigned commit-queue steveblock oldest_to_newest 305549 0 jreck 2010-11-05 14:58:47 -0700 from: http://code.google.com/p/android/issues/detail?id=4641 Using navigator.language reports always "en" in androids browser where as my system language is de-at and the browser UI-Language is german as well. Looking at the attributes of the navigator object I see: navigator.language: en navigator.userAgent: Mozilla/5.0(Linux;U;Android 1.5;de-at;T-Mobile_G2_Touch Build/CPUCAKE) AppleWebKit/528.5+ ... navigator.appVersion: 5.0 (Linux;U;Android 1.5; de-at; ...) I know that navigator.language does not reflect the OS-Language but because my browser interacts with me in german I would have expected navigator.language to be "de" 305560 1 73125 jreck 2010-11-05 15:03:53 -0700 Created attachment 73125 Changes Android's WebCore::platformDefaultLanguage() to get the correct value from PlatformBridge 305738 2 ap 2010-11-05 22:46:41 -0700 Looks fine, assuming it's the normal design pattern for Android to call PlatformBridge from WebCore/platform/android files (which seems weird). 305896 3 73125 steveblock 2010-11-07 15:21:49 -0800 Comment on attachment 73125 Changes Android's WebCore::platformDefaultLanguage() to get the correct value from PlatformBridge Yes, this is a standard pattern for Android. Chromium uses a similar approach too. 305906 4 73125 commit-queue 2010-11-07 15:38:32 -0800 Comment on attachment 73125 Changes Android's WebCore::platformDefaultLanguage() to get the correct value from PlatformBridge Clearing flags on attachment: 73125 Committed r71484: <http://trac.webkit.org/changeset/71484> 305907 5 commit-queue 2010-11-07 15:38:38 -0800 All reviewed patches have been landed. Closing bug. 73125 2010-11-05 15:03:53 -0700 2010-11-07 15:38:32 -0800 Changes Android's WebCore::platformDefaultLanguage() to get the correct value from PlatformBridge navLangPatch text/plain 4976 jreck SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTQ1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMTEtMDUgIEpvaG4gUmVjayAgPGpyZWNrQGdvb2dsZS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVt ZW50cyBuYXZpZ2F0b3IubGFuZ3VhZ2UgZm9yIEFuZHJvaWQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5MDk5CisgICAgICAgIAorICAgICAgICBBbmRy b2lkIHdhcyBwcmV2aW91c2x5IGhhcmRjb2RpbmcgdGhlIHZhbHVlIGZvciBXZWJDb3JlOjpwbGF0 Zm9ybURlZmF1bHRMYW5ndWFnZSgpLgorICAgICAgICBUaGlzIHBhdGNoIHJlbW92ZXMgdGhlIGhh cmRjb2RpbmcgYW5kIGNhbGxzIGludG8gdGhlIFBsYXRmb3JtQnJpZGdlIHRvIGdldCB0aGUKKyAg ICAgICAgY29ycmVjdCBsYW5ndWFnZSBiYXNlZCBvZmYgb2YgdGhlIHVzZXIncyBzZXR0aW5ncy4K KworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLCB0aGlzIGlzIGFscmVhZHkgY292ZXJlZAor CisgICAgICAgICogQW5kcm9pZC5tazoKKyAgICAgICAgKiBwbGF0Zm9ybS9hbmRyb2lkL0xhbmd1 YWdlQW5kcm9pZC5jcHA6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6cGxhdGZvcm1EZWZhdWx0 TGFuZ3VhZ2UpOgorICAgICAgICAqIHBsYXRmb3JtL2FuZHJvaWQvUGxhdGZvcm1CcmlkZ2UuaDoK KyAgICAgICAgKiBwbGF0Zm9ybS9hbmRyb2lkL1RlbXBvcmFyeUxpbmtTdHVicy5jcHA6CisKIDIw MTAtMTEtMDUgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KSW5kZXg6IFdlYkNvcmUvQW5kcm9pZC5tawo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL0FuZHJvaWQubWsJKHJldmlzaW9uIDcxNDIzKQorKysgV2ViQ29yZS9B bmRyb2lkLm1rCSh3b3JraW5nIGNvcHkpCkBAIC00ODMsNiArNDgzLDcgQEAgTE9DQUxfU1JDX0ZJ TEVTIDo9ICQoTE9DQUxfU1JDX0ZJTEVTKSBcCiAJcGxhdGZvcm0vYW5kcm9pZC9HZW9sb2NhdGlv blNlcnZpY2VBbmRyb2lkLmNwcCBcCiAJcGxhdGZvcm0vYW5kcm9pZC9HZW9sb2NhdGlvblNlcnZp Y2VCcmlkZ2UuY3BwIFwKIAlwbGF0Zm9ybS9hbmRyb2lkL0tleUV2ZW50QW5kcm9pZC5jcHAgXAor CXBsYXRmb3JtL2FuZHJvaWQvTGFuZ3VhZ2VBbmRyb2lkLmNwcCBcCiAJcGxhdGZvcm0vYW5kcm9p ZC9Mb2NhbGl6ZWRTdHJpbmdzQW5kcm9pZC5jcHAgXAogCXBsYXRmb3JtL2FuZHJvaWQvUGxhdGZv cm1Ub3VjaEV2ZW50QW5kcm9pZC5jcHAgXAogCXBsYXRmb3JtL2FuZHJvaWQvUGxhdGZvcm1Ub3Vj aFBvaW50QW5kcm9pZC5jcHAgXApJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9hbmRyb2lkL0xhbmd1 YWdlQW5kcm9pZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9hbmRyb2lkL0xh bmd1YWdlQW5kcm9pZC5jcHAJKHJldmlzaW9uIDApCisrKyBXZWJDb3JlL3BsYXRmb3JtL2FuZHJv aWQvTGFuZ3VhZ2VBbmRyb2lkLmNwcAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0MiBAQAorLyoK KyAqIENvcHlyaWdodCAyMDEwLCBUaGUgQW5kcm9pZCBPcGVuIFNvdXJjZSBQcm9qZWN0CisgKgor ICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0 aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhh dCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAgKiBSZWRpc3RyaWJ1 dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICog ICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNj bGFpbWVyLgorICogICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9k dWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRp dGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50 YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRp b24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhP TERFUlMgYGBBUyBJUycnIEFORCBBTlkKKyAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVT LCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFCisgKiBJTVBMSUVEIFdBUlJBTlRJ RVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKKyAqIFBV UlBPU0UgQVJFIERJU0NMQUlNRUQuICBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUIE9X TkVSIE9SCisgKiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVD VCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAqIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBE QU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyAqIFBST0NVUkVNRU5UIE9G IFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgorICog UFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04g QU5ZIFRIRU9SWQorICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1Qg TElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNF KSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUs IEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8K KworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIkxhbmd1YWdlLmgiCisKKyNpbmNsdWRl ICJQbGF0Zm9ybUJyaWRnZS5oIgorI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCisKK25hbWVz cGFjZSBXZWJDb3JlIHsKKworLy8gVGhpcyBmdW5jdGlvbiBpcyB1c2VkIGJ5IEphdmFzY3JpcHQg dG8gZmluZCBvdXQgd2hhdCB0aGUgZGVmYXVsdCBsYW5ndWFnZQorLy8gdGhlIHVzZXIgaGFzIHNl bGVjdGVkLiBJdCBpcyB1c2VkIGJ5IHRoZSBKUyBvYmplY3QgTmF2aWdhdG9yLmxhbmd1YWdlCisv LyBJIGd1ZXNzIHRoaXMgaW5mb3JtYXRpb24gc2hvdWxkIGJlIG1hcHBlZCB3aXRoIHRoZSBBY2Nl cHQtTGFuZ3VhZ2U6IEhUVFAgaGVhZGVyLgorU3RyaW5nIHBsYXRmb3JtRGVmYXVsdExhbmd1YWdl KCkKK3sKKyAgICByZXR1cm4gUGxhdGZvcm1CcmlkZ2U6OmNvbXB1dGVEZWZhdWx0TGFuZ3VhZ2Uo KTsKK30KKworfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9h bmRyb2lkL1BsYXRmb3JtQnJpZGdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9h bmRyb2lkL1BsYXRmb3JtQnJpZGdlLmgJKHJldmlzaW9uIDcxMzUzKQorKysgV2ViQ29yZS9wbGF0 Zm9ybS9hbmRyb2lkL1BsYXRmb3JtQnJpZGdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNCw2ICsx MDQsOCBAQCBwdWJsaWM6CiAgICAgc3RhdGljIGJvb2wgY29va2llc0VuYWJsZWQoKTsKICAgICAv LyBQbHVnaW4KICAgICBzdGF0aWMgTlBPYmplY3QqIHBsdWdpblNjcmlwdGFibGVPYmplY3QoV2lk Z2V0Kik7CisgICAgLy8gTGFuZ3VhZ2UKKyAgICBzdGF0aWMgU3RyaW5nIGNvbXB1dGVEZWZhdWx0 TGFuZ3VhZ2UoKTsKIH07CiAKIH0KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vYW5kcm9pZC9UZW1w b3JhcnlMaW5rU3R1YnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vYW5kcm9p ZC9UZW1wb3JhcnlMaW5rU3R1YnMuY3BwCShyZXZpc2lvbiA3MTM1MykKKysrIFdlYkNvcmUvcGxh dGZvcm0vYW5kcm9pZC9UZW1wb3JhcnlMaW5rU3R1YnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05 MywxNSArOTMsNiBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIC8qIENvbXBsZXRlbHkgZW1w dHkgc3R1YnMgKG1vc3RseSB0byBhbGxvdyBEUlQgdG8gcnVuKTogKi8KIC8qKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKi8KIAotLy8gVGhpcyBm dW5jdGlvbiBpcyB1c2VkIGJ5IEphdmFzY3JpcHQgdG8gZmluZCBvdXQgd2hhdCB0aGUgZGVmYXVs dCBsYW5ndWFnZQotLy8gdGhlIHVzZXIgaGFzIHNlbGVjdGVkLiBJdCBpcyB1c2VkIGJ5IHRoZSBK UyBvYmplY3QgTmF2aWdhdG9yLmxhbmd1YWdlCi0vLyBJIGd1ZXNzIHRoaXMgaW5mb3JtYXRpb24g c2hvdWxkIGJlIG1hcHBlZCB3aXRoIHRoZSBBY2NlcHQtTGFuZ3VhZ2U6IEhUVFAgaGVhZGVyLgot U3RyaW5nIFdlYkNvcmU6OmRlZmF1bHRMYW5ndWFnZSgpCi17Ci0gICAgdmVyaWZpZWRPaygpOwot ICAgIHJldHVybiAiZW4iOwotfQotCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIC8vIFRoaXMgZnVu Y3Rpb24gdGVsbHMgdGhlIGJyaWRnZSB0aGF0IGEgcmVzb3VyY2Ugd2FzIGxvYWRlZCBmcm9tIHRo ZSBjYWNoZSBhbmQgdGh1cwo=