49082 2010-11-05 11:32:57 -0700 [EFL] Change the usage of eina_iterator_next due to latest EFL changes. 2010-11-08 13:01:00 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 antognolli+webkit antognolli+webkit commit-queue gyuyoung.kim kenneth leandro lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 305409 0 antognolli+webkit 2010-11-05 11:32:57 -0700 [EFL] Change the usage of eina_iterator_next due to latest EFL changes. 305412 1 73090 antognolli+webkit 2010-11-05 11:35:02 -0700 Created attachment 73090 Patch 305420 2 73090 tonikitoo 2010-11-05 11:38:48 -0700 Comment on attachment 73090 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73090&action=review > WebKit/efl/ChangeLog:8 > + https://bugs.webkit.org/show_bug.cgi?id=49082 > + > + A change on how the iterator for a tiler is used in EFL needs to be Fix indentation, please. 305421 3 webkit.review.bot 2010-11-05 11:39:14 -0700 Attachment 73090 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit/efl/ChangeLog', u'WebKit/efl/ewk/ewk_view_single.c']" exit_code: 1 WebKit/efl/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] WebKit/efl/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] WebKit/efl/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] WebKit/efl/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 305426 4 73094 antognolli+webkit 2010-11-05 11:45:58 -0700 Created attachment 73094 Patch 306298 5 73094 leandro 2010-11-08 12:57:02 -0800 Comment on attachment 73094 Patch I'll land the patch manually, since this'll break the build temporarily. Removing cq+. 306302 6 73094 leandro 2010-11-08 13:00:51 -0800 Comment on attachment 73094 Patch Clearing flags on attachment: 73094 Committed r71561: <http://trac.webkit.org/changeset/71561> 306303 7 leandro 2010-11-08 13:01:00 -0800 All reviewed patches have been landed. Closing bug. 73090 2010-11-05 11:35:02 -0700 2010-11-05 11:45:52 -0700 Patch bug-49082-20101105183503.patch text/plain 2210 antognolli+webkit ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggOTkzN2RlNDJkMjc5NDgyYzYxZjk2MjMyNzQ2NzFiMGM4YjFiMzVjMC4uMzkzYmFjOGQy MGVjODJmNjMxZDQ5ZmIxOWM1ZDZmYzk5NTZlYWM2NyAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAx MC0xMS0wNSAgUmFmYWVsIEFudG9nbm9sbGkgIDxhbnRvZ25vbGxpQHByb2Z1c2lvbi5tb2JpPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIENo YW5nZSB0aGUgdXNhZ2Ugb2YgZWluYV9pdGVyYXRvcl9uZXh0IGR1ZSB0byBsYXRlc3QgRUZMIGNo YW5nZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 OTA4MgorCisJCUEgY2hhbmdlIG9uIGhvdyB0aGUgaXRlcmF0b3IgZm9yIGEgdGlsZXIgaXMgdXNl ZCBpbiBFRkwgbmVlZHMgdG8gYmUKKwkJcmVmbGVjdGVkIGluIFdlYktpdC1FRkwuIFRoZSBpdGVy YXRvciBub3cgcmVjZWl2ZXMgYSBwb2ludGVyIHRvIGFuCisJCUVpbmFfUmVjdGFuZ2xlIGFuZCBt YWtlcyBpdCBwb2ludCB0byBpdHMgaW50ZXJuYWwgc3RydWN0dXJlLiBUaGUgb2xkCisJCXVzYWdl IHdhcyB0byByZWNlaXZlIGEgcmVmZXJlbmNlIHRvIGEgcHJlLWFsbG9jYXRlZCBFaW5hX1JlY3Rh bmdsZS4KKworICAgICAgICAqIGV3ay9ld2tfdmlld19zaW5nbGUuYzoKKyAgICAgICAgKF9ld2tf dmlld19zaW5nbGVfc21hcnRfcmVwYWludHNfcHJvY2Vzcyk6CisKIDIwMTAtMTEtMDUgIFBhdHJp Y2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGF2aWQgS2lsemVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdfc2luZ2xl LmMgYi9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld19zaW5nbGUuYwppbmRleCA4NWU1MzM5MjA1MTUx MGM4MzA1YWU1YmMwNWUyNWU2YWQyMjZiMjk3Li42ZDk2NWQwYzU1NWUyMDc5ZjFmZGY5YWVlOTU4 YjRjOWZkZmQ3MDA3IDEwMDY0NAotLS0gYS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld19zaW5nbGUu YworKysgYi9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld19zaW5nbGUuYwpAQCAtMzU4LDcgKzM1OCw3 IEBAIHN0YXRpYyBFaW5hX0Jvb2wgX2V3a192aWV3X3NpbmdsZV9zbWFydF9yZXBhaW50c19wcm9j ZXNzKEV3a19WaWV3X1NtYXJ0X0RhdGEgKnNkCiAgICAgRXdrX1ZpZXdfUGFpbnRfQ29udGV4dCAq Y3R4dDsKICAgICBFdmFzX0Nvb3JkIG93LCBvaDsKICAgICB2b2lkICpwaXhlbHM7Ci0gICAgRWlu YV9SZWN0YW5nbGUgciA9IHswLCAwLCAwLCAwfTsKKyAgICBFaW5hX1JlY3RhbmdsZSAqcjsKICAg ICBjb25zdCBFaW5hX1JlY3RhbmdsZSAqcHI7CiAgICAgY29uc3QgRWluYV9SZWN0YW5nbGUgKnBy X2VuZDsKICAgICBFaW5hX1RpbGVyICp0aWxlcjsKQEAgLTQ0Niw4ICs0NDYsOCBAQCBzdGF0aWMg RWluYV9Cb29sIF9ld2tfdmlld19zaW5nbGVfc21hcnRfcmVwYWludHNfcHJvY2VzcyhFd2tfVmll d19TbWFydF9EYXRhICpzZAogCiAgICAgRUlOQV9JVEVSQVRPUl9GT1JFQUNIKGl0ciwgcikgewog ICAgICAgICBFaW5hX1JlY3RhbmdsZSBzY3JvbGxlZF9yZWN0ID0gewotICAgICAgICAgICAgci54 ICsgc3gsIHIueSArIHN5LAotICAgICAgICAgICAgci53LCByLmgKKyAgICAgICAgICAgIHItPngg KyBzeCwgci0+eSArIHN5LAorICAgICAgICAgICAgci0+dywgci0+aAogICAgICAgICB9OwogCiAg ICAgICAgIGV3a192aWV3X3BhaW50X2NvbnRleHRfc2F2ZShjdHh0KTsKQEAgLTQ2MCw3ICs0NjAs NyBAQCBzdGF0aWMgRWluYV9Cb29sIF9ld2tfdmlld19zaW5nbGVfc21hcnRfcmVwYWludHNfcHJv Y2VzcyhFd2tfVmlld19TbWFydF9EYXRhICpzZAogCiAgICAgICAgIGV3a192aWV3X3BhaW50X2Nv bnRleHRfcmVzdG9yZShjdHh0KTsKICAgICAgICAgZXZhc19vYmplY3RfaW1hZ2VfZGF0YV91cGRh dGVfYWRkCi0gICAgICAgICAgICAoc2QtPmJhY2tpbmdfc3RvcmUsIHIueCwgci55LCByLncsIHIu aCk7CisgICAgICAgICAgICAoc2QtPmJhY2tpbmdfc3RvcmUsIHItPngsIHItPnksIHItPncsIHIt PmgpOwogICAgIH0KICAgICBlaW5hX2l0ZXJhdG9yX2ZyZWUoaXRyKTsKIAo= 73094 2010-11-05 11:45:58 -0700 2010-11-08 13:00:50 -0800 Patch bug-49082-20101105184558.patch text/plain 2234 antognolli+webkit ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggOTkzN2RlNDJkMjc5NDgyYzYxZjk2MjMyNzQ2NzFiMGM4YjFiMzVjMC4uNjE3ZTZmNjQ1 N2M4MjQ3NDBiNDI2NDdlYjNhZmI3N2VhNTQ1ZTc4YyAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAx MC0xMS0wNSAgUmFmYWVsIEFudG9nbm9sbGkgIDxhbnRvZ25vbGxpQHByb2Z1c2lvbi5tb2JpPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIENo YW5nZSB0aGUgdXNhZ2Ugb2YgZWluYV9pdGVyYXRvcl9uZXh0IGR1ZSB0byBsYXRlc3QgRUZMIGNo YW5nZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 OTA4MgorCisgICAgICAgIEEgY2hhbmdlIG9uIGhvdyB0aGUgaXRlcmF0b3IgZm9yIGEgdGlsZXIg aXMgdXNlZCBpbiBFRkwgbmVlZHMgdG8gYmUKKyAgICAgICAgcmVmbGVjdGVkIGluIFdlYktpdC1F RkwuIFRoZSBpdGVyYXRvciBub3cgcmVjZWl2ZXMgYSBwb2ludGVyIHRvIGFuCisgICAgICAgIEVp bmFfUmVjdGFuZ2xlIGFuZCBtYWtlcyBpdCBwb2ludCB0byBpdHMgaW50ZXJuYWwgc3RydWN0dXJl LiBUaGUgb2xkCisgICAgICAgIHVzYWdlIHdhcyB0byByZWNlaXZlIGEgcmVmZXJlbmNlIHRvIGEg cHJlLWFsbG9jYXRlZCBFaW5hX1JlY3RhbmdsZS4KKworICAgICAgICAqIGV3ay9ld2tfdmlld19z aW5nbGUuYzoKKyAgICAgICAgKF9ld2tfdmlld19zaW5nbGVfc21hcnRfcmVwYWludHNfcHJvY2Vz cyk6CisKIDIwMTAtMTEtMDUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgS2lsemVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0 L2VmbC9ld2svZXdrX3ZpZXdfc2luZ2xlLmMgYi9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld19zaW5n bGUuYwppbmRleCA4NWU1MzM5MjA1MTUxMGM4MzA1YWU1YmMwNWUyNWU2YWQyMjZiMjk3Li42ZDk2 NWQwYzU1NWUyMDc5ZjFmZGY5YWVlOTU4YjRjOWZkZmQ3MDA3IDEwMDY0NAotLS0gYS9XZWJLaXQv ZWZsL2V3ay9ld2tfdmlld19zaW5nbGUuYworKysgYi9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld19z aW5nbGUuYwpAQCAtMzU4LDcgKzM1OCw3IEBAIHN0YXRpYyBFaW5hX0Jvb2wgX2V3a192aWV3X3Np bmdsZV9zbWFydF9yZXBhaW50c19wcm9jZXNzKEV3a19WaWV3X1NtYXJ0X0RhdGEgKnNkCiAgICAg RXdrX1ZpZXdfUGFpbnRfQ29udGV4dCAqY3R4dDsKICAgICBFdmFzX0Nvb3JkIG93LCBvaDsKICAg ICB2b2lkICpwaXhlbHM7Ci0gICAgRWluYV9SZWN0YW5nbGUgciA9IHswLCAwLCAwLCAwfTsKKyAg ICBFaW5hX1JlY3RhbmdsZSAqcjsKICAgICBjb25zdCBFaW5hX1JlY3RhbmdsZSAqcHI7CiAgICAg Y29uc3QgRWluYV9SZWN0YW5nbGUgKnByX2VuZDsKICAgICBFaW5hX1RpbGVyICp0aWxlcjsKQEAg LTQ0Niw4ICs0NDYsOCBAQCBzdGF0aWMgRWluYV9Cb29sIF9ld2tfdmlld19zaW5nbGVfc21hcnRf cmVwYWludHNfcHJvY2VzcyhFd2tfVmlld19TbWFydF9EYXRhICpzZAogCiAgICAgRUlOQV9JVEVS QVRPUl9GT1JFQUNIKGl0ciwgcikgewogICAgICAgICBFaW5hX1JlY3RhbmdsZSBzY3JvbGxlZF9y ZWN0ID0gewotICAgICAgICAgICAgci54ICsgc3gsIHIueSArIHN5LAotICAgICAgICAgICAgci53 LCByLmgKKyAgICAgICAgICAgIHItPnggKyBzeCwgci0+eSArIHN5LAorICAgICAgICAgICAgci0+ dywgci0+aAogICAgICAgICB9OwogCiAgICAgICAgIGV3a192aWV3X3BhaW50X2NvbnRleHRfc2F2 ZShjdHh0KTsKQEAgLTQ2MCw3ICs0NjAsNyBAQCBzdGF0aWMgRWluYV9Cb29sIF9ld2tfdmlld19z aW5nbGVfc21hcnRfcmVwYWludHNfcHJvY2VzcyhFd2tfVmlld19TbWFydF9EYXRhICpzZAogCiAg ICAgICAgIGV3a192aWV3X3BhaW50X2NvbnRleHRfcmVzdG9yZShjdHh0KTsKICAgICAgICAgZXZh c19vYmplY3RfaW1hZ2VfZGF0YV91cGRhdGVfYWRkCi0gICAgICAgICAgICAoc2QtPmJhY2tpbmdf c3RvcmUsIHIueCwgci55LCByLncsIHIuaCk7CisgICAgICAgICAgICAoc2QtPmJhY2tpbmdfc3Rv cmUsIHItPngsIHItPnksIHItPncsIHItPmgpOwogICAgIH0KICAgICBlaW5hX2l0ZXJhdG9yX2Zy ZWUoaXRyKTsKIAo=