49080 2010-11-05 11:24:41 -0700 webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation 2011-08-23 12:27:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 48166 1 dglazkov paroga aroben webkit.review.bot oldest_to_newest 305404 0 dglazkov 2010-11-05 11:24:41 -0700 The output is like this: WebKitTools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl ............ ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl ......... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl .............. Dubious, test returned 25 (wstat 6400, 0x1900) Failed 8/16 subtests List form of pipe open not implemented at D:/google-windows-2/chromium-win-release-tests/build/WebKitTools/Scripts/VCSUtils.pm line 1579. # Looks like you planned 16 tests but ran 8. # Looks like your test exited with 25 just after 8. WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl .................... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl .............. ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl ........... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl ................... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl ........... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl ........... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl ............. ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl ........ ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl ........... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl .................... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl .............. ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl .. ok Test Summary Report ------------------- WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl (Wstat: 6400 Tests: 8 Failed: 0) Non-zero exit status: 25 Parse errors: Bad plan. You planned 16 tests but ran 8. Files=15, Tests=301, 2 wallclock secs ( 0.09 usr + 0.02 sys = 0.11 CPU) Result: FAIL Failed 1/15 test programs. 0/301 subtests failed. 455519 1 104868 paroga 2011-08-23 11:08:40 -0700 Created attachment 104868 Patch 455522 2 104868 aroben 2011-08-23 11:11:19 -0700 Comment on attachment 104868 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104868&action=review > Tools/Scripts/VCSUtils.pm:1699 > - open(DIFF, "-|", qw(diff -u -a --binary), $fileOlder, $fileMine) or die $!; > + open(DIFF, "diff -u -a --binary $fileOlder $fileMine |") or die $!; You now need to quote $fileOlder and $fileMine in case they contain spaces. 455527 3 104868 paroga 2011-08-23 11:15:58 -0700 Comment on attachment 104868 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104868&action=review >> Tools/Scripts/VCSUtils.pm:1699 >> + open(DIFF, "diff -u -a --binary $fileOlder $fileMine |") or die $!; > > You now need to quote $fileOlder and $fileMine in case they contain spaces. We don't do correct escaping on different places. e.g. only 8 lines down: http://trac.webkit.org/browser/trunk/Tools/Scripts/VCSUtils.pm#L1707 455529 4 104868 aroben 2011-08-23 11:18:05 -0700 Comment on attachment 104868 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104868&action=review >>> Tools/Scripts/VCSUtils.pm:1699 >>> + open(DIFF, "diff -u -a --binary $fileOlder $fileMine |") or die $!; >> >> You now need to quote $fileOlder and $fileMine in case they contain spaces. > > We don't do correct escaping on different places. e.g. only 8 lines down: http://trac.webkit.org/browser/trunk/Tools/Scripts/VCSUtils.pm#L1707 We should fix those places (separately). We want WebKit scripts to work regardless of the path to your checkout. 455531 5 104872 paroga 2011-08-23 11:19:42 -0700 Created attachment 104872 Patch 455600 6 104872 webkit.review.bot 2011-08-23 12:27:46 -0700 Comment on attachment 104872 Patch Clearing flags on attachment: 104872 Committed r93623: <http://trac.webkit.org/changeset/93623> 455601 7 webkit.review.bot 2011-08-23 12:27:50 -0700 All reviewed patches have been landed. Closing bug. 104868 2011-08-23 11:08:40 -0700 2011-08-23 11:19:42 -0700 Patch bug-49080.patch text/plain 1196 paroga ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3Y2Ni YzU1Li4wN2NiMTNmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMjMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8 cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgd2Via2l0LXBlcmwgdGVzdHMgZmFpbCBvbiB3 aW4zMiBQZXJsIGR1ZSB0byBsYWNrIG9mIGxpc3QgZm9ybSBvZiBwaXBlIG9wZW4gaW1wbGVtZW50 YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5 MDgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNl IHRoZSBzdHJpbmcgZm9ybSBvZiBwaXBlIG9wZW4gaW5zdGVhZCAobGlrZSB3ZSBkbyBhdCBhbGwg b3RoZXIgcGxhY2VzKS4KKworICAgICAgICAqIFNjcmlwdHMvVkNTVXRpbHMucG06CisgICAgICAg IChtZXJnZUNoYW5nZUxvZ3MpOgorCiAyMDExLTA4LTE0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdl YmtpdC5vcmc+CiAKICAgICAgICAgU3dpdGNoIHJlc3VsdHMgZGV0YWlsIHZpZXcgb3ZlciB0byBu ZXctc3R5bGUgb2JqZWN0LW9yaWVudGVkIFVJIHdpZGdldHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvVkNTVXRpbHMucG0gYi9Ub29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCmluZGV4IDE0MTEz MDEuLjcyZjM4MmEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0KKysrIGIv VG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQpAQCAtMTY5Niw3ICsxNjk2LDcgQEAgc3ViIG1lcmdl Q2hhbmdlTG9ncygkJCQpCiAgICAgICAgIHJlbmFtZSgkZmlsZU1pbmUsICIkZmlsZU1pbmUuc2F2 ZSIpOwogICAgICAgICByZW5hbWUoJGZpbGVPbGRlciwgIiRmaWxlT2xkZXIuc2F2ZSIpOwogICAg IH0gZWxzZSB7Ci0gICAgICAgIG9wZW4oRElGRiwgIi18IiwgcXcoZGlmZiAtdSAtYSAtLWJpbmFy eSksICRmaWxlT2xkZXIsICRmaWxlTWluZSkgb3IgZGllICQhOworICAgICAgICBvcGVuKERJRkYs ICJkaWZmIC11IC1hIC0tYmluYXJ5ICRmaWxlT2xkZXIgJGZpbGVNaW5lIHwiKSBvciBkaWUgJCE7 CiAgICAgICAgICRwYXRjaCA9IDxESUZGPjsKICAgICAgICAgY2xvc2UoRElGRik7CiAgICAgfQo= 104872 2011-08-23 11:19:42 -0700 2011-08-23 12:27:46 -0700 Patch bug-49080.patch text/plain 1204 paroga ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3Y2Ni YzU1Li4wN2NiMTNmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMjMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8 cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgd2Via2l0LXBlcmwgdGVzdHMgZmFpbCBvbiB3 aW4zMiBQZXJsIGR1ZSB0byBsYWNrIG9mIGxpc3QgZm9ybSBvZiBwaXBlIG9wZW4gaW1wbGVtZW50 YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5 MDgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNl IHRoZSBzdHJpbmcgZm9ybSBvZiBwaXBlIG9wZW4gaW5zdGVhZCAobGlrZSB3ZSBkbyBhdCBhbGwg b3RoZXIgcGxhY2VzKS4KKworICAgICAgICAqIFNjcmlwdHMvVkNTVXRpbHMucG06CisgICAgICAg IChtZXJnZUNoYW5nZUxvZ3MpOgorCiAyMDExLTA4LTE0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdl YmtpdC5vcmc+CiAKICAgICAgICAgU3dpdGNoIHJlc3VsdHMgZGV0YWlsIHZpZXcgb3ZlciB0byBu ZXctc3R5bGUgb2JqZWN0LW9yaWVudGVkIFVJIHdpZGdldHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvVkNTVXRpbHMucG0gYi9Ub29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCmluZGV4IDE0MTEz MDEuLjcyZjM4MmEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0KKysrIGIv VG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQpAQCAtMTY5Niw3ICsxNjk2LDcgQEAgc3ViIG1lcmdl Q2hhbmdlTG9ncygkJCQpCiAgICAgICAgIHJlbmFtZSgkZmlsZU1pbmUsICIkZmlsZU1pbmUuc2F2 ZSIpOwogICAgICAgICByZW5hbWUoJGZpbGVPbGRlciwgIiRmaWxlT2xkZXIuc2F2ZSIpOwogICAg IH0gZWxzZSB7Ci0gICAgICAgIG9wZW4oRElGRiwgIi18IiwgcXcoZGlmZiAtdSAtYSAtLWJpbmFy eSksICRmaWxlT2xkZXIsICRmaWxlTWluZSkgb3IgZGllICQhOworICAgICAgICBvcGVuKERJRkYs ICJkaWZmIC11IC1hIC0tYmluYXJ5IFwiJGZpbGVPbGRlclwiIFwiJGZpbGVNaW5lXCIgfCIpIG9y IGRpZSAkITsKICAgICAgICAgJHBhdGNoID0gPERJRkY+OwogICAgICAgICBjbG9zZShESUZGKTsK ICAgICB9Cg==