49076 2010-11-05 10:41:12 -0700 loadedPlugins parameter to PluginInfoStore::shouldUsePlugin is redundant 2010-11-05 11:16:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 43509 1 aroben aroben andersca eric jhoneycutt oldest_to_newest 305357 0 aroben 2010-11-05 10:41:12 -0700 loadedPlugins parameter to PluginInfoStore::shouldUsePlugin is redundant 305361 1 73081 aroben 2010-11-05 10:43:02 -0700 Created attachment 73081 Patch 305369 2 73081 aroben 2010-11-05 10:47:17 -0700 Comment on attachment 73081 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73081&action=review > WebKit2/UIProcess/Plugins/PluginInfoStore.h:82 > - static bool shouldUsePlugin(const Plugin& plugin, const Vector<Plugin>& loadedPlugins); > + static bool shouldUsePlugin(const Plugin& plugin); Whoops, that "static" should have been removed. 305372 3 eric 2010-11-05 10:50:23 -0700 Attachment 73081 did not build on mac: Build output: http://queues.webkit.org/results/5255012 305397 4 aroben 2010-11-05 11:16:10 -0700 Committed r71435: <http://trac.webkit.org/changeset/71435> 73081 2010-11-05 10:43:02 -0700 2010-11-05 10:47:42 -0700 Patch bug-49076-20101105134319.patch text/plain 5988 aroben ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg NWE1ZDc1YTk1ZjFjMGJjN2QzYzQ3OWRjN2I1ZmJkMjlmOWFlYjhiNC4uYTJiYWM4ZTVlY2E0OGIy ZDI5NDIzYmZkZDRjYjlhYmI0ZWVlODY2NiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOSBAQAorMjAxMC0xMS0wNSAgQWRh bSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisKKyAgICAgICAgT3BlcmF0ZSBvbiBtX3BsdWdp bnMgZGlyZWN0bHkgaW4gUGx1Z2luSW5mb1N0b3JlOjpzaG91bGRVc2VQbHVnaW4KKworICAgICAg ICBXZSdsbCBuZWVkIHRvIG9wZXJhdGUgb24gbV9wbHVnaW5zIGlmIHdlIGV2ZXIgd2FudCB0byB1 bmxvYWQgYW4KKyAgICAgICAgYWxyZWFkeS1sb2FkZWQgcGx1Z2luIGJlZm9yZSBsb2FkaW5nIHRo ZSBuZXcgb25lLgorCisgICAgICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzQ5MDc2PiBs b2FkZWRQbHVnaW5zIHBhcmFtZXRlciB0bworICAgICAgICBQbHVnaW5JbmZvU3RvcmU6OnNob3Vs ZFVzZVBsdWdpbiBpcyByZWR1bmRhbnQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9QbHVnaW5zL1BsdWdpbkluZm9TdG9yZS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OlBsdWdpbkluZm9TdG9yZTo6bG9hZFBsdWdpbik6CisgICAgICAg ICogVUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2luSW5mb1N0b3JlLmg6CisgICAgICAgICogVUlQcm9j ZXNzL1BsdWdpbnMvZ3RrL1BsdWdpbkluZm9TdG9yZUd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6 OlBsdWdpbkluZm9TdG9yZTo6c2hvdWxkVXNlUGx1Z2luKToKKyAgICAgICAgKiBVSVByb2Nlc3Mv UGx1Z2lucy9tYWMvUGx1Z2luSW5mb1N0b3JlTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpQbHVn aW5JbmZvU3RvcmU6OnNob3VsZFVzZVBsdWdpbik6CisgICAgICAgICogVUlQcm9jZXNzL1BsdWdp bnMvcXQvUGx1Z2luSW5mb1N0b3JlUXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5JbmZv U3RvcmU6OnNob3VsZFVzZVBsdWdpbik6CisgICAgICAgICogVUlQcm9jZXNzL1BsdWdpbnMvd2lu L1BsdWdpbkluZm9TdG9yZVdpbi5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpbkluZm9TdG9y ZTo6c2hvdWxkVXNlUGx1Z2luKToKKyAgICAgICAgUmVtb3ZlZCB0aGUgbG9hZGVkUGx1Z2lucyBw YXJhbWV0ZXIgZnJvbSBzaG91bGRVc2VQbHVnaW4uIFRoZSBzaW5nbGUKKyAgICAgICAgaW1wbGVt ZW50YXRpb24gKE1hYykgbm93IHVzZXMgbV9wbHVnaW5zIGRpcmVjdGx5LgorCiAyMDEwLTExLTA0 ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgYSB3aW5kb3cg cmVnaW9uIHRvIGNsaXAgd2luZG93ZWQgcGx1Z2lucwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVBy b2Nlc3MvUGx1Z2lucy9QbHVnaW5JbmZvU3RvcmUuY3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1 Z2lucy9QbHVnaW5JbmZvU3RvcmUuY3BwCmluZGV4IDRkYjk3ODQ4MTk1NDQ3OTJiNTU4OTI2ZGM1 M2ZiZTIzZDQzYTVlOTQuLmY0ZmI1YWQ2MGI4Y2JjMTBkM2VhMDUzYWYyNTZjYzI5M2MzZjY0ZTQg MTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2luSW5mb1N0b3JlLmNw cAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL1BsdWdpbkluZm9TdG9yZS5jcHAKQEAg LTk5LDcgKzk5LDcgQEAgdm9pZCBQbHVnaW5JbmZvU3RvcmU6OmxvYWRQbHVnaW4oY29uc3QgU3Ry aW5nJiBwbHVnaW5QYXRoKQogICAgIGlmICghZ2V0UGx1Z2luSW5mbyhwbHVnaW5QYXRoLCBwbHVn aW4pKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoIXNob3VsZFVzZVBsdWdpbihwbHVnaW4s IG1fcGx1Z2lucykpCisgICAgaWYgKCFzaG91bGRVc2VQbHVnaW4ocGx1Z2luKSkKICAgICAgICAg cmV0dXJuOwogICAgIAogICAgIC8vIEFkZCB0aGUgcGx1Zy1pbi4KZGlmZiAtLWdpdCBhL1dlYktp dDIvVUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2luSW5mb1N0b3JlLmggYi9XZWJLaXQyL1VJUHJvY2Vz cy9QbHVnaW5zL1BsdWdpbkluZm9TdG9yZS5oCmluZGV4IGYzZTY2OWU4ZGJkMGY5ZmYxNDE1NTVi NTg1Yjk1YTljOGVkNWMwZjMuLmJlOTFmNGM0MDYwMmQzNGNkZTA4ZmJjN2UwNDUzYWI4NmNiZDcw M2YgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2luSW5mb1N0b3Jl LmgKKysrIGIvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5JbmZvU3RvcmUuaApAQCAt NzksNyArNzksNyBAQCBwcml2YXRlOgogICAgIC8vIFJldHVybnMgcGF0aHMgdG8gaW5kaXZpZHVh bCBwbHVnLWlucyB0aGF0IHdvbid0IGJlIGZvdW5kIHZpYSBwbHVnaW5zRGlyZWN0b3JpZXMvcGx1 Z2luUGF0aHNJbkRpcmVjdG9yeS4KICAgICBzdGF0aWMgVmVjdG9yPFN0cmluZz4gaW5kaXZpZHVh bFBsdWdpblBhdGhzKCk7CiAgICAgc3RhdGljIGJvb2wgZ2V0UGx1Z2luSW5mbyhjb25zdCBTdHJp bmcmIHBsdWdpblBhdGgsIFBsdWdpbiYgcGx1Z2luKTsKLSAgICBzdGF0aWMgYm9vbCBzaG91bGRV c2VQbHVnaW4oY29uc3QgUGx1Z2luJiBwbHVnaW4sIGNvbnN0IFZlY3RvcjxQbHVnaW4+JiBsb2Fk ZWRQbHVnaW5zKTsKKyAgICBzdGF0aWMgYm9vbCBzaG91bGRVc2VQbHVnaW4oY29uc3QgUGx1Z2lu JiBwbHVnaW4pOwogICAgIHN0YXRpYyBTdHJpbmcgZ2V0TUlNRVR5cGVGb3JFeHRlbnNpb24oY29u c3QgU3RyaW5nJiBleHRlbnNpb24pOwogCiAgICAgVmVjdG9yPFN0cmluZz4gbV9hZGRpdGlvbmFs UGx1Z2luc0RpcmVjdG9yaWVzOwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lu cy9ndGsvUGx1Z2luSW5mb1N0b3JlR3RrLmNwcCBiL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMv Z3RrL1BsdWdpbkluZm9TdG9yZUd0ay5jcHAKaW5kZXggMDRlMzdkYjZmOTNmNjIzMzk2MDAwNmE2 MTNmNzlkZTI4YmM3YTNhOC4uOGE2ZTg2YzNlNGJhOGQ1YjRiYTJlYTUyZjY2OTg1YTJhMzJjYmM0 NSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9ndGsvUGx1Z2luSW5mb1N0 b3JlR3RrLmNwcAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL2d0ay9QbHVnaW5JbmZv U3RvcmVHdGsuY3BwCkBAIC01OCw3ICs1OCw3IEBAIGJvb2wgUGx1Z2luSW5mb1N0b3JlOjpnZXRQ bHVnaW5JbmZvKGNvbnN0IFN0cmluZyYgcGx1Z2luUGF0aCwgUGx1Z2luJiBwbHVnaW4pCiAgICAg cmV0dXJuIGZhbHNlOwogfQogCi1ib29sIFBsdWdpbkluZm9TdG9yZTo6c2hvdWxkVXNlUGx1Z2lu KGNvbnN0IFBsdWdpbiYgcGx1Z2luLCBjb25zdCBWZWN0b3I8UGx1Z2luPiYgbG9hZGVkUGx1Z2lu cykKK2Jvb2wgUGx1Z2luSW5mb1N0b3JlOjpzaG91bGRVc2VQbHVnaW4oY29uc3QgUGx1Z2luJiBw bHVnaW4pCiB7CiAgICAgbm90SW1wbGVtZW50ZWQoKTsKICAgICByZXR1cm4gZmFsc2U7CmRpZmYg LS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL21hYy9QbHVnaW5JbmZvU3RvcmVNYWMu bW0gYi9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL21hYy9QbHVnaW5JbmZvU3RvcmVNYWMubW0K aW5kZXggOTAyZDQyZmZhNzQ3MTUyZWVhMTMxOGVmMmViNzgwYzQ3NmY1ZTk2Ni4uMzYwZDYyOThk OWFiN2VkZjNiMTMwYmVmNzYzNTUzN2RkOWRjNTA1MyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVBy b2Nlc3MvUGx1Z2lucy9tYWMvUGx1Z2luSW5mb1N0b3JlTWFjLm1tCisrKyBiL1dlYktpdDIvVUlQ cm9jZXNzL1BsdWdpbnMvbWFjL1BsdWdpbkluZm9TdG9yZU1hYy5tbQpAQCAtMzYwLDEwICszNjAs MTAgQEAgYm9vbCBQbHVnaW5JbmZvU3RvcmU6OmdldFBsdWdpbkluZm8oY29uc3QgU3RyaW5nJiBw bHVnaW5QYXRoLCBQbHVnaW4mIHBsdWdpbikKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotYm9vbCBQ bHVnaW5JbmZvU3RvcmU6OnNob3VsZFVzZVBsdWdpbihjb25zdCBQbHVnaW4mIHBsdWdpbiwgY29u c3QgVmVjdG9yPFBsdWdpbj4mIGxvYWRlZFBsdWdpbnMpCitib29sIFBsdWdpbkluZm9TdG9yZTo6 c2hvdWxkVXNlUGx1Z2luKGNvbnN0IFBsdWdpbiYgcGx1Z2luKQogewotICAgIGZvciAoc2l6ZV90 IGkgPSAwOyBpIDwgbG9hZGVkUGx1Z2lucy5zaXplKCk7ICsraSkgewotICAgICAgICBjb25zdCBQ bHVnaW4mIGxvYWRlZFBsdWdpbiA9IGxvYWRlZFBsdWdpbnNbaV07CisgICAgZm9yIChzaXplX3Qg aSA9IDA7IGkgPCBtX3BsdWdpbnMuc2l6ZSgpOyArK2kpIHsKKyAgICAgICAgY29uc3QgUGx1Z2lu JiBsb2FkZWRQbHVnaW4gPSBtX3BsdWdpbnNbaV07CiAKICAgICAgICAgLy8gSWYgYSBwbHVnLWlu IHdpdGggdGhlIHNhbWUgYnVuZGxlIGlkZW50aWZpZXIgYWxyZWFkeSBleGlzdHMsIHdlIGRvbid0 IHdhbnQgdG8gbG9hZCBpdC4KICAgICAgICAgaWYgKGxvYWRlZFBsdWdpbi5idW5kbGVJZGVudGlm aWVyID09IHBsdWdpbi5idW5kbGVJZGVudGlmaWVyKQpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVBy b2Nlc3MvUGx1Z2lucy9xdC9QbHVnaW5JbmZvU3RvcmVRdC5jcHAgYi9XZWJLaXQyL1VJUHJvY2Vz cy9QbHVnaW5zL3F0L1BsdWdpbkluZm9TdG9yZVF0LmNwcAppbmRleCAyNWRjMGY3MDRjNmEzODlj MmZjMDUxNjVmM2Q5ZDU2YzhiZGE4YzUyLi5iMmM1MDNjN2I3MjFjNGU1OTRlYmI3NTQ5NzAwY2Q2 YmFhM2MyMzVkIDEwMDY0NAotLS0gYS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3F0L1BsdWdp bkluZm9TdG9yZVF0LmNwcAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3F0L1BsdWdp bkluZm9TdG9yZVF0LmNwcApAQCAtODksNyArODksNyBAQCBib29sIFBsdWdpbkluZm9TdG9yZTo6 Z2V0UGx1Z2luSW5mbyhjb25zdCBTdHJpbmcmIHBsdWdpblBhdGgsIFBsdWdpbiYgcGx1Z2luKQog ICAgIHJldHVybiB0cnVlOwogfQogCi1ib29sIFBsdWdpbkluZm9TdG9yZTo6c2hvdWxkVXNlUGx1 Z2luKGNvbnN0IFBsdWdpbiYgcGx1Z2luLCBjb25zdCBWZWN0b3I8UGx1Z2luPiYgbG9hZGVkUGx1 Z2lucykKK2Jvb2wgUGx1Z2luSW5mb1N0b3JlOjpzaG91bGRVc2VQbHVnaW4oY29uc3QgUGx1Z2lu JiBwbHVnaW4pCiB7CiAgICAgLy8gV2UgZG8gbm90IGRvIGFueSBibGFjay1saXN0aW5nIHByZXNl bnRseS4KICAgICByZXR1cm4gdHJ1ZTsKZGlmZiAtLWdpdCBhL1dlYktpdDIvVUlQcm9jZXNzL1Bs dWdpbnMvd2luL1BsdWdpbkluZm9TdG9yZVdpbi5jcHAgYi9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVn aW5zL3dpbi9QbHVnaW5JbmZvU3RvcmVXaW4uY3BwCmluZGV4IGQ1YWUwMzc2ODNkZDUyYjhmNzM3 ZGNmOWQ1M2MwZTc4OTAyY2ZiZmEuLjhlYjg2MGViY2NhOTRlYTZjNDZmNWVkODNkNjcxODM3ZTAx YTkwMTUgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvd2luL1BsdWdpbklu Zm9TdG9yZVdpbi5jcHAKKysrIGIvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy93aW4vUGx1Z2lu SW5mb1N0b3JlV2luLmNwcApAQCAtNDA2LDcgKzQwNiw3IEBAIGJvb2wgUGx1Z2luSW5mb1N0b3Jl OjpnZXRQbHVnaW5JbmZvKGNvbnN0IFN0cmluZyYgcGx1Z2luUGF0aCwgUGx1Z2luJiBwbHVnaW4p CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLWJvb2wgUGx1Z2luSW5mb1N0b3JlOjpzaG91bGRVc2VQ bHVnaW4oY29uc3QgUGx1Z2luJiBwbHVnaW4sIGNvbnN0IFZlY3RvcjxQbHVnaW4+JiBsb2FkZWRQ bHVnaW5zKQorYm9vbCBQbHVnaW5JbmZvU3RvcmU6OnNob3VsZFVzZVBsdWdpbihjb25zdCBQbHVn aW4mIHBsdWdpbikKIHsKICAgICAvLyBGSVhNRTogPGh0dHA6Ly93ZWJraXQub3JnL2IvNDM1MDk+ IE1pZ3JhdGUgbG9naWMgaGVyZSBmcm9tCiAgICAgLy8gUGx1Z2luRGF0YWJhc2U6OmdldFBsdWdp blBhdGhzSW5EaXJlY3RvcmllcyBhbmQgUGx1Z2luUGFja2FnZTo6aXNQbHVnaW5CbGFja2xpc3Rl ZC4K