49047 2010-11-04 18:52:03 -0700 [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar 2010-11-09 10:55:15 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P3 Enhancement --- 0 max.hong.shen webkit-unassigned commit-queue kling oldest_to_newest 305093 0 max.hong.shen 2010-11-04 18:52:03 -0700 if loading some wrong url (e.g. file:///adfsadfsdfx), the browser fails and changes the url in the urlbar to 'about:blank'. It is very annoying that you have to enter the whole url again, especially when using the qttestbrowser for testing on a cellphone -- VKB is typo-prone and too slow. It might be better for always displaying the wrong url when loading fails, then user can fix the typo instead of reentering a long url. 305096 1 73029 max.hong.shen 2010-11-04 18:54:55 -0700 Created attachment 73029 first try 305425 2 73093 max.hong.shen 2010-11-05 11:45:08 -0700 Created attachment 73093 updated 306859 3 73093 kling 2010-11-09 10:21:08 -0800 Comment on attachment 73093 updated Nice to get rid of this itch, r=me 306874 4 73093 commit-queue 2010-11-09 10:55:10 -0800 Comment on attachment 73093 updated Clearing flags on attachment: 73093 Committed r71649: <http://trac.webkit.org/changeset/71649> 306875 5 commit-queue 2010-11-09 10:55:15 -0800 All reviewed patches have been landed. Closing bug. 73029 2010-11-04 18:54:55 -0700 2010-11-05 11:45:08 -0700 first try 49047.patch text/plain 1297 max.hong.shen SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcxMzc4KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMDQgIFlpIFNoZW4gIDx5aS40LnNo ZW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF1bUXRUZXN0QnJvd3Nlcl0gRG9uJ3QgZXJhc2UgaW5jb3JyZWN0IHVybCBpbiB0 aGUgVXJsIEJhcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDkwNDcKKworICAgICAgICAqIFF0VGVzdEJyb3dzZXIvbWFpbndpbmRvdy5jcHA6CisgICAg ICAgIChNYWluV2luZG93OjpzZXRBZGRyZXNzVXJsKToKKwogMjAxMC0xMS0wNCAgTWloYWkgUGFy cGFyaXRhICA8bWloYWlwQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGZpeCB0 byB3ZWJraXQtcGF0Y2ggcmViYXNlbGluZS1zZXJ2ZXIgc28gdGhhdCBpdCBydW5zIHVuZGVyCklu ZGV4OiBXZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL21haW53aW5kb3cuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvbWFpbndpbmRvdy5jcHAJKHJldmlzaW9uIDcx MzczKQorKysgV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9tYWlud2luZG93LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTE2LDEyICsxMTYsMTMgQEAgV2ViUGFnZSogTWFpbldpbmRvdzo6cGFnZSgp IGNvbnN0CiAKIHZvaWQgTWFpbldpbmRvdzo6c2V0QWRkcmVzc1VybChjb25zdCBRVXJsJiB1cmwp CiB7Ci0gICAgdXJsRWRpdC0+c2V0VGV4dCh1cmwudG9TdHJpbmcoUVVybDo6UmVtb3ZlVXNlcklu Zm8pKTsKKyAgICBzZXRBZGRyZXNzVXJsKHVybC50b1N0cmluZyhRVXJsOjpSZW1vdmVVc2VySW5m bykpOwogfQogCiB2b2lkIE1haW5XaW5kb3c6OnNldEFkZHJlc3NVcmwoY29uc3QgUVN0cmluZyYg dXJsKQogewotICAgIHVybEVkaXQtPnNldFRleHQodXJsKTsKKyAgICBpZiAodXJsICE9ICJhYm91 dDpibGFuayIpCisgICAgICAgIHVybEVkaXQtPnNldFRleHQodXJsKTsKIH0KIAogdm9pZCBNYWlu V2luZG93OjphZGRDb21wbGV0ZXJFbnRyeShjb25zdCBRVXJsJiB1cmwpCg== 73093 2010-11-05 11:45:08 -0700 2010-11-09 10:55:10 -0800 updated 49047.patch text/plain 1271 max.hong.shen SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcxNDMyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMDUgIFlpIFNoZW4gIDx5aS40LnNo ZW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF1bUXRUZXN0QnJvd3Nlcl0gRG9uJ3QgZXJhc2UgaW5jb3JyZWN0IHVybCBpbiB0 aGUgVXJsIEJhcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDkwNDcKKworICAgICAgICAqIFF0VGVzdEJyb3dzZXIvbWFpbndpbmRvdy5jcHA6CisgICAg ICAgIChNYWluV2luZG93OjpzZXRBZGRyZXNzVXJsKToKKwogMjAxMC0xMS0wNCAgQWRhbSBSb2Jl biAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgVGVhY2ggY2hlY2std2Via2l0LXN0eWxl IGFib3V0IFRlc3ROZXRzY2FwZVBsdWdJbgpJbmRleDogV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nl ci9tYWlud2luZG93LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9RdFRlc3RCcm93c2Vy L21haW53aW5kb3cuY3BwCShyZXZpc2lvbiA3MTQzMSkKKysrIFdlYktpdFRvb2xzL1F0VGVzdEJy b3dzZXIvbWFpbndpbmRvdy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNiwxMiArMTE2LDEzIEBA IFdlYlBhZ2UqIE1haW5XaW5kb3c6OnBhZ2UoKSBjb25zdAogCiB2b2lkIE1haW5XaW5kb3c6OnNl dEFkZHJlc3NVcmwoY29uc3QgUVVybCYgdXJsKQogewotICAgIHVybEVkaXQtPnNldFRleHQodXJs LnRvU3RyaW5nKFFVcmw6OlJlbW92ZVVzZXJJbmZvKSk7CisgICAgc2V0QWRkcmVzc1VybCh1cmwu dG9TdHJpbmcoUVVybDo6UmVtb3ZlVXNlckluZm8pKTsKIH0KIAogdm9pZCBNYWluV2luZG93Ojpz ZXRBZGRyZXNzVXJsKGNvbnN0IFFTdHJpbmcmIHVybCkKIHsKLSAgICB1cmxFZGl0LT5zZXRUZXh0 KHVybCk7CisgICAgaWYgKCF1cmwuY29udGFpbnMoImFib3V0OiIpKQorICAgICAgICB1cmxFZGl0 LT5zZXRUZXh0KHVybCk7CiB9CiAKIHZvaWQgTWFpbldpbmRvdzo6YWRkQ29tcGxldGVyRW50cnko Y29uc3QgUVVybCYgdXJsKQo=