49036 2010-11-04 16:02:04 -0700 [chromium] fix getintidentifier-special-values.html using TestNetscapePlugIn 2010-11-30 15:56:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 49710 1 tony tony abarth dglazkov fishd jam levin stuartmorgan oldest_to_newest 304961 0 tony 2010-11-04 16:02:04 -0700 [chromium] fix getintidentifier-special-values.html using TestNetscapePlugIn 304971 1 73000 tony 2010-11-04 16:08:59 -0700 Created attachment 73000 Patch 304980 2 tony 2010-11-04 16:15:28 -0700 I talked to Ananta about this and he can't remember exactly why this change was needed. The test cases in the bug tracker are no longer valid because the sites mentioned (microsoft.com and msdn.microsoft.com) no longer use silverlight. I manually tested the following: - http://joel.neubeck.net/2008/06/sl2b2-media-player-markers/ - a few sites linked from silverlight.net - netflix streaming 307005 3 tony 2010-11-09 14:51:32 -0800 Maybe jam or stuart can review this? I'm not sure who owns this code these days. 307016 4 stuartmorgan 2010-11-09 15:06:42 -0800 I'm not familiar with this code, so I'm probably not a good reviewer. Does this test failing mean that Apple's WebKit returns a double? If so, I'm fine with this from the Mac standpoint certainly, but if both Gecko and Safari return ints this seems like it would be a dangerous change. 307021 5 tony 2010-11-09 15:12:21 -0800 (In reply to comment #4) > I'm not familiar with this code, so I'm probably not a good reviewer. > > Does this test failing mean that Apple's WebKit returns a double? If so, I'm fine with this from the Mac standpoint certainly, but if both Gecko and Safari return ints this seems like it would be a dangerous change. Safari returns a double and Firefox returns an int. We originally were matching Firefox, but this change makes us match Safari since it doesn't seem to be necessary anymore. 307022 6 stuartmorgan 2010-11-09 15:14:29 -0800 As long as we're matching something else I'm fine with this. I mostly deal with the Mac though, where matching Safari is pretty much a guarantee existing plugins will work ;) 310451 7 tony 2010-11-17 12:36:08 -0800 Can someone review this? dglazkov? fishd? 310457 8 jam 2010-11-17 12:42:57 -0800 sorry just saw this. I'm not a WebKit reviewer. I'm also not sure why the code is like that. if it doesn't break any tests, try it :) 310509 9 73000 abarth 2010-11-17 14:00:47 -0800 Comment on attachment 73000 Patch If JAM is ok with this change, it's fine with me. 310523 10 tony 2010-11-17 14:16:42 -0800 Committed r72243: <http://trac.webkit.org/changeset/72243> 310690 11 levin 2010-11-17 20:51:09 -0800 Rolled out here: http://trac.webkit.org/changeset/72271 Seemed to cause a large set of Chromium layout tests to start failing. 310694 12 73000 levin 2010-11-17 20:59:45 -0800 Comment on attachment 73000 Patch Clearing r+ on bad patch and marking obsolete. We just went from 103 layout test failures on Win to 3 with this rolled out! 311064 13 74285 tony 2010-11-18 13:23:35 -0800 Created attachment 74285 Patch 311067 14 tony 2010-11-18 13:27:01 -0800 (In reply to comment #11) > Rolled out here: http://trac.webkit.org/changeset/72271 > > Seemed to cause a large set of Chromium layout tests to start failing. Sorry about that! I didn't realize this change could cause non-plugin tests to fail. Turns out our C++ bindings uses NPObject. This patch fixes the calls in DRT and http://codereview.chromium.org/5209004/ fixes the calls in test_shell. 312446 15 74581 tony 2010-11-22 11:57:45 -0800 Created attachment 74581 Patch 312449 16 tony 2010-11-22 11:59:28 -0800 (In reply to comment #15) > Created an attachment (id=74581) [details] > Patch Updated to include drt_expectations.txt update since I've switched DRT to using the upstream TestNetscapePlugIn. Adam, can you review? The analogous change to test_shell went in here: http://codereview.chromium.org/5209004/ 314636 17 74581 abarth 2010-11-29 14:13:11 -0800 Comment on attachment 74581 Patch Yay for testing. :) 315367 18 tony 2010-11-30 15:56:04 -0800 Committed r72974: <http://trac.webkit.org/changeset/72974> 73000 2010-11-04 16:08:59 -0700 2010-11-17 20:59:45 -0800 Patch bug-49036-20101104160928.patch text/plain 2049 tony ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTBmODJmZTk5MjA2ZjkzMjE1MTFmYjE4OTFjZDc5NzE5NzlhNDU3Mi4uMzM0Y2Y0MDFlYjA0ZGRk ZTEzNGZjZTJkZDY2MjE5NDUyMmZlZjdmYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMC0xMS0wNCAgVG9u eSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gZml4IGdldC1pbnQtaWRlbnRpZmllci1z cGVjaWFsLXZhbHVlcy5odG1sIHVzaW5nIFRlc3ROZXRzY2FwZVBsdWdJbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkwMzYKKworICAgICAgICBObyBu ZXcgdGVzdHM6IENvdmVyZWQgYnkgcGx1Z2lucy9ucHJ1bnRpbWUvZ2V0LWludC1pZGVudGlmaWVy LXNwZWNpYWwtdmFsdWVzLmh0bWwKKworICAgICAgICBJbiBodHRwOi8vY29kZXJldmlldy5jaHJv bWl1bS5vcmcvMTE1NzQsIHRoZSBmb3JrZWQgY2hyb21pdW0gdGVzdAorICAgICAgICBwbHVnaW4g Y2hhbmdlZCBob3cgaXQgdGVzdEdldEludElkZW50aWZpZXIgdG8gd29yayBhcm91bmQgYSBjaGFu Z2UKKyAgICAgICAgY2F1c2VkIGJ5IGEgc2lsdmVybGlnaHQgc3BlY2lmaWMgcGx1Z2luIGZpeDoK KyAgICAgICAgaHR0cDovL2NvZGVyZXZpZXcuY2hyb21pdW0ub3JnLzExNTY5L2RpZmYvMS8yCisK KyAgICAgICAgSXQncyBub3QgY2xlYXIgdG8gbWUgdGhhdCB0aGlzIGNoYW5nZSBpcyBuZWVkZWQg YW55bW9yZSBzaW5jZQorICAgICAgICBzaWx2ZXJsaWdodCBoYXMgaGFkIG11bHRpcGxlIHJlbGVh c2VzLCB0ZXN0aW5nIHdpdGhvdXQgdGhpcyBwYXRjaAorICAgICAgICB3b3JrcyBvbiBhIHRlc3Qg d2luZG93cyBidWlsZCwgYW5kIHNhZmFyaSB3aW4gc2VlbXMgdG8gcnVuIHNpbHZlcmxpZ2h0Cisg ICAgICAgIHdpdGhvdXQgdGhpcyBlaXRoZXIuICBTaW5jZSB0aGVyZSdzIG5vIHRlc3QgZm9yIHRo aXMgYmVoYXZpb3IsIEknbQorICAgICAgICByb2xsaW5nIGl0IG91dCBzbyB3ZSBjYW4gbWF0Y2gg dGhlIHVwc3RyZWFtIHRlc3QuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOE5QVXRpbHMuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Y29udmVydFY4T2JqZWN0VG9OUFZhcmlhbnQpOgorCiAyMDEw LTExLTA0ICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhO UFV0aWxzLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhOUFV0aWxzLmNwcAppbmRleCA4ZmEx OWQ3YWFlZTU5ZmMwZDk3NzgzNWVmYzNhNzUyNjJiZTBjZjI3Li42NWMzMGEwOTE0MTAxZGYwZDcz NWRmZWRjN2IyMTYyNWI0NDk3MzRiIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 TlBVdGlscy5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOE5QVXRpbHMuY3BwCkBAIC01 Myw5ICs1Myw3IEBAIHZvaWQgY29udmVydFY4T2JqZWN0VG9OUFZhcmlhbnQodjg6OkxvY2FsPHY4 OjpWYWx1ZT4gb2JqZWN0LCBOUE9iamVjdCogb3duZXIsIE5QCiAgICAgaWYgKG9iamVjdC5Jc0Vt cHR5KCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmIChvYmplY3QtPklzSW50MzIoKSkKLSAg ICAgICAgSU5UMzJfVE9fTlBWQVJJQU5UKG9iamVjdC0+TnVtYmVyVmFsdWUoKSwgKnJlc3VsdCk7 Ci0gICAgZWxzZSBpZiAob2JqZWN0LT5Jc051bWJlcigpKQorICAgIGlmIChvYmplY3QtPklzTnVt YmVyKCkpCiAgICAgICAgIERPVUJMRV9UT19OUFZBUklBTlQob2JqZWN0LT5OdW1iZXJWYWx1ZSgp LCAqcmVzdWx0KTsKICAgICBlbHNlIGlmIChvYmplY3QtPklzQm9vbGVhbigpKQogICAgICAgICBC T09MRUFOX1RPX05QVkFSSUFOVChvYmplY3QtPkJvb2xlYW5WYWx1ZSgpLCAqcmVzdWx0KTsK 74285 2010-11-18 13:23:35 -0800 2010-11-22 11:57:41 -0800 Patch bug-49036-20101118132412.patch text/plain 5515 tony ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjhlOWEzMjdlNjk2YzZlODQyYTRkZjVmYzUwMDE3MjEwZjc1MTU2Ny4uZTU3YzM1YjBkMDgzZmUx MTkzYTkzZDA3ZDY4MDkxNTU0ZmM1MzIwMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMC0xMS0xOCAgVG9u eSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gZml4IGdldC1pbnQtaWRlbnRpZmllci1z cGVjaWFsLXZhbHVlcy5odG1sIHVzaW5nIFRlc3ROZXRzY2FwZVBsdWdJbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkwMzYKKworICAgICAgICBObyBu ZXcgdGVzdHM6IENvdmVyZWQgYnkgcGx1Z2lucy9ucHJ1bnRpbWUvZ2V0LWludC1pZGVudGlmaWVy LXNwZWNpYWwtdmFsdWVzLmh0bWwKKworICAgICAgICBJbiBodHRwOi8vY29kZXJldmlldy5jaHJv bWl1bS5vcmcvMTE1NzQsIHRoZSBmb3JrZWQgY2hyb21pdW0gdGVzdAorICAgICAgICBwbHVnaW4g Y2hhbmdlZCBob3cgaXQgdGVzdEdldEludElkZW50aWZpZXIgdG8gd29yayBhcm91bmQgYSBjaGFu Z2UKKyAgICAgICAgY2F1c2VkIGJ5IGEgc2lsdmVybGlnaHQgc3BlY2lmaWMgcGx1Z2luIGZpeDoK KyAgICAgICAgaHR0cDovL2NvZGVyZXZpZXcuY2hyb21pdW0ub3JnLzExNTY5L2RpZmYvMS8yCisK KyAgICAgICAgSXQncyBub3QgY2xlYXIgdG8gbWUgdGhhdCB0aGlzIGNoYW5nZSBpcyBuZWVkZWQg YW55bW9yZSBzaW5jZQorICAgICAgICBzaWx2ZXJsaWdodCBoYXMgaGFkIG11bHRpcGxlIHJlbGVh c2VzLCB0ZXN0aW5nIHdpdGhvdXQgdGhpcyBwYXRjaAorICAgICAgICB3b3JrcyBvbiBhIHRlc3Qg d2luZG93cyBidWlsZCwgYW5kIHNhZmFyaSB3aW4gc2VlbXMgdG8gcnVuIHNpbHZlcmxpZ2h0Cisg ICAgICAgIHdpdGhvdXQgdGhpcyBlaXRoZXIuICBTaW5jZSB0aGVyZSdzIG5vIHRlc3QgZm9yIHRo aXMgYmVoYXZpb3IsIEknbQorICAgICAgICByb2xsaW5nIGl0IG91dCBzbyB3ZSBjYW4gbWF0Y2gg dGhlIHVwc3RyZWFtIHRlc3QuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOE5QVXRpbHMuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Y29udmVydFY4T2JqZWN0VG9OUFZhcmlhbnQpOgorCiAyMDEw LTExLTE4ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOE5QVXRpbHMuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOE5QVXRpbHMuY3BwCmluZGV4 IDhmYTE5ZDdhYWVlNTlmYzBkOTc3ODM1ZWZjM2E3NTI2MmJlMGNmMjcuLjY1YzMwYTA5MTQxMDFk ZjBkNzM1ZGZlZGM3YjIxNjI1YjQ0OTczNGIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhOUFV0aWxzLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4TlBVdGlscy5jcHAK QEAgLTUzLDkgKzUzLDcgQEAgdm9pZCBjb252ZXJ0VjhPYmplY3RUb05QVmFyaWFudCh2ODo6TG9j YWw8djg6OlZhbHVlPiBvYmplY3QsIE5QT2JqZWN0KiBvd25lciwgTlAKICAgICBpZiAob2JqZWN0 LklzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKG9iamVjdC0+SXNJbnQzMigp KQotICAgICAgICBJTlQzMl9UT19OUFZBUklBTlQob2JqZWN0LT5OdW1iZXJWYWx1ZSgpLCAqcmVz dWx0KTsKLSAgICBlbHNlIGlmIChvYmplY3QtPklzTnVtYmVyKCkpCisgICAgaWYgKG9iamVjdC0+ SXNOdW1iZXIoKSkKICAgICAgICAgRE9VQkxFX1RPX05QVkFSSUFOVChvYmplY3QtPk51bWJlclZh bHVlKCksICpyZXN1bHQpOwogICAgIGVsc2UgaWYgKG9iamVjdC0+SXNCb29sZWFuKCkpCiAgICAg ICAgIEJPT0xFQU5fVE9fTlBWQVJJQU5UKG9iamVjdC0+Qm9vbGVhblZhbHVlKCksICpyZXN1bHQp OwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdl TG9nCmluZGV4IGFjN2RmNTM5N2FmZjFjM2IwNTAyNDM3ZmIyMjNhZDBkNTRkMjVlN2MuLjljMzA2 OGFmMTUwYmRjMDZjNWViZDlmYTc1ZjlkYmYzNzRmZWUxZmEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRv b2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBA QAorMjAxMC0xMS0xOCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gZml4IGdl dC1pbnQtaWRlbnRpZmllci1zcGVjaWFsLXZhbHVlcy5odG1sIHVzaW5nIFRlc3ROZXRzY2FwZVBs dWdJbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkw MzYKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9s bGVyLmNwcDogVXNlIElzTnVtYmVyIGluc3RlYWQgb2YgSXNJbnQzMgorICAgICAgICAgICAgZm9y IENwcFZhcmlhbnRzLgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OmNwcFZhcmlhbnRU b0Jvb2wpOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OmNwcFZhcmlhbnRUb0ludDMy KToKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpzZXREYXRhYmFzZVF1b3RhKToKKyAg ICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpldmFsdWF0ZUluV2ViSW5zcGVjdG9yKToKKyAg ICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpzZXRNb2NrR2VvbG9jYXRpb25FcnJvcik6CisK IDIwMTAtMTEtMTggIFN0ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwIGIvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCmluZGV4 IDg1YjJkY2U1ZjVmNDczYWE4NTY5MDE2NWI2MzRkMzY4Nzc1YzY5MDguLjk2MDgzNzdkYjFjYmNm NzJkMTYxZmNhZWU4NmJkMGZmYTg1YTE0MjcgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAorKysgYi9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAKQEAg LTExNzQsNyArMTE3NCw3IEBAIGJvb2wgTGF5b3V0VGVzdENvbnRyb2xsZXI6OmNwcFZhcmlhbnRU b0Jvb2woY29uc3QgQ3BwVmFyaWFudCYgdmFsdWUpCiB7CiAgICAgaWYgKHZhbHVlLmlzQm9vbCgp KQogICAgICAgICByZXR1cm4gdmFsdWUudG9Cb29sZWFuKCk7Ci0gICAgaWYgKHZhbHVlLmlzSW50 MzIoKSkKKyAgICBpZiAodmFsdWUuaXNOdW1iZXIoKSkKICAgICAgICAgcmV0dXJuIHZhbHVlLnRv SW50MzIoKTsKICAgICBpZiAodmFsdWUuaXNTdHJpbmcoKSkgewogICAgICAgICBzdHJpbmcgdmFs dWVTdHJpbmcgPSB2YWx1ZS50b1N0cmluZygpOwpAQCAtMTE4OSw3ICsxMTg5LDcgQEAgYm9vbCBM YXlvdXRUZXN0Q29udHJvbGxlcjo6Y3BwVmFyaWFudFRvQm9vbChjb25zdCBDcHBWYXJpYW50JiB2 YWx1ZSkKIAogaW50MzJfdCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6Y3BwVmFyaWFudFRvSW50MzIo Y29uc3QgQ3BwVmFyaWFudCYgdmFsdWUpCiB7Ci0gICAgaWYgKHZhbHVlLmlzSW50MzIoKSkKKyAg ICBpZiAodmFsdWUuaXNOdW1iZXIoKSkKICAgICAgICAgcmV0dXJuIHZhbHVlLnRvSW50MzIoKTsK ICAgICBpZiAodmFsdWUuaXNTdHJpbmcoKSkgewogICAgICAgICBzdHJpbmcgc3RyaW5nU291cmNl ID0gdmFsdWUudG9TdHJpbmcoKTsKQEAgLTEzNDIsNyArMTM0Miw3IEBAIHZvaWQgTGF5b3V0VGVz dENvbnRyb2xsZXI6OmNsZWFyQWxsRGF0YWJhc2VzKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJn dW1lbnRzLCBDCiB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXREYXRhYmFzZVF1b3RhKGNv bnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBDcHBWYXJpYW50KiByZXN1bHQpCiB7CiAg ICAgcmVzdWx0LT5zZXROdWxsKCk7Ci0gICAgaWYgKChhcmd1bWVudHMuc2l6ZSgpID49IDEpICYm IGFyZ3VtZW50c1swXS5pc0ludDMyKCkpCisgICAgaWYgKChhcmd1bWVudHMuc2l6ZSgpID49IDEp ICYmIGFyZ3VtZW50c1swXS5pc051bWJlcigpKQogICAgICAgICB3ZWJraXRfc3VwcG9ydDo6U2V0 RGF0YWJhc2VRdW90YShhcmd1bWVudHNbMF0udG9JbnQzMigpKTsKIH0KIApAQCAtMTQ0NCw3ICsx NDQ0LDcgQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0VGltZWxpbmVQcm9maWxpbmdF bmFibGVkKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXIKIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xs ZXI6OmV2YWx1YXRlSW5XZWJJbnNwZWN0b3IoY29uc3QgQ3BwQXJndW1lbnRMaXN0JiBhcmd1bWVu dHMsIENwcFZhcmlhbnQqIHJlc3VsdCkKIHsKICAgICByZXN1bHQtPnNldE51bGwoKTsKLSAgICBp ZiAoYXJndW1lbnRzLnNpemUoKSA8IDIgfHwgIWFyZ3VtZW50c1swXS5pc0ludDMyKCkgfHwgIWFy Z3VtZW50c1sxXS5pc1N0cmluZygpKQorICAgIGlmIChhcmd1bWVudHMuc2l6ZSgpIDwgMiB8fCAh YXJndW1lbnRzWzBdLmlzTnVtYmVyKCkgfHwgIWFyZ3VtZW50c1sxXS5pc1N0cmluZygpKQogICAg ICAgICByZXR1cm47CiAgICAgbV9zaGVsbC0+ZHJ0RGV2VG9vbHNBZ2VudCgpLT5ldmFsdWF0ZUlu V2ViSW5zcGVjdG9yKGFyZ3VtZW50c1swXS50b0ludDMyKCksIGFyZ3VtZW50c1sxXS50b1N0cmlu ZygpKTsKIH0KQEAgLTE1MjcsNyArMTUyNyw3IEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6 OnNldE1vY2tHZW9sb2NhdGlvblBvc2l0aW9uKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJnCiB2 b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRNb2NrR2VvbG9jYXRpb25FcnJvcihjb25zdCBD cHBBcmd1bWVudExpc3QmIGFyZ3VtZW50cywgQ3BwVmFyaWFudCogcmVzdWx0KQogewogICAgIHJl c3VsdC0+c2V0TnVsbCgpOwotICAgIGlmIChhcmd1bWVudHMuc2l6ZSgpIDwgMiB8fCAhYXJndW1l bnRzWzBdLmlzSW50MzIoKSB8fCAhYXJndW1lbnRzWzFdLmlzU3RyaW5nKCkpCisgICAgaWYgKGFy Z3VtZW50cy5zaXplKCkgPCAyIHx8ICFhcmd1bWVudHNbMF0uaXNOdW1iZXIoKSB8fCAhYXJndW1l bnRzWzFdLmlzU3RyaW5nKCkpCiAgICAgICAgIHJldHVybjsKICAgICBXZWJHZW9sb2NhdGlvblNl cnZpY2VNb2NrOjpzZXRNb2NrR2VvbG9jYXRpb25FcnJvcihhcmd1bWVudHNbMF0udG9JbnQzMigp LCBjcHBWYXJpYW50VG9XZWJTdHJpbmcoYXJndW1lbnRzWzFdKSk7CiB9Cg== 74581 2010-11-22 11:57:45 -0800 2010-11-29 14:13:11 -0800 Patch bug-49036-20101122115825.patch text/plain 6388 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2RydF9leHBlY3RhdGlv bnMudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZHJ0X2V4cGVjdGF0aW9ucy50 eHQKaW5kZXggYzIxZDk1ZmM2Y2I0YWYwODAyMTRjOWMxMjQwYjdhZjhkNGI0ZWJiZC4uNjY3MDZl ZDE1ZDA5YTY1Yjc3NWFlNDhkZmUzYTAwYjg0MDBjMWY3NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vZHJ0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vZHJ0X2V4cGVjdGF0aW9ucy50eHQKQEAgLTg0LDcgKzg0LDYg QEAgQlVHX0RSVCBXSU4gOiBwbHVnaW5zL2ludmFsaWQtbWltZS13aXRoLXZhbGlkLWV4dGVuc2lv bi1zaG93cy1taXNzaW5nLXBsdWdpbi5odG0KIEJVR1dLNDg2NTUgOiBwbHVnaW5zL2pzLWZyb20t ZGVzdHJveS5odG1sID0gQ1JBU0gKIEJVR19EUlQgV0lOIDogcGx1Z2lucy9tb3VzZS1ldmVudHMu aHRtbCA9IFRFWFQKIEJVR19EUlQgV0lOIDogcGx1Z2lucy9tb3VzZS1ldmVudHMtZml4ZWRwb3Mu aHRtbCA9IFBBU1MKLUJVR1dLNDkwMzYgOiBwbHVnaW5zL25wcnVudGltZS9nZXQtaW50LWlkZW50 aWZpZXItc3BlY2lhbC12YWx1ZXMuaHRtbCA9IFRFWFQKIEJVR19EUlQgOiBwbHVnaW5zL25wcnVu dGltZS9yb3VuZC10cmlwLW5wb2JqZWN0Lmh0bWwgPSBQQVNTCiBCVUdfRFJUIE1BQyA6IHBsdWdp bnMvb3Blbi1hbmQtY2xvc2Utd2luZG93LXdpdGgtcGx1Z2luLmh0bWwgPSBURVhUCiBCVUdfRFJU IDogcGx1Z2lucy9vdmVycmlkZS1ub2RlLW1ldGhvZC5odG1sID0gUEFTUwpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkYmRiMWI3NzM0YjBi ZjYwMTg2ZTg3YTkxYzE1ODMyMjRiMGZmYjViLi43YTg1Y2FiYjU3NjFhNGY0NjA3YmZmNDc0MTMw OTFkYmQ1NzU0NTZkIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEwLTExLTIyICBUb255IENoYW5nICA8dG9u eUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW2Nocm9taXVtXSBmaXggZ2V0LWludC1pZGVudGlmaWVyLXNwZWNpYWwtdmFsdWVz Lmh0bWwgdXNpbmcgVGVzdE5ldHNjYXBlUGx1Z0luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTAzNgorCisgICAgICAgIE5vIG5ldyB0ZXN0czogQ292 ZXJlZCBieSBwbHVnaW5zL25wcnVudGltZS9nZXQtaW50LWlkZW50aWZpZXItc3BlY2lhbC12YWx1 ZXMuaHRtbAorCisgICAgICAgIEluIGh0dHA6Ly9jb2RlcmV2aWV3LmNocm9taXVtLm9yZy8xMTU3 NCwgdGhlIGZvcmtlZCBjaHJvbWl1bSB0ZXN0CisgICAgICAgIHBsdWdpbiBjaGFuZ2VkIGhvdyBp dCB0ZXN0R2V0SW50SWRlbnRpZmllciB0byB3b3JrIGFyb3VuZCBhIGNoYW5nZQorICAgICAgICBj YXVzZWQgYnkgYSBzaWx2ZXJsaWdodCBzcGVjaWZpYyBwbHVnaW4gZml4OgorICAgICAgICBodHRw Oi8vY29kZXJldmlldy5jaHJvbWl1bS5vcmcvMTE1NjkvZGlmZi8xLzIKKworICAgICAgICBJdCdz IG5vdCBjbGVhciB0byBtZSB0aGF0IHRoaXMgY2hhbmdlIGlzIG5lZWRlZCBhbnltb3JlIHNpbmNl CisgICAgICAgIHNpbHZlcmxpZ2h0IGhhcyBoYWQgbXVsdGlwbGUgcmVsZWFzZXMsIHRlc3Rpbmcg d2l0aG91dCB0aGlzIHBhdGNoCisgICAgICAgIHdvcmtzIG9uIGEgdGVzdCB3aW5kb3dzIGJ1aWxk LCBhbmQgc2FmYXJpIHdpbiBzZWVtcyB0byBydW4gc2lsdmVybGlnaHQKKyAgICAgICAgd2l0aG91 dCB0aGlzIGVpdGhlci4gIFNpbmNlIHRoZXJlJ3Mgbm8gdGVzdCBmb3IgdGhpcyBiZWhhdmlvciwg SSdtCisgICAgICAgIHJvbGxpbmcgaXQgb3V0IHNvIHdlIGNhbiBtYXRjaCB0aGUgdXBzdHJlYW0g dGVzdC4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4TlBVdGlscy5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpjb252ZXJ0VjhPYmplY3RUb05QVmFyaWFudCk6CisKIDIwMTAtMTEtMjIgIEFsZXhh bmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOE5QVXRp bHMuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOE5QVXRpbHMuY3BwCmluZGV4IDhmYTE5ZDdh YWVlNTlmYzBkOTc3ODM1ZWZjM2E3NTI2MmJlMGNmMjcuLjY1YzMwYTA5MTQxMDFkZjBkNzM1ZGZl ZGM3YjIxNjI1YjQ0OTczNGIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhOUFV0 aWxzLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4TlBVdGlscy5jcHAKQEAgLTUzLDkg KzUzLDcgQEAgdm9pZCBjb252ZXJ0VjhPYmplY3RUb05QVmFyaWFudCh2ODo6TG9jYWw8djg6OlZh bHVlPiBvYmplY3QsIE5QT2JqZWN0KiBvd25lciwgTlAKICAgICBpZiAob2JqZWN0LklzRW1wdHko KSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKG9iamVjdC0+SXNJbnQzMigpKQotICAgICAg ICBJTlQzMl9UT19OUFZBUklBTlQob2JqZWN0LT5OdW1iZXJWYWx1ZSgpLCAqcmVzdWx0KTsKLSAg ICBlbHNlIGlmIChvYmplY3QtPklzTnVtYmVyKCkpCisgICAgaWYgKG9iamVjdC0+SXNOdW1iZXIo KSkKICAgICAgICAgRE9VQkxFX1RPX05QVkFSSUFOVChvYmplY3QtPk51bWJlclZhbHVlKCksICpy ZXN1bHQpOwogICAgIGVsc2UgaWYgKG9iamVjdC0+SXNCb29sZWFuKCkpCiAgICAgICAgIEJPT0xF QU5fVE9fTlBWQVJJQU5UKG9iamVjdC0+Qm9vbGVhblZhbHVlKCksICpyZXN1bHQpOwpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4 IDRhMDE2YzFmMTgxNDU3MTVlOWEwMWEzZDJlZjZjMDUxMzZkYWFiMGYuLjY5Y2IwZDY0ZmJhZTcx ODE0NTFjNTE4ZDE4NzI3ZWQzNTUyNDA5NWYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5n ZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0x MS0yMiAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gZml4IGdldC1pbnQtaWRl bnRpZmllci1zcGVjaWFsLXZhbHVlcy5odG1sIHVzaW5nIFRlc3ROZXRzY2FwZVBsdWdJbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkwMzYKKworICAg ICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcDog VXNlIElzTnVtYmVyIGluc3RlYWQgb2YgSXNJbnQzMgorICAgICAgICAgICAgZm9yIENwcFZhcmlh bnRzLgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OmNwcFZhcmlhbnRUb0Jvb2wpOgor ICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OmNwcFZhcmlhbnRUb0ludDMyKToKKyAgICAg ICAgKExheW91dFRlc3RDb250cm9sbGVyOjpzZXREYXRhYmFzZVF1b3RhKToKKyAgICAgICAgKExh eW91dFRlc3RDb250cm9sbGVyOjpldmFsdWF0ZUluV2ViSW5zcGVjdG9yKToKKyAgICAgICAgKExh eW91dFRlc3RDb250cm9sbGVyOjpzZXRNb2NrR2VvbG9jYXRpb25FcnJvcik6CisKIDIwMTAtMTEt MjIgIEpvw6NvIFBhdWxvIFJlY2hpIFZpdGEgIDxqcHJ2aXRhQHByb2Z1c2lvbi5tb2JpPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xs ZXIuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENv bnRyb2xsZXIuY3BwCmluZGV4IGFkMDQxNzBkOTU5NGE2NjdlZWE5ODViNjFiYjQ3YWYzYjY5YTFm NTkuLmMwZjI0MWE2YjBjMjRkZjhhOTYyZDFiMTU3M2E0ZjcxY2MwNzZlMmIgMTAwNjQ0Ci0tLSBh L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVy LmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0 Q29udHJvbGxlci5jcHAKQEAgLTExNzQsNyArMTE3NCw3IEBAIGJvb2wgTGF5b3V0VGVzdENvbnRy b2xsZXI6OmNwcFZhcmlhbnRUb0Jvb2woY29uc3QgQ3BwVmFyaWFudCYgdmFsdWUpCiB7CiAgICAg aWYgKHZhbHVlLmlzQm9vbCgpKQogICAgICAgICByZXR1cm4gdmFsdWUudG9Cb29sZWFuKCk7Ci0g ICAgaWYgKHZhbHVlLmlzSW50MzIoKSkKKyAgICBpZiAodmFsdWUuaXNOdW1iZXIoKSkKICAgICAg ICAgcmV0dXJuIHZhbHVlLnRvSW50MzIoKTsKICAgICBpZiAodmFsdWUuaXNTdHJpbmcoKSkgewog ICAgICAgICBzdHJpbmcgdmFsdWVTdHJpbmcgPSB2YWx1ZS50b1N0cmluZygpOwpAQCAtMTE4OSw3 ICsxMTg5LDcgQEAgYm9vbCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6Y3BwVmFyaWFudFRvQm9vbChj b25zdCBDcHBWYXJpYW50JiB2YWx1ZSkKIAogaW50MzJfdCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6 Y3BwVmFyaWFudFRvSW50MzIoY29uc3QgQ3BwVmFyaWFudCYgdmFsdWUpCiB7Ci0gICAgaWYgKHZh bHVlLmlzSW50MzIoKSkKKyAgICBpZiAodmFsdWUuaXNOdW1iZXIoKSkKICAgICAgICAgcmV0dXJu IHZhbHVlLnRvSW50MzIoKTsKICAgICBpZiAodmFsdWUuaXNTdHJpbmcoKSkgewogICAgICAgICBz dHJpbmcgc3RyaW5nU291cmNlID0gdmFsdWUudG9TdHJpbmcoKTsKQEAgLTEzNDIsNyArMTM0Miw3 IEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OmNsZWFyQWxsRGF0YWJhc2VzKGNvbnN0IENw cEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBDCiB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpz ZXREYXRhYmFzZVF1b3RhKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBDcHBWYXJp YW50KiByZXN1bHQpCiB7CiAgICAgcmVzdWx0LT5zZXROdWxsKCk7Ci0gICAgaWYgKChhcmd1bWVu dHMuc2l6ZSgpID49IDEpICYmIGFyZ3VtZW50c1swXS5pc0ludDMyKCkpCisgICAgaWYgKChhcmd1 bWVudHMuc2l6ZSgpID49IDEpICYmIGFyZ3VtZW50c1swXS5pc051bWJlcigpKQogICAgICAgICB3 ZWJraXRfc3VwcG9ydDo6U2V0RGF0YWJhc2VRdW90YShhcmd1bWVudHNbMF0udG9JbnQzMigpKTsK IH0KIApAQCAtMTQ0NCw3ICsxNDQ0LDcgQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0 VGltZWxpbmVQcm9maWxpbmdFbmFibGVkKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXIKIHZvaWQg TGF5b3V0VGVzdENvbnRyb2xsZXI6OmV2YWx1YXRlSW5XZWJJbnNwZWN0b3IoY29uc3QgQ3BwQXJn dW1lbnRMaXN0JiBhcmd1bWVudHMsIENwcFZhcmlhbnQqIHJlc3VsdCkKIHsKICAgICByZXN1bHQt PnNldE51bGwoKTsKLSAgICBpZiAoYXJndW1lbnRzLnNpemUoKSA8IDIgfHwgIWFyZ3VtZW50c1sw XS5pc0ludDMyKCkgfHwgIWFyZ3VtZW50c1sxXS5pc1N0cmluZygpKQorICAgIGlmIChhcmd1bWVu dHMuc2l6ZSgpIDwgMiB8fCAhYXJndW1lbnRzWzBdLmlzTnVtYmVyKCkgfHwgIWFyZ3VtZW50c1sx XS5pc1N0cmluZygpKQogICAgICAgICByZXR1cm47CiAgICAgbV9zaGVsbC0+ZHJ0RGV2VG9vbHNB Z2VudCgpLT5ldmFsdWF0ZUluV2ViSW5zcGVjdG9yKGFyZ3VtZW50c1swXS50b0ludDMyKCksIGFy Z3VtZW50c1sxXS50b1N0cmluZygpKTsKIH0KQEAgLTE1MjcsNyArMTUyNyw3IEBAIHZvaWQgTGF5 b3V0VGVzdENvbnRyb2xsZXI6OnNldE1vY2tHZW9sb2NhdGlvblBvc2l0aW9uKGNvbnN0IENwcEFy Z3VtZW50TGlzdCYgYXJnCiB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRNb2NrR2VvbG9j YXRpb25FcnJvcihjb25zdCBDcHBBcmd1bWVudExpc3QmIGFyZ3VtZW50cywgQ3BwVmFyaWFudCog cmVzdWx0KQogewogICAgIHJlc3VsdC0+c2V0TnVsbCgpOwotICAgIGlmIChhcmd1bWVudHMuc2l6 ZSgpIDwgMiB8fCAhYXJndW1lbnRzWzBdLmlzSW50MzIoKSB8fCAhYXJndW1lbnRzWzFdLmlzU3Ry aW5nKCkpCisgICAgaWYgKGFyZ3VtZW50cy5zaXplKCkgPCAyIHx8ICFhcmd1bWVudHNbMF0uaXNO dW1iZXIoKSB8fCAhYXJndW1lbnRzWzFdLmlzU3RyaW5nKCkpCiAgICAgICAgIHJldHVybjsKICAg ICBXZWJHZW9sb2NhdGlvblNlcnZpY2VNb2NrOjpzZXRNb2NrR2VvbG9jYXRpb25FcnJvcihhcmd1 bWVudHNbMF0udG9JbnQzMigpLCBjcHBWYXJpYW50VG9XZWJTdHJpbmcoYXJndW1lbnRzWzFdKSk7 CiB9Cg==