<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>49023</bug_id>
          
          <creation_ts>2010-11-04 14:22:48 -0700</creation_ts>
          <short_desc>RenderFlexibleBox::layoutBlock calls setNeedsLayout(false) while children still have m_needsLayout=true</short_desc>
          <delta_ts>2012-06-21 13:26:34 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>49019</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="James Robinson">jamesr</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>inferno</cc>
    
    <cc>jchaffraix</cc>
    
    <cc>ojan</cc>
    
    <cc>sjl</cc>
    
    <cc>tony</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>304867</commentid>
    <comment_count>0</comment_count>
    <who name="James Robinson">jamesr</who>
    <bug_when>2010-11-04 14:22:48 -0700</bug_when>
    <thetext>The ASSERT()s in https://bugs.webkit.org/show_bug.cgi?id=49019 trigger on fast/flexbox/021.html.  With this render tree:

RenderView 0x3dfa858                   	#document	0x3e03220
  RenderBlock 0x3e003f8                	HTML	0x3e421b0
    RenderBody 0x3e3d578               	BODY	0x3e42240
      RenderBlock 0x3cc9948            	P	0x3e3d6b0
        RenderText 0x3e3e3c8           	#text	0x3e3e340 &quot;You should see a 100x100 green square below.  If you see any red, the test has failed.  This test is checking\nfor visibility:collapse support.&quot;
      RenderFlexibleBox 0x3e3e5f8      	DIV	0x3e3e4b0
*       RenderFlexibleBox 0x3e3ead8    	DIV	0x3e3e840 CLASS=first
        RenderFlexibleBox 0x3e3eff8    	DIV	0x3e3ece0 CLASS=second

RenderFlexibleBox::layoutBlock() on the 0x3e3e5f8 box calls setNeedsLayout(false) on itself while its first child 0x3e3ead8 still has m_needsLayout set to true.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>654813</commentid>
    <comment_count>1</comment_count>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2012-06-21 13:06:11 -0700</bug_when>
    <thetext>This doesn&apos;t reproduce anymore. I don&apos;t know Flexbox enough to pinpoint when it was solved though. Maybe Ojan or Tony know more.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>654830</commentid>
    <comment_count>2</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2012-06-21 13:26:34 -0700</bug_when>
    <thetext>This is for old flexbox.

Not sure off the top of my head. Looking through the commit history maybe https://bugs.webkit.org/show_bug.cgi?id=64842 or https://bugs.webkit.org/show_bug.cgi?id=63776 , but it doesn&apos;t seem that important.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>