49021 2010-11-04 13:28:48 -0700 [chromium] Mac: WebGL: all textured content is blue 2010-11-05 10:56:08 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Mac All RESOLVED FIXED P1 Normal --- 47974 1 kbr kbr abarth enne fishd jamesr zmo oldest_to_newest 304831 0 kbr 2010-11-04 13:28:48 -0700 https://bugs.webkit.org/show_bug.cgi?id=47974 introduced a regression in WebGL content in Chromium on Mac OS X where all textures have a blue tinge. I've definitively isolated the regression to that commit. Am currently investigating the root cause to propose a fix. Layout test fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html, among others, should have caught this; we'll have to investigate separately why this wasn't caught until now. 304834 1 zmo 2010-11-04 13:37:35 -0700 fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html is skipped currently. I just looked: a bunch of tests were skipped due to a image "shadow" issue, including several webgl tests. I would think a patch caused so many test failures should be reverted instead of just masking out failing tests... 304891 2 abarth 2010-11-04 14:55:35 -0700 There certainly were folks who wanted to revert the patch, and that would have been a more cautious path forward. Please let me know how I can be helpful in fixing this issue. 304922 3 kbr 2010-11-04 15:25:25 -0700 I don't want to impede forward progress by reverting the patch. Because it passes the vast majority of the layout tests it clearly doesn't have impact beyond WebGL. I've identified the essential difference in behavior between the earlier and current image decoding paths and am working on a fix to the WebGL texture uploading code. 304926 4 kbr 2010-11-04 15:30:08 -0700 (In reply to comment #1) > fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html is skipped currently. I just looked: a bunch of tests were skipped due to a image "shadow" issue, including several webgl tests. I would think a patch caused so many test failures should be reverted instead of just masking out failing tests... Ah. Yes, this is disheartening. The WebGL failure was incorrectly lumped in to the other failures. 305025 5 73012 kbr 2010-11-04 17:23:18 -0700 Created attachment 73012 Patch 305027 6 zmo 2010-11-04 17:26:40 -0700 Maybe now the indexed PNG files are supported? 305032 7 73012 abarth 2010-11-04 17:31:17 -0700 Comment on attachment 73012 Patch Thanks for cleaning up my mess. Sorry we screwed up recognizing the failure. 305034 8 kbr 2010-11-04 17:33:38 -0700 Committed r71370: <http://trac.webkit.org/changeset/71370> 305038 9 kbr 2010-11-04 17:35:42 -0700 (In reply to comment #6) > Maybe now the indexed PNG files are supported? Possibly but I doubt it since I didn't test it. My experience has been that if it isn't tested, it doesn't work. 305378 10 zmo 2010-11-05 10:56:08 -0700 Tested, with this decoder switch, indexed PNG files work fine in Chrome now, but not in Safari. I really like it when a patch unintentionally fix some bugs. :) 73012 2010-11-04 17:23:18 -0700 2010-11-04 17:31:17 -0700 Patch bug-49021-20101104172317.patch text/plain 13072 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTM2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTAtMTEtMDQgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtj aHJvbWl1bV0gTWFjOiBXZWJHTDogYWxsIHRleHR1cmVkIGNvbnRlbnQgaXMgYmx1ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkwMjEKKworICAgICAg ICBBZGRlZCBzdXBwb3J0IGZvciA4LWJpdCwgbGl0dGxlLWVuZGlhbiBDR0ltYWdlcy4gVGhlIHBy ZXZpb3VzCisgICAgICAgIGltYWdlIGRlY29kZSBwYXRoIHVzZWQgdGhlIGRlZmF1bHQgYnl0ZSBv cmRlciwgd2hpY2ggaXMgYXBwYXJlbnRseQorICAgICAgICBiaWctZW5kaWFuLgorCisgICAgICAg IFRlc3RlZCB3aXRoIHZhcmlvdXMgV2ViR0wgY29udGVudCBhbmQgbGF5b3V0IHRlc3RzIGluIENo cm9taXVtLgorICAgICAgICBSYW4gbGF5b3V0IHRlc3RzIGluIFdlYktpdCBhbmQgdGVzdGVkIHZh cmlvdXMgV2ViR0wgY29udGVudCBpbgorICAgICAgICBTYWZhcmkuIFdhcyBub3QgYWJsZSB0byBy dW4gbGF5b3V0IHRlc3RzIHdpdGggQ2hyb21pdW0gcG9ydCBvZgorICAgICAgICBEdW1wUmVuZGVy VHJlZSBkdWUgdG8gYnVpbGQgZmFpbHVyZXMgY3VycmVudGx5IGluIHRoZSB0cmVlLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuY3BwOgorICAgICAgICAo V2ViQ29yZTo6ZG9QYWNraW5nKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGlj c0NvbnRleHQzRC5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29u dGV4dDNEQ0cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0U291cmNlRGF0YUZvcm1hdCk6Cisg ICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6Z2V0SW1hZ2VEYXRhKToKKwogMjAx MC0xMS0wMyAgWmhlbnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEtlbm5ldGggUnVzc2VsbC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3Jh cGhpY3NDb250ZXh0M0QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvR3JhcGhpY3NDb250ZXh0M0QuY3BwCShyZXZpc2lvbiA3MTM2NikKKysrIFdlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z MDMsNiArMzAzLDE0IEBAIHZvaWQgdW5wYWNrUkdCMTZCaWdUb1JHQkE4KGNvbnN0IHVpbnQxNl8K ICAgICBkZXN0aW5hdGlvblszXSA9IDB4RkY7CiB9CiAKK3ZvaWQgdW5wYWNrQkdSOFRvUkdCQTgo Y29uc3QgdWludDhfdCogc291cmNlLCB1aW50OF90KiBkZXN0aW5hdGlvbikKK3sKKyAgICBkZXN0 aW5hdGlvblswXSA9IHNvdXJjZVsyXTsKKyAgICBkZXN0aW5hdGlvblsxXSA9IHNvdXJjZVsxXTsK KyAgICBkZXN0aW5hdGlvblsyXSA9IHNvdXJjZVswXTsKKyAgICBkZXN0aW5hdGlvblszXSA9IDB4 RkY7Cit9CisKIHZvaWQgdW5wYWNrQVJHQjhUb1JHQkE4KGNvbnN0IHVpbnQ4X3QqIHNvdXJjZSwg dWludDhfdCogZGVzdGluYXRpb24pCiB7CiAgICAgZGVzdGluYXRpb25bMF0gPSBzb3VyY2VbMV07 CkBAIC0zMjcsNiArMzM1LDE0IEBAIHZvaWQgdW5wYWNrQVJHQjE2QmlnVG9SR0JBOChjb25zdCB1 aW50MTYKICAgICBkZXN0aW5hdGlvblszXSA9IGNvbnZlcnRDb2xvcjE2QmlnVG84KHNvdXJjZVsw XSk7CiB9CiAKK3ZvaWQgdW5wYWNrQUJHUjhUb1JHQkE4KGNvbnN0IHVpbnQ4X3QqIHNvdXJjZSwg dWludDhfdCogZGVzdGluYXRpb24pCit7CisgICAgZGVzdGluYXRpb25bMF0gPSBzb3VyY2VbM107 CisgICAgZGVzdGluYXRpb25bMV0gPSBzb3VyY2VbMl07CisgICAgZGVzdGluYXRpb25bMl0gPSBz b3VyY2VbMV07CisgICAgZGVzdGluYXRpb25bM10gPSBzb3VyY2VbMF07Cit9CisKIHZvaWQgdW5w YWNrQkdSQThUb1JHQkE4KGNvbnN0IHVpbnQ4X3QqIHNvdXJjZSwgdWludDhfdCogZGVzdGluYXRp b24pCiB7CiAgICAgZGVzdGluYXRpb25bMF0gPSBzb3VyY2VbMl07CkBAIC04MTksNiArODM1LDEy IEBAIHN0YXRpYyB2b2lkIGRvUGFja2luZyhjb25zdCB2b2lkKiBzb3VyY2UKICAgICAgICAgZG9V bnBhY2tpbmdBbmRQYWNraW5nPHVpbnQxNl90LCBEZXN0VHlwZSwgdW5wYWNrUkdCMTZCaWdUb1JH QkE4LCBwYWNraW5nRnVuYz4oc3RhdGljX2Nhc3Q8Y29uc3QgdWludDE2X3QqPihzb3VyY2VEYXRh KSwgd2lkdGgsIGhlaWdodCwgc291cmNlRWxlbWVudHNQZXJQaXhlbCwgc291cmNlRWxlbWVudHNQ ZXJSb3csIGRlc3RpbmF0aW9uRGF0YSwgZGVzdGluYXRpb25FbGVtZW50c1BlclBpeGVsKTsKICAg ICAgICAgYnJlYWs7CiAgICAgfQorICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlNvdXJjZUZv cm1hdEJHUjg6IHsKKyAgICAgICAgdW5zaWduZWQgaW50IHNvdXJjZUVsZW1lbnRzUGVyUGl4ZWws IHNvdXJjZUVsZW1lbnRzUGVyUm93OworICAgICAgICBjb21wdXRlSW5jcmVtZW50UGFyYW1ldGVy czx1aW50OF90Pih3aWR0aCwgMywgc291cmNlVW5wYWNrQWxpZ25tZW50LCAmc291cmNlRWxlbWVu dHNQZXJQaXhlbCwgJnNvdXJjZUVsZW1lbnRzUGVyUm93KTsKKyAgICAgICAgZG9VbnBhY2tpbmdB bmRQYWNraW5nPHVpbnQ4X3QsIERlc3RUeXBlLCB1bnBhY2tCR1I4VG9SR0JBOCwgcGFja2luZ0Z1 bmM+KHN0YXRpY19jYXN0PGNvbnN0IHVpbnQ4X3QqPihzb3VyY2VEYXRhKSwgd2lkdGgsIGhlaWdo dCwgc291cmNlRWxlbWVudHNQZXJQaXhlbCwgc291cmNlRWxlbWVudHNQZXJSb3csIGRlc3RpbmF0 aW9uRGF0YSwgZGVzdGluYXRpb25FbGVtZW50c1BlclBpeGVsKTsKKyAgICAgICAgYnJlYWs7Cisg ICAgfQogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlNvdXJjZUZvcm1hdEFSR0I4OiB7CiAg ICAgICAgIHVuc2lnbmVkIGludCBzb3VyY2VFbGVtZW50c1BlclBpeGVsLCBzb3VyY2VFbGVtZW50 c1BlclJvdzsKICAgICAgICAgY29tcHV0ZUluY3JlbWVudFBhcmFtZXRlcnM8dWludDhfdD4od2lk dGgsIDQsIHNvdXJjZVVucGFja0FsaWdubWVudCwgJnNvdXJjZUVsZW1lbnRzUGVyUGl4ZWwsICZz b3VyY2VFbGVtZW50c1BlclJvdyk7CkBAIC04MzcsNiArODU5LDEyIEBAIHN0YXRpYyB2b2lkIGRv UGFja2luZyhjb25zdCB2b2lkKiBzb3VyY2UKICAgICAgICAgZG9VbnBhY2tpbmdBbmRQYWNraW5n PHVpbnQxNl90LCBEZXN0VHlwZSwgdW5wYWNrQVJHQjE2QmlnVG9SR0JBOCwgcGFja2luZ0Z1bmM+ KHN0YXRpY19jYXN0PGNvbnN0IHVpbnQxNl90Kj4oc291cmNlRGF0YSksIHdpZHRoLCBoZWlnaHQs IHNvdXJjZUVsZW1lbnRzUGVyUGl4ZWwsIHNvdXJjZUVsZW1lbnRzUGVyUm93LCBkZXN0aW5hdGlv bkRhdGEsIGRlc3RpbmF0aW9uRWxlbWVudHNQZXJQaXhlbCk7CiAgICAgICAgIGJyZWFrOwogICAg IH0KKyAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpTb3VyY2VGb3JtYXRBQkdSODogeworICAg ICAgICB1bnNpZ25lZCBpbnQgc291cmNlRWxlbWVudHNQZXJQaXhlbCwgc291cmNlRWxlbWVudHNQ ZXJSb3c7CisgICAgICAgIGNvbXB1dGVJbmNyZW1lbnRQYXJhbWV0ZXJzPHVpbnQ4X3Q+KHdpZHRo LCA0LCBzb3VyY2VVbnBhY2tBbGlnbm1lbnQsICZzb3VyY2VFbGVtZW50c1BlclBpeGVsLCAmc291 cmNlRWxlbWVudHNQZXJSb3cpOworICAgICAgICBkb1VucGFja2luZ0FuZFBhY2tpbmc8dWludDhf dCwgRGVzdFR5cGUsIHVucGFja0FCR1I4VG9SR0JBOCwgcGFja2luZ0Z1bmM+KHN0YXRpY19jYXN0 PGNvbnN0IHVpbnQ4X3QqPihzb3VyY2VEYXRhKSwgd2lkdGgsIGhlaWdodCwgc291cmNlRWxlbWVu dHNQZXJQaXhlbCwgc291cmNlRWxlbWVudHNQZXJSb3csIGRlc3RpbmF0aW9uRGF0YSwgZGVzdGlu YXRpb25FbGVtZW50c1BlclBpeGVsKTsKKyAgICAgICAgYnJlYWs7CisgICAgfQogICAgIGNhc2Ug R3JhcGhpY3NDb250ZXh0M0Q6OlNvdXJjZUZvcm1hdEJHUkE4OiB7CiAgICAgICAgIHVuc2lnbmVk IGludCBzb3VyY2VFbGVtZW50c1BlclBpeGVsLCBzb3VyY2VFbGVtZW50c1BlclJvdzsKICAgICAg ICAgY29tcHV0ZUluY3JlbWVudFBhcmFtZXRlcnM8dWludDhfdD4od2lkdGgsIDQsIHNvdXJjZVVu cGFja0FsaWdubWVudCwgJnNvdXJjZUVsZW1lbnRzUGVyUGl4ZWwsICZzb3VyY2VFbGVtZW50c1Bl clJvdyk7CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNE LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRl eHQzRC5oCShyZXZpc2lvbiA3MTM2NikKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3Jh cGhpY3NDb250ZXh0M0QuaAkod29ya2luZyBjb3B5KQpAQCAtNTQwLDEyICs1NDAsMTQgQEAgcHVi bGljOgogICAgICAgICBTb3VyY2VGb3JtYXRSR0I4LAogICAgICAgICBTb3VyY2VGb3JtYXRSR0Ix NkxpdHRsZSwKICAgICAgICAgU291cmNlRm9ybWF0UkdCMTZCaWcsCisgICAgICAgIFNvdXJjZUZv cm1hdEJHUjgsCiAgICAgICAgIFNvdXJjZUZvcm1hdEJHUkE4LAogICAgICAgICBTb3VyY2VGb3Jt YXRCR1JBMTZMaXR0bGUsCiAgICAgICAgIFNvdXJjZUZvcm1hdEJHUkExNkJpZywKICAgICAgICAg U291cmNlRm9ybWF0QVJHQjgsCiAgICAgICAgIFNvdXJjZUZvcm1hdEFSR0IxNkxpdHRsZSwKICAg ICAgICAgU291cmNlRm9ybWF0QVJHQjE2QmlnLAorICAgICAgICBTb3VyY2VGb3JtYXRBQkdSOCwK ICAgICAgICAgU291cmNlRm9ybWF0UkdCQTU1NTEsCiAgICAgICAgIFNvdXJjZUZvcm1hdFJHQkE0 NDQ0LAogICAgICAgICBTb3VyY2VGb3JtYXRSR0I1NjUsCkluZGV4OiBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dDNEQ0cuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0M0RDRy5jcHAJKHJldmlzaW9u IDcxMzY2KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHQz RENHLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjksMjYgKzY5LDIyIEBAIHN0YXRpYyBHcmFwaGlj c0NvbnRleHQzRDo6U291cmNlRGF0YUZvcm0KICAgICAgICAgeyBTb3VyY2VGb3JtYXRCYXNlUkdC LCAgICAgICAgU291cmNlRm9ybWF0QmFzZU51bUZvcm1hdHMsIFNvdXJjZUZvcm1hdEJhc2VOdW1G b3JtYXRzIH0sIC8vIDMgY29tcG9uZW50c1BlclBpeGVsCiAgICAgICAgIHsgU291cmNlRm9ybWF0 QmFzZU51bUZvcm1hdHMsIFNvdXJjZUZvcm1hdEJhc2VBUkdCLCAgICAgICBTb3VyY2VGb3JtYXRC YXNlUkdCQSAgICAgICAgfSAvLyA0IGNvbXBvbmVudHNQZXJQaXhlbAogICAgIH07Ci0gICAgY29u c3Qgc3RhdGljIEdyYXBoaWNzQ29udGV4dDNEOjpTb3VyY2VEYXRhRm9ybWF0IGZvcm1hdFRhYmxl W1NvdXJjZUZvcm1hdEJhc2VOdW1Gb3JtYXRzXVszXSA9IHsgLy8gU291cmNlRGF0YUZvcm1hdEJh c2UgeCBiaXRzUGVyQ29tcG9uZW50QW5kRW5kaWFuCi0gICAgICAgIC8vIDhiaXRzICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAxNmJpdHMsIGxpdHRsZSBlbmRpYW4gICAgICAgICAgICAg ICAgICAgICAgICAxNmJpdHMsIGJpZyBlbmRpYW4KLSAgICAgICAgeyBHcmFwaGljc0NvbnRleHQz RDo6U291cmNlRm9ybWF0UjgsICAgIEdyYXBoaWNzQ29udGV4dDNEOjpTb3VyY2VGb3JtYXRSMTZM aXR0bGUsICAgIEdyYXBoaWNzQ29udGV4dDNEOjpTb3VyY2VGb3JtYXRSMTZCaWcgfSwKLSAgICAg ICAgeyBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0QTgsICAgIEdyYXBoaWNzQ29udGV4 dDNEOjpTb3VyY2VGb3JtYXRBMTZMaXR0bGUsICAgIEdyYXBoaWNzQ29udGV4dDNEOjpTb3VyY2VG b3JtYXRBMTZCaWcgfSwKLSAgICAgICAgeyBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0 UkE4LCAgIEdyYXBoaWNzQ29udGV4dDNEOjpTb3VyY2VGb3JtYXRSQTE2TGl0dGxlLCAgIEdyYXBo aWNzQ29udGV4dDNEOjpTb3VyY2VGb3JtYXRSQTE2QmlnIH0sCi0gICAgICAgIHsgR3JhcGhpY3ND b250ZXh0M0Q6OlNvdXJjZUZvcm1hdEFSOCwgICBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9y bWF0QVIxNkxpdHRsZSwgICBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0QVIxNkJpZyB9 LAotICAgICAgICB7IEdyYXBoaWNzQ29udGV4dDNEOjpTb3VyY2VGb3JtYXRSR0I4LCAgR3JhcGhp Y3NDb250ZXh0M0Q6OlNvdXJjZUZvcm1hdFJHQjE2TGl0dGxlLCAgR3JhcGhpY3NDb250ZXh0M0Q6 OlNvdXJjZUZvcm1hdFJHQjE2QmlnIH0sCi0gICAgICAgIHsgR3JhcGhpY3NDb250ZXh0M0Q6OlNv dXJjZUZvcm1hdFJHQkE4LCBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0UkdCQTE2TGl0 dGxlLCBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0UkdCQTE2QmlnIH0sCi0gICAgICAg IHsgR3JhcGhpY3NDb250ZXh0M0Q6OlNvdXJjZUZvcm1hdEFSR0I4LCBHcmFwaGljc0NvbnRleHQz RDo6U291cmNlRm9ybWF0QVJHQjE2TGl0dGxlLCBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9y bWF0QVJHQjE2QmlnIH0KKyAgICBjb25zdCBzdGF0aWMgR3JhcGhpY3NDb250ZXh0M0Q6OlNvdXJj ZURhdGFGb3JtYXQgZm9ybWF0VGFibGVbU291cmNlRm9ybWF0QmFzZU51bUZvcm1hdHNdWzRdID0g eyAvLyBTb3VyY2VEYXRhRm9ybWF0QmFzZSB4IGJpdHNQZXJDb21wb25lbnQgeCBlbmRpYW4KKyAg ICAgICAgLy8gOGJpdHMsIGxpdHRsZSBlbmRpYW4gICAgICAgICAgICAgICAgIDhiaXRzLCBiaWcg ZW5kaWFuICAgICAgICAgICAgICAgICAgICAgMTZiaXRzLCBsaXR0bGUgZW5kaWFuICAgICAgICAg ICAgICAgICAgICAgICAgMTZiaXRzLCBiaWcgZW5kaWFuCisgICAgICAgIHsgR3JhcGhpY3NDb250 ZXh0M0Q6OlNvdXJjZUZvcm1hdFI4LCAgICBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0 UjgsICAgIEdyYXBoaWNzQ29udGV4dDNEOjpTb3VyY2VGb3JtYXRSMTZMaXR0bGUsICAgIEdyYXBo aWNzQ29udGV4dDNEOjpTb3VyY2VGb3JtYXRSMTZCaWcgfSwKKyAgICAgICAgeyBHcmFwaGljc0Nv bnRleHQzRDo6U291cmNlRm9ybWF0QTgsICAgIEdyYXBoaWNzQ29udGV4dDNEOjpTb3VyY2VGb3Jt YXRBOCwgICAgR3JhcGhpY3NDb250ZXh0M0Q6OlNvdXJjZUZvcm1hdEExNkxpdHRsZSwgICAgR3Jh cGhpY3NDb250ZXh0M0Q6OlNvdXJjZUZvcm1hdEExNkJpZyB9LAorICAgICAgICB7IEdyYXBoaWNz Q29udGV4dDNEOjpTb3VyY2VGb3JtYXRBUjgsICAgR3JhcGhpY3NDb250ZXh0M0Q6OlNvdXJjZUZv cm1hdFJBOCwgICBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0UkExNkxpdHRsZSwgICBH cmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0UkExNkJpZyB9LAorICAgICAgICB7IEdyYXBo aWNzQ29udGV4dDNEOjpTb3VyY2VGb3JtYXRSQTgsICAgR3JhcGhpY3NDb250ZXh0M0Q6OlNvdXJj ZUZvcm1hdEFSOCwgICBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0QVIxNkxpdHRsZSwg ICBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0QVIxNkJpZyB9LAorICAgICAgICB7IEdy YXBoaWNzQ29udGV4dDNEOjpTb3VyY2VGb3JtYXRCR1I4LCAgR3JhcGhpY3NDb250ZXh0M0Q6OlNv dXJjZUZvcm1hdFJHQjgsICBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0UkdCMTZMaXR0 bGUsICBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0UkdCMTZCaWcgfSwKKyAgICAgICAg eyBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0QUJHUjgsIEdyYXBoaWNzQ29udGV4dDNE OjpTb3VyY2VGb3JtYXRSR0JBOCwgR3JhcGhpY3NDb250ZXh0M0Q6OlNvdXJjZUZvcm1hdFJHQkEx NkxpdHRsZSwgR3JhcGhpY3NDb250ZXh0M0Q6OlNvdXJjZUZvcm1hdFJHQkExNkJpZyB9LAorICAg ICAgICB7IEdyYXBoaWNzQ29udGV4dDNEOjpTb3VyY2VGb3JtYXRCR1JBOCwgR3JhcGhpY3NDb250 ZXh0M0Q6OlNvdXJjZUZvcm1hdEFSR0I4LCBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0 QVJHQjE2TGl0dGxlLCBHcmFwaGljc0NvbnRleHQzRDo6U291cmNlRm9ybWF0QVJHQjE2QmlnIH0K ICAgICB9OwogCiAgICAgQVNTRVJUKGNvbXBvbmVudHNQZXJQaXhlbCA8PSA0ICYmIGNvbXBvbmVu dHNQZXJQaXhlbCA+IDApOwogICAgIFNvdXJjZURhdGFGb3JtYXRCYXNlIGZvcm1hdEJhc2UgPSBm b3JtYXRUYWJsZUJhc2VbY29tcG9uZW50c1BlclBpeGVsIC0gMV1bYWxwaGFGb3JtYXRdOwogICAg IGlmIChmb3JtYXRCYXNlID09IFNvdXJjZUZvcm1hdEJhc2VOdW1Gb3JtYXRzKQogICAgICAgICBy ZXR1cm4gR3JhcGhpY3NDb250ZXh0M0Q6OlNvdXJjZUZvcm1hdE51bUZvcm1hdHM7Ci0gICAgaWYg KCFpczE2Qml0Rm9ybWF0KQotICAgICAgICByZXR1cm4gZm9ybWF0VGFibGVbZm9ybWF0QmFzZV1b MF07Ci0gICAgaWYgKCFiaWdFbmRpYW4pCi0gICAgICAgIHJldHVybiBmb3JtYXRUYWJsZVtmb3Jt YXRCYXNlXVsxXTsKLSAgICByZXR1cm4gZm9ybWF0VGFibGVbZm9ybWF0QmFzZV1bMl07CisgICAg cmV0dXJuIGZvcm1hdFRhYmxlW2Zvcm1hdEJhc2VdWyhpczE2Qml0Rm9ybWF0ID8gMiA6IDApICsg KGJpZ0VuZGlhbiA/IDEgOiAwKV07CiB9CiAKIGJvb2wgR3JhcGhpY3NDb250ZXh0M0Q6OmdldElt YWdlRGF0YShJbWFnZSogaW1hZ2UsCkBAIC0xMjUsMjEgKzEyMSw0MCBAQCBib29sIEdyYXBoaWNz Q29udGV4dDNEOjpnZXRJbWFnZURhdGEoSW1hCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBz aXplX3QgY29tcG9uZW50c1BlclBpeGVsID0gYml0c1BlclBpeGVsIC8gYml0c1BlckNvbXBvbmVu dDsKIAotICAgIGJvb2wgc3JjQnl0ZU9yZGVyMTZCaWcgPSBmYWxzZTsKKyAgICBDR0JpdG1hcElu Zm8gYml0SW5mbyA9IENHSW1hZ2VHZXRCaXRtYXBJbmZvKGNnSW1hZ2UpOworICAgIGJvb2wgYmln RW5kaWFuU291cmNlID0gZmFsc2U7CisgICAgLy8gVGhlc2UgY291bGQgdGVjaG5pY2FsbHkgYmUg Y29tYmluZWQgaW50byBvbmUgbGFyZ2Ugc3dpdGNoCisgICAgLy8gc3RhdGVtZW50LCBidXQgd2Ug cHJlZmVyIG5vdCB0byBzbyB0aGF0IHdlIGZhaWwgZmFzdCBpZiB3ZQorICAgIC8vIGVuY291bnRl ciBhbiB1bmV4cGVjdGVkIGltYWdlIGNvbmZpZ3VyYXRpb24uCiAgICAgaWYgKGJpdHNQZXJDb21w b25lbnQgPT0gMTYpIHsKLSAgICAgICAgQ0dCaXRtYXBJbmZvIGJpdEluZm8gPSBDR0ltYWdlR2V0 Qml0bWFwSW5mbyhjZ0ltYWdlKTsKICAgICAgICAgc3dpdGNoIChiaXRJbmZvICYga0NHQml0bWFw Qnl0ZU9yZGVyTWFzaykgewogICAgICAgICBjYXNlIGtDR0JpdG1hcEJ5dGVPcmRlcjE2QmlnOgot ICAgICAgICAgICAgc3JjQnl0ZU9yZGVyMTZCaWcgPSB0cnVlOworICAgICAgICAgICAgYmlnRW5k aWFuU291cmNlID0gdHJ1ZTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIGtDR0Jp dG1hcEJ5dGVPcmRlcjE2TGl0dGxlOgotICAgICAgICAgICAgc3JjQnl0ZU9yZGVyMTZCaWcgPSBm YWxzZTsKKyAgICAgICAgICAgIGJpZ0VuZGlhblNvdXJjZSA9IGZhbHNlOwogICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgIGNhc2Uga0NHQml0bWFwQnl0ZU9yZGVyRGVmYXVsdDoKICAgICAgICAg ICAgIC8vIFRoaXMgaXMgYSBidWcgaW4gZWFybGllciB2ZXJzaW9uIG9mIGNnIHdoZXJlIHRoZSBk ZWZhdWx0IGVuZGlhbgogICAgICAgICAgICAgLy8gaXMgbGl0dGxlIHdoZXJlYXMgdGhlIGRlY29k ZWQgMTYtYml0IHBuZyBpbWFnZSBkYXRhIGlzIGFjdHVhbGx5CiAgICAgICAgICAgICAvLyBCaWcu IExhdGVyIHZlcnNpb24gKDEwLjYuNCkgbm8gbG9uZ2VyIHJldHVybnMgQnl0ZU9yZGVyRGVmYXVs dC4KLSAgICAgICAgICAgIHNyY0J5dGVPcmRlcjE2QmlnID0gdHJ1ZTsKKyAgICAgICAgICAgIGJp Z0VuZGlhblNvdXJjZSA9IHRydWU7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgZGVmYXVs dDoKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgfQorICAgIH0gZWxzZSB7Cisg ICAgICAgIHN3aXRjaCAoYml0SW5mbyAmIGtDR0JpdG1hcEJ5dGVPcmRlck1hc2spIHsKKyAgICAg ICAgY2FzZSBrQ0dCaXRtYXBCeXRlT3JkZXIzMkJpZzoKKyAgICAgICAgICAgIGJpZ0VuZGlhblNv dXJjZSA9IHRydWU7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBrQ0dCaXRtYXBC eXRlT3JkZXIzMkxpdHRsZToKKyAgICAgICAgICAgIGJpZ0VuZGlhblNvdXJjZSA9IGZhbHNlOwor ICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2Uga0NHQml0bWFwQnl0ZU9yZGVyRGVmYXVs dDoKKyAgICAgICAgICAgIC8vIEl0IGFwcGVhcnMgdGhhdCB0aGUgZGVmYXVsdCBieXRlIG9yZGVy IGlzIGFjdHVhbGx5IGJpZworICAgICAgICAgICAgLy8gZW5kaWFuIGV2ZW4gb24gbGl0dGxlIGVu ZGlhbiBhcmNoaXRlY3R1cmVzLgorICAgICAgICAgICAgYmlnRW5kaWFuU291cmNlID0gdHJ1ZTsK ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwpAQCAtMTkwLDcgKzIwNSw3IEBAIGJvb2wgR3JhcGhpY3NDb250ZXh0M0Q6OmdldElt YWdlRGF0YShJbWEKICAgICBkZWZhdWx0OgogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQot ICAgIFNvdXJjZURhdGFGb3JtYXQgc3JjRGF0YUZvcm1hdCA9IGdldFNvdXJjZURhdGFGb3JtYXQo Y29tcG9uZW50c1BlclBpeGVsLCBhbHBoYUZvcm1hdCwgYml0c1BlckNvbXBvbmVudCA9PSAxNiwg c3JjQnl0ZU9yZGVyMTZCaWcpOworICAgIFNvdXJjZURhdGFGb3JtYXQgc3JjRGF0YUZvcm1hdCA9 IGdldFNvdXJjZURhdGFGb3JtYXQoY29tcG9uZW50c1BlclBpeGVsLCBhbHBoYUZvcm1hdCwgYml0 c1BlckNvbXBvbmVudCA9PSAxNiwgYmlnRW5kaWFuU291cmNlKTsKICAgICBpZiAoc3JjRGF0YUZv cm1hdCA9PSBTb3VyY2VGb3JtYXROdW1Gb3JtYXRzKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcxMzY4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTEtMDQgIEtlbm5ldGggUnVzc2VsbCAg PGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtjaHJvbWl1bV0gTWFjOiBXZWJHTDogYWxsIHRleHR1cmVkIGNvbnRlbnQgaXMg Ymx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDkw MjEKKworICAgICAgICBVcGRhdGVkIGV4cGVjdGF0aW9ucyBmb3IgV2ViR0wgbGF5b3V0IHRlc3Rz IHdoaWNoIHdlcmUgYWZmZWN0ZWQgYnkKKyAgICAgICAgdGhlIGltYWdlIGRlY29kZXIgY2hhbmdl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Nzk3NCAu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisK IDIwMTAtMTEtMDMgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBLZW5uZXRoIFJ1c3NlbGwuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJv bWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CShyZXZpc2lvbiA3MTM2NikKKysr IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkod29y a2luZyBjb3B5KQpAQCAtMzM0NiwxMCArMzM0Niw2IEBAIEJVR1dLNDg2MzQgTUFDIDogZmFzdC9s aXN0cy9vbC1zdGFydC1keW4KIEJVR1dLNDg2MzQgTUFDIDogZmFzdC9saXN0cy9vcmRlcmVkLWxp c3Qtd2l0aC1uby1vbC10YWcuaHRtbCA9IElNQUdFCiBCVUdXSzQ4NjM0IE1BQyA6IGZhc3QvbGlz dHMvc2Nyb2xsZWQtbWFya2VyLXBhaW50Lmh0bWwgPSBJTUFHRQogQlVHV0s0ODYzNCBNQUMgOiBm YXN0L3JlcGFpbnQvYmxvY2stbGF5b3V0LWlubGluZS1jaGlsZHJlbi1yZXBsYWNlZC5odG1sID0g SU1BR0UKLUJVR1dLNDg2MzQgTUFDIDogZmFzdC9jYW52YXMvd2ViZ2wvZ2wtdGV4aW1hZ2UuaHRt bCA9IFRFWFQKLUJVR1dLNDg2MzQgTUFDIDogZmFzdC9jYW52YXMvd2ViZ2wvdGV4LWltYWdlLWFu ZC1zdWItaW1hZ2UtMmQtd2l0aC1pbWFnZS5odG1sID0gVEVYVAotQlVHV0s0ODYzNCBNQUMgOiBm YXN0L2NhbnZhcy93ZWJnbC90ZXgtaW1hZ2Utd2l0aC1mb3JtYXQtYW5kLXR5cGUuaHRtbCA9IFRF WFQKLUJVR1dLNDg2MzQgTUFDIDogZmFzdC9jYW52YXMvd2ViZ2wvdGV4dHVyZS10cmFuc3BhcmVu dC1waXhlbHMtaW5pdGlhbGl6ZWQuaHRtbCA9IFRFWFQKIAogLy8gTmV3IHRlc3QsIHNlZW1zIFY4 IGRpZmZlcnMgZnJvbSBKU0MgaGVyZS4KIC8vIEFkZGVkIGJ5IGh0dHA6Ly90cmFjLndlYmtpdC5v cmcvY2hhbmdlc2V0LzcwOTEwCg==