49004 2010-11-04 09:23:19 -0700 Enable running of Qt API tests on BuildBot 2010-11-09 07:19:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 rgabor webkit-unassigned abecsi ossy wsiegrist oldest_to_newest 304701 0 rgabor 2010-11-04 09:23:19 -0700 Run Qt API tests on Qt slaves. 304705 1 72949 rgabor 2010-11-04 09:34:06 -0700 Created attachment 72949 proposed patch It's running now on our x86 bots at http://webkit.sed.hu/buildbot/waterfall with this config. 305596 2 72949 ossy 2010-11-05 15:51:43 -0700 Comment on attachment 72949 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=72949&action=review Otherwise LGTM, r=me with these changes. Bill, could you execute a reconfigure on buildbot master after this patch landed? > WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:337 > + def evaluateCommand(self, cmd): > + if self.incorrectLines: > + return FAILURE Qt API tests are quite stable, but I think we shouldn't block the bots if it fails. I prefer using WARNINGS instead of FAILURE. > WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:342 > + if cmd.rc != 0: > + return FAILURE > + > + return SUCCESS Ditto. 306077 3 ossy 2010-11-08 04:11:55 -0800 Landed in http://trac.webkit.org/changeset/71509 Bill, could you reconfigure the buildbot master, please? 306134 4 wsiegrist 2010-11-08 08:40:51 -0800 Master restart started. 306772 5 ossy 2010-11-09 07:19:32 -0800 (In reply to comment #4) > Master restart started. Thx, it works now. ;) 72949 2010-11-04 09:34:06 -0700 2010-11-08 04:12:08 -0800 proposed patch master_config.patch text/plain 2932 rgabor SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcxMzM4KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTEtMDQgIEdhYm9yIFJhcGNzYW55aSAg PHJnYWJvckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRW5hYmxlIHJ1bm5pbmcgb2YgUXQgQVBJIHRlc3RzIG9uIEJ1aWxk Qm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTAw NAorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv bWFzdGVyLmNmZzoKKwogMjAxMC0xMS0wNCAgR2Fib3IgUmFwY3NhbnlpICA8cmdhYm9yQGluZi51 LXN6ZWdlZC5odT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdl YktpdFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rl ci5jZmcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwkocmV2aXNpb24gNzEzMTYpCisrKyBXZWJLaXRU b29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2Zn CSh3b3JraW5nIGNvcHkpCkBAIC0zMDUsNiArMzA1LDUwIEBAIGNsYXNzIFJ1bkd0a0FQSVRlc3Rz KHNoZWxsLlRlc3QpOgogCiAgICAgICAgIHJldHVybiBbc2VsZi5uYW1lXQogCitjbGFzcyBSdW5R dEFQSVRlc3RzKHNoZWxsLlRlc3QpOgorICAgIG5hbWUgPSAiQVBJIHRlc3RzIgorICAgIGRlc2Ny aXB0aW9uID0gWyJBUEkgdGVzdHMgcnVubmluZyJdCisgICAgZGVzY3JpcHRpb25Eb25lID0gWyJB UEkgdGVzdHMiXQorICAgIGNvbW1hbmQgPSBbInB5dGhvbiIsICIuL1dlYktpdFRvb2xzL1Njcmlw dHMvcnVuLXF0d2Via2l0LXRlc3RzIiwKKyAgICAgICAgICAgICAgICItLW91dHB1dC1maWxlPXF0 LXVuaXQtdGVzdHMuaHRtbCIsICItLWRvLW5vdC1vcGVuLXJlc3VsdHMiLAorICAgICAgICAgICAg ICAgV2l0aFByb3BlcnRpZXMoIldlYktpdEJ1aWxkLyUoY29uZmlndXJhdGlvbl9wcmV0dHkpcy9X ZWJLaXQvcXQvdGVzdHMvIildCisKKyAgICBkZWYgc3RhcnQoc2VsZik6CisgICAgICAgIHNlbGYu c2V0UHJvcGVydHkoImNvbmZpZ3VyYXRpb25fcHJldHR5Iiwgc2VsZi5nZXRQcm9wZXJ0eSgiY29u ZmlndXJhdGlvbiIpLnRpdGxlKCkpCisgICAgICAgIHJldHVybiBzaGVsbC5UZXN0LnN0YXJ0KHNl bGYpCisKKyAgICBkZWYgY29tbWFuZENvbXBsZXRlKHNlbGYsIGNtZCk6CisgICAgICAgIHNoZWxs LlRlc3QuY29tbWFuZENvbXBsZXRlKHNlbGYsIGNtZCkKKworICAgICAgICBsb2dUZXh0ID0gY21k LmxvZ3NbJ3N0ZGlvJ10uZ2V0VGV4dCgpCisgICAgICAgIGZvdW5kSXRlbXMgPSByZS5maW5kYWxs KCJUT1RBTFM6ICg/UDxwYXNzZWQ+XGQrKSBwYXNzZWQsICg/UDxmYWlsZWQ+XGQrKSBmYWlsZWQs ICg/UDxza2lwcGVkPlxkKykgc2tpcHBlZCIsIGxvZ1RleHQpCisKKyAgICAgICAgc2VsZi5pbmNv cnJlY3RMaW5lcyA9IDAKKyAgICAgICAgc2VsZi5zdGF0dXNMaW5lID0gW10KKyAgICAgICAgaWYg Zm91bmRJdGVtczoKKyAgICAgICAgICAgIHNlbGYuaW5jb3JyZWN0TGluZXMgPSBpbnQoZm91bmRJ dGVtc1swXVsxXSkKKyAgICAgICAgICAgIGlmIHNlbGYuaW5jb3JyZWN0TGluZXMgPiAwOgorICAg ICAgICAgICAgICAgIHNlbGYuc3RhdHVzTGluZSA9IFsKKyAgICAgICAgICAgICAgICAgICAgIiVz IHBhc3NlZCwgJXMgZmFpbGVkLCAlcyBza2lwcGVkIiAlIChmb3VuZEl0ZW1zWzBdWzBdLCBmb3Vu ZEl0ZW1zWzBdWzFdLCBmb3VuZEl0ZW1zWzBdWzJdKQorICAgICAgICAgICAgICAgIF0KKworICAg IGRlZiBldmFsdWF0ZUNvbW1hbmQoc2VsZiwgY21kKToKKyAgICAgICAgaWYgc2VsZi5pbmNvcnJl Y3RMaW5lczoKKyAgICAgICAgICAgIHJldHVybiBGQUlMVVJFCisKKyAgICAgICAgaWYgY21kLnJj ICE9IDA6CisgICAgICAgICAgICByZXR1cm4gRkFJTFVSRQorCisgICAgICAgIHJldHVybiBTVUND RVNTCisKKyAgICBkZWYgZ2V0VGV4dChzZWxmLCBjbWQsIHJlc3VsdHMpOgorICAgICAgICByZXR1 cm4gc2VsZi5nZXRUZXh0MihjbWQsIHJlc3VsdHMpCisKKyAgICBkZWYgZ2V0VGV4dDIoc2VsZiwg Y21kLCByZXN1bHRzKToKKyAgICAgICAgaWYgcmVzdWx0cyAhPSBTVUNDRVNTIGFuZCBzZWxmLmlu Y29ycmVjdExpbmVzOgorICAgICAgICAgICAgcmV0dXJuIHNlbGYuc3RhdHVzTGluZQorCisgICAg ICAgIHJldHVybiBbc2VsZi5uYW1lXQogCiBjbGFzcyBSdW5XZWJLaXRMZWFrVGVzdHMoUnVuV2Vi S2l0VGVzdHMpOgogICAgIGRlZiBzdGFydChzZWxmKToKQEAgLTQyMSw2ICs0NjUsOCBAQCBjbGFz cyBCdWlsZEFuZFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAgICAgICBzZWxmLmFkZFN0ZXAoRXh0 cmFjdFRlc3RSZXN1bHRzKQogICAgICAgICBpZiBwbGF0Zm9ybSA9PSAiZ3RrIjoKICAgICAgICAg ICAgIHNlbGYuYWRkU3RlcChSdW5HdGtBUElUZXN0cykKKyAgICAgICAgaWYgcGxhdGZvcm0gPT0g InF0IjoKKyAgICAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5RdEFQSVRlc3RzKQogCiBjbGFzcyBC dWlsZEFuZFRlc3RMZWFrc0ZhY3RvcnkoQnVpbGRBbmRUZXN0RmFjdG9yeSk6CiAgICAgVGVzdENs YXNzID0gUnVuV2ViS2l0TGVha1Rlc3RzCg==