49003 2010-11-04 09:18:09 -0700 Request.h getters can be made const 2010-11-04 09:45:08 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue oldest_to_newest 304698 0 joepeck 2010-11-04 09:18:09 -0700 I don't see a reason for them not to be const. http://trac.webkit.org/browser/trunk/WebCore/loader/Request.h Let me know if there is no advantage to this patch overwriting the history. 304700 1 72948 joepeck 2010-11-04 09:21:54 -0700 Created attachment 72948 [PATCH] Adds const qualifier to getters 304702 2 72948 kling 2010-11-04 09:26:18 -0700 Comment on attachment 72948 [PATCH] Adds const qualifier to getters r=me 304713 3 72948 commit-queue 2010-11-04 09:45:03 -0700 Comment on attachment 72948 [PATCH] Adds const qualifier to getters Clearing flags on attachment: 72948 Committed r71341: <http://trac.webkit.org/changeset/71341> 304714 4 commit-queue 2010-11-04 09:45:08 -0700 All reviewed patches have been landed. Closing bug. 72948 2010-11-04 09:21:54 -0700 2010-11-04 09:45:03 -0700 [PATCH] Adds const qualifier to getters const.patch text/plain 1859 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzkzZTUyMi4uOTljODFkNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMS0wNCAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJlcXVlc3QuaCBnZXR0ZXJzIGNhbiBiZSBtYWRlIGNvbnN0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTAwMworCisg ICAgICAgIEFkZGVkIHRoZSBjb25zdCBxdWFsaWZpZXIgdG8gc29tZSBnZXR0ZXJzIHRoYXQgZG9u J3QgbXV0YXRlIHRoZSBvYmplY3QuCisKKyAgICAgICAgKiBsb2FkZXIvUmVxdWVzdC5oOgorICAg ICAgICAoV2ViQ29yZTo6UmVxdWVzdDo6Y2FjaGVkUmVzb3VyY2UpOgorICAgICAgICAoV2ViQ29y ZTo6UmVxdWVzdDo6Y2FjaGVkUmVzb3VyY2VMb2FkZXIpOgorICAgICAgICAoV2ViQ29yZTo6UmVx dWVzdDo6aXNJbmNyZW1lbnRhbCk6CisgICAgICAgIChXZWJDb3JlOjpSZXF1ZXN0Ojppc011bHRp cGFydCk6CisKIDIwMTAtMTEtMDEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvbG9hZGVyL1JlcXVlc3QuaCBiL1dlYkNvcmUvbG9hZGVyL1JlcXVlc3QuaAppbmRleCAyNWJm MzFhLi5iNmRlMzEyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9SZXF1ZXN0LmgKKysrIGIv V2ViQ29yZS9sb2FkZXIvUmVxdWVzdC5oCkBAIC0zNiwxMyArMzYsMTMgQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogICAgICAgICBSZXF1ZXN0KENhY2hlZFJlc291cmNlTG9hZGVyKiwgQ2FjaGVkUmVz b3VyY2UqLCBib29sIGluY3JlbWVudGFsLCBTZWN1cml0eUNoZWNrUG9saWN5LCBib29sIHNlbmRS ZXNvdXJjZUxvYWRDYWxsYmFja3MpOwogICAgICAgICB+UmVxdWVzdCgpOwogICAgICAgICAKLSAg ICAgICAgQ2FjaGVkUmVzb3VyY2UqIGNhY2hlZFJlc291cmNlKCkgeyByZXR1cm4gbV9vYmplY3Q7 IH0KLSAgICAgICAgQ2FjaGVkUmVzb3VyY2VMb2FkZXIqIGNhY2hlZFJlc291cmNlTG9hZGVyKCkg eyByZXR1cm4gbV9jYWNoZWRSZXNvdXJjZUxvYWRlcjsgfQorICAgICAgICBDYWNoZWRSZXNvdXJj ZSogY2FjaGVkUmVzb3VyY2UoKSBjb25zdCB7IHJldHVybiBtX29iamVjdDsgfQorICAgICAgICBD YWNoZWRSZXNvdXJjZUxvYWRlciogY2FjaGVkUmVzb3VyY2VMb2FkZXIoKSBjb25zdCB7IHJldHVy biBtX2NhY2hlZFJlc291cmNlTG9hZGVyOyB9CiAKLSAgICAgICAgYm9vbCBpc0luY3JlbWVudGFs KCkgeyByZXR1cm4gbV9pbmNyZW1lbnRhbDsgfQorICAgICAgICBib29sIGlzSW5jcmVtZW50YWwo KSBjb25zdCB7IHJldHVybiBtX2luY3JlbWVudGFsOyB9CiAgICAgICAgIHZvaWQgc2V0SXNJbmNy ZW1lbnRhbChib29sIGIgPSB0cnVlKSB7IG1faW5jcmVtZW50YWwgPSBiOyB9CiAKLSAgICAgICAg Ym9vbCBpc011bHRpcGFydCgpIHsgcmV0dXJuIG1fbXVsdGlwYXJ0OyB9CisgICAgICAgIGJvb2wg aXNNdWx0aXBhcnQoKSBjb25zdCB7IHJldHVybiBtX211bHRpcGFydDsgfQogICAgICAgICB2b2lk IHNldElzTXVsdGlwYXJ0KGJvb2wgYiA9IHRydWUpIHsgbV9tdWx0aXBhcnQgPSBiOyB9CiAKICAg ICAgICAgU2VjdXJpdHlDaGVja1BvbGljeSBzaG91bGREb1NlY3VyaXR5Q2hlY2soKSBjb25zdCB7 IHJldHVybiBtX3Nob3VsZERvU2VjdXJpdHlDaGVjazsgfQo=