48984 2010-11-04 03:14:26 -0700 [Chromium] @media print crash due to paged media support 2010-11-09 17:26:36 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 hamaji yuzo commit-queue hamaji mihaip playmobil yuzo oldest_to_newest 304557 0 72921 hamaji 2010-11-04 03:14:26 -0700 Created attachment 72921 Test case Chromium crashes when we are printing the following HTML: <style> @media print { * { display: none; } } </style> Chromium bug: http://code.google.com/p/chromium/issues/detail?id=60464 306056 1 73225 yuzo 2010-11-08 01:23:40 -0800 Created attachment 73225 Patch 306082 2 73225 hamaji 2010-11-08 04:22:32 -0800 Comment on attachment 73225 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73225&action=review Looks like the expectation file is wrong? > LayoutTests/printing/page-format-data-display-none-expected.txt:1 > + Does DRT really output this file? > WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=48984 I'd comment why this patch fixes this issue. 306558 3 73334 yuzo 2010-11-08 18:55:37 -0800 Created attachment 73334 Added comments 306562 4 yuzo 2010-11-08 18:59:17 -0800 Thank you for the review. (In reply to comment #2) > (From update of attachment 73225 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=73225&action=review > > Looks like the expectation file is wrong? > > > LayoutTests/printing/page-format-data-display-none-expected.txt:1 > > + > > Does DRT really output this file? Yes. I thought it was weird and spent some time to see if I made any mistakes. But DRT somehow spit it. > > > WebCore/ChangeLog:6 > > + https://bugs.webkit.org/show_bug.cgi?id=48984 > > I'd comment why this patch fixes this issue. Added comments there and at styleForPage(). 306626 5 hamaji 2010-11-08 23:26:27 -0800 > Yes. > > I thought it was weird and spent some time to see if I made any mistakes. > But DRT somehow spit it. I see. So, how about adding document.styleSheets[0].removeRule(0); after calling pageSizeAndMarginsInPixels to get a sane result? I'd add a comment which describes how to run the layout test manually. 306657 6 73346 yuzo 2010-11-09 01:01:45 -0800 Created attachment 73346 Make expected result cleaner, added manual test instruction 306659 7 yuzo 2010-11-09 01:02:46 -0800 Thank you for the review, again. (In reply to comment #5) > > Yes. > > > > I thought it was weird and spent some time to see if I made any mistakes. > > But DRT somehow spit it. > > I see. So, how about adding > > document.styleSheets[0].removeRule(0); > > after calling pageSizeAndMarginsInPixels to get a sane result? Done. > > > I'd add a comment which describes how to run the layout test manually. Done. 306663 8 73346 hamaji 2010-11-09 01:16:06 -0800 Comment on attachment 73346 Make expected result cleaner, added manual test instruction Looks good. Thanks for updating patch! 306696 9 73346 commit-queue 2010-11-09 04:21:35 -0800 Comment on attachment 73346 Make expected result cleaner, added manual test instruction Clearing flags on attachment: 73346 Committed r71621: <http://trac.webkit.org/changeset/71621> 306697 10 commit-queue 2010-11-09 04:21:40 -0800 All reviewed patches have been landed. Closing bug. 306803 11 mihaip 2010-11-09 08:26:28 -0800 It looks like neither the test_shell nor the Chromium DRT have pageSizeAndMarginsInPixels, I'm going to add a TEXT expectation for this test and open a bug about adding support for it. 307074 12 yuzo 2010-11-09 17:26:36 -0800 Mihai, Sorry for the breakage and thank you for filing the bug. 72921 2010-11-04 03:14:26 -0700 2010-11-04 03:14:26 -0700 Test case media-crash.html text/html 63 hamaji PHN0eWxlPgpAbWVkaWEgcHJpbnQgewogICogewogICAgZGlzcGxheTogbm9uZTsKICB9Cn0KPC9z dHlsZT4K 73225 2010-11-08 01:23:40 -0800 2010-11-08 18:55:32 -0800 Patch bug-48984-20101108012339.patch text/plain 3722 yuzo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5YzlmZWFkNGUxMjRkZDcwNmFkYTdiNmNjOTE0ZWQ4ZTBjMjNhMzIxLi44YmU2YmFj OWEwZTdmNDQxMGM1MTg5YTRiYzhmM2Y0NGU0ZTdlMjFmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTEtMDggIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgQnVnIDQ4OTg0 IC0gW0Nocm9taXVtXSBAbWVkaWEgcHJpbnQgY3Jhc2ggZHVlIHRvIHBhZ2VkIG1lZGlhIHN1cHBv cnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4OTg0 CisKKyAgICAgICAgKiBwcmludGluZy9wYWdlLWZvcm1hdC1kYXRhLWRpc3BsYXktbm9uZS1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHByaW50aW5nL3BhZ2UtZm9ybWF0LWRhdGEtZGlz cGxheS1ub25lLmh0bWw6IEFkZGVkLgorCiAyMDEwLTExLTA1ICBIZWxkZXIgQ29ycmVpYSAgPGhl bGRlckBzZW5jaGEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wcmludGluZy9wYWdlLWZvcm1hdC1kYXRhLWRpc3BsYXkt bm9uZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wcmludGluZy9wYWdlLWZvcm1hdC1kYXRh LWRpc3BsYXktbm9uZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDBhOTRiYTE2NGEwNzc0ODk5 ZTVmMTVhYjIxMmYyOGM2ZWMwYzU3ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3By aW50aW5nL3BhZ2UtZm9ybWF0LWRhdGEtZGlzcGxheS1ub25lLWV4cGVjdGVkLnR4dApAQCAtMCww ICsxLDIxIEBACisKK1Rlc3QgZm9yIEJ1ZyA0ODk4NCAtIFtDaHJvbWl1bV0gQG1lZGlhIHByaW50 IGNyYXNoIGR1ZSB0byBwYWdlZCBtZWRpYSBzdXBwb3J0CisKKyogeyBkaXNwbGF5OiBub25lOyB9 CisKKworCitQQVNTCisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAgICAvLyBUaGUgdGVzdCBwYXNz ZXMgaWYgdGhlIGZvbGxvd2luZyBsaW5lIGRvZXNuJ3QgY2F1c2UgYSBjcmFzaC4KKyAgICBsYXlv dXRUZXN0Q29udHJvbGxlci5wYWdlU2l6ZUFuZE1hcmdpbnNJblBpeGVscygwLCAxMDAsIDIwMCwg MSwgMiwgMywgNCk7CisKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgib3V0cHV0IikuaW5u ZXJIVE1MID0gIlBBU1MiOworfQorCisKKworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wcmlu dGluZy9wYWdlLWZvcm1hdC1kYXRhLWRpc3BsYXktbm9uZS5odG1sIGIvTGF5b3V0VGVzdHMvcHJp bnRpbmcvcGFnZS1mb3JtYXQtZGF0YS1kaXNwbGF5LW5vbmUuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kOTJm Njk2NDA5NjEyNjQ1MWEzNmZhMDBjYzRhNGRlMTY1MzAwMDU4Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvcHJpbnRpbmcvcGFnZS1mb3JtYXQtZGF0YS1kaXNwbGF5LW5vbmUuaHRtbApA QCAtMCwwICsxLDI0IEBACis8IWRvY3R5cGUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8dGl0bGU+ VGVzdCBmb3IgQnVnIDQ4OTg0IC0gW0Nocm9taXVtXSBAbWVkaWEgcHJpbnQgY3Jhc2ggZHVlIHRv IHBhZ2VkIG1lZGlhIHN1cHBvcnQ8L3RpdGxlPgorPHN0eWxlPgorKiB7IGRpc3BsYXk6IG5vbmU7 IH0KKzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYgaWQ9Im91dHB1dCI+CitUZXN0IGlz IG5vdCBydW4uCis8L2Rpdj4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9s bGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgLy8g VGhlIHRlc3QgcGFzc2VzIGlmIHRoZSBmb2xsb3dpbmcgbGluZSBkb2Vzbid0IGNhdXNlIGEgY3Jh c2guCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIucGFnZVNpemVBbmRNYXJnaW5zSW5QaXhlbHMo MCwgMTAwLCAyMDAsIDEsIDIsIDMsIDQpOworCisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo Im91dHB1dCIpLmlubmVySFRNTCA9ICJQQVNTIjsKK30KKzwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCAxOTNkNTQ1YjhkZjAzMDEyYWRmODYzNWZiZDNlYmE1NWZhOThlNmVkLi4yNDFhMmRiYWVi NGI1Y2Q0NjhlY2VhNDg5NWVlODg3ZDU3Y2Y3MTRlIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTExLTA4 ICBZdXpvIEZ1amlzaGltYSAgPHl1em9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yIEJ1ZyA0ODk4NCAtIFtDaHJvbWl1 bV0gQG1lZGlhIHByaW50IGNyYXNoIGR1ZSB0byBwYWdlZCBtZWRpYSBzdXBwb3J0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODk4NAorCisgICAgICAg IFRlc3Q6IHByaW50aW5nL3BhZ2UtZm9ybWF0LWRhdGEtZGlzcGxheS1ub25lLmh0bWwKKworICAg ICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0 eWxlU2VsZWN0b3I6OnN0eWxlRm9yUGFnZSk6IFBhZ2UgY29udGV4dCBpbmhlcml0cyBmcm9tCisg ICAgICAgIGRvY3VtZW50IGVsZW1lbnQuCisKIDIwMTAtMTEtMDUgIEhlbGRlciBDb3JyZWlhICA8 aGVsZGVyQHNlbmNoYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwIGIvV2ViQ29yZS9j c3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKaW5kZXggMzE3ZmM3ZTcyNjUzOWEyMzI4MDE1NzMyNDEx N2FhOWViNDliN2NmMi4uZDBhNmQwYmY5ZjY3MzQ2ODI1YzY2ZGNhZDc0ZTIxYWY5NjhiNzI4MCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKKysrIGIvV2ViQ29y ZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKQEAgLTE2MDIsNyArMTYwMiw3IEBAIFBhc3NSZWZQ dHI8UmVuZGVyU3R5bGU+IENTU1N0eWxlU2VsZWN0b3I6OnBzZXVkb1N0eWxlRm9yRWxlbWVudChQ c2V1ZG9JZCBwc2V1ZG8sCiAKIFBhc3NSZWZQdHI8UmVuZGVyU3R5bGU+IENTU1N0eWxlU2VsZWN0 b3I6OnN0eWxlRm9yUGFnZShpbnQgcGFnZUluZGV4KQogewotICAgIGluaXRGb3JTdHlsZVJlc29s dmUobV9jaGVja2VyLm1fZG9jdW1lbnQtPmJvZHkoKSk7CisgICAgaW5pdEZvclN0eWxlUmVzb2x2 ZShtX2NoZWNrZXIubV9kb2N1bWVudC0+ZG9jdW1lbnRFbGVtZW50KCkpOwogCiAgICAgbV9zdHls ZSA9IFJlbmRlclN0eWxlOjpjcmVhdGUoKTsKICAgICBtX3N0eWxlLT5pbmhlcml0RnJvbShtX3Jv b3RFbGVtZW50U3R5bGUpOwo= 73334 2010-11-08 18:55:37 -0800 2010-11-09 01:01:40 -0800 Added comments bug-48984-20101108185535.patch text/plain 4022 yuzo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5YzlmZWFkNGUxMjRkZDcwNmFkYTdiNmNjOTE0ZWQ4ZTBjMjNhMzIxLi44YmU2YmFj OWEwZTdmNDQxMGM1MTg5YTRiYzhmM2Y0NGU0ZTdlMjFmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTEtMDggIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgQnVnIDQ4OTg0 IC0gW0Nocm9taXVtXSBAbWVkaWEgcHJpbnQgY3Jhc2ggZHVlIHRvIHBhZ2VkIG1lZGlhIHN1cHBv cnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4OTg0 CisKKyAgICAgICAgKiBwcmludGluZy9wYWdlLWZvcm1hdC1kYXRhLWRpc3BsYXktbm9uZS1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHByaW50aW5nL3BhZ2UtZm9ybWF0LWRhdGEtZGlz cGxheS1ub25lLmh0bWw6IEFkZGVkLgorCiAyMDEwLTExLTA1ICBIZWxkZXIgQ29ycmVpYSAgPGhl bGRlckBzZW5jaGEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wcmludGluZy9wYWdlLWZvcm1hdC1kYXRhLWRpc3BsYXkt bm9uZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wcmludGluZy9wYWdlLWZvcm1hdC1kYXRh LWRpc3BsYXktbm9uZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDBhOTRiYTE2NGEwNzc0ODk5 ZTVmMTVhYjIxMmYyOGM2ZWMwYzU3ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3By aW50aW5nL3BhZ2UtZm9ybWF0LWRhdGEtZGlzcGxheS1ub25lLWV4cGVjdGVkLnR4dApAQCAtMCww ICsxLDIxIEBACisKK1Rlc3QgZm9yIEJ1ZyA0ODk4NCAtIFtDaHJvbWl1bV0gQG1lZGlhIHByaW50 IGNyYXNoIGR1ZSB0byBwYWdlZCBtZWRpYSBzdXBwb3J0CisKKyogeyBkaXNwbGF5OiBub25lOyB9 CisKKworCitQQVNTCisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAgICAvLyBUaGUgdGVzdCBwYXNz ZXMgaWYgdGhlIGZvbGxvd2luZyBsaW5lIGRvZXNuJ3QgY2F1c2UgYSBjcmFzaC4KKyAgICBsYXlv dXRUZXN0Q29udHJvbGxlci5wYWdlU2l6ZUFuZE1hcmdpbnNJblBpeGVscygwLCAxMDAsIDIwMCwg MSwgMiwgMywgNCk7CisKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgib3V0cHV0IikuaW5u ZXJIVE1MID0gIlBBU1MiOworfQorCisKKworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wcmlu dGluZy9wYWdlLWZvcm1hdC1kYXRhLWRpc3BsYXktbm9uZS5odG1sIGIvTGF5b3V0VGVzdHMvcHJp bnRpbmcvcGFnZS1mb3JtYXQtZGF0YS1kaXNwbGF5LW5vbmUuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kOTJm Njk2NDA5NjEyNjQ1MWEzNmZhMDBjYzRhNGRlMTY1MzAwMDU4Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvcHJpbnRpbmcvcGFnZS1mb3JtYXQtZGF0YS1kaXNwbGF5LW5vbmUuaHRtbApA QCAtMCwwICsxLDI0IEBACis8IWRvY3R5cGUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8dGl0bGU+ VGVzdCBmb3IgQnVnIDQ4OTg0IC0gW0Nocm9taXVtXSBAbWVkaWEgcHJpbnQgY3Jhc2ggZHVlIHRv IHBhZ2VkIG1lZGlhIHN1cHBvcnQ8L3RpdGxlPgorPHN0eWxlPgorKiB7IGRpc3BsYXk6IG5vbmU7 IH0KKzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYgaWQ9Im91dHB1dCI+CitUZXN0IGlz IG5vdCBydW4uCis8L2Rpdj4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9s bGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgLy8g VGhlIHRlc3QgcGFzc2VzIGlmIHRoZSBmb2xsb3dpbmcgbGluZSBkb2Vzbid0IGNhdXNlIGEgY3Jh c2guCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIucGFnZVNpemVBbmRNYXJnaW5zSW5QaXhlbHMo MCwgMTAwLCAyMDAsIDEsIDIsIDMsIDQpOworCisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo Im91dHB1dCIpLmlubmVySFRNTCA9ICJQQVNTIjsKK30KKzwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCAxOTNkNTQ1YjhkZjAzMDEyYWRmODYzNWZiZDNlYmE1NWZhOThlNmVkLi5hOTg2ZDRjODI4 Zjc2NTMyYjMzZWY4NzJlODM1NTI0MjI1Y2Y2NDkwIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTExLTA4 ICBZdXpvIEZ1amlzaGltYSAgPHl1em9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yIEJ1ZyA0ODk4NCAtIFtDaHJvbWl1 bV0gQG1lZGlhIHByaW50IGNyYXNoIGR1ZSB0byBwYWdlZCBtZWRpYSBzdXBwb3J0CisgICAgICAg IFBhZ2UgY29udGV4dCBoYXMgYmVlbiBpbmhlcml0aW5nIGZyb20gZG9jdW1lbnQgZWxlbWVudCBz dHlsZSB0aGF0IGJlY29tZXMgbnVsbCBpZiBkaXNwbGF5IHByb3BlcnR5IGlzIG5vbmUuCisgICAg ICAgIEl0IHNob3VsZCBpbmhlcml0IGZyb20gZG9jdW1lbnQgc3R5bGUgaW5zdGVhZCB0byBwcm9w ZXJseSBoYW5kbGUgZGlyZWN0aW9uIHByb3BlcnR5IChhbmQgdG8gYXZvaWQgdGhlIG51bGwgcmVm ZXJlbmNlKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ4OTg0CisKKyAgICAgICAgVGVzdDogcHJpbnRpbmcvcGFnZS1mb3JtYXQtZGF0YS1kaXNwbGF5 LW5vbmUuaHRtbAorCisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6c3R5bGVGb3JQYWdlKTogUGFnZSBjb250ZXh0 IGluaGVyaXRzIGZyb20KKyAgICAgICAgZG9jdW1lbnQgc3R5bGUuCisKIDIwMTAtMTEtMDUgIEhl bGRlciBDb3JyZWlhICA8aGVsZGVyQHNlbmNoYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QW5kcmVhcyBLbGluZy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3Iu Y3BwIGIvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKaW5kZXggMzE3ZmM3ZTcyNjUz OWEyMzI4MDE1NzMyNDExN2FhOWViNDliN2NmMi4uNjNlZWFkZjJjNTY3NjU4MzNmODUzOGQwNzA1 MmRiNGQ5NDY5NzE1NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5j cHAKKysrIGIvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKQEAgLTE2MDIsNyArMTYw Miw3IEBAIFBhc3NSZWZQdHI8UmVuZGVyU3R5bGU+IENTU1N0eWxlU2VsZWN0b3I6OnBzZXVkb1N0 eWxlRm9yRWxlbWVudChQc2V1ZG9JZCBwc2V1ZG8sCiAKIFBhc3NSZWZQdHI8UmVuZGVyU3R5bGU+ IENTU1N0eWxlU2VsZWN0b3I6OnN0eWxlRm9yUGFnZShpbnQgcGFnZUluZGV4KQogewotICAgIGlu aXRGb3JTdHlsZVJlc29sdmUobV9jaGVja2VyLm1fZG9jdW1lbnQtPmJvZHkoKSk7CisgICAgaW5p dEZvclN0eWxlUmVzb2x2ZShtX2NoZWNrZXIubV9kb2N1bWVudC0+ZG9jdW1lbnRFbGVtZW50KCkp OyAvLyBtX3Jvb3RFbGVtZW50U3R5bGUgd2lsbCBiZSBzZXQgdG8gdGhlIGRvY3VtZW50IHN0eWxl LgogCiAgICAgbV9zdHlsZSA9IFJlbmRlclN0eWxlOjpjcmVhdGUoKTsKICAgICBtX3N0eWxlLT5p bmhlcml0RnJvbShtX3Jvb3RFbGVtZW50U3R5bGUpOwo= 73346 2010-11-09 01:01:45 -0800 2010-11-09 04:21:35 -0800 Make expected result cleaner, added manual test instruction bug-48984-20101109010143.patch text/plain 3957 yuzo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5YzlmZWFkNGUxMjRkZDcwNmFkYTdiNmNjOTE0ZWQ4ZTBjMjNhMzIxLi44YmU2YmFj OWEwZTdmNDQxMGM1MTg5YTRiYzhmM2Y0NGU0ZTdlMjFmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTEtMDggIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgQnVnIDQ4OTg0 IC0gW0Nocm9taXVtXSBAbWVkaWEgcHJpbnQgY3Jhc2ggZHVlIHRvIHBhZ2VkIG1lZGlhIHN1cHBv cnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4OTg0 CisKKyAgICAgICAgKiBwcmludGluZy9wYWdlLWZvcm1hdC1kYXRhLWRpc3BsYXktbm9uZS1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHByaW50aW5nL3BhZ2UtZm9ybWF0LWRhdGEtZGlz cGxheS1ub25lLmh0bWw6IEFkZGVkLgorCiAyMDEwLTExLTA1ICBIZWxkZXIgQ29ycmVpYSAgPGhl bGRlckBzZW5jaGEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wcmludGluZy9wYWdlLWZvcm1hdC1kYXRhLWRpc3BsYXkt bm9uZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wcmludGluZy9wYWdlLWZvcm1hdC1kYXRh LWRpc3BsYXktbm9uZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2VmMjJlOWE0MzFhZDAyNzI3 MTNiNzFmZGM4Nzk0MDE2YzhlZjEyZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3By aW50aW5nL3BhZ2UtZm9ybWF0LWRhdGEtZGlzcGxheS1ub25lLWV4cGVjdGVkLnR4dApAQCAtMCww ICsxIEBACitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wcmludGluZy9wYWdlLWZvcm1h dC1kYXRhLWRpc3BsYXktbm9uZS5odG1sIGIvTGF5b3V0VGVzdHMvcHJpbnRpbmcvcGFnZS1mb3Jt YXQtZGF0YS1kaXNwbGF5LW5vbmUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yYzk5ZTBmYzQ0NDI0NDM0NDYw YmYwMDE4Y2UxOTMwODBiMTQyOGRmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcHJp bnRpbmcvcGFnZS1mb3JtYXQtZGF0YS1kaXNwbGF5LW5vbmUuaHRtbApAQCAtMCwwICsxLDMzIEBA Cis8IWRvY3R5cGUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8dGl0bGU+VGVzdCBmb3IgQnVnIDQ4 OTg0IC0gW0Nocm9taXVtXSBAbWVkaWEgcHJpbnQgY3Jhc2ggZHVlIHRvIHBhZ2VkIG1lZGlhIHN1 cHBvcnQ8L3RpdGxlPgorPHN0eWxlPgorKiB7IGRpc3BsYXk6IG5vbmU7IH0KKzwvc3R5bGU+Cis8 L2hlYWQ+Cis8Ym9keT4KKzxkaXYgaWQ9Im91dHB1dCI+CitUZXN0IGhhcyBub3QgcnVuIHlldC4K K0NsaWNrIHRoZSBwcmludCBidXR0b24gYW5kIHNlZSBpZiBDaHJvbWl1bSBjcmFzaGVzLgorPGlu cHV0IHR5cGU9ImJ1dHRvbiIgdmFsdWU9InByaW50IiBvbmNsaWNrPSJ0ZXN0TWFudWFsbHkoKSIv PgorPC9kaXY+Cis8c2NyaXB0PgorZnVuY3Rpb24gdGVzdE1hbnVhbGx5KCkgeworICAgIGRvY3Vt ZW50LmRvY3VtZW50RWxlbWVudC5zdHlsZS5kaXNwbGF5ID0gIm5vbmUiOworICAgIHdpbmRvdy5w cmludCgpOworfQorCitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5 b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgLy8gVGhlIHRlc3QgcGFzc2Vz IGlmIHRoZSBmb2xsb3dpbmcgbGluZSBkb2Vzbid0IGNhdXNlIGEgY3Jhc2guCisgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIucGFnZVNpemVBbmRNYXJnaW5zSW5QaXhlbHMoMCwgMTAwLCAyMDAsIDEs IDIsIDMsIDQpOworCisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm91dHB1dCIpLmlubmVy SFRNTCA9ICJQQVNTIjsKK30KKy8vIFJlbW92ZSB0aGUgZGlzcGxheTogbm9uZTsgcnVsZS4gT3Ro ZXJ3aXNlLCBEdW1wUmVuZGVyVHJlZSBkdW1wcyB3ZWlyZCBzdHVmZi4KK2RvY3VtZW50LnN0eWxl U2hlZXRzWzBdLnJlbW92ZVJ1bGUoMCk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTkz ZDU0NWI4ZGYwMzAxMmFkZjg2MzVmYmQzZWJhNTVmYTk4ZTZlZC4uYTk4NmQ0YzgyOGY3NjUzMmIz M2VmODcyZTgzNTUyNDIyNWNmNjQ5MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMS0wOCAgWXV6byBG dWppc2hpbWEgIDx5dXpvQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRml4IGZvciBCdWcgNDg5ODQgLSBbQ2hyb21pdW1dIEBtZWRp YSBwcmludCBjcmFzaCBkdWUgdG8gcGFnZWQgbWVkaWEgc3VwcG9ydAorICAgICAgICBQYWdlIGNv bnRleHQgaGFzIGJlZW4gaW5oZXJpdGluZyBmcm9tIGRvY3VtZW50IGVsZW1lbnQgc3R5bGUgdGhh dCBiZWNvbWVzIG51bGwgaWYgZGlzcGxheSBwcm9wZXJ0eSBpcyBub25lLgorICAgICAgICBJdCBz aG91bGQgaW5oZXJpdCBmcm9tIGRvY3VtZW50IHN0eWxlIGluc3RlYWQgdG8gcHJvcGVybHkgaGFu ZGxlIGRpcmVjdGlvbiBwcm9wZXJ0eSAoYW5kIHRvIGF2b2lkIHRoZSBudWxsIHJlZmVyZW5jZSku CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODk4NAor CisgICAgICAgIFRlc3Q6IHByaW50aW5nL3BhZ2UtZm9ybWF0LWRhdGEtZGlzcGxheS1ub25lLmh0 bWwKKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNTU1N0eWxlU2VsZWN0b3I6OnN0eWxlRm9yUGFnZSk6IFBhZ2UgY29udGV4dCBpbmhlcml0 cyBmcm9tCisgICAgICAgIGRvY3VtZW50IHN0eWxlLgorCiAyMDEwLTExLTA1ICBIZWxkZXIgQ29y cmVpYSAgPGhlbGRlckBzZW5jaGEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMg S2xpbmcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcCBiL1dl YkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCmluZGV4IDMxN2ZjN2U3MjY1MzlhMjMyODAx NTczMjQxMTdhYTllYjQ5YjdjZjIuLjYzZWVhZGYyYzU2NzY1ODMzZjg1MzhkMDcwNTJkYjRkOTQ2 OTcxNTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCisrKyBi L1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCkBAIC0xNjAyLDcgKzE2MDIsNyBAQCBQ YXNzUmVmUHRyPFJlbmRlclN0eWxlPiBDU1NTdHlsZVNlbGVjdG9yOjpwc2V1ZG9TdHlsZUZvckVs ZW1lbnQoUHNldWRvSWQgcHNldWRvLAogCiBQYXNzUmVmUHRyPFJlbmRlclN0eWxlPiBDU1NTdHls ZVNlbGVjdG9yOjpzdHlsZUZvclBhZ2UoaW50IHBhZ2VJbmRleCkKIHsKLSAgICBpbml0Rm9yU3R5 bGVSZXNvbHZlKG1fY2hlY2tlci5tX2RvY3VtZW50LT5ib2R5KCkpOworICAgIGluaXRGb3JTdHls ZVJlc29sdmUobV9jaGVja2VyLm1fZG9jdW1lbnQtPmRvY3VtZW50RWxlbWVudCgpKTsgLy8gbV9y b290RWxlbWVudFN0eWxlIHdpbGwgYmUgc2V0IHRvIHRoZSBkb2N1bWVudCBzdHlsZS4KIAogICAg IG1fc3R5bGUgPSBSZW5kZXJTdHlsZTo6Y3JlYXRlKCk7CiAgICAgbV9zdHlsZS0+aW5oZXJpdEZy b20obV9yb290RWxlbWVudFN0eWxlKTsK