48964 2010-11-03 18:20:22 -0700 Linker error, undefined reference WebCore::setsetCookieStoragePrivateBrowsingEnabled(bool) 2010-11-04 11:03:08 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 0 jreck webkit-unassigned ap commit-queue steveblock oldest_to_newest 304394 0 jreck 2010-11-03 18:20:22 -0700 Linker error building Settings.cpp for Android, undefined reference to WebCore::setCookieStoragePrivateBrowsingEnabled(bool). 304395 1 72891 jreck 2010-11-03 18:21:57 -0700 Created attachment 72891 Patch that moves the setCookieStoragePrivateBrowsingEnabled stub into the WebCore namespace 304445 2 72891 ap 2010-11-03 20:02:26 -0700 Comment on attachment 72891 Patch that moves the setCookieStoragePrivateBrowsingEnabled stub into the WebCore namespace Sorry, r- due to lack of ChangeLog. 304501 3 steveblock 2010-11-03 23:56:52 -0700 It would be useful to include in the ChangeLog a link to the change that introduced the problem, and maybe CC the original author to check they're happy with the fix. 304507 4 ap 2010-11-04 00:04:27 -0700 This is certainly fine as a build fix. I'd welcome input from folks who know how private browsing works on Android and Chromium - perhaps we could refactor setCookieStoragePrivateBrowsingEnabled() in a way that doesn't involve dummy implementations on platforms that do this differently now. 304728 5 72957 jreck 2010-11-04 10:11:39 -0700 Created attachment 72957 Moved the Android setCookieStoragePrivateBrowsingEnabled(bool) stub to the WebCore namespace 304731 6 72957 steveblock 2010-11-04 10:19:18 -0700 Comment on attachment 72957 Moved the Android setCookieStoragePrivateBrowsingEnabled(bool) stub to the WebCore namespace View in context: https://bugs.webkit.org/attachment.cgi?id=72957&action=review Did you track down the original offending change? Would be good to link to it > WebCore/ChangeLog:9 > + a linker failure when building for Android. Moved the stub to the WebCore namespace. All WebCore changes need to mention how they're tested. In this case, 'No new tests, build fix only' is sufficient 304732 7 72958 jreck 2010-11-04 10:23:04 -0700 Created attachment 72958 Moved the Android setCookieStoragePrivateBrowsingEnabled(bool) stub to the WebCore namespace 3rd times a charm? *crosses fingers* heh 304737 8 72958 steveblock 2010-11-04 10:32:49 -0700 Comment on attachment 72958 Moved the Android setCookieStoragePrivateBrowsingEnabled(bool) stub to the WebCore namespace r=me 304758 9 commit-queue 2010-11-04 11:00:56 -0700 The commit-queue encountered the following flaky tests while processing attachment 72958: http/tests/xmlhttprequest/cross-origin-no-credential-prompt.html Please file bugs against the tests. These tests were authored by ap@webkit.org. The commit-queue is continuing to process your patch. 304762 10 72958 commit-queue 2010-11-04 11:03:03 -0700 Comment on attachment 72958 Moved the Android setCookieStoragePrivateBrowsingEnabled(bool) stub to the WebCore namespace Clearing flags on attachment: 72958 Committed r71346: <http://trac.webkit.org/changeset/71346> 304763 11 commit-queue 2010-11-04 11:03:08 -0700 All reviewed patches have been landed. Closing bug. 72891 2010-11-03 18:21:57 -0700 2010-11-04 10:11:39 -0700 Patch that moves the setCookieStoragePrivateBrowsingEnabled stub into the WebCore namespace linkStubPatch text/plain 496 jreck SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vYW5kcm9pZC9UZW1wb3JhcnlMaW5rU3R1YnMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vYW5kcm9pZC9UZW1wb3JhcnlMaW5rU3R1YnMu Y3BwCShyZXZpc2lvbiA3MDk0OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vYW5kcm9pZC9UZW1wb3Jh cnlMaW5rU3R1YnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MDEsOSArNTAxLDEzIEBAIE9wYXF1 ZUpTQ2xhc3NDb250ZXh0RGF0YTo6fk9wYXF1ZUpTQ2xhc3MKICAgICBub3RJbXBsZW1lbnRlZCgp OwogfQogCisjZW5kaWYKKworbmFtZXNwYWNlIFdlYkNvcmUgeworCiB2b2lkIHNldENvb2tpZVN0 b3JhZ2VQcml2YXRlQnJvd3NpbmdFbmFibGVkKGJvb2wpCiB7CiAgICAgbm90SW1wbGVtZW50ZWQo KTsKIH0KIAotI2VuZGlmCit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg== 72957 2010-11-04 10:11:39 -0700 2010-11-04 10:23:04 -0700 Moved the Android setCookieStoragePrivateBrowsingEnabled(bool) stub to the WebCore namespace linkStubPatch text/plain 1247 jreck SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTM0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMDQgIEpvaG4gUmVjayAgPGpyZWNrQGdvb2dsZS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGEg bGlua2VyIGZhaWx1cmUgd2hlbiBidWlsZGluZyBmb3IgQW5kcm9pZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg5NjQKKyAgICAgICAgCisgICAgICAg IFRoZSBBbmRyb2lkIHN0dWIgZm9yIHNldENvb2tpZVN0b3JhZ2VQcml2YXRlQnJvd3NpbmdFbmFi bGVkKGJvb2wpIHdhc24ndCBpbiB0aGUgV2ViQ29yZSBuYW1lc3BhY2UsIHdoaWNoIGNhdXNlZAor ICAgICAgICBhIGxpbmtlciBmYWlsdXJlIHdoZW4gYnVpbGRpbmcgZm9yIEFuZHJvaWQuIE1vdmVk IHRoZSBzdHViIHRvIHRoZSBXZWJDb3JlIG5hbWVzcGFjZS4KKworICAgICAgICAqIHBsYXRmb3Jt L2FuZHJvaWQvVGVtcG9yYXJ5TGlua1N0dWJzLmNwcDoKKwogMjAxMC0xMS0wNCAgSm9zZXBoIFBl Y29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJl YXMgS2xpbmcuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2FuZHJvaWQvVGVtcG9yYXJ5TGlua1N0 dWJzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2FuZHJvaWQvVGVtcG9yYXJ5 TGlua1N0dWJzLmNwcAkocmV2aXNpb24gNzA5NDkpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2FuZHJv aWQvVGVtcG9yYXJ5TGlua1N0dWJzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTAxLDkgKzUwMSwx MyBAQCBPcGFxdWVKU0NsYXNzQ29udGV4dERhdGE6On5PcGFxdWVKU0NsYXNzCiAgICAgbm90SW1w bGVtZW50ZWQoKTsKIH0KIAorI2VuZGlmCisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKwogdm9pZCBz ZXRDb29raWVTdG9yYWdlUHJpdmF0ZUJyb3dzaW5nRW5hYmxlZChib29sKQogewogICAgIG5vdElt cGxlbWVudGVkKCk7CiB9CiAKLSNlbmRpZgorfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 72958 2010-11-04 10:23:04 -0700 2010-11-04 11:03:03 -0700 Moved the Android setCookieStoragePrivateBrowsingEnabled(bool) stub to the WebCore namespace linkStubPatch text/plain 1363 jreck SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTM0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMTEtMDQgIEpvaG4gUmVjayAgPGpyZWNrQGdvb2dsZS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGEg bGlua2VyIGZhaWx1cmUgd2hlbiBidWlsZGluZyBmb3IgQW5kcm9pZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg5NjQKKyAgICAgICAgCisgICAgICAg IFRoZSBBbmRyb2lkIHN0dWIgZm9yIHNldENvb2tpZVN0b3JhZ2VQcml2YXRlQnJvd3NpbmdFbmFi bGVkKGJvb2wpIHdhc24ndCBpbiB0aGUgV2ViQ29yZSBuYW1lc3BhY2UsIHdoaWNoIGNhdXNlZAor ICAgICAgICBhIGxpbmtlciBmYWlsdXJlIHdoZW4gYnVpbGRpbmcgZm9yIEFuZHJvaWQuIE1vdmVk IHRoZSBzdHViIHRvIHRoZSBXZWJDb3JlIG5hbWVzcGFjZS4gVGhpcyB3YXMgY2F1c2VkIGJ5IAor ICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC83MDQwMAorICAgICAgICAK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBidWlsZCBmaXggb25seQorCisgICAgICAgICogcGxhdGZv cm0vYW5kcm9pZC9UZW1wb3JhcnlMaW5rU3R1YnMuY3BwOgorCiAyMDEwLTExLTA0ICBKb3NlcGgg UGVjb3Jhcm8gIDxqb2VwZWNrQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5k cmVhcyBLbGluZy4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vYW5kcm9pZC9UZW1wb3JhcnlMaW5r U3R1YnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vYW5kcm9pZC9UZW1wb3Jh cnlMaW5rU3R1YnMuY3BwCShyZXZpc2lvbiA3MDk0OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vYW5k cm9pZC9UZW1wb3JhcnlMaW5rU3R1YnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MDEsOSArNTAx LDEzIEBAIE9wYXF1ZUpTQ2xhc3NDb250ZXh0RGF0YTo6fk9wYXF1ZUpTQ2xhc3MKICAgICBub3RJ bXBsZW1lbnRlZCgpOwogfQogCisjZW5kaWYKKworbmFtZXNwYWNlIFdlYkNvcmUgeworCiB2b2lk IHNldENvb2tpZVN0b3JhZ2VQcml2YXRlQnJvd3NpbmdFbmFibGVkKGJvb2wpCiB7CiAgICAgbm90 SW1wbGVtZW50ZWQoKTsKIH0KIAotI2VuZGlmCit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==