48958 2010-11-03 15:23:23 -0700 [Qt] DRT sideeffect revealed by r71268 2011-05-02 07:27:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ossy webkit-unassigned benjamin commit-queue webkit.review.bot oldest_to_newest 304324 0 ossy 2010-11-03 15:23:23 -0700 After r71268, 15 tests fail on Qt bot: http://build.webkit.org/results/Qt%20Linux%20Release/r71268%20%2823109%29/results.html r71268 fixed an absolutely unrelated bug, and unskipped two tests: canvas/philip/tests/2d.pattern.image.null.html canvas/philip/tests/2d.pattern.image.undefined.html old-run-webkit-test script restarts DRT after 1000 tests, and this patch shifted the restart point, and the bug was revealed. 304332 1 ossy 2010-11-03 15:50:58 -0700 I added the unskipped tests to the Skipped list again, to make builbot happy: canvas/philip/tests/2d.pattern.image.null.html canvas/philip/tests/2d.pattern.image.undefined.html http://trac.webkit.org/changeset/71276 Tomorrow I'm going to find a real fix for this bug. 304403 2 ossy 2010-11-03 18:45:39 -0700 Unfortunately 3 new tests added in http://trac.webkit.org/changeset/71277 , and the 15 tests fail again. I found the real culprit: svg/custom/text-zoom.xhtml , and skipped it by http://trac.webkit.org/changeset/71295 396350 3 91917 feherzs 2011-05-02 06:01:52 -0700 Created attachment 91917 proposed fix 396353 4 webkit.review.bot 2011-05-02 06:04:39 -0700 Attachment 91917 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:557: Should have a space between // and comment [whitespace/comments] [4] Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:558: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 396354 5 91920 feherzs 2011-05-02 06:11:00 -0700 Created attachment 91920 proposed fix 396364 6 91920 ossy 2011-05-02 07:07:49 -0700 Comment on attachment 91920 proposed fix r=me 396377 7 91920 commit-queue 2011-05-02 07:27:41 -0700 Comment on attachment 91920 proposed fix Clearing flags on attachment: 91920 Committed r85474: <http://trac.webkit.org/changeset/85474> 396378 8 commit-queue 2011-05-02 07:27:46 -0700 All reviewed patches have been landed. Closing bug. 91917 2011-05-02 06:01:52 -0700 2011-05-02 06:11:00 -0700 proposed fix patch_to_bug48958.txt text/plain 3340 feherzs ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNDhlODQxLi5mOTVlNmNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQt MjcgIFpzb2x0IEZlaMOpciAgPGg0OTAyNjdAc3R1ZC51LXN6ZWdlZC5odT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEUlQgc2lkZWVmZmVjdCByZXZl YWxlZCBieSByNzEyNjgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ4OTU4CisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOiBVbnNraXAgc3Zn L2N1c3RvbS90ZXh0LXpvb20ueGh0bWwKKwogMjAxMS0wNC0yNiAgQ2hhbmcgU2h1ICA8Y3NodUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvU2tpcHBlZAppbmRleCAzZGYyMzhmLi4wZWQ2MjIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQKQEAgLTIyODMsMTAgKzIyODMsNiBAQCBmYXN0L21lZGlhL2NvbG9yLWRvZXMtbm90LWluY2x1 ZGUtYWxwaGEuaHRtbAogIyBSZXF1aXJlcyBXZWJQIHN1cHBvcnQuCiBmYXN0L2ltYWdlcy93ZWJw LWltYWdlLWRlY29kaW5nLmh0bWwKIAotIyBbUXRdIERSVCBzaWRlZWZmZWN0IHJldmVhbGVkIGJ5 IHI3MTI2OAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg5NTgK LXN2Zy9jdXN0b20vdGV4dC16b29tLnhodG1sCi0KICMgW1F0XSBzdmcvYW5pbWF0aW9ucy9hbmlt YXRlLXBhdGgtbmVzdGVkLXRyYW5zZm9ybXMuaHRtbCBmYWlscwogIyBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg5ODcKIHN2Zy9hbmltYXRpb25zL2FuaW1hdGUtcGF0 aC1uZXN0ZWQtdHJhbnNmb3Jtcy5odG1sCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9U b29scy9DaGFuZ2VMb2cKaW5kZXggNzNiZDIxNy4uYzBkZTVmNiAxMDA2NDQKLS0tIGEvVG9vbHMv Q2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDExLTA0 LTI3ICBac29sdCBGZWjDqXIgIDxoNDkwMjY3QHN0dWQudS1zemVnZWQuaHU+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRFJUIHNpZGVlZmZlY3QgcmV2 ZWFsZWQgYnkgcjcxMjY4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDg5NTgKKworICAgICAgICBSZXNldCBRV2ViU2V0dGluZ3M6Olpvb21UZXh0T25s eSBhdHRyaWJ1dGUgYmVmb3JlIGFsbCB0ZXN0cy4gCisKKyAgICAgICAgQ2FsbCBzZXRUZXh0U2l6 ZU11bHRpcGxpZXIoMS4wKSB0byByZXNldCBUZXh0Wm9vbUZhY3RvciBhbmQgCisgICAgICAgIFBh Z2Vab29tRmFjdG9yIHRvby4gSXQgc2hvdWxkIGJlIGRvbmUgYmVmb3JlIHJlc2V0c2V0dGluZ3Mo KSAKKyAgICAgICAgdG8gZ3VhcmFudGVlIHJlc2V0dGluZyBRV2ViU2V0dGluZ3M6Olpvb21UZXh0 T25seSBjb3JyZWN0bHkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVy VHJlZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYlBhZ2U6OnJlc2V0U2V0dGluZ3MpOgor ICAgICAgICAoV2ViQ29yZTo6RHVtcFJlbmRlclRyZWU6OnJlc2V0VG9Db25zaXN0ZW50U3RhdGVC ZWZvcmVUZXN0aW5nKToKKwogMjAxMS0wNC0yNSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93ZS4KZGlmZiAtLWdpdCBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKaW5kZXggMWE2YzgzMy4uNjA2ZjkzYSAxMDA2 NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKKysr IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKQEAgLTE5NCw2 ICsxOTQsNyBAQCB2b2lkIFdlYlBhZ2U6OnJlc2V0U2V0dGluZ3MoKQogICAgIHNldHRpbmdzKCkt PnJlc2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6UGx1Z2luc0VuYWJsZWQpOwogICAgIHNldHRp bmdzKCktPnJlc2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6SmF2YXNjcmlwdENhbkFjY2Vzc0Ns aXBib2FyZCk7CiAgICAgc2V0dGluZ3MoKS0+cmVzZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpB dXRvTG9hZEltYWdlcyk7CisgICAgc2V0dGluZ3MoKS0+cmVzZXRBdHRyaWJ1dGUoUVdlYlNldHRp bmdzOjpab29tVGV4dE9ubHkpOwogCiAgICAgbV9kcnQtPmxheW91dFRlc3RDb250cm9sbGVyKCkt PnNldENhcmV0QnJvd3NpbmdFbmFibGVkKGZhbHNlKTsKICAgICBtX2RydC0+bGF5b3V0VGVzdENv bnRyb2xsZXIoKS0+c2V0RnJhbWVGbGF0dGVuaW5nRW5hYmxlZChmYWxzZSk7CkBAIC01NTIsMTIg KzU1MywxNiBAQCB2b2lkIER1bXBSZW5kZXJUcmVlOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlQmVm b3JlVGVzdGluZyhjb25zdCBRVXJsJiB1cmwpCiAgICAgbV9ldmVudFNlbmRlci0+cmVzZXRDbGlj a0NvdW50KCk7CiAKICAgICBjbG9zZVJlbWFpbmluZ1dpbmRvd3MoKTsKKyAgICAKKyAgICAvL0Nh bGwgc2V0VGV4dFNpemVNdWx0aXBsaWVyKDEuMCkgdG8gcmVzZXQgVGV4dFpvb21GYWN0b3IgYW5k IFBhZ2Vab29tRmFjdG9yIHRvby4gCisgICAgLy9JdCBzaG91bGQgYmUgZG9uZSBiZWZvcmUgcmVz ZXRTZXR0aW5ncygpIHRvIGd1YXJhbnRlZSByZXNldHRpbmcgUVdlYlNldHRpbmdzOjpab29tVGV4 dE9ubHkgY29ycmVjdGx5LgorICAgIG1fcGFnZS0+bWFpbkZyYW1lKCktPnNldFRleHRTaXplTXVs dGlwbGllcigxLjApOwogCiAgICAgbV9wYWdlLT5yZXNldFNldHRpbmdzKCk7CiAjaWZuZGVmIFFU X05PX1VORE9TVEFDSwogICAgIG1fcGFnZS0+dW5kb1N0YWNrKCktPmNsZWFyKCk7CiAjZW5kaWYK LSAgICBtX3BhZ2UtPm1haW5GcmFtZSgpLT5zZXRab29tRmFjdG9yKDEuMCk7CisgICAgCiAgICAg Y2xlYXJIaXN0b3J5KG1fcGFnZSk7CiAgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6OmNsZWFy RnJhbWVOYW1lKG1fcGFnZS0+bWFpbkZyYW1lKCkpOwogCg== 91920 2011-05-02 06:11:00 -0700 2011-05-02 07:27:41 -0700 proposed fix patch_to_bug48958.txt text/plain 3342 feherzs ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNDhlODQxLi5mOTVlNmNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQt MjcgIFpzb2x0IEZlaMOpciAgPGg0OTAyNjdAc3R1ZC51LXN6ZWdlZC5odT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEUlQgc2lkZWVmZmVjdCByZXZl YWxlZCBieSByNzEyNjgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ4OTU4CisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOiBVbnNraXAgc3Zn L2N1c3RvbS90ZXh0LXpvb20ueGh0bWwKKwogMjAxMS0wNC0yNiAgQ2hhbmcgU2h1ICA8Y3NodUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvU2tpcHBlZAppbmRleCAzZGYyMzhmLi4wZWQ2MjIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQKQEAgLTIyODMsMTAgKzIyODMsNiBAQCBmYXN0L21lZGlhL2NvbG9yLWRvZXMtbm90LWluY2x1 ZGUtYWxwaGEuaHRtbAogIyBSZXF1aXJlcyBXZWJQIHN1cHBvcnQuCiBmYXN0L2ltYWdlcy93ZWJw LWltYWdlLWRlY29kaW5nLmh0bWwKIAotIyBbUXRdIERSVCBzaWRlZWZmZWN0IHJldmVhbGVkIGJ5 IHI3MTI2OAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg5NTgK LXN2Zy9jdXN0b20vdGV4dC16b29tLnhodG1sCi0KICMgW1F0XSBzdmcvYW5pbWF0aW9ucy9hbmlt YXRlLXBhdGgtbmVzdGVkLXRyYW5zZm9ybXMuaHRtbCBmYWlscwogIyBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg5ODcKIHN2Zy9hbmltYXRpb25zL2FuaW1hdGUtcGF0 aC1uZXN0ZWQtdHJhbnNmb3Jtcy5odG1sCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9U b29scy9DaGFuZ2VMb2cKaW5kZXggNzNiZDIxNy4uYzBkZTVmNiAxMDA2NDQKLS0tIGEvVG9vbHMv Q2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDExLTA0 LTI3ICBac29sdCBGZWjDqXIgIDxoNDkwMjY3QHN0dWQudS1zemVnZWQuaHU+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRFJUIHNpZGVlZmZlY3QgcmV2 ZWFsZWQgYnkgcjcxMjY4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDg5NTgKKworICAgICAgICBSZXNldCBRV2ViU2V0dGluZ3M6Olpvb21UZXh0T25s eSBhdHRyaWJ1dGUgYmVmb3JlIGFsbCB0ZXN0cy4gCisKKyAgICAgICAgQ2FsbCBzZXRUZXh0U2l6 ZU11bHRpcGxpZXIoMS4wKSB0byByZXNldCBUZXh0Wm9vbUZhY3RvciBhbmQgCisgICAgICAgIFBh Z2Vab29tRmFjdG9yIHRvby4gSXQgc2hvdWxkIGJlIGRvbmUgYmVmb3JlIHJlc2V0c2V0dGluZ3Mo KSAKKyAgICAgICAgdG8gZ3VhcmFudGVlIHJlc2V0dGluZyBRV2ViU2V0dGluZ3M6Olpvb21UZXh0 T25seSBjb3JyZWN0bHkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVy VHJlZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYlBhZ2U6OnJlc2V0U2V0dGluZ3MpOgor ICAgICAgICAoV2ViQ29yZTo6RHVtcFJlbmRlclRyZWU6OnJlc2V0VG9Db25zaXN0ZW50U3RhdGVC ZWZvcmVUZXN0aW5nKToKKwogMjAxMS0wNC0yNSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93ZS4KZGlmZiAtLWdpdCBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKaW5kZXggMWE2YzgzMy4uMmJiN2FhNSAxMDA2 NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKKysr IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKQEAgLTE5NCw2 ICsxOTQsNyBAQCB2b2lkIFdlYlBhZ2U6OnJlc2V0U2V0dGluZ3MoKQogICAgIHNldHRpbmdzKCkt PnJlc2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6UGx1Z2luc0VuYWJsZWQpOwogICAgIHNldHRp bmdzKCktPnJlc2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6SmF2YXNjcmlwdENhbkFjY2Vzc0Ns aXBib2FyZCk7CiAgICAgc2V0dGluZ3MoKS0+cmVzZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpB dXRvTG9hZEltYWdlcyk7CisgICAgc2V0dGluZ3MoKS0+cmVzZXRBdHRyaWJ1dGUoUVdlYlNldHRp bmdzOjpab29tVGV4dE9ubHkpOwogCiAgICAgbV9kcnQtPmxheW91dFRlc3RDb250cm9sbGVyKCkt PnNldENhcmV0QnJvd3NpbmdFbmFibGVkKGZhbHNlKTsKICAgICBtX2RydC0+bGF5b3V0VGVzdENv bnRyb2xsZXIoKS0+c2V0RnJhbWVGbGF0dGVuaW5nRW5hYmxlZChmYWxzZSk7CkBAIC01NTIsMTIg KzU1MywxNiBAQCB2b2lkIER1bXBSZW5kZXJUcmVlOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlQmVm b3JlVGVzdGluZyhjb25zdCBRVXJsJiB1cmwpCiAgICAgbV9ldmVudFNlbmRlci0+cmVzZXRDbGlj a0NvdW50KCk7CiAKICAgICBjbG9zZVJlbWFpbmluZ1dpbmRvd3MoKTsKKyAgICAKKyAgICAvLyBD YWxsIHNldFRleHRTaXplTXVsdGlwbGllcigxLjApIHRvIHJlc2V0IFRleHRab29tRmFjdG9yIGFu ZCBQYWdlWm9vbUZhY3RvciB0b28uIAorICAgIC8vIEl0IHNob3VsZCBiZSBkb25lIGJlZm9yZSBy ZXNldFNldHRpbmdzKCkgdG8gZ3VhcmFudGVlIHJlc2V0dGluZyBRV2ViU2V0dGluZ3M6Olpvb21U ZXh0T25seSBjb3JyZWN0bHkuCisgICAgbV9wYWdlLT5tYWluRnJhbWUoKS0+c2V0VGV4dFNpemVN dWx0aXBsaWVyKDEuMCk7CiAKICAgICBtX3BhZ2UtPnJlc2V0U2V0dGluZ3MoKTsKICNpZm5kZWYg UVRfTk9fVU5ET1NUQUNLCiAgICAgbV9wYWdlLT51bmRvU3RhY2soKS0+Y2xlYXIoKTsKICNlbmRp ZgotICAgIG1fcGFnZS0+bWFpbkZyYW1lKCktPnNldFpvb21GYWN0b3IoMS4wKTsKKyAgICAKICAg ICBjbGVhckhpc3RvcnkobV9wYWdlKTsKICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6Y2xl YXJGcmFtZU5hbWUobV9wYWdlLT5tYWluRnJhbWUoKSk7CiAK