48946 2010-11-03 13:27:51 -0700 Crash under WebCore::platformDefaultLanguage() when using Arabic language 2010-11-08 20:41:10 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P1 Normal --- 1 mthole mthole ap oldest_to_newest 304239 0 mthole 2010-11-03 13:27:51 -0700 After choosing the Arabic locale, launching Safari and navigating somewhere will cause a crash: 1 libobjc.A.dylib 0x7fff82ae8318 objc_msgSend_vtable13 + 0x10 > 2 com.apple.WebCore 0x101e0a5bd WebCore::platformDefaultLanguage() + 0x3d (Language.mm:100) 3 com.apple.WebCore 0x101e09e38 WebCore::defaultLanguage() + 0x38 (Language.cpp:72) 4 com.apple.WebKit 0x1012c9cc9 +[NSUserDefaults(WebNSUserDefaultsExtras) _webkit_preferredLanguageCode] + 0x19 (WebNSUserDefaultsExtras.mm:40) 5 com.apple.WebKit 0x1012fb835 +[WebView(WebPrivate) _standardUserAgentWithApplicationName:] + 0x55 (WebView.mm:550) 6 com.apple.Safari.framework 0x10020ae15 Safari::SWebView::defaultUserAgent() + 0x47 (SWebView.mac.mm:166) 304250 1 72863 mthole 2010-11-03 13:38:42 -0700 Created attachment 72863 Proposed patch 304263 2 72863 ap 2010-11-03 13:49:43 -0700 Comment on attachment 72863 Proposed patch Oops. 304270 3 mthole 2010-11-03 13:55:28 -0700 Committed revision 71264. 304284 4 72863 darin 2010-11-03 14:14:23 -0700 Comment on attachment 72863 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=72863&action=review > WebCore/platform/mac/Language.mm:62 > + NSString *httpStyleLanguageCode = nil; It would be clearer to define this just before it’s initialized rather than putting the definition at the top of the function. If you did that it would be clear you need not set it to nil since it’s already initialized in all code paths. > WebCore/platform/mac/Language.mm:79 > + } > + else We put the } on the same line as the “else” in WebKit coding style. 304304 5 mthole 2010-11-03 14:46:21 -0700 Tweaked style per Darin's comments in r71271. 306593 6 ap 2010-11-08 20:41:10 -0800 <rdar://problem/8644034> 72863 2010-11-03 13:38:42 -0700 2010-11-03 14:14:23 -0700 Proposed patch textmate stdin hvm2rq.txt text/plain 2441 mthole SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTI2MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMDMgIE1pa2UgVGhvbGUgIDxtdGhvbGVAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyYXNo IHVuZGVyIFdlYkNvcmU6OnBsYXRmb3JtRGVmYXVsdExhbmd1YWdlKCkgd2hlbiB1c2luZyBBcmFi aWMgbGFuZ3VhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ4OTQ2CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvTGFuZ3VhZ2UubW06CisgICAgICAg IChXZWJDb3JlOjpjcmVhdGVIVFRQU3R5bGVMYW5ndWFnZUNvZGUpOgorICAgICAgICBSZXRhaW4g dGhlIGxvd2VyY2FzZUxhbmd1YWdlQ29kZSBzdHJpbmcgYmVmb3JlIHJldHVybmluZyBpdC4gIFRo aXMgd2FzIHRoZSBjb2RlIHBhdGggdGhhdAorICAgICAgICB3b3VsZCBsZWFkIHRvIGEgY3Jhc2gu ICBBbHNvIHJlbW92ZWQgZWFybHkgcmV0dXJuIHRvIHByZXZlbnQgYSBsZWFrIG9mIHByZWZlcnJl ZExhbmd1YWdlQ29kZS4KKwogMjAxMC0xMS0wMyAgTm8nYW0gUm9zZW50aGFsICA8bm9hbS5yb3Nl bnRoYWxAbm9raWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvciByNzEy NTMKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbWFjL0xhbmd1YWdlLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGxhdGZvcm0vbWFjL0xhbmd1YWdlLm1tCShyZXZpc2lvbiA3MTI0MykKKysrIFdl YkNvcmUvcGxhdGZvcm0vbWFjL0xhbmd1YWdlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01OSw2ICs1 OSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIHN0YXRpYyBOU1N0cmluZyAqY3JlYXRlSFRUUFN0 eWxlTGFuZ3VhZ2VDb2RlKE5TU3RyaW5nICpsYW5ndWFnZUNvZGUpCiB7CiAgICAgQVNTRVJUKGlz TWFpblRocmVhZCgpKTsKKyAgICBOU1N0cmluZyAqaHR0cFN0eWxlTGFuZ3VhZ2VDb2RlID0gbmls OwogCiAgICAgLy8gTG9vayB1cCB0aGUgbGFuZ3VhZ2UgY29kZSB1c2luZyBDRkJ1bmRsZS4KICAg ICBDRlN0cmluZ1JlZiBwcmVmZXJyZWRMYW5ndWFnZUNvZGUgPSB3a0NvcHlDRkxvY2FsaXphdGlv blByZWZlcnJlZE5hbWUoKENGU3RyaW5nUmVmKWxhbmd1YWdlQ29kZSk7CkBAIC03MCwxNiArNzEs MTggQEAgc3RhdGljIE5TU3RyaW5nICpjcmVhdGVIVFRQU3R5bGVMYW5ndWFnZQogICAgIE5TU3Ry aW5nICpsb3dlcmNhc2VMYW5ndWFnZUNvZGUgPSBbbGFuZ3VhZ2VDb2RlIGxvd2VyY2FzZVN0cmlu Z107CiAgICAgCiAgICAgLy8gVHVybiBhICdfJyBpbnRvIGEgJy0nIGlmIGl0IGFwcGVhcnMgYWZ0 ZXIgYSAyLWxldHRlciBsYW5ndWFnZSBjb2RlLgotICAgIGlmIChbbG93ZXJjYXNlTGFuZ3VhZ2VD b2RlIGxlbmd0aF0gPCAzIHx8IFtsb3dlcmNhc2VMYW5ndWFnZUNvZGUgY2hhcmFjdGVyQXRJbmRl eDoyXSAhPSAnXycpCi0gICAgICAgIHJldHVybiBsb3dlcmNhc2VMYW5ndWFnZUNvZGU7Ci0KLSAg ICBOU011dGFibGVTdHJpbmcgKnJlc3VsdCA9IFtsb3dlcmNhc2VMYW5ndWFnZUNvZGUgbXV0YWJs ZUNvcHldOwotICAgIFtyZXN1bHQgcmVwbGFjZUNoYXJhY3RlcnNJblJhbmdlOk5TTWFrZVJhbmdl KDIsIDEpIHdpdGhTdHJpbmc6QCItIl07Ci0KKyAgICBpZiAoW2xvd2VyY2FzZUxhbmd1YWdlQ29k ZSBsZW5ndGhdID49IDMgJiYgW2xvd2VyY2FzZUxhbmd1YWdlQ29kZSBjaGFyYWN0ZXJBdEluZGV4 OjJdID09ICdfJykgeworICAgICAgICBOU011dGFibGVTdHJpbmcgKm11dGFibGVMYW5ndWFnZUNv ZGUgPSBbbG93ZXJjYXNlTGFuZ3VhZ2VDb2RlIG11dGFibGVDb3B5XTsKKyAgICAgICAgW211dGFi bGVMYW5ndWFnZUNvZGUgcmVwbGFjZUNoYXJhY3RlcnNJblJhbmdlOk5TTWFrZVJhbmdlKDIsIDEp IHdpdGhTdHJpbmc6QCItIl07CisgICAgICAgIGh0dHBTdHlsZUxhbmd1YWdlQ29kZSA9IG11dGFi bGVMYW5ndWFnZUNvZGU7CisgICAgfQorICAgIGVsc2UKKyAgICAgICAgaHR0cFN0eWxlTGFuZ3Vh Z2VDb2RlID0gW2xvd2VyY2FzZUxhbmd1YWdlQ29kZSByZXRhaW5dOworICAgIAogICAgIGlmIChw cmVmZXJyZWRMYW5ndWFnZUNvZGUpCiAgICAgICAgIENGUmVsZWFzZShwcmVmZXJyZWRMYW5ndWFn ZUNvZGUpOwogCi0gICAgcmV0dXJuIHJlc3VsdDsKKyAgICByZXR1cm4gaHR0cFN0eWxlTGFuZ3Vh Z2VDb2RlOwogfQogCiBTdHJpbmcgcGxhdGZvcm1EZWZhdWx0TGFuZ3VhZ2UoKQo=