48945 2010-11-03 13:02:25 -0700 Patch logicalLeftSelectionOffset and logicalRightSelectionOffset 2010-11-03 13:27:40 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 47237 1 hyatt hyatt oldest_to_newest 304224 0 hyatt 2010-11-03 13:02:25 -0700 Patch logicalLeftSelectionOffset and logicalRightSelectionOffset to be directionally abstract. 304227 1 72854 hyatt 2010-11-03 13:04:24 -0700 Created attachment 72854 Patch 304238 2 hyatt 2010-11-03 13:27:40 -0700 Fixed in r71259. 72854 2010-11-03 13:04:24 -0700 2010-11-03 13:09:46 -0700 Patch patch.txt text/plain 4748 hyatt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTI1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTEtMDMgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODk0NQorICAgICAgICAKKyAgICAg ICAgUGF0Y2ggbG9naWNhbExlZnRTZWxlY3Rpb25PZmZzZXQgYW5kIGxvZ2ljYWxSaWdodFNlbGVj dGlvbk9mZnNldCB0byBiZSBkaXJlY3Rpb25hbGx5IGFic3RyYWN0LgorICAgICAgICAKKyAgICAg ICAgQWxzbyBtYWtlIHN1cmUgd3JpdGluZyBtb2RlIHJvb3RzIGFyZSBhbHNvIHNlbGVjdGlvbiBw YWludGluZyByb290cy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6aXNTZWxlY3Rpb25Sb290KToKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlckJsb2NrOjpsb2dpY2FsTGVmdFNlbGVjdGlvbk9mZnNldCk6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6bG9naWNhbFJpZ2h0U2VsZWN0aW9uT2Zmc2V0KToK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suaDoKKwogMjAxMC0xMS0wMyAgUGF2ZWwg RmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBU aW1vdGh5IEhhdGNoZXIuCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lv biA3MTI1NikKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjUyNiw3ICsyNTI2LDcgQEAgYm9vbCBSZW5kZXJCbG9jazo6aXNTZWxlY3Rpb25S b290KCkgY29ucwogICAgICAgICAKICAgICBpZiAoaXNCb2R5KCkgfHwgaXNSb290KCkgfHwgaGFz T3ZlcmZsb3dDbGlwKCkgfHwgaXNSZWxQb3NpdGlvbmVkKCkgfHwKICAgICAgICAgaXNGbG9hdGlu Z09yUG9zaXRpb25lZCgpIHx8IGlzVGFibGVDZWxsKCkgfHwgaXNJbmxpbmVCbG9ja09ySW5saW5l VGFibGUoKSB8fCBoYXNUcmFuc2Zvcm0oKSB8fAotICAgICAgICBoYXNSZWZsZWN0aW9uKCkgfHwg aGFzTWFzaygpKQorICAgICAgICBoYXNSZWZsZWN0aW9uKCkgfHwgaGFzTWFzaygpIHx8IGlzV3Jp dGluZ01vZGVSb290KCkpCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIAogICAgIGlmICh2aWV3 KCkgJiYgdmlldygpLT5zZWxlY3Rpb25TdGFydCgpKSB7CkBAIC0yODMzLDQzICsyODMzLDQzIEBA IHZvaWQgUmVuZGVyQmxvY2s6OmdldFNlbGVjdGlvbkdhcEluZm8oU2UKICAgICAgICAgICAgICAg IChzdGF0ZSA9PSBSZW5kZXJPYmplY3Q6OlNlbGVjdGlvbkVuZCAmJiAhbHRyKTsKIH0KIAotaW50 IFJlbmRlckJsb2NrOjpsb2dpY2FsTGVmdFNlbGVjdGlvbk9mZnNldChSZW5kZXJCbG9jayogcm9v dEJsb2NrLCBpbnQgeVBvcykKK2ludCBSZW5kZXJCbG9jazo6bG9naWNhbExlZnRTZWxlY3Rpb25P ZmZzZXQoUmVuZGVyQmxvY2sqIHJvb3RCbG9jaywgaW50IHBvc2l0aW9uKQogewotICAgIGludCBs ZWZ0ID0gbG9naWNhbExlZnRPZmZzZXRGb3JMaW5lKHlQb3MsIGZhbHNlKTsKLSAgICBpZiAobGVm dCA9PSBib3JkZXJMZWZ0KCkgKyBwYWRkaW5nTGVmdCgpKSB7CisgICAgaW50IGxvZ2ljYWxMZWZ0 ID0gbG9naWNhbExlZnRPZmZzZXRGb3JMaW5lKHBvc2l0aW9uLCBmYWxzZSk7CisgICAgaWYgKGxv Z2ljYWxMZWZ0ID09IGxvZ2ljYWxMZWZ0T2Zmc2V0Rm9yQ29udGVudCgpKSB7CiAgICAgICAgIGlm IChyb290QmxvY2sgIT0gdGhpcykKICAgICAgICAgICAgIC8vIFRoZSBib3JkZXIgY2FuIHBvdGVu dGlhbGx5IGJlIGZ1cnRoZXIgZXh0ZW5kZWQgYnkgb3VyIGNvbnRhaW5pbmdCbG9jaygpLgotICAg ICAgICAgICAgcmV0dXJuIGNvbnRhaW5pbmdCbG9jaygpLT5sb2dpY2FsTGVmdFNlbGVjdGlvbk9m ZnNldChyb290QmxvY2ssIHlQb3MgKyB5KCkpOwotICAgICAgICByZXR1cm4gbGVmdDsKKyAgICAg ICAgICAgIHJldHVybiBjb250YWluaW5nQmxvY2soKS0+bG9naWNhbExlZnRTZWxlY3Rpb25PZmZz ZXQocm9vdEJsb2NrLCBwb3NpdGlvbiArIGxvZ2ljYWxUb3AoKSk7CisgICAgICAgIHJldHVybiBs b2dpY2FsTGVmdDsKICAgICB9CiAgICAgZWxzZSB7CiAgICAgICAgIFJlbmRlckJsb2NrKiBjYiA9 IHRoaXM7CiAgICAgICAgIHdoaWxlIChjYiAhPSByb290QmxvY2spIHsKLSAgICAgICAgICAgIGxl ZnQgKz0gY2ItPngoKTsKKyAgICAgICAgICAgIGxvZ2ljYWxMZWZ0ICs9IGNiLT5sb2dpY2FsTGVm dCgpOwogICAgICAgICAgICAgY2IgPSBjYi0+Y29udGFpbmluZ0Jsb2NrKCk7CiAgICAgICAgIH0K ICAgICB9CiAgICAgCi0gICAgcmV0dXJuIGxlZnQ7CisgICAgcmV0dXJuIGxvZ2ljYWxMZWZ0Owog fQogCi1pbnQgUmVuZGVyQmxvY2s6OmxvZ2ljYWxSaWdodFNlbGVjdGlvbk9mZnNldChSZW5kZXJC bG9jayogcm9vdEJsb2NrLCBpbnQgeVBvcykKK2ludCBSZW5kZXJCbG9jazo6bG9naWNhbFJpZ2h0 U2VsZWN0aW9uT2Zmc2V0KFJlbmRlckJsb2NrKiByb290QmxvY2ssIGludCBwb3NpdGlvbikKIHsK LSAgICBpbnQgcmlnaHQgPSBsb2dpY2FsUmlnaHRPZmZzZXRGb3JMaW5lKHlQb3MsIGZhbHNlKTsK LSAgICBpZiAocmlnaHQgPT0gKGNvbnRlbnRXaWR0aCgpICsgKGJvcmRlckxlZnQoKSArIHBhZGRp bmdMZWZ0KCkpKSkgeworICAgIGludCBsb2dpY2FsUmlnaHQgPSBsb2dpY2FsUmlnaHRPZmZzZXRG b3JMaW5lKHBvc2l0aW9uLCBmYWxzZSk7CisgICAgaWYgKGxvZ2ljYWxSaWdodCA9PSBsb2dpY2Fs UmlnaHRPZmZzZXRGb3JDb250ZW50KCkpIHsKICAgICAgICAgaWYgKHJvb3RCbG9jayAhPSB0aGlz KQogICAgICAgICAgICAgLy8gVGhlIGJvcmRlciBjYW4gcG90ZW50aWFsbHkgYmUgZnVydGhlciBl eHRlbmRlZCBieSBvdXIgY29udGFpbmluZ0Jsb2NrKCkuCi0gICAgICAgICAgICByZXR1cm4gY29u dGFpbmluZ0Jsb2NrKCktPmxvZ2ljYWxSaWdodFNlbGVjdGlvbk9mZnNldChyb290QmxvY2ssIHlQ b3MgKyB5KCkpOwotICAgICAgICByZXR1cm4gcmlnaHQ7CisgICAgICAgICAgICByZXR1cm4gY29u dGFpbmluZ0Jsb2NrKCktPmxvZ2ljYWxSaWdodFNlbGVjdGlvbk9mZnNldChyb290QmxvY2ssIHBv c2l0aW9uICsgbG9naWNhbFRvcCgpKTsKKyAgICAgICAgcmV0dXJuIGxvZ2ljYWxSaWdodDsKICAg ICB9CiAgICAgZWxzZSB7CiAgICAgICAgIFJlbmRlckJsb2NrKiBjYiA9IHRoaXM7CiAgICAgICAg IHdoaWxlIChjYiAhPSByb290QmxvY2spIHsKLSAgICAgICAgICAgIHJpZ2h0ICs9IGNiLT54KCk7 CisgICAgICAgICAgICBsb2dpY2FsUmlnaHQgKz0gY2ItPmxvZ2ljYWxMZWZ0KCk7CiAgICAgICAg ICAgICBjYiA9IGNiLT5jb250YWluaW5nQmxvY2soKTsKICAgICAgICAgfQogICAgIH0KLSAgICBy ZXR1cm4gcmlnaHQ7CisgICAgcmV0dXJuIGxvZ2ljYWxSaWdodDsKIH0KIAogdm9pZCBSZW5kZXJC bG9jazo6aW5zZXJ0UG9zaXRpb25lZE9iamVjdChSZW5kZXJCb3gqIG8pCkluZGV4OiBXZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrLmgJKHJldmlzaW9uIDcxMjU2KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQmxvY2suaAkod29ya2luZyBjb3B5KQpAQCAtNTM5LDggKzUzOSw4IEBAIHByaXZhdGU6CiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQmIGxhc3RUb3AsIGludCYgbGFz dExlZnQsIGludCYgbGFzdFJpZ2h0LCBjb25zdCBQYWludEluZm8qKTsKICAgICBJbnRSZWN0IGZp bGxCbG9ja1NlbGVjdGlvbkdhcChpbnQgbGFzdFRvcCwgaW50IGxhc3RMZWZ0LCBpbnQgbGFzdFJp Z2h0LCBpbnQgYm90dG9tWSwgUmVuZGVyQmxvY2sqIHJvb3RCbG9jaywKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpbnQgYmxvY2tYLCBpbnQgYmxvY2tZLCBjb25zdCBQYWludElu Zm8qKTsKLSAgICBpbnQgbG9naWNhbExlZnRTZWxlY3Rpb25PZmZzZXQoUmVuZGVyQmxvY2sqIHJv b3RCbG9jaywgaW50IHkpOwotICAgIGludCBsb2dpY2FsUmlnaHRTZWxlY3Rpb25PZmZzZXQoUmVu ZGVyQmxvY2sqIHJvb3RCbG9jaywgaW50IHkpOworICAgIGludCBsb2dpY2FsTGVmdFNlbGVjdGlv bk9mZnNldChSZW5kZXJCbG9jayogcm9vdEJsb2NrLCBpbnQgcG9zaXRpb24pOworICAgIGludCBs b2dpY2FsUmlnaHRTZWxlY3Rpb25PZmZzZXQoUmVuZGVyQmxvY2sqIHJvb3RCbG9jaywgaW50IHBv c2l0aW9uKTsKIAogICAgIHZpcnR1YWwgdm9pZCBhYnNvbHV0ZVJlY3RzKFZlY3RvcjxJbnRSZWN0 PiYsIGludCB0eCwgaW50IHR5KTsKICAgICB2aXJ0dWFsIHZvaWQgYWJzb2x1dGVRdWFkcyhWZWN0 b3I8RmxvYXRRdWFkPiYpOwo=