4892 2005-09-08 13:27:17 -0700 Date constructor has problems with months larger than 11 2007-11-13 14:35:19 -0800 1 1 1 Unclassified WebKit JavaScriptCore 312.x Mac OS X 10.3 RESOLVED FIXED http://ruairimccomb.com/safari/date.htm P2 Normal --- 1 ruairi mjs darin ggaren oldest_to_newest 19112 0 ruairi 2005-09-08 13:27:17 -0700 When creating dates in the following manner: new Date(year, month, date); If the month is larger than 11, the date returned starts going random. I've tested the page with Firefox (1.0.6 OSX, 1.0.1 & 1.0.6 WinXP) and IE (WinXP 6.0.2900) and if the month is larger than 11 these browsers update the date accordingly (e.g. if month is 13, they add 1 year and 2 months). 19113 1 3820 ruairi 2005-09-08 13:29:02 -0700 Created attachment 3820 Demonstration of the bug. 19340 2 mrowe 2005-09-11 01:13:52 -0700 Confirmed with WebKit 412.7 and ToT WebKit. In the ECMA 262 spec, section 15.9.1.12 (the MakeDay operator) it mentions that the year should be set to year + floor(month / 12), and the month to month % 12. This logic is currently implemented in date_object.cpp's fillStructuresUsingDateArgs. The Date constructor does not make use of this function, so the adjustment never takes place. It looks that Date.UTC suffers from the same problem. 19342 3 3858 mrowe 2005-09-11 01:46:24 -0700 Created attachment 3858 Patch to wrap month around inside Date constructor, and Date.UTC. I will add some layout tests shortly. 19414 4 3866 mrowe 2005-09-11 16:19:03 -0700 Created attachment 3866 Layout test This layout test covers both the Date constructor and Date.UTC. 19428 5 3858 darin 2005-09-11 21:54:26 -0700 Comment on attachment 3858 Patch to wrap month around inside Date constructor, and Date.UTC. This fix doesn't look right to me. I think handling things like this is part of the job of the makeTime function, so we should fix that instead of doing this. 19434 6 3868 mrowe 2005-09-11 22:20:00 -0700 Created attachment 3868 Updated patch This patch moves the existing month wrapping from inside fillStructuresUsingDateArgs into makeTime so that it handles the Date constructor and Date.UTC case. 19435 7 3868 darin 2005-09-11 22:25:50 -0700 Comment on attachment 3868 Updated patch Looks great. One complaint: The comment mentions CFGregorianDate overflow, but that's only one reason to adjust the year and do %= on the month. The other is to work best with the year offset machinery, and it applies even on non-Mac-OS-X. 19952 8 ggaren 2005-09-18 11:17:22 -0700 *** Bug 4782 has been marked as a duplicate of this bug. *** 61117 9 kevin 2007-11-13 14:26:18 -0800 Has this actually been released in the latest version of Safari 2.0.4? Because I still have a problem with this code: var test = new Date(this.VisibleDate.getFullYear(),this.VisibleDate.getMonth()+(this.MonthRows*this.MonthColumns); 61118 10 darin 2007-11-13 14:35:19 -0800 (In reply to comment #9) > Has this actually been released in the latest version of Safari 2.0.4? No. It's fixed for Safari 3. 3820 2005-09-08 13:29:02 -0700 2005-09-08 13:29:02 -0700 Demonstration of the bug. date.htm text/html 242 ruairi PGh0bWw+CjxoZWFkPjwvaGVhZD4KPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KYm9keSB7IGZvbnQt ZmFtaWx5IDogbW9ub3NwYWNlOyB9Cjwvc3R5bGU+Cjxib2R5Pgo8c2NyaXB0IHR5cGU9InRleHQv amF2YXNjcmlwdCI+CmZvciAodmFyIGkgPSAwLCBsID0gMjQ7IGkgPCBsOyBpKyspIHsKICBkb2N1 bWVudC53cml0ZShuZXcgRGF0ZSgyMDA1LCBpLCAxKSArICI8YnIvPiIpOwp9Cjwvc2NyaXB0Pgo8 L2JvZHk+CjwvaHRtbD4= 3858 2005-09-11 01:46:24 -0700 2005-09-11 22:20:00 -0700 Patch to wrap month around inside Date constructor, and Date.UTC. js-date-month-out-of-range-3.patch text/plain 1563 mrowe SW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9kYXRlX29iamVjdC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9yb290L0phdmFTY3JpcHRDb3JlL2tqcy9kYXRlX29iamVjdC5jcHAsdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuNTUKZGlmZiAtcCAtdSAtcjEuNTUgSmF2YVNjcmlwdENvcmUva2pz L2RhdGVfb2JqZWN0LmNwcAotLS0gSmF2YVNjcmlwdENvcmUva2pzL2RhdGVfb2JqZWN0LmNwcAk3 IFNlcCAyMDA1IDIzOjI3OjI4IC0wMDAwCTEuNTUKKysrIEphdmFTY3JpcHRDb3JlL2tqcy9kYXRl X29iamVjdC5jcHAJMTEgU2VwIDIwMDUgMDg6Mjc6NDIgLTAwMDAKQEAgLTg3NCw4ICs4NzQsOSBA QCBPYmplY3RJbXAgKkRhdGVPYmplY3RJbXA6OmNvbnN0cnVjdChFeGVjCiAgICAgICBzdHJ1Y3Qg dG0gdDsKICAgICAgIG1lbXNldCgmdCwgMCwgc2l6ZW9mKHQpKTsKICAgICAgIGludCB5ZWFyID0g YXJnc1swXS0+dG9JbnQzMihleGVjKTsKLSAgICAgIHQudG1feWVhciA9ICh5ZWFyID49IDAgJiYg eWVhciA8PSA5OSkgPyB5ZWFyIDogeWVhciAtIDE5MDA7Ci0gICAgICB0LnRtX21vbiA9IGFyZ3Nb MV0tPnRvSW50MzIoZXhlYyk7CisgICAgICBpbnQgbW9udGggPSBhcmdzWzFdLT50b0ludDMyKGV4 ZWMpOworICAgICAgdC50bV95ZWFyID0gKCh5ZWFyID49IDAgJiYgeWVhciA8PSA5OSkgPyB5ZWFy IDogeWVhciAtIDE5MDApICsgbW9udGggLyAxMjsKKyAgICAgIHQudG1fbW9uID0gbW9udGggJSAx MjsKICAgICAgIHQudG1fbWRheSA9IChudW1BcmdzID49IDMpID8gYXJnc1syXS0+dG9JbnQzMihl eGVjKSA6IDE7CiAgICAgICB0LnRtX2hvdXIgPSAobnVtQXJncyA+PSA0KSA/IGFyZ3NbM10tPnRv SW50MzIoZXhlYykgOiAwOwogICAgICAgdC50bV9taW4gPSAobnVtQXJncyA+PSA1KSA/IGFyZ3Nb NF0tPnRvSW50MzIoZXhlYykgOiAwOwpAQCAtOTQ2LDggKzk0Nyw5IEBAIFZhbHVlSW1wICpEYXRl T2JqZWN0RnVuY0ltcDo6Y2FsbEFzRnVuY3QKICAgICBzdHJ1Y3QgdG0gdDsKICAgICBtZW1zZXQo JnQsIDAsIHNpemVvZih0KSk7CiAgICAgaW50IHllYXIgPSBhcmdzWzBdLT50b0ludDMyKGV4ZWMp OwotICAgIHQudG1feWVhciA9ICh5ZWFyID49IDAgJiYgeWVhciA8PSA5OSkgPyB5ZWFyIDogeWVh ciAtIDE5MDA7Ci0gICAgdC50bV9tb24gPSBhcmdzWzFdLT50b0ludDMyKGV4ZWMpOworICAgIGlu dCBtb250aCA9IGFyZ3NbMV0tPnRvSW50MzIoZXhlYyk7CisgICAgdC50bV95ZWFyID0gKCh5ZWFy ID49IDAgJiYgeWVhciA8PSA5OSkgPyB5ZWFyIDogeWVhciAtIDE5MDApICsgbW9udGggLyAxMjsK KyAgICB0LnRtX21vbiA9IG1vbnRoICUgMTI7CiAgICAgdC50bV9tZGF5ID0gKG4gPj0gMykgPyBh cmdzWzJdLT50b0ludDMyKGV4ZWMpIDogMTsKICAgICB0LnRtX2hvdXIgPSAobiA+PSA0KSA/IGFy Z3NbM10tPnRvSW50MzIoZXhlYykgOiAwOwogICAgIHQudG1fbWluID0gKG4gPj0gNSkgPyBhcmdz WzRdLT50b0ludDMyKGV4ZWMpIDogMDsK 3866 2005-09-11 16:19:03 -0700 2005-09-11 16:19:48 -0700 Layout test js-date-month-out-of-range-test.html text/html 2397 mrowe PGh0bWw+CiAgPGhlYWQ+CiAgICA8dGl0bGU+VGVzdCBDYXNlOiAgVmVyaWZ5IHRoYXQgbW9udGhz IGdyZWF0ZXIgdGhhbiAxMSBhcmUgaGFuZGxlZCBjb3JyZWN0bHkgaW4gRGF0ZSBjb25zdHJ1Y3Rv ciBhbmQgRGF0ZS5VVEM8L3RpdGxlPgogIDwvaGVhZD4KICA8Ym9keT4KICAgIDxwPgogICAgICBU aGlzIHRlc3QgY2FzZSBjaGVja3MgdGhhdCBtb250aHMgZ3JlYXRlciB0aGFuIDExIGFyZSBoYW5k bGVkIGNvcnJlY3RseSB3aGVuIHBhc3NlZCB0byB0aGUgRGF0ZSBjb25zdHJ1Y3RvciBhbmQgdGhl CiAgICAgIERhdGUuVVRDIGZ1bmN0aW9uLiAgVGhlIEVDTUEgMjYyIHNwZWNpZmljYXRpb24gc2F5 cyB0aGF0IG1vbnRocyAmZ3Q7IDExIHNob3VsZCBiZSB0cmVhdGVkIGFzIG1vbnRoICUgMTIgYW5k IHRoZSB5ZWFyCiAgICAgIGFzIHllYXIgKyBmbG9vcihtb250aCAvIDEyKS4gIFRoZSBleHBlY3Rl ZCBvdXRwdXQgb24gc3VjY2VzcyBpcyAiU3VjY2VzcyEiIGJlbG93LiAgT24gZmFpbHVyZSBhIGxp c3Qgb2YgZGlmZmVyZW5jZXMKICAgICAgYmV0d2VlbiBleHBlY3RlZCBhbmQgYWN0dWFsIG91dHB1 dCB3aWxsIGJlIHNob3duLgogICAgPC9wPgogICAgCiAgICA8ZGl2IGlkPSJjb25zb2xlIj4KICAg IAogICAgPC9kaXY+CiAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CiAgICAgIHZh ciBmYWlsdXJlcyA9IDA7CiAgICAgIAogICAgICBmdW5jdGlvbiB3cml0ZShtc2cpIHsKICAgICAg ICB2YXIgbiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICAgICAgIG4uYXBwZW5k Q2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUobXNnKSk7CiAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoImNvbnNvbGUiKS5hcHBlbmRDaGlsZChuKTsKICAgICAgfQoKICAgICAgZnVu Y3Rpb24gZXhwZWN0KGV4cGVjdGVkLCBpbnB1dCwgYWN0dWFsKSB7CiAgICAgICAgaWYgKGV4cGVj dGVkICE9IGFjdHVhbCkgewogICAgICAgICAgd3JpdGUoIkV4cGVjdGVkICIgKyBleHBlY3RlZCAr ICIgZm9yICIgKyBpbnB1dCArICIgYnV0IGdvdCAiICsgYWN0dWFsKTsKICAgICAgICAgIGZhaWx1 cmVzKys7CiAgICAgICAgfQogICAgICB9CiAgICAKICAgICAgdmFyIGV4cGVjdGVkVVRDID0gWzEx MDQ1Mzc2MDAwMDAsIDExMDcyMTYwMDAwMDAsIDExMDk2MzUyMDAwMDAsIDExMTIzMTM2MDAwMDAs CiAgICAgICAgICAgICAgICAgICAgICAgICAxMTE0OTA1NjAwMDAwLCAxMTE3NTg0MDAwMDAwLCAx MTIwMTc2MDAwMDAwLCAxMTIyODU0NDAwMDAwLAogICAgICAgICAgICAgICAgICAgICAgICAgMTEy NTUzMjgwMDAwMCwgMTEyODEyNDgwMDAwMCwgMTEzMDgwMzIwMDAwMCwgMTEzMzM5NTIwMDAwMCwK ICAgICAgICAgICAgICAgICAgICAgICAgIDExMzYwNzM2MDAwMDAsIDExMzg3NTIwMDAwMDAsIDEx NDExNzEyMDAwMDAsIDExNDM4NDk2MDAwMDAsCiAgICAgICAgICAgICAgICAgICAgICAgICAxMTQ2 NDQxNjAwMDAwLCAxMTQ5MTIwMDAwMDAwLCAxMTUxNzEyMDAwMDAwLCAxMTU0MzkwNDAwMDAwLAog ICAgICAgICAgICAgICAgICAgICAgICAgMTE1NzA2ODgwMDAwMCwgMTE1OTY2MDgwMDAwMCwgMTE2 MjMzOTIwMDAwMCwgMTE2NDkzMTIwMDAwMCwKICAgICAgICAgICAgICAgICAgICAgICAgIDExNjc2 MDk2MDAwMDAsIDExNzAyODgwMDAwMDAsIDExNzI3MDcyMDAwMDAsIDExNzUzODU2MDAwMDAsCiAg ICAgICAgICAgICAgICAgICAgICAgICAxMTc3OTc3NjAwMDAwLCAxMTgwNjU2MDAwMDAwLCAxMTgz MjQ4MDAwMDAwLCAxMTg1OTI2NDAwMDAwLAogICAgICAgICAgICAgICAgICAgICAgICAgMTE4ODYw NDgwMDAwMCwgMTE5MTE5NjgwMDAwMCwgMTE5Mzg3NTIwMDAwMCwgMTE5NjQ2NzIwMDAwMF07Cgog ICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMzY7IGkrKykgewogICAgICAgdmFyIGQgPSBuZXcgRGF0 ZSgyMDA1LCBpLCAxKTsKICAgICAgIHZhciBpbnB1dCA9IDIwMDUgKyAiLSIgKyBpOwogICAgICAg dmFyIGV4cGVjdGVkID0gMjAwNSArIE1hdGguZmxvb3IoaSAvIDEyKSArICItIiArIChpICUgMTIp OwogICAgICAgdmFyIGFjdHVhbCA9IGQuZ2V0RnVsbFllYXIoKSArICItIiArIGQuZ2V0TW9udGgo KTsKICAgICAgIGV4cGVjdChleHBlY3RlZCwgaW5wdXQsIGFjdHVhbCk7CiAgICAgfQoKICAgICBm b3IgKHZhciBpID0gMDsgaSA8IDM2OyBpKyspIHsKICAgICAgIHZhciB1ID0gRGF0ZS5VVEMoMjAw NSwgaSwgMSk7CiAgICAgICB2YXIgaW5wdXQgPSAyMDA1ICsgIi0iICsgaTsKICAgICAgIGV4cGVj dChleHBlY3RlZFVUQ1tpXSwgaW5wdXQsIHUpOwogICAgIH0KCiAgICAgIGlmICghIGZhaWx1cmVz KQogICAgICAgIHdyaXRlKCJTdWNjZXNzISIpOwogICAgPC9zY3JpcHQ+CiAgPC9ib2R5Pgo8L2h0 bWw+ 3868 2005-09-11 22:20:00 -0700 2005-09-11 22:25:50 -0700 Updated patch jscore-date-month-out-of-range-4.patch text/plain 1689 mrowe SW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9kYXRlX29iamVjdC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9yb290L0phdmFTY3JpcHRDb3JlL2tqcy9kYXRlX29iamVjdC5jcHAsdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuNTUKZGlmZiAtcCAtdSAtcjEuNTUgSmF2YVNjcmlwdENvcmUva2pz L2RhdGVfb2JqZWN0LmNwcAotLS0gSmF2YVNjcmlwdENvcmUva2pzL2RhdGVfb2JqZWN0LmNwcAk3 IFNlcCAyMDA1IDIzOjI3OjI4IC0wMDAwCTEuNTUKKysrIEphdmFTY3JpcHRDb3JlL2tqcy9kYXRl X29iamVjdC5jcHAJMTIgU2VwIDIwMDUgMDU6MTI6NTkgLTAwMDAKQEAgLTQ2NSwxMiArNDY1LDcg QEAgc3RhdGljIHZvaWQgZmlsbFN0cnVjdHVyZXNVc2luZ0RhdGVBcmdzKAogICAKICAgLy8gbW9u dGhzCiAgIGlmIChtYXhBcmdzID49IDIgJiYgaWR4IDwgbnVtQXJncykgewotICAgIGludCBtb250 aHMgPSBhcmdzW2lkeCsrXS0+dG9JbnQzMihleGVjKTsKLQotICAgIC8vIHQtPnRtX3llYXIgbXVz dCBob2xkIHRoZSBidWxrIG9mIHRoZSBkYXRhIHRvIGF2b2lkIG92ZXJmbG93IHdoZW4gY29udmVy dGluZwotICAgIC8vIHRvIGEgQ0ZHcmVnb3JpYW5EYXRlLiAoQ0ZHcmVnb3JpYW5EYXRlLm1vbnRo IGlzIGFuIFNJbnQ4OyBDRkdyZWdvcmlhbkRhdGUueWVhciBpcyBhbiBTSW50MzIuKQotICAgIHQt PnRtX3llYXIgKz0gbW9udGhzIC8gMTI7Ci0gICAgdC0+dG1fbW9uID0gbW9udGhzICUgMTI7Cisg ICAgdC0+dG1fbW9uID0gYXJnc1tpZHgrK10tPnRvSW50MzIoZXhlYyk7CiAgIH0KICAgCiAgIC8v IGRheXMKQEAgLTEwMTQsNyArMTAwOSw3IEBAIGRvdWJsZSBtYWtlVGltZShzdHJ1Y3QgdG0gKnQs IGRvdWJsZSBtcywKIHsKICAgICBpbnQgdXRjT2Zmc2V0OwogICAgIGlmICh1dGMpIHsKLQl0aW1l X3QgemVybyA9IDA7CisgICAgICAgIHRpbWVfdCB6ZXJvID0gMDsKICNpZiBkZWZpbmVkIEJTRCB8 fCBkZWZpbmVkKF9fbGludXhfXykgfHwgZGVmaW5lZChfX0FQUExFX18pCiAgICAgICAgIHN0cnVj dCB0bSB0MzsKICAgICAgICAgbG9jYWx0aW1lX3IoJnplcm8sICZ0Myk7CkBAIC0xMDMwLDkgKzEw MjUsMTUgQEAgZG91YmxlIG1ha2VUaW1lKHN0cnVjdCB0bSAqdCwgZG91YmxlIG1zLAogICAgICAg ICB0LT50bV9pc2RzdCA9IDA7CiAjZW5kaWYKICAgICB9IGVsc2UgewotCXV0Y09mZnNldCA9IDA7 Ci0JdC0+dG1faXNkc3QgPSAtMTsKKyAgICAgICAgdXRjT2Zmc2V0ID0gMDsKKyAgICAgICAgdC0+ dG1faXNkc3QgPSAtMTsKICAgICB9CisgICAgCisgICAgLy8gdC0+dG1feWVhciBtdXN0IGhvbGQg dGhlIGJ1bGsgb2YgdGhlIGRhdGEgdG8gYXZvaWQgb3ZlcmZsb3cgd2hlbiBjb252ZXJ0aW5nCisg ICAgLy8gdG8gYSBDRkdyZWdvcmlhbkRhdGUuIChDRkdyZWdvcmlhbkRhdGUubW9udGggaXMgYW4g U0ludDg7IENGR3JlZ29yaWFuRGF0ZS55ZWFyIGlzIGFuIFNJbnQzMi4pCisgICAgdC0+dG1feWVh ciArPSB0LT50bV9tb24gLyAxMjsKKyAgICB0LT50bV9tb24gJT0gMTI7CisgICAgCiAKICAgICBk b3VibGUgeWVhck9mZnNldCA9IDAuMDsKICAgICBpZiAodC0+dG1feWVhciA8ICgxOTcwIC0gMTkw MCkgfHwgdC0+dG1feWVhciA+ICgyMDM4IC0gMTkwMCkpIHsK