48912 2010-11-03 06:26:36 -0700 ARM JIT asserts when loading http://reader.google.com in debug mode 2010-11-22 16:52:24 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED http://reader.google.com P4 Minor --- 1 jturcotte loki abarth barraclough christian.webkit commit-queue ddkilzer eric loki oliver thomas webkit.review.bot oldest_to_newest 304003 0 jturcotte 2010-11-03 06:26:36 -0700 ASSERTION FAILED: differenceBetween(m_uninterruptedInstructionSequenceBegin, label()) == insnSpace (../../../qtwebkit-webkit2-dev/JavaScriptCore/jit/JITInlineMethods.h:127 void JSC::JIT::endUninterruptedSequence(int, int)) It happens under JIT::compileGetByIdSlowCase, stubCall.call(dst) eventually calls ARMAssembler::dataTransfer32 which might generate 1 or 2 instructions depending on the value of "dst". 304712 1 ddkilzer 2010-11-04 09:44:27 -0700 I believe this is only an issue with the ARMAssembler, not the ARMv7Assembler. 304835 2 loki 2010-11-04 13:38:03 -0700 This issue is related to ARM JIT, not ARMv7 (Thumb-2) one. I will upload a patch soon. 306643 3 73344 loki 2010-11-09 00:34:13 -0800 Created attachment 73344 ARM JIT asserts when loading http://reader.google.com in debug mode 307188 4 73344 commit-queue 2010-11-09 23:36:54 -0800 Comment on attachment 73344 ARM JIT asserts when loading http://reader.google.com in debug mode Clearing flags on attachment: 73344 Committed r71722: <http://trac.webkit.org/changeset/71722> 307189 5 commit-queue 2010-11-09 23:37:00 -0800 All reviewed patches have been landed. Closing bug. 307228 6 webkit.review.bot 2010-11-10 00:52:22 -0800 http://trac.webkit.org/changeset/71722 might have broken GTK Linux 64-bit Debug The following tests are not passing: fast/events/tabindex-focus-blur-all.html 307242 7 loki 2010-11-10 01:23:33 -0800 > http://trac.webkit.org/changeset/71722 might have broken GTK Linux 64-bit Debug > The following tests are not passing: > fast/events/tabindex-focus-blur-all.html It should be a flaky test. This patch related to ARM. 307376 8 73344 darin 2010-11-10 09:15:21 -0800 Comment on attachment 73344 ARM JIT asserts when loading http://reader.google.com in debug mode View in context: https://bugs.webkit.org/attachment.cgi?id=73344&action=review > JavaScriptCore/jit/JITInlineMethods.h:131 > + /* There are several cases when the uninterrupted sequence is larger than > + * maximum required offset for pathing the same sequence. Eg.: if in a > + * uninterrupted sequence the last macroassembler's instruction is a stub > + * call, it emits store instruction(s) which should not be included in the > + * calculation of length of uninterrupted sequence. So, the insnSpace and > + * constSpace should be upper limit instead of hard limit. > + */ In the future, please use // comments, not /* comments, in WebKit code. 73344 2010-11-09 00:34:13 -0800 2010-11-10 09:15:21 -0800 ARM JIT asserts when loading http://reader.google.com in debug mode 0001-ARM-JIT-asserts-when-loading-http-reader.google.com-.patch text/plain 3589 loki RnJvbSBkODEzZmViZWJkOTBhMjMzODIyMDU3NTdjZmIyMWJhNTc3ZjliYmYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogVHVlLCA5IE5vdiAyMDEwIDA5OjMwOjUzICswMTAwClN1YmplY3Q6IFtQQVRDSF0gQVJNIEpJ VCBhc3NlcnRzIHdoZW4gbG9hZGluZyBodHRwOi8vcmVhZGVyLmdvb2dsZS5jb20gaW4gZGVidWcg bW9kZQoKU2lnbmVkLW9mZi1ieTogR2Fib3IgTG9raSA8bG9raUBpbmYudS1zemVnZWQuaHU+Ci0t LQogSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICB8ICAgMTggKysrKysrKysr KysrKysrKysrCiBKYXZhU2NyaXB0Q29yZS9qaXQvSklULmggICAgICAgICAgICAgIHwgICAgMiAr LQogSmF2YVNjcmlwdENvcmUvaml0L0pJVElubGluZU1ldGhvZHMuaCB8ICAgMTEgKysrKysrKysr LS0KIDMgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cKaW5kZXggOGY2NjNmZi4uODA0NzlmYSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBA CisyMDEwLTExLTA5ICBHYWJvciBMb2tpICA8bG9raUB3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFSTSBKSVQgYXNzZXJ0cyB3aGVu IGxvYWRpbmcgaHR0cDovL3JlYWRlci5nb29nbGUuY29tIGluIGRlYnVnIG1vZGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4OTEyCisKKyAgICAgICAg VGhlcmUgYXJlIHNldmVyYWwgY2FzZXMgd2hlbiB0aGUgdW5pbnRlcnJ1cHRlZCBzZXF1ZW5jZSBp cyBsYXJnZXIgdGhhbgorICAgICAgICBtYXhpbXVtIHJlcXVpcmVkIG9mZnNldCBmb3IgcGF0aGlu ZyB0aGUgc2FtZSBzZXF1ZW5jZS4gRWcuOiBpZiBpbiBhCisgICAgICAgIHVuaW50ZXJydXB0ZWQg c2VxdWVuY2UgdGhlIGxhc3QgbWFjcm9hc3NlbWJsZXIncyBpbnN0cnVjdGlvbiBpcyBhIHN0dWIK KyAgICAgICAgY2FsbCwgaXQgZW1pdHMgc3RvcmUgaW5zdHJ1Y3Rpb24ocykgd2hpY2ggc2hvdWxk IG5vdCBiZSBpbmNsdWRlZCBpbiB0aGUKKyAgICAgICAgY2FsY3VsYXRpb24gb2YgbGVuZ3RoIG9m IHVuaW50ZXJydXB0ZWQgc2VxdWVuY2UuIFNvLCB0aGUgaW5zblNwYWNlIGFuZAorICAgICAgICBj b25zdFNwYWNlIHNob3VsZCBiZSB1cHBlciBsaW1pdCBpbnN0ZWFkIG9mIGhhcmQgbGltaXQuCisK KyAgICAgICAgKiBqaXQvSklULmg6CisgICAgICAgICogaml0L0pJVElubGluZU1ldGhvZHMuaDoK KyAgICAgICAgKEpTQzo6SklUOjplbmRVbmludGVycnVwdGVkU2VxdWVuY2UpOgorCiAyMDEwLTEx LTA4ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSb2xsIG91dCBy NzE1MzIKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2ppdC9KSVQuaCBiL0phdmFTY3JpcHRD b3JlL2ppdC9KSVQuaAppbmRleCAzZWYwNTM4Li5hNzE3ZmM0IDEwMDY0NAotLS0gYS9KYXZhU2Ny aXB0Q29yZS9qaXQvSklULmgKKysrIGIvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oCkBAIC00MDIs NyArNDAyLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHN0YXRpYyBjb25zdCBpbnQgc2Vx dWVuY2VHZXRCeUlkSG90UGF0aEluc3RydWN0aW9uU3BhY2UgPSAzNjsKICAgICAgICAgc3RhdGlj IGNvbnN0IGludCBzZXF1ZW5jZUdldEJ5SWRIb3RQYXRoQ29uc3RhbnRTcGFjZSA9IDQ7CiAgICAg ICAgIC8vIHNlcXVlbmNlR2V0QnlJZFNsb3dDYXNlCi0gICAgICAgIHN0YXRpYyBjb25zdCBpbnQg c2VxdWVuY2VHZXRCeUlkU2xvd0Nhc2VJbnN0cnVjdGlvblNwYWNlID0gNDA7CisgICAgICAgIHN0 YXRpYyBjb25zdCBpbnQgc2VxdWVuY2VHZXRCeUlkU2xvd0Nhc2VJbnN0cnVjdGlvblNwYWNlID0g NTY7CiAgICAgICAgIHN0YXRpYyBjb25zdCBpbnQgc2VxdWVuY2VHZXRCeUlkU2xvd0Nhc2VDb25z dGFudFNwYWNlID0gMjsKICAgICAgICAgLy8gc2VxdWVuY2VQdXRCeUlkCiAgICAgICAgIHN0YXRp YyBjb25zdCBpbnQgc2VxdWVuY2VQdXRCeUlkSW5zdHJ1Y3Rpb25TcGFjZSA9IDM2OwpkaWZmIC0t Z2l0IGEvSmF2YVNjcmlwdENvcmUvaml0L0pJVElubGluZU1ldGhvZHMuaCBiL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRJbmxpbmVNZXRob2RzLmgKaW5kZXggNzYxMTE1MS4uMzljYTRhNSAxMDA2NDQK LS0tIGEvSmF2YVNjcmlwdENvcmUvaml0L0pJVElubGluZU1ldGhvZHMuaAorKysgYi9KYXZhU2Ny aXB0Q29yZS9qaXQvSklUSW5saW5lTWV0aG9kcy5oCkBAIC0xMjIsOCArMTIyLDE1IEBAIEFMV0FZ U19JTkxJTkUgdm9pZCBKSVQ6OmJlZ2luVW5pbnRlcnJ1cHRlZFNlcXVlbmNlKGludCBpbnNuU3Bh Y2UsIGludCBjb25zdFNwYWNlCiBBTFdBWVNfSU5MSU5FIHZvaWQgSklUOjplbmRVbmludGVycnVw dGVkU2VxdWVuY2UoaW50IGluc25TcGFjZSwgaW50IGNvbnN0U3BhY2UpCiB7CiAjaWYgZGVmaW5l ZChBU1NFTUJMRVJfSEFTX0NPTlNUQU5UX1BPT0wpICYmIEFTU0VNQkxFUl9IQVNfQ09OU1RBTlRf UE9PTAotICAgIEFTU0VSVChkaWZmZXJlbmNlQmV0d2VlbihtX3VuaW50ZXJydXB0ZWRJbnN0cnVj dGlvblNlcXVlbmNlQmVnaW4sIGxhYmVsKCkpID09IGluc25TcGFjZSk7Ci0gICAgQVNTRVJUKHNp emVPZkNvbnN0YW50UG9vbCgpIC0gbV91bmludGVycnVwdGVkQ29uc3RhbnRTZXF1ZW5jZUJlZ2lu ID09IGNvbnN0U3BhY2UpOworICAgIC8qIFRoZXJlIGFyZSBzZXZlcmFsIGNhc2VzIHdoZW4gdGhl IHVuaW50ZXJydXB0ZWQgc2VxdWVuY2UgaXMgbGFyZ2VyIHRoYW4KKyAgICAgKiBtYXhpbXVtIHJl cXVpcmVkIG9mZnNldCBmb3IgcGF0aGluZyB0aGUgc2FtZSBzZXF1ZW5jZS4gRWcuOiBpZiBpbiBh CisgICAgICogdW5pbnRlcnJ1cHRlZCBzZXF1ZW5jZSB0aGUgbGFzdCBtYWNyb2Fzc2VtYmxlcidz IGluc3RydWN0aW9uIGlzIGEgc3R1YgorICAgICAqIGNhbGwsIGl0IGVtaXRzIHN0b3JlIGluc3Ry dWN0aW9uKHMpIHdoaWNoIHNob3VsZCBub3QgYmUgaW5jbHVkZWQgaW4gdGhlCisgICAgICogY2Fs Y3VsYXRpb24gb2YgbGVuZ3RoIG9mIHVuaW50ZXJydXB0ZWQgc2VxdWVuY2UuIFNvLCB0aGUgaW5z blNwYWNlIGFuZAorICAgICAqIGNvbnN0U3BhY2Ugc2hvdWxkIGJlIHVwcGVyIGxpbWl0IGluc3Rl YWQgb2YgaGFyZCBsaW1pdC4KKyAgICAgKi8KKyAgICBBU1NFUlQoZGlmZmVyZW5jZUJldHdlZW4o bV91bmludGVycnVwdGVkSW5zdHJ1Y3Rpb25TZXF1ZW5jZUJlZ2luLCBsYWJlbCgpKSA8PSBpbnNu U3BhY2UpOworICAgIEFTU0VSVChzaXplT2ZDb25zdGFudFBvb2woKSAtIG1fdW5pbnRlcnJ1cHRl ZENvbnN0YW50U2VxdWVuY2VCZWdpbiA8PSBjb25zdFNwYWNlKTsKICNlbmRpZgogICAgIEpTSW50 ZXJmYWNlSklUOjplbmRVbmludGVycnVwdGVkU2VxdWVuY2UoKTsKIH0KLS0gCjEuNy4wLjQKCg==