48902 2010-11-03 02:17:13 -0700 [GTK] Implement unencodable characters handling in TextCodecGtk::encode() 2010-11-04 01:23:38 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 cgarcia webkit-unassigned commit-queue oldest_to_newest 303941 0 cgarcia 2010-11-03 02:17:13 -0700 It causes a crash in test fast/encoding/char-encoding.html 303943 1 72800 cgarcia 2010-11-03 02:20:27 -0700 Created attachment 72800 Patch 304520 2 commit-queue 2010-11-04 01:22:34 -0700 The commit-queue encountered the following flaky tests while processing attachment 72800: http/tests/appcache/remove-cache.html Please file bugs against the tests. These tests were authored by ap@webkit.org. The commit-queue is continuing to process your patch. 304521 3 72800 commit-queue 2010-11-04 01:23:33 -0700 Comment on attachment 72800 Patch Clearing flags on attachment: 72800 Committed r71312: <http://trac.webkit.org/changeset/71312> 304522 4 commit-queue 2010-11-04 01:23:38 -0700 All reviewed patches have been landed. Closing bug. 72800 2010-11-03 02:20:27 -0700 2010-11-04 01:23:33 -0700 Patch unencodable.diff text/plain 2188 cgarcia ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTU1OTc3Yy4uY2ZlOTg3YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMS0wMyAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gSW1wbGVtZW50IHVuZW5jb2RhYmxlIGNoYXJh Y3RlcnMgaGFuZGxpbmcgaW4gVGV4dENvZGVjR3RrOjplbmNvZGUoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg5MDIKKworICAgICAgICBGaXhlcyBh IGNyYXNoIGluIHRlc3QgZmFzdC9lbmNvZGluZy9jaGFyLWVuY29kaW5nLmh0bWwuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS90ZXh0L2d0ay9UZXh0Q29kZWNHdGsuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6VGV4dENvZGVjR3RrOjplbmNvZGUpOgorCiAyMDEwLTEwLTIxICBLd2FuZyBZdWwgU2VvICA8 c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvZ3RrL1RleHRDb2RlY0d0ay5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL3RleHQvZ3RrL1RleHRDb2RlY0d0ay5jcHAKaW5kZXggYmY2YWZj ZC4uOTMwOGIzMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2d0ay9UZXh0Q29k ZWNHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9ndGsvVGV4dENvZGVjR3RrLmNw cApAQCAtNTQzLDkgKzU0MywyOCBAQCBDU3RyaW5nIFRleHRDb2RlY0d0azo6ZW5jb2RlKGNvbnN0 IFVDaGFyKiBjaGFyYWN0ZXJzLCBzaXplX3QgbGVuZ3RoLCBVbmVuY29kYWJsZQogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICZlcnJvci5vdXRQdHIoKSk7CiAgICAgICAgIGlucHV0ICs9IGJ5 dGVzUmVhZDsKICAgICAgICAgaW5wdXRMZW5ndGggLT0gYnl0ZXNSZWFkOwotICAgICAgICByZXN1 bHQuZ3JvdyhzaXplICsgYnl0ZXNXcml0dGVuKTsKLSAgICAgICAgbWVtY3B5KHJlc3VsdC5kYXRh KCkgKyBzaXplLCBidWZmZXIsIGJ5dGVzV3JpdHRlbik7Ci0gICAgICAgIHNpemUgKz0gYnl0ZXNX cml0dGVuOworICAgICAgICBpZiAoYnl0ZXNXcml0dGVuID4gMCkgeworICAgICAgICAgICAgcmVz dWx0Lmdyb3coc2l6ZSArIGJ5dGVzV3JpdHRlbik7CisgICAgICAgICAgICBtZW1jcHkocmVzdWx0 LmRhdGEoKSArIHNpemUsIGJ1ZmZlciwgYnl0ZXNXcml0dGVuKTsKKyAgICAgICAgICAgIHNpemUg Kz0gYnl0ZXNXcml0dGVuOworICAgICAgICB9CisKKyAgICAgICAgaWYgKGVycm9yICYmIGdfZXJy b3JfbWF0Y2hlcyhlcnJvci5nZXQoKSwgR19JT19FUlJPUiwgR19JT19FUlJPUl9JTlZBTElEX0RB VEEpKSB7CisgICAgICAgICAgICBVQ2hhciBjb2RlUG9pbnQgPSByZWludGVycHJldF9jYXN0PGNv bnN0IFVDaGFyKj4oaW5wdXQpWzBdOworICAgICAgICAgICAgVW5lbmNvZGFibGVSZXBsYWNlbWVu dEFycmF5IHJlcGxhY2VtZW50OworICAgICAgICAgICAgaW50IHJlcGxhY2VtZW50TGVuZ3RoID0g VGV4dENvZGVjOjpnZXRVbmVuY29kYWJsZVJlcGxhY2VtZW50KGNvZGVQb2ludCwgaGFuZGxpbmcs IHJlcGxhY2VtZW50KTsKKworICAgICAgICAgICAgLy8gQ29uc3VtZSB0aGUgaW52YWxpZCBjaGFy YWN0ZXIuCisgICAgICAgICAgICBpbnB1dCArPSBzaXplb2YoVUNoYXIpOworICAgICAgICAgICAg aW5wdXRMZW5ndGggLT0gc2l6ZW9mKFVDaGFyKTsKKworICAgICAgICAgICAgLy8gQXBwZW5kIHJl cGxhY2VtZW50IHN0cmluZyB0byByZXN1bHQgYnVmZmVyLgorICAgICAgICAgICAgcmVzdWx0Lmdy b3coc2l6ZSArIHJlcGxhY2VtZW50TGVuZ3RoKTsKKyAgICAgICAgICAgIG1lbWNweShyZXN1bHQu ZGF0YSgpICsgc2l6ZSwgcmVwbGFjZW1lbnQsIHJlcGxhY2VtZW50TGVuZ3RoKTsKKyAgICAgICAg ICAgIHNpemUgKz0gcmVwbGFjZW1lbnRMZW5ndGg7CisKKyAgICAgICAgICAgIGVycm9yLmNsZWFy KCk7CisgICAgICAgIH0KICAgICB9IHdoaWxlIChpbnB1dExlbmd0aCAmJiAhZXJyb3IuZ2V0KCkp OwogCiAgICAgaWYgKGVycm9yKSB7Cg==