48890 2010-11-02 17:34:12 -0700 Undo r54932 which inappropriately adjusts font sizes on zoomed pages 2010-11-03 11:31:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony arv eric ojan oldest_to_newest 303813 0 tony 2010-11-02 17:34:12 -0700 Undo r54932 which inappropriately adjusts font sizes on zoomed pages 303816 1 72776 tony 2010-11-02 17:37:01 -0700 Created attachment 72776 Patch 303897 2 72776 arv 2010-11-02 22:09:30 -0700 Comment on attachment 72776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72776&action=review > LayoutTests/editing/pasteboard/page-zoom2.html:26 > + document.getElementById("target").innerHTML.toString(); innerHTML is already a string 303904 3 72776 rniwa 2010-11-02 23:57:01 -0700 Comment on attachment 72776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72776&action=review > LayoutTests/editing/pasteboard/page-zoom2.html:23 > + execPasteCommand(); Doesn't document.execCommand("insertHTML", false, "<span style="font-size: 16px" id="test">This font is size 16px.</span>") also work? 304029 4 72776 ojan 2010-11-03 07:39:20 -0700 Comment on attachment 72776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72776&action=review Removing paste hacks is awesome! The copy-paste code is far too complicated. > LayoutTests/editing/pasteboard/page-zoom2.html:15 > + eventSender.zoomPageIn(); I think you can just set CSS zoom on the body element and get the same effect. That way, you don't need to zoom out at the end and this test is closer to being able to run in other browsers. It also simplifies running the test manualy. 304148 5 tony 2010-11-03 11:30:14 -0700 Committed r71252: <http://trac.webkit.org/changeset/71252> 304150 6 tony 2010-11-03 11:31:45 -0700 (In reply to comment #5) > Committed r71252: <http://trac.webkit.org/changeset/71252> Before landing I made the following test changes: - Removed toString() calls and used local variables for nodes. - Switched to insertHTML (had to fake an apple style span) - Used css zoom instead. - Moved the test to editing/inserting since it no longer involved pasting. 72776 2010-11-02 17:37:01 -0700 2010-11-03 07:39:20 -0700 Patch bug-48890-20101102173728.patch text/plain 5681 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlZTI0MDQ5MjA2OGExODFjNWM2ODRjMTkwZTcwNDQ2ZWVjNzcwNmNkLi43YmU2NjRi ZTYzMjJhZTViYzBjNGY4M2QzYzc3ZWJhYmNmZDVhN2Y0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAK KzIwMTAtMTEtMDIgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbmRvIHI1NDkzMiB3aGljaCBp bmFwcHJvcHJpYXRlbHkgYWRqdXN0cyBmb250IHNpemVzIG9uIHpvb21lZCBwYWdlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg4OTAKKworICAgICAg ICBXaGVuIGNvcHlpbmcgem9vbWVkIHRleHQsIHdlIHVzZWQgdG8gd3JpdGUgdG8gdGhlIGNsaXBi b2FyZCB0aGUgem9vbWVkCisgICAgICAgIGZvbnQgc2l6ZS4gIHI1NDkzMiB3b3JrZWQgYXJvdW5k IHRoaXMgYXQgcGFzdGUgdGltZSBieSBzY2FsaW5nIHRoZQorICAgICAgICBmb250IHNpemUgYmFz ZWQgb24gdGhlIHpvb20uCisKKyAgICAgICAgSW4gcjY3NTY4LCBFcmlrIGZpeGVkIGdldENvbXB1 dGVkU3R5bGUgdG8gcmV0dXJuIHRoZSBvcmlnaW5hbCB2YWx1ZQorICAgICAgICByYXRoZXIgdGhh biB0aGUgem9vbWVkIGZvbnQgc2l6ZS4gIFRoaXMgbWFrZXMgdGhlIHdvcmsgYXJvdW5kIGFkZGVk CisgICAgICAgIGJ5IHI1NDkzMiB1bm5lY2Vzc2FyeS4KKworICAgICAgICBUaGUgY29kZSBpbiBy NTQ5MzIgd2FzIGJ1c3RlZCBpbiB0aGUgZmlyc3QgcGxhY2Ugc2luY2UgaXQgb25seSB3b3JrZWQK KyAgICAgICAgd2hlbiBpbiBxdWlya3MgbW9kZSBzaW5jZSBpdCBkaWRuJ3QgYWRkIHVuaXRzIHRv IHRoZSBmb250IHNpemUuCisKKyAgICAgICAgKiBlZGl0aW5nL3Bhc3RlYm9hcmQvcGFnZS16b29t Mi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvcGFzdGVib2FyZC9wYWdl LXpvb20yLmh0bWw6IEFkZGVkLgorCiAyMDEwLTExLTAyICBNaWhhaSBQYXJwYXJpdGEgIDxtaWhh aXBAY2hyb21pdW0ub3JnPgogICAgICAgICAKICAgICAgICAgVXBkYXRlIHRoZSBwaXhlbCBleHBl Y3RhdGlvbnMgZm9yIGZhc3QvY2FudmFzLCBmYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudCwgZmFz dC9pbmxpbmUtYmxvY2ssIGZhc3QvaW5saW5lLCBhbmQgZmFzdC9vdmVyZmxvdyBmb3IgdGhlIE1h YyBwb3J0LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL3BhZ2Ut em9vbTItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL3BhZ2Ut em9vbTItZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjYwYTFlMzc1OWJjMjliZDY5MzZiMGRmYTM4 NTdmYmRhYTQxM2NjOGUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3Bh c3RlYm9hcmQvcGFnZS16b29tMi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw3IEBACitUZXN0IHRv IG1ha2Ugc3VyZSB0aGF0IHBhc3RpbmcgdGV4dCB3aXRoIGEgZm9udCBzaXplIGludG8gYSBxdWly a3MgbW9kZSBkb2N1bWVudCB0aGF0IGlzIHpvb21lZCBkb2VzIG5vdCBhbHRlciB0aGUgZm9udCBz aXplLiBUbyB0ZXN0IHdpdGhvdXQgRHVtcFJlbmRlclRyZWUsIG1ha2Ugc3VyZSB0byB6b29tIGJl Zm9yZSBwYXN0aW5nLgorCitUaGlzIGZvbnQgaXMgc2l6ZSAxNnB4LgorUGFzdGUgSGVyZTpUaGlz IGZvbnQgaXMgc2l6ZSAxNnB4CisKK1BBU1MKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRp dGluZy9wYXN0ZWJvYXJkL3BhZ2Utem9vbTIuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvcGFz dGVib2FyZC9wYWdlLXpvb20yLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uODA2YzBmZDM5NWE3MzlkOTBlZDU3 YTk0YzYyOGEwODFkODA5MjgzOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRp bmcvcGFzdGVib2FyZC9wYWdlLXpvb20yLmh0bWwKQEAgLTAsMCArMSwzOCBAQAorPCFET0NUWVBF IEhUTUwgRk9SQ0UgUVVJUktTTU9ERT4KKzxib2R5PgorPHA+VGVzdCB0byBtYWtlIHN1cmUgdGhh dCBwYXN0aW5nIHRleHQgd2l0aCBhIGZvbnQgc2l6ZSBpbnRvIGEgcXVpcmtzIG1vZGUKK2RvY3Vt ZW50IHRoYXQgaXMgem9vbWVkIGRvZXMgbm90IGFsdGVyIHRoZSBmb250IHNpemUuICBUbyB0ZXN0 IHdpdGhvdXQKK0R1bXBSZW5kZXJUcmVlLCBtYWtlIHN1cmUgdG8gem9vbSBiZWZvcmUgcGFzdGlu Zy48L3A+Cis8c3BhbiBzdHlsZT0iZm9udC1zaXplOiAxNnB4IiBpZD0idGVzdCI+VGhpcyBmb250 IGlzIHNpemUgMTZweC48L3NwYW4+Cis8ZGl2IGNvbnRlbnRFZGl0YWJsZT0idHJ1ZSIgaWQ9InRh cmdldCI+UGFzdGUgSGVyZTogPC9kaXY+Cis8ZGl2IGlkPSJyZXN1bHRzIj48L2Rpdj4KKzwvYm9k eT4KKzxzY3JpcHQgc3JjPSIuLi9lZGl0aW5nLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CitmdW5j dGlvbiBlZGl0aW5nVGVzdCgpCit7CisgICAgaWYgKHdpbmRvdy5ldmVudFNlbmRlcikKKyAgICAg ICAgZXZlbnRTZW5kZXIuem9vbVBhZ2VJbigpOworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgNTsg KytpKQorICAgICAgICBleGVjRXh0ZW5kU2VsZWN0aW9uRm9yd2FyZEJ5V29yZENvbW1hbmQoKTsK KyAgICBleGVjQ29weUNvbW1hbmQoKTsKKworICAgIHZhciBlbGVtID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoInRhcmdldCIpOworICAgIHZhciBzZWxlY3Rpb24gPSB3aW5kb3cuZ2V0U2VsZWN0 aW9uKCk7CisgICAgc2VsZWN0aW9uLnNldFBvc2l0aW9uKGVsZW0sIDEyKTsKKyAgICBleGVjUGFz dGVDb21tYW5kKCk7CisKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0cyIpLmlu bmVyVGV4dCA9IAorICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0IikuaW5u ZXJIVE1MLnRvU3RyaW5nKCk7CisKKyAgICBpZiAoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRh cmdldCIpLmlubmVySFRNTC50b1N0cmluZygpLmluZGV4T2YoImZvbnQtc2l6ZTogMTZweCIpID09 IC0xKSB7CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHRzIikuaW5uZXJI VE1MICs9ICI8YnI+RkFJTCI7CisgICAgfSBlbHNlCisgICAgICAgIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJyZXN1bHRzIikuaW5uZXJIVE1MID0gIjxicj5QQVNTIjsKKworICAgIGlmICh3aW5k b3cuZXZlbnRTZW5kZXIpCisgICAgICAgIGV2ZW50U2VuZGVyLnpvb21QYWdlT3V0KCk7Cit9CisK K3J1bkR1bXBBc1RleHRFZGl0aW5nVGVzdChmYWxzZSk7Cis8L3NjcmlwdD4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTllYWFhZjY1NWRk ODk4YWVjOWVhOTNhNmJhZjg5OWY5ZGU4ZGY1My4uNTFjNDlmMmQ2NDFmZDcwYzE2YjAxODM5NzBh NTI3NDcxZGZjZWU1OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMS0wMiAgVG9ueSBDaGFuZyAgPHRv bnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFVuZG8gcjU0OTMyIHdoaWNoIGluYXBwcm9wcmlhdGVseSBhZGp1c3RzIGZvbnQg c2l6ZXMgb24gem9vbWVkIHBhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00ODg5MAorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcvcGFzdGVib2FyZC9w YWdlLXpvb20yLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1h bmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQ6Om5lZ2F0 ZVN0eWxlUnVsZXNUaGF0QWZmZWN0QXBwZWFyYW5jZSk6CisKIDIwMTAtMTEtMDIgIElseWEgU2hl cm1hbiAgPGlzaGVybWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50 IFRhbXVyYS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29t bWFuZC5jcHAgYi9XZWJDb3JlL2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwCmlu ZGV4IDA1NmFiNzA1ZjMyYzkxM2JjMmI0YTk4M2Q2NTdiNzcwZTdkODFmOWYuLjUzYWI3MGY0YmJk ZmYxYmIyNzU5NmY2OWQ2MmI5ODZiMTcxNmRkYzQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZWRpdGlu Zy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAKKysrIGIvV2ViQ29yZS9lZGl0aW5nL1JlcGxh Y2VTZWxlY3Rpb25Db21tYW5kLmNwcApAQCAtNDg0LDE3ICs0ODQsNiBAQCB2b2lkIFJlcGxhY2VT ZWxlY3Rpb25Db21tYW5kOjpuZWdhdGVTdHlsZVJ1bGVzVGhhdEFmZmVjdEFwcGVhcmFuY2UoKQog ICAgICAgICAgICAgICAgIGUtPmdldElubGluZVN0eWxlRGVjbCgpLT5zZXRQcm9wZXJ0eShDU1NQ cm9wZXJ0eURpc3BsYXksIENTU1ZhbHVlSW5saW5lKTsKICAgICAgICAgICAgIGlmIChlLT5yZW5k ZXJlcigpICYmIGUtPnJlbmRlcmVyKCktPnN0eWxlKCktPmZsb2F0aW5nKCkgIT0gRk5PTkUpCiAg ICAgICAgICAgICAgICAgZS0+Z2V0SW5saW5lU3R5bGVEZWNsKCktPnNldFByb3BlcnR5KENTU1By b3BlcnR5RmxvYXQsIENTU1ZhbHVlTm9uZSk7Ci0KLSAgICAgICAgICAgIC8vIFVuZG8gdGhlIGVm ZmVjdHMgb2YgcGFnZSB6b29tIGlmIHdlIGhhdmUgYW4gYWJzb2x1dGUgZm9udCBzaXplLiAgV2hl biB3ZSBjb3B5LCB3ZQotICAgICAgICAgICAgLy8gY29tcHV0ZSB0aGUgbmV3IGZvbnQgc2l6ZSBh cyBhbiBhYnNvbHV0ZSBzaXplIHNvIHBhc3Rpbmcgd2lsbCBjYXVzZSB0aGUgem9vbSB0byBiZQot ICAgICAgICAgICAgLy8gYXBwbGllZCB0d2ljZS4KLSAgICAgICAgICAgIGlmIChlLT5yZW5kZXJl cigpICYmIGUtPnJlbmRlcmVyKCktPnN0eWxlKCkgJiYgZS0+cmVuZGVyZXIoKS0+c3R5bGUoKS0+ ZWZmZWN0aXZlWm9vbSgpICE9IDEuMAotICAgICAgICAgICAgICAgICYmIGUtPnJlbmRlcmVyKCkt PnN0eWxlKCktPmZvbnREZXNjcmlwdGlvbigpLmlzQWJzb2x1dGVTaXplKCkpIHsKLSAgICAgICAg ICAgICAgICBmbG9hdCBuZXdTaXplID0gZS0+cmVuZGVyZXIoKS0+c3R5bGUoKS0+Zm9udERlc2Ny aXB0aW9uKCkuc3BlY2lmaWVkU2l6ZSgpIC8gZS0+cmVuZGVyZXIoKS0+c3R5bGUoKS0+ZWZmZWN0 aXZlWm9vbSgpOwotICAgICAgICAgICAgICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwotICAgICAg ICAgICAgICAgIGUtPnN0eWxlKCktPnNldFByb3BlcnR5KENTU1Byb3BlcnR5Rm9udFNpemUsIFN0 cmluZzo6bnVtYmVyKG5ld1NpemUpLCBmYWxzZSwgZWMpOwotICAgICAgICAgICAgICAgIEFTU0VS VCghZWMpOwotICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgICAgIGlmIChub2RlID09IG1f bGFzdExlYWZJbnNlcnRlZCkKICAgICAgICAgICAgIGJyZWFrOwo=