48876 2010-11-02 15:11:26 -0700 Implement NP_HasProperty for NPObjectProxy 2010-11-02 15:29:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca webkit.review.bot oldest_to_newest 303712 0 andersca 2010-11-02 15:11:26 -0700 Implement NP_HasProperty for NPObjectProxy 303717 1 72750 andersca 2010-11-02 15:16:11 -0700 Created attachment 72750 Patch 303720 2 webkit.review.bot 2010-11-02 15:18:12 -0700 Attachment 72750 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac-wk2/Skipped', u'WebKit2/ChangeLog', u'WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp', u'WebKit2/Shared/Plugins/NPObjectMessageReceiver.h', u'WebKit2/Shared/Plugins/NPObjectMessageReceiver.messages.in', u'WebKit2/Shared/Plugins/NPObjectProxy.cpp', u'WebKit2/Shared/Plugins/NPObjectProxy.h']" exit_code: 1 WebKit2/Shared/Plugins/NPObjectProxy.cpp:174: NPObjectProxy::NP_HasProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 303723 3 andersca 2010-11-02 15:29:31 -0700 Committed r71178: <http://trac.webkit.org/changeset/71178> 72750 2010-11-02 15:16:11 -0700 2010-11-02 15:17:27 -0700 Patch bug-48876-20101102151610.patch text/plain 6549 andersca ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZGMxOTUxZWQyNDA5ODFmMjQwOGZiM2UzZGZkZTkwYTAzYjViNTM1Li4zNDlkNThk MzViMTFkNGNmNTk0NDlhOTg4MjkwYTQ0NmFiM2E5M2ZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMTEtMDIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgTlBf SGFzUHJvcGVydHkgZm9yIE5QT2JqZWN0UHJveHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4ODc2CisKKyAgICAgICAgUmVtb3ZlIG5vdyBwYXNzaW5n IHRlc3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1NraXBwZWQ6CisKIDIwMTAtMTEt MDIgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy13azIvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvU2tpcHBlZAppbmRl eCAxNGY4YTEzZmU2NTI5YTJlMzE0YzExYWUzNjQzZDAzYTk0MGY2NjZjLi43MDk0OTQ1ODhiZDIw MDcxYzgwNzRlZDgzOTljNmIzYTZmZmZiMTYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMtd2syL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9T a2lwcGVkCkBAIC0xNzM3LDcgKzE3MzcsNiBAQCBwbHVnaW5zL3JldHVybi1uZWdhdGl2ZS1vbmUt ZnJvbS13cml0ZS5odG1sCiBwbHVnaW5zL3NldC1zdGF0dXMuaHRtbAogcGx1Z2lucy91cGRhdGUt d2lkZ2V0cy1jcmFzaC5odG1sCiBwbHVnaW5zL3dpbmRvdy1vcGVuLmh0bWwKLXBsdWdpbnMvbnBy dW50aW1lL2VtYmVkLXByb3BlcnR5Lmh0bWwKIHBsdWdpbnMvbnBydW50aW1lL2VudW1lcmF0ZS5o dG1sCiBwbHVnaW5zL25wcnVudGltZS9ldmFsdWF0ZS5odG1sCiBwbHVnaW5zL25wcnVudGltZS9n ZXQtaW50LWlkZW50aWZpZXItc3BlY2lhbC12YWx1ZXMuaHRtbApkaWZmIC0tZ2l0IGEvV2ViS2l0 Mi9DaGFuZ2VMb2cgYi9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBiNmQwNzBiNmQ0Njk1Mjc2YTY5 OTk3NjEyM2I2ZDVlNzZmOTJiY2YwLi4yMjhhZTRlNTMwNmZiZDBjMDhkNGVlOTdkMTEzNmNiM2Fl MGVlNWExIDEwMDY0NAotLS0gYS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9XZWJLaXQyL0NoYW5n ZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDEwLTExLTAyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSW1wbGVtZW50IE5QX0hhc1Byb3BlcnR5IGZvciBOUE9iamVjdFByb3h5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODg3NgorCisgICAg ICAgICogU2hhcmVkL1BsdWdpbnMvTlBPYmplY3RNZXNzYWdlUmVjZWl2ZXIuY3BwOgorICAgICAg ICAoV2ViS2l0OjpOUE9iamVjdE1lc3NhZ2VSZWNlaXZlcjo6aGFzUHJvcGVydHkpOgorICAgICAg ICBDYWxsIFRoZSBoYXNQcm9wZXJ0eSBjYWxsYmFjayBmdW5jdGlvbi4KKworICAgICAgICAqIFNo YXJlZC9QbHVnaW5zL05QT2JqZWN0TWVzc2FnZVJlY2VpdmVyLm1lc3NhZ2VzLmluOgorICAgICAg ICBBZGQgSGFzUHJvcGVydHkgbWVzc2FnZS4KKworICAgICAgICAqIFNoYXJlZC9QbHVnaW5zL05Q T2JqZWN0UHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpOUE9iamVjdFByb3h5OjpoYXNQcm9w ZXJ0eSk6CisgICAgICAgIFNlbmQgdGhlIEhhc1Byb3BlcnR5IG1lc3NhZ2UuCisKKyAgICAgICAg KFdlYktpdDo6TlBPYmplY3RQcm94eTo6TlBfSGFzUHJvcGVydHkpOgorICAgICAgICBDYWxsIGhh c1Byb3BlcnR5LgorCisKKzIwMTAtMTEtMDIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgogCiAgICAgICAgIElt cGxlbWVudCBQbHVnaW5Qcm94eTo6cGx1Z2luU2NyaXB0YWJsZU5QT2JqZWN0CmRpZmYgLS1naXQg YS9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05QT2JqZWN0TWVzc2FnZVJlY2VpdmVyLmNwcCBiL1dl YktpdDIvU2hhcmVkL1BsdWdpbnMvTlBPYmplY3RNZXNzYWdlUmVjZWl2ZXIuY3BwCmluZGV4IDZk ZjBmZDk1MzJkMjNlMDAwZDEzNjFmMDQwYjAwOWQwZjE3ZTY4MjAuLjVjYzc0MWY4OTdjOTg4MmVh ZTJjMTIxOGMzYmE0OTBiM2EwMjNiODIgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvU2hhcmVkL1BsdWdp bnMvTlBPYmplY3RNZXNzYWdlUmVjZWl2ZXIuY3BwCisrKyBiL1dlYktpdDIvU2hhcmVkL1BsdWdp bnMvTlBPYmplY3RNZXNzYWdlUmVjZWl2ZXIuY3BwCkBAIC02MCw2ICs2MCwxNiBAQCB2b2lkIE5Q T2JqZWN0TWVzc2FnZVJlY2VpdmVyOjpkZWFsbG9jYXRlKCkKICAgICBkZWxldGUgdGhpczsKIH0K IAordm9pZCBOUE9iamVjdE1lc3NhZ2VSZWNlaXZlcjo6aGFzUHJvcGVydHkoY29uc3QgTlBJZGVu dGlmaWVyRGF0YSYgcHJvcGVydHlOYW1lRGF0YSwgYm9vbCYgcmV0dXJuVmFsdWUpCit7CisgICAg aWYgKCFtX25wT2JqZWN0LT5fY2xhc3MtPmhhc1Byb3BlcnR5KSB7CisgICAgICAgIHJldHVyblZh bHVlID0gZmFsc2U7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICByZXR1cm5WYWx1ZSA9 IG1fbnBPYmplY3QtPl9jbGFzcy0+aGFzUHJvcGVydHkobV9ucE9iamVjdCwgcHJvcGVydHlOYW1l RGF0YS5jcmVhdGVOUElkZW50aWZpZXIoKSk7Cit9CisKIHZvaWQgTlBPYmplY3RNZXNzYWdlUmVj ZWl2ZXI6OmdldFByb3BlcnR5KGNvbnN0IE5QSWRlbnRpZmllckRhdGEmIHByb3BlcnR5TmFtZURh dGEsIGJvb2wmIHJldHVyblZhbHVlLCBOUFZhcmlhbnREYXRhJiByZXN1bHREYXRhKQogewogICAg IGlmICghbV9ucE9iamVjdC0+X2NsYXNzLT5nZXRQcm9wZXJ0eSkgewpkaWZmIC0tZ2l0IGEvV2Vi S2l0Mi9TaGFyZWQvUGx1Z2lucy9OUE9iamVjdE1lc3NhZ2VSZWNlaXZlci5oIGIvV2ViS2l0Mi9T aGFyZWQvUGx1Z2lucy9OUE9iamVjdE1lc3NhZ2VSZWNlaXZlci5oCmluZGV4IDMyMWUwYzJjNTk1 NTg3Y2FhMTdkMGVkYjQwOTVmNmNmMzdkY2ZmNDQuLmE3OGUxM2RiNTkzNzUyYmY2ZmFjNGU4MTNl YWQ3Mzc3ZDg5NTBhYTUgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvU2hhcmVkL1BsdWdpbnMvTlBPYmpl Y3RNZXNzYWdlUmVjZWl2ZXIuaAorKysgYi9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05QT2JqZWN0 TWVzc2FnZVJlY2VpdmVyLmgKQEAgLTUzLDYgKzUzLDcgQEAgcHJpdmF0ZToKIAogICAgIC8vIE1l c3NhZ2UgaGFuZGxlcnMuCiAgICAgdm9pZCBkZWFsbG9jYXRlKCk7CisgICAgdm9pZCBoYXNQcm9w ZXJ0eShjb25zdCBOUElkZW50aWZpZXJEYXRhJiwgYm9vbCYgcmV0dXJuVmFsdWUpOwogICAgIHZv aWQgZ2V0UHJvcGVydHkoY29uc3QgTlBJZGVudGlmaWVyRGF0YSYsIGJvb2wmIHJldHVyblZhbHVl LCBOUFZhcmlhbnREYXRhJiByZXN1bHREYXRhKTsKIAogICAgIE5QUmVtb3RlT2JqZWN0TWFwKiBt X25wUmVtb3RlT2JqZWN0TWFwOwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9O UE9iamVjdE1lc3NhZ2VSZWNlaXZlci5tZXNzYWdlcy5pbiBiL1dlYktpdDIvU2hhcmVkL1BsdWdp bnMvTlBPYmplY3RNZXNzYWdlUmVjZWl2ZXIubWVzc2FnZXMuaW4KaW5kZXggMWZjMTIwZmEyOWM1 YWMxNjZlOGY0ZWJhYjAyODM1Y2MxYTZjZjQzNS4uM2RkMDcyMmNmM2QwZjM3MTFjMzg1ZWQyYzE4 OTc1ODk4ZDcyMTEwNCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9OUE9iamVj dE1lc3NhZ2VSZWNlaXZlci5tZXNzYWdlcy5pbgorKysgYi9XZWJLaXQyL1NoYXJlZC9QbHVnaW5z L05QT2JqZWN0TWVzc2FnZVJlY2VpdmVyLm1lc3NhZ2VzLmluCkBAIC0yMywxMCArMjMsOCBAQAog I2lmIEVOQUJMRShQTFVHSU5fUFJPQ0VTUykKIAogbWVzc2FnZXMgLT4gTlBPYmplY3RNZXNzYWdl UmVjZWl2ZXIgewotICAgICMgRGVhbGxvY2F0ZSB0aGUgTlBPYmplY3QuCiAgICAgRGVhbGxvY2F0 ZSgpIC0+ICgpCi0KLSAgICAjIEdldCB0aGUgZ2l2ZW4gcHJvcGVydHkuCisgICAgSGFzUHJvcGVy dHkoV2ViS2l0OjpOUElkZW50aWZpZXJEYXRhIHByb3BlcnR5TmFtZSkgLT4gKGJvb2wgcmV0dXJu VmFsdWUpCiAgICAgR2V0UHJvcGVydHkoV2ViS2l0OjpOUElkZW50aWZpZXJEYXRhIHByb3BlcnR5 TmFtZSkgLT4gKGJvb2wgcmV0dXJuVmFsdWUsIFdlYktpdDo6TlBWYXJpYW50RGF0YSByZXN1bHRE YXRhKQogfQogCmRpZmYgLS1naXQgYS9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05QT2JqZWN0UHJv eHkuY3BwIGIvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9OUE9iamVjdFByb3h5LmNwcAppbmRleCAw MzYzOTJjYjhjNzQ5NjFlYjU1ZmZiZGZiNDIwYWQ5YjMzMzJmNGQxLi5jM2M0ZGU1ODgzYTdhNjZl Y2JlNTE5ZDU1MjhhOGM2OWE1YTc0Y2VmIDEwMDY0NAotLS0gYS9XZWJLaXQyL1NoYXJlZC9QbHVn aW5zL05QT2JqZWN0UHJveHkuY3BwCisrKyBiL1dlYktpdDIvU2hhcmVkL1BsdWdpbnMvTlBPYmpl Y3RQcm94eS5jcHAKQEAgLTg0LDYgKzg0LDIxIEBAIHZvaWQgTlBPYmplY3RQcm94eTo6aW5pdGlh bGl6ZShOUFJlbW90ZU9iamVjdE1hcCogbnBSZW1vdGVPYmplY3RNYXAsIHVpbnQ2NF90IG5wCiAg ICAgbV9ucE9iamVjdElEID0gbnBPYmplY3RJRDsKIH0KIAorYm9vbCBOUE9iamVjdFByb3h5Ojpo YXNQcm9wZXJ0eShOUElkZW50aWZpZXIgcHJvcGVydHlOYW1lKQoreworICAgIGlmICghbV9ucFJl bW90ZU9iamVjdE1hcCkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIAorICAgIE5QSWRlbnRp ZmllckRhdGEgcHJvcGVydHlOYW1lRGF0YSA9IE5QSWRlbnRpZmllckRhdGE6OmZyb21OUElkZW50 aWZpZXIocHJvcGVydHlOYW1lKTsKKworICAgIGJvb2wgcmV0dXJuVmFsdWUgPSBmYWxzZTsKKyAg ICAKKyAgICBpZiAoIW1fbnBSZW1vdGVPYmplY3RNYXAtPmNvbm5lY3Rpb24oKS0+c2VuZFN5bmMo TWVzc2FnZXM6Ok5QT2JqZWN0TWVzc2FnZVJlY2VpdmVyOjpIYXNQcm9wZXJ0eShwcm9wZXJ0eU5h bWVEYXRhKSwgTWVzc2FnZXM6Ok5QT2JqZWN0TWVzc2FnZVJlY2VpdmVyOjpIYXNQcm9wZXJ0eTo6 UmVwbHkocmV0dXJuVmFsdWUpLCBtX25wT2JqZWN0SUQpKQorICAgICAgICByZXR1cm4gZmFsc2U7 CisKKyAgICByZXR1cm4gcmV0dXJuVmFsdWU7Cit9CisKIGJvb2wgTlBPYmplY3RQcm94eTo6Z2V0 UHJvcGVydHkoTlBJZGVudGlmaWVyIHByb3BlcnR5TmFtZSwgTlBWYXJpYW50KiByZXN1bHQpCiB7 CiAgICAgaWYgKCFtX25wUmVtb3RlT2JqZWN0TWFwKQpAQCAtMTU2LDEwICsxNzEsOSBAQCBib29s IE5QT2JqZWN0UHJveHk6Ok5QX0ludm9rZURlZmF1bHQoTlBPYmplY3QqLCBjb25zdCBOUFZhcmlh bnQqIGFyZ3VtZW50cywgdWludAogICAgIHJldHVybiBmYWxzZTsKIH0KIAotYm9vbCBOUE9iamVj dFByb3h5OjpOUF9IYXNQcm9wZXJ0eShOUE9iamVjdCosIE5QSWRlbnRpZmllciBwcm9wZXJ0eU5h bWUpCitib29sIE5QT2JqZWN0UHJveHk6Ok5QX0hhc1Byb3BlcnR5KE5QT2JqZWN0KiBucE9iamVj dCwgTlBJZGVudGlmaWVyIHByb3BlcnR5TmFtZSkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwot ICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gdG9OUE9iamVjdFByb3h5KG5wT2JqZWN0KS0+ aGFzUHJvcGVydHkocHJvcGVydHlOYW1lKTsKIH0KIAogYm9vbCBOUE9iamVjdFByb3h5OjpOUF9H ZXRQcm9wZXJ0eShOUE9iamVjdCogbnBPYmplY3QsIE5QSWRlbnRpZmllciBwcm9wZXJ0eU5hbWUs IE5QVmFyaWFudCogcmVzdWx0KQpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9O UE9iamVjdFByb3h5LmggYi9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05QT2JqZWN0UHJveHkuaApp bmRleCA2YmM1YzQ5NGRjZjk2YmJkMGMwNzdiYTM2YWE4NDE5ZjZjNzc5ZmEzLi5jYjlkMjRhY2Rj YzRkOGVkOWJhNTViYTkzNjIyYmU0ZDgzMjllNzZjIDEwMDY0NAotLS0gYS9XZWJLaXQyL1NoYXJl ZC9QbHVnaW5zL05QT2JqZWN0UHJveHkuaAorKysgYi9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05Q T2JqZWN0UHJveHkuaApAQCAtNTcsNiArNTcsNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBpbml0 aWFsaXplKE5QUmVtb3RlT2JqZWN0TWFwKiBucFJlbW90ZU9iamVjdE1hcCwgdWludDY0X3QgbnBP YmplY3RJRCk7CiAKKyAgICBib29sIGhhc1Byb3BlcnR5KE5QSWRlbnRpZmllciBwcm9wZXJ0eU5h bWUpOwogICAgIGJvb2wgZ2V0UHJvcGVydHkoTlBJZGVudGlmaWVyIHByb3BlcnR5TmFtZSwgTlBW YXJpYW50KiByZXN1bHQpOwogCiAgICAgc3RhdGljIE5QQ2xhc3MqIG5wQ2xhc3MoKTsK