48869 2010-11-02 14:01:51 -0700 [Qt] Adding iphone user agent string the user agent list for QtTestBrowser 2011-01-03 05:29:36 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 leonid.ebril webkit-unassigned ademar commit-queue webkit.review.bot oldest_to_newest 303640 0 leonid.ebril 2010-11-02 14:01:51 -0700 This change will simplify testing/debugging iphone specific use cases on QtTestBrowser. 303714 1 72749 leonid.ebril 2010-11-02 15:13:48 -0700 Created attachment 72749 adding user agent string for iphone 4 to the useragentlist.txt added user agent string for iphone 4 303718 2 webkit.review.bot 2010-11-02 15:16:58 -0700 Attachment 72749 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/QtTestBrowser/useragentlist.txt']" exit_code: 1 WebKitTools/QtTestBrowser/useragentlist.txt:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 10 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 303917 3 72749 kling 2010-11-03 00:55:10 -0700 Comment on attachment 72749 adding user agent string for iphone 4 to the useragentlist.txt The change is fine, but the patch should be using Unix newlines, rather than CRLF. 303996 4 72816 leonid.ebril 2010-11-03 06:14:02 -0700 Created attachment 72816 an updated version of patch (using Unix newlines, rather than CRLF). 304592 5 72816 kling 2010-11-04 05:01:42 -0700 Comment on attachment 72816 an updated version of patch (using Unix newlines, rather than CRLF). r=me 304599 6 72816 commit-queue 2010-11-04 05:29:20 -0700 Comment on attachment 72816 an updated version of patch (using Unix newlines, rather than CRLF). Clearing flags on attachment: 72816 Committed r71325: <http://trac.webkit.org/changeset/71325> 304600 7 commit-queue 2010-11-04 05:29:25 -0700 All reviewed patches have been landed. Closing bug. 328534 8 ademar 2011-01-03 05:26:54 -0800 Revision r71325 cherry-picked into qtwebkit-2.2 with commit 7a3db1d <http://gitorious.org/webkit/qtwebkit/commit/7a3db1d> 328536 9 ademar 2011-01-03 05:29:36 -0800 Has just been cherry-picked to qtwebkit-2.2, removing blockage. 72749 2010-11-02 15:13:48 -0700 2010-11-03 00:55:09 -0700 adding user agent string for iphone 4 to the useragentlist.txt 48869.patch text/plain 3182 leonid.ebril SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcxMTY5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTEtMDIgIExlb25pZCBFYnJpbCAgPGxl b25pZC5lYnJpbEBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW1F0XSBBZGRpbmcgaXBob25lIHVzZXIgYWdlbnQgc3RyaW5nIHRoZSB1 c2VyIGFnZW50IGxpc3QgZm9yIFF0VGVzdEJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4ODY5CisKKyAgICAgICAgKiBRdFRlc3RCcm93c2Vy L3VzZXJhZ2VudGxpc3QudHh0OgorCiAyMDEwLTExLTAyICBCZW5qYW1pbiBLYWxtYW4gIDxrYWxt YW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpJbmRleDog V2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci91c2VyYWdlbnRsaXN0LnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL3VzZXJhZ2VudGxpc3QudHh0CShyZXZpc2lvbiA3 MTE2OCkKKysrIFdlYktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvdXNlcmFnZW50bGlzdC50eHQJKHdv cmtpbmcgY29weSkKQEAgLTEsOSArMSwxMCBAQAotTW96aWxsYS81LjAgKFgxMTsgVTsgTGludXg7 IGVuLVVTKSBBcHBsZVdlYktpdC81MzMuMyAoS0hUTUwsIGxpa2UgR2Vja28pIFF0VGVzdEJyb3dz ZXIvMC4xIFNhZmFyaS81MzMuMwotTW96aWxsYS81LjAgKFN5bWJpYW5PUy85LjQ7IFU7IFNlcmll czYwLzUuMDsgZW4tR0IpIEFwcGxlV2ViS2l0LzUzMy4zIChLSFRNTCwgbGlrZSBHZWNrbykgUXRU ZXN0QnJvd3Nlci8wLjEgTW9iaWxlIFNhZmFyaS81MzMuMwotTW96aWxsYS81LjAgKE1hY2ludG9z aDsgVTsgUFBDIE1hYyBPUyBYOyBlbikgQXBwbGVXZWJLaXQvMTI1LjIgKEtIVE1MLCBsaWtlIEdl Y2tvKSBTYWZhcmkvMTI1LjgKLU1vemlsbGEvNS4wIChMaW51eDsgVTsgQW5kcm9pZCAxLjE7IGVu LWdiOyBkcmVhbSkgQXBwbGVXZWJLaXQvNTI1LjEwKyAoS0hUTUwsIGxpa2UgR2Vja28pIFZlcnNp b24vMy4wLjQgTW9iaWxlIFNhZmFyaS81MjMuMTIuMgotTW96aWxsYS81LjAgKGlQaG9uZTsgVTsg Q1BVIE9TIDNfMiBsaWtlIE1hYyBPUyBYOyBlbi11cykgQXBwbGVXZWJLaXQvNTMxLjIxLjEwIChL SFRNTCwgbGlrZSBHZWNrbykgVmVyc2lvbi80LjAuNCBNb2JpbGUvN0IzMzRiIFNhZmFyaS81MzEu MjEuMTAKLU1vemlsbGEvNS4wKGlQYWQ7IFU7IENQVSBpUGhvbmUgT1MgM18yIGxpa2UgTWFjIE9T IFg7IGVuLXVzKSBBcHBsZVdlYktpdC81MzEuMjEuMTAgKEtIVE1MLCBsaWtlIEdlY2tvKSBWZXJz aW9uLzQuMC40IE1vYmlsZS83QjMxNCBTYWZhcmkvNTMxLjIxLjEwCi1PcGVyYS85LjI1IChXaW5k b3dzIE5UIDYuMDsgVTsgZW4pCi1Nb3ppbGxhLzUuMCAoU3ltYmlhbk9TLzkuNDsgVTsgU2VyaWVz NjAvNS4wIE5va2lhNTgwMGQtMWIvMjAuMi4wMTQ7IFByb2ZpbGUvTUlEUC0yLjEgQ29uZmlndXJh dGlvbi9DTERDLTEuMSApIEFwcGxlV2ViS2l0LzQxMyAoS0hUTUwsIGxpa2UgR2Vja28pIFNhZmFy aS80MTMKLU1vemlsbGEvNC4wIChjb21wYXRpYmxlOyBNU0lFIDguMDsgV2luZG93cyBOVCA2LjI7 IFRyaWRlbnQvNC4wOyBTTENDMjsgLk5FVCBDTFIgMi4wLjUwNzI3OyAuTkVUIENMUiAzLjUuMzA3 Mjk7IC5ORVQgQ0xSIDMuMC4zMDcyOTsgTWVkaWEgQ2VudGVyIFBDIDYuMCkKK01vemlsbGEvNS4w IChYMTE7IFU7IExpbnV4OyBlbi1VUykgQXBwbGVXZWJLaXQvNTMzLjMgKEtIVE1MLCBsaWtlIEdl Y2tvKSBRdFRlc3RCcm93c2VyLzAuMSBTYWZhcmkvNTMzLjMNCitNb3ppbGxhLzUuMCAoU3ltYmlh bk9TLzkuNDsgVTsgU2VyaWVzNjAvNS4wOyBlbi1HQikgQXBwbGVXZWJLaXQvNTMzLjMgKEtIVE1M LCBsaWtlIEdlY2tvKSBRdFRlc3RCcm93c2VyLzAuMSBNb2JpbGUgU2FmYXJpLzUzMy4zDQorTW96 aWxsYS81LjAgKGlQaG9uZTsgVTsgQ1BVIGlQaG9uZSBPUyA0XzAgbGlrZSBNYWMgT1MgWDsgZW4t dXMpIEFwcGxlV2ViS2l0LzUzMi45IChLSFRNTCwgbGlrZSBHZWNrbykgVmVyc2lvbi80LjAuNSBN b2JpbGUvOEEyOTMgU2FmYXJpLzY1MzEuMjIuNw0KK01vemlsbGEvNS4wIChNYWNpbnRvc2g7IFU7 IFBQQyBNYWMgT1MgWDsgZW4pIEFwcGxlV2ViS2l0LzEyNS4yIChLSFRNTCwgbGlrZSBHZWNrbykg U2FmYXJpLzEyNS44DQorTW96aWxsYS81LjAgKExpbnV4OyBVOyBBbmRyb2lkIDEuMTsgZW4tZ2I7 IGRyZWFtKSBBcHBsZVdlYktpdC81MjUuMTArIChLSFRNTCwgbGlrZSBHZWNrbykgVmVyc2lvbi8z LjAuNCBNb2JpbGUgU2FmYXJpLzUyMy4xMi4yDQorTW96aWxsYS81LjAgKGlQaG9uZTsgVTsgQ1BV IE9TIDNfMiBsaWtlIE1hYyBPUyBYOyBlbi11cykgQXBwbGVXZWJLaXQvNTMxLjIxLjEwIChLSFRN TCwgbGlrZSBHZWNrbykgVmVyc2lvbi80LjAuNCBNb2JpbGUvN0IzMzRiIFNhZmFyaS81MzEuMjEu MTANCitNb3ppbGxhLzUuMChpUGFkOyBVOyBDUFUgaVBob25lIE9TIDNfMiBsaWtlIE1hYyBPUyBY OyBlbi11cykgQXBwbGVXZWJLaXQvNTMxLjIxLjEwIChLSFRNTCwgbGlrZSBHZWNrbykgVmVyc2lv bi80LjAuNCBNb2JpbGUvN0IzMTQgU2FmYXJpLzUzMS4yMS4xMA0KK09wZXJhLzkuMjUgKFdpbmRv d3MgTlQgNi4wOyBVOyBlbikNCitNb3ppbGxhLzUuMCAoU3ltYmlhbk9TLzkuNDsgVTsgU2VyaWVz NjAvNS4wIE5va2lhNTgwMGQtMWIvMjAuMi4wMTQ7IFByb2ZpbGUvTUlEUC0yLjEgQ29uZmlndXJh dGlvbi9DTERDLTEuMSApIEFwcGxlV2ViS2l0LzQxMyAoS0hUTUwsIGxpa2UgR2Vja28pIFNhZmFy aS80MTMNCitNb3ppbGxhLzQuMCAoY29tcGF0aWJsZTsgTVNJRSA4LjA7IFdpbmRvd3MgTlQgNi4y OyBUcmlkZW50LzQuMDsgU0xDQzI7IC5ORVQgQ0xSIDIuMC41MDcyNzsgLk5FVCBDTFIgMy41LjMw NzI5OyAuTkVUIENMUiAzLjAuMzA3Mjk7IE1lZGlhIENlbnRlciBQQyA2LjApDQo= 72816 2010-11-03 06:14:02 -0700 2010-11-04 05:29:20 -0700 an updated version of patch (using Unix newlines, rather than CRLF). 48869.patch text/plain 1726 leonid.ebril SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcxMTY5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTEtMDIgIExlb25pZCBFYnJpbCAgPGxl b25pZC5lYnJpbEBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW1F0XSBBZGRpbmcgaXBob25lIHVzZXIgYWdlbnQgc3RyaW5nIHRoZSB1 c2VyIGFnZW50IGxpc3QgZm9yIFF0VGVzdEJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4ODY5CisKKyAgICAgICAgKiBRdFRlc3RCcm93c2Vy L3VzZXJhZ2VudGxpc3QudHh0OgorCiAyMDEwLTExLTAyICBCZW5qYW1pbiBLYWxtYW4gIDxrYWxt YW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpJbmRleDog V2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci91c2VyYWdlbnRsaXN0LnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL3VzZXJhZ2VudGxpc3QudHh0CShyZXZpc2lvbiA3 MTE2OSkKKysrIFdlYktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvdXNlcmFnZW50bGlzdC50eHQJKHdv cmtpbmcgY29weSkKQEAgLTMsNiArMyw3IEBAIE1vemlsbGEvNS4wIChTeW1iaWFuT1MvOS40OyBV OyBTZXJpZXM2MC8KIE1vemlsbGEvNS4wIChNYWNpbnRvc2g7IFU7IFBQQyBNYWMgT1MgWDsgZW4p IEFwcGxlV2ViS2l0LzEyNS4yIChLSFRNTCwgbGlrZSBHZWNrbykgU2FmYXJpLzEyNS44CiBNb3pp bGxhLzUuMCAoTGludXg7IFU7IEFuZHJvaWQgMS4xOyBlbi1nYjsgZHJlYW0pIEFwcGxlV2ViS2l0 LzUyNS4xMCsgKEtIVE1MLCBsaWtlIEdlY2tvKSBWZXJzaW9uLzMuMC40IE1vYmlsZSBTYWZhcmkv NTIzLjEyLjIKIE1vemlsbGEvNS4wIChpUGhvbmU7IFU7IENQVSBPUyAzXzIgbGlrZSBNYWMgT1Mg WDsgZW4tdXMpIEFwcGxlV2ViS2l0LzUzMS4yMS4xMCAoS0hUTUwsIGxpa2UgR2Vja28pIFZlcnNp b24vNC4wLjQgTW9iaWxlLzdCMzM0YiBTYWZhcmkvNTMxLjIxLjEwCitNb3ppbGxhLzUuMCAoaVBo b25lOyBVOyBDUFUgaVBob25lIE9TIDRfMCBsaWtlIE1hYyBPUyBYOyBlbi11cykgQXBwbGVXZWJL aXQvNTMyLjkgKEtIVE1MLCBsaWtlIEdlY2tvKSBWZXJzaW9uLzQuMC41IE1vYmlsZS84QTI5MyBT YWZhcmkvNjUzMS4yMi43CiBNb3ppbGxhLzUuMChpUGFkOyBVOyBDUFUgaVBob25lIE9TIDNfMiBs aWtlIE1hYyBPUyBYOyBlbi11cykgQXBwbGVXZWJLaXQvNTMxLjIxLjEwIChLSFRNTCwgbGlrZSBH ZWNrbykgVmVyc2lvbi80LjAuNCBNb2JpbGUvN0IzMTQgU2FmYXJpLzUzMS4yMS4xMAogT3BlcmEv OS4yNSAoV2luZG93cyBOVCA2LjA7IFU7IGVuKQogTW96aWxsYS81LjAgKFN5bWJpYW5PUy85LjQ7 IFU7IFNlcmllczYwLzUuMCBOb2tpYTU4MDBkLTFiLzIwLjIuMDE0OyBQcm9maWxlL01JRFAtMi4x IENvbmZpZ3VyYXRpb24vQ0xEQy0xLjEgKSBBcHBsZVdlYktpdC80MTMgKEtIVE1MLCBsaWtlIEdl Y2tvKSBTYWZhcmkvNDEzCg==